[JIRA] (JENKINS-60393) cloudbees-folder circular dependency

2019-12-06 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-60393  
 
 
  cloudbees-folder circular dependency   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Francisco Fernández  
 
 
Components: 
 cloudbees-folder-plugin  
 
 
Created: 
 2019-12-06 20:32  
 
 
Environment: 
 jenkins 2.190.3  cloudbees-folder-plugin 6.10  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Matthew Hall  
 

  
 
 
 
 

 
   Seeing the following in my jenkins log as a stacktrace :   2019-12-06 19:26:29.676+ [id=29] WARNING h.ExtensionFinder$GuiceFinder$FaultTolerantScope$1#error: Failed to instantiate Key[type=com.cloudbees.hudson.plugins.folder.config.AbstractFolderConfiguration, annotation=[none]]; skipping this component com.google.inject.ProvisionException: Unable to provision, see the following errors:1) Tried proxying com.cloudbees.hudson.plugins.folder.config.AbstractFolderConfiguration to support a circular dependency, but it is not an interface.1 error {{ at com.google.inject.internal.ProviderToInternalFactoryAdapter.get(ProviderToInternalFactoryAdapter.java:52)}} {{ at com.google.inject.internal.SingletonScope$1.get(SingletonScope.java:145)}} {{ at hudson.ExtensionFinder$GuiceFinder$FaultTolerantScope$1.get(ExtensionFinder.java:439)}} {{ at com.google.inject.internal.InternalFactoryToProviderAdapter.get(InternalFactoryToProviderAdapter.java:41)}} {{ at com.google.inject.internal.InjectorImpl$2$1.call(InjectorImpl.java:1016)}} {{ at com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1103)}} {{ at com.google.inject.internal.InjectorImpl$2.get(InjectorImpl.java:1012)}} {{ at hudson.ExtensionFinder$GuiceFinder._find(ExtensionFinder.java:401)}} {{ at hudson.ExtensionFinder$GuiceFinder.find(ExtensionFinder.java:392)}} {{ at hudson.ClassicPluginStrategy.findComponents(ClassicPluginStrategy.java:344)}} {{ at 

[JIRA] (JENKINS-59650) Can't properly create Emoji Only Jobs (╯°□°)╯︵ ┻━┻

2019-10-03 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall edited a comment on  JENKINS-59650  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Can't properly create Emoji Only Jobs (╯°□°)╯︵ ┻━┻   
 

  
 
 
 
 

 
 Also, to use another example. If I create :{noformat}See No Evil :see no evil monkey: {noformat}as a job, this works.If I try to create it as :{noformat}:see no evil monkey: See No Evil{noformat}It fails.  Seems to be related to the emoji being the leading part of the job name. (I can't use the actual monkey, due to Jira not taking it : It fails.][numvalue,null][updated,2019-10-03 18:41:35.326] (SQL Exception while executing the following:UPDATE jiraaction SET issueid=?, AUTHOR=?, actiontype=?, actionlevel=?, rolelevel=?, actionbody=?, CREATED=?, UPDATEAUTHOR=?, UPDATED=?, actionnum=? WHERE ID=? (Incorrect string value: '\xF0\x9F\x99\x88: ...' for column 'actionbody' at row 1)))  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202340.1570126979000.766.1570128840055%40Atlassian.JIRA.


[JIRA] (JENKINS-59650) Can't properly create Emoji Only Jobs (╯°□°)╯︵ ┻━┻

2019-10-03 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-59650  
 
 
  Can't properly create Emoji Only Jobs (╯°□°)╯︵ ┻━┻   
 

  
 
 
 
 

 
Change By: 
 Matthew Hall  
 
 
Labels: 
 emoji  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202340.1570126979000.765.1570128720067%40Atlassian.JIRA.


[JIRA] (JENKINS-59650) Can't properly create Emoji Only Jobs (╯°□°)╯︵ ┻━┻

2019-10-03 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall edited a comment on  JENKINS-59650  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Can't properly create Emoji Only Jobs (╯°□°)╯︵ ┻━┻   
 

  
 
 
 
 

 
 Also, to use another example. If I create :{noformat}See No Evil :see no evil monkey: {noformat}as a job, this works.If I try to create it as :{noformat}:see no evil monkey: See No Evil{noformat}It fails. (I can't use the actual monkey, due to Jira not taking it : It fails.][numvalue,null][updated,2019-10-03 18:41:35.326] (SQL Exception while executing the following:UPDATE jiraaction SET issueid=?, AUTHOR=?, actiontype=?, actionlevel=?, rolelevel=?, actionbody=?, CREATED=?, UPDATEAUTHOR=?, UPDATED=?, actionnum=? WHERE ID=? (Incorrect string value: '\xF0\x9F\x99\x88: ...' for column 'actionbody' at row 1)))  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202340.1570126979000.764.1570128180060%40Atlassian.JIRA.


[JIRA] (JENKINS-59650) Can't properly create Emoji Only Jobs (╯°□°)╯︵ ┻━┻

2019-10-03 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall commented on  JENKINS-59650  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Can't properly create Emoji Only Jobs (╯°□°)╯︵ ┻━┻   
 

  
 
 
 
 

 
 Also, to use another example. If I create : 

 
See No Evil :see no evil monkey:  

 as a job, this works. If I try to create it as : 

 
:see no evil monkey: See No Evil 

 It fails.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202340.1570126979000.763.1570128120051%40Atlassian.JIRA.


[JIRA] (JENKINS-59650) Can't properly create Emoji Only Jobs (╯°□°)╯︵ ┻━┻

2019-10-03 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall edited a comment on  JENKINS-59650  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Can't properly create Emoji Only Jobs (╯°□°)╯︵ ┻━┻   
 

  
 
 
 
 

 
 {noformat} [root@jmtest jobs]# cd  \ (╯°□° \ )╯︵\ ┻━┻/[root@jmtest (╯°□°)╯︵ ┻━┻]# lsbuilds  config.xml[root@jmtest (╯°□°)╯︵ ┻━┻]# ls -altotal 32drwxr-xr-x   3 jenkins jenkins  4096 Oct  3 11:19 .drwxr-xr-x 405 jenkins jenkins 20480 Oct  3 11:19 ..drwxr-xr-x   2 jenkins jenkins  4096 Oct  3 11:19 builds - rw- r rr - -r--    1 jenkins jenkins   206 Oct  3 11:19 config.xml[root@jmtest (╯°□°)╯︵ ┻━┻]# more config.xml   false  false[root@jmtest (╯°□°)╯︵ ┻━┻]# ls buildslegacyIds[root@jmtest (╯°□°)╯︵ ┻━┻]# pwd/home/jenkins/jobs/(╯°□°)╯︵ ┻━┻  {noformat}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202340.1570126979000.762.1570127340070%40Atlassian.JIRA.


[JIRA] (JENKINS-59650) Can't properly create Emoji Only Jobs (╯°□°)╯︵ ┻━┻

2019-10-03 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall edited a comment on  JENKINS-59650  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Can't properly create Emoji Only Jobs (╯°□°)╯︵ ┻━┻   
 

  
 
 
 
 

 
 {{ [root@jmtest jobs]# cd \(╯°□°\)╯︵\ ┻━┻/[root@jmtest (╯°□°)╯︵ ┻━┻]# lsbuilds  config.xml[root@jmtest (╯°□°)╯︵ ┻━┻]# ls -altotal 32drwxr-xr-x   3 jenkins jenkins  4096 Oct  3 11:19 .drwxr-xr-x 405 jenkins jenkins 20480 Oct  3 11:19 ..drwxr-xr-x   2 jenkins jenkins  4096 Oct  3 11:19 builds-rw-r--r--   1 jenkins jenkins   206 Oct  3 11:19 config.xml[root@jmtest (╯°□°)╯︵ ┻━┻]# more config.xml   false  false[root@jmtest (╯°□°)╯︵ ┻━┻]# ls buildslegacyIds[root@jmtest (╯°□°)╯︵ ┻━┻]# pwd/home/jenkins/jobs/(╯°□°)╯︵ ┻━┻ }}   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202340.1570126979000.761.1570127280056%40Atlassian.JIRA.


[JIRA] (JENKINS-59650) Can't properly create Emoji Only Jobs (╯°□°)╯︵ ┻━┻

2019-10-03 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall commented on  JENKINS-59650  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Can't properly create Emoji Only Jobs (╯°□°)╯︵ ┻━┻   
 

  
 
 
 
 

 
 {{[root@jmtest jobs]# cd (╯°□°)╯︵\ ┻━┻/ [root@jmtest (╯°□°)╯︵ ┻━┻]# ls builds config.xml [root@jmtest (╯°□°)╯︵ ┻━┻]# ls -al total 32 drwxr-xr-x 3 jenkins jenkins 4096 Oct 3 11:19 . drwxr-xr-x 405 jenkins jenkins 20480 Oct 3 11:19 .. drwxr-xr-x 2 jenkins jenkins 4096 Oct 3 11:19 builds rw-rr- 1 jenkins jenkins 206 Oct 3 11:19 config.xml [root@jmtest (╯°□°)╯︵ ┻━┻]# more config.xmlfalse   false  [root@jmtest (╯°□°)╯︵ ┻━┻]# ls builds legacyIds [root@jmtest (╯°□°)╯︵ ┻━┻]# pwd /home/jenkins/jobs/(╯°□°)╯︵ ┻━┻}}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202340.1570126979000.760.1570127220062%40Atlassian.JIRA.


[JIRA] (JENKINS-59650) Can't properly create Emoji Only Jobs (╯°□°)╯︵ ┻━┻

2019-10-03 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-59650  
 
 
  Can't properly create Emoji Only Jobs (╯°□°)╯︵ ┻━┻   
 

  
 
 
 
 

 
Change By: 
 Matthew Hall  
 
 
Attachment: 
 stacktrace.log  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202340.1570126979000.759.1570127100141%40Atlassian.JIRA.


[JIRA] (JENKINS-59650) Can't properly create Emoji Only Jobs (╯°□°)╯︵ ┻━┻

2019-10-03 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-59650  
 
 
  Can't properly create Emoji Only Jobs (╯°□°)╯︵ ┻━┻   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Components: 
 core  
 
 
Created: 
 2019-10-03 18:22  
 
 
Environment: 
 Jenkins 2.190.1  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Matthew Hall  
 

  
 
 
 
 

 
 Tried to create job named "(╯°□°)╯︵ ┻━┻" Expected results : Would move to job configuration page.  Actual results : (java stack trace) Now, if I create a similar job, but I use some leading ascii text, eg: Tried to create job named : "TBF (╯°□°)╯︵ ┻━┻" Expected results : Would move to job configuration page. Actual results : Moved to job configuration page.  If I inspect the JENKINS_HOME/jobs directory, the (╯°□°)╯︵ ┻━┻ directory does get created, but I am unable to configure this through the GUI.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

[JIRA] (JENKINS-56595) Regression: higher than usual CPU usage with 2.164.1

2019-04-30 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall edited a comment on  JENKINS-56595  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Regression: higher than usual CPU usage with 2.164.1   
 

  
 
 
 
 

 
 This sounds almost exactly like our failed upgrade attempt from 2.121.3 to 2.150.3. We were comfortably running with 4GB heap, and then suddenly the CPU was pegged, UI was slow to unresponsive. Had to revert back to 2.121.3. I did grab 1 threaddump   [^threaddump-1552681298816.tdump]  before reverting. But if you're looking for root cause changes, may want to include >= 2.121.3.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56595) Regression: higher than usual CPU usage with 2.164.1

2019-04-30 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall edited a comment on  JENKINS-56595  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Regression: higher than usual CPU usage with 2.164.1   
 

  
 
 
 
 

 
 This sounds almost exactly like our failed upgrade attempt from 2.121.3 to 2.150.3. We were comfortably running with 4GB heap, and then suddenly the CPU was pegged, UI was slow to unresponsive. Had to revert back to 2.121.3.  Sadly,  I did  not  grab  any thread dumps at the time  1 threaddump before reverting . But if you're looking for root cause changes, may want to include >= 2.121.3.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56595) Regression: higher than usual CPU usage with 2.164.1

2019-04-30 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-56595  
 
 
  Regression: higher than usual CPU usage with 2.164.1   
 

  
 
 
 
 

 
Change By: 
 Matthew Hall  
 
 
Attachment: 
 threaddump-1552681298816.tdump  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56595) Regression: higher than usual CPU usage with 2.164.1

2019-04-30 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall commented on  JENKINS-56595  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Regression: higher than usual CPU usage with 2.164.1   
 

  
 
 
 
 

 
 This sounds almost exactly like our failed upgrade attempt from 2.121.3 to 2.150.3. We were comfortably running with 4GB heap, and then suddenly the CPU was pegged, UI was slow to unresponsive. Had to revert back to 2.121.3. Sadly, I did not grab any thread dumps at the time. But if you're looking for root cause changes, may want to include >= 2.121.3.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-55308) intermittent "terminated" messages using sh in Pipelines

2019-02-19 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall commented on  JENKINS-55308  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: intermittent "terminated" messages using sh in Pipelines   
 

  
 
 
 
 

 
 Also seeing this. Jenkins 2.150.3 and durable-task 1.29, which was an upgrade from 1.25.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56162) p4 plugin doesn't add '/...' to older p4sync calls.

2019-02-19 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall commented on  JENKINS-56162  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: p4 plugin doesn't add '/...' to older p4sync calls.   
 

  
 
 
 
 

 
 Thanks for the info Karl. This is a rough change to suddenly run into, because we now have to go and fix several hundred Jenkinsfiles across multiple teams and groups.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56162) p4 plugin doesn't add '/...' to older p4sync calls.

2019-02-15 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-56162  
 
 
  p4 plugin doesn't add '/...' to older p4sync calls.   
 

  
 
 
 
 

 
Change By: 
 Matthew Hall  
 

  
 
 
 
 

 
 Updating our p4 plugin from 1.8.12 to 1.9.6, we find that jobs using the older p4sync, where the trailing '/...' was optional, fails to write out useful/working p4 clients. For p4sync call:{code:java} p4sync(charset: 'none', credential: credential, depotPath: '//depot/svrtools/mainline/sme-tools/jenkins_test',   format: user + '-${NODE_NAME}-${JOB_NAME}', populate: [ $class: 'AutoCleanImpl', delete: true, modtime: false, parallel: [   enable: false, minbytes: '1024', minfiles: '1',   path: '/usr/local/bin/p4', threads: '4' ], pin: '', quiet: true, replace: true   ]  ){code}We get in the resultant client:{noformat}View: //depot/svrtools/mainline/sme-tools/jenkins_test //build-repo01-jenkins-test/jenkins_test{noformat}Which then fails to sync/checkout anything. The log output is attached as 'a.txt' Behaviour of this seems changed in :https://swarm.workshop.perforce.com/changes/24767If we revert plugin to older, and then delete generated client, we see the difference in c.txt output. We also see our view has changed : {noformat}View: //d-alviso/svrtools/mainline/sme-tools/jenkins_test/... //build-repo01-jenkins-test/...{noformat}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  

[JIRA] (JENKINS-56162) p4 plugin doesn't add '/...' to older p4sync calls.

2019-02-15 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-56162  
 
 
  p4 plugin doesn't add '/...' to older p4sync calls.   
 

  
 
 
 
 

 
Change By: 
 Matthew Hall  
 
 
Attachment: 
 c.txt  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56162) p4 plugin doesn't add '/...' to older p4sync calls.

2019-02-15 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-56162  
 
 
  p4 plugin doesn't add '/...' to older p4sync calls.   
 

  
 
 
 
 

 
Change By: 
 Matthew Hall  
 

  
 
 
 
 

 
 Updating our p4 plugin from 1.8.12 to 1.9.6, we find that jobs using the older p4sync, where the trailing '/...' was optional, fails to write out useful/working p4 clients. For p4sync call:{code:java} p4sync(charset: 'none', credential: credential, depotPath: '//depot/svrtools/mainline/sme-tools/jenkins_test',   format: user + '-${NODE_NAME}-${JOB_NAME}', populate: [ $class: 'AutoCleanImpl', delete: true, modtime: false, parallel: [   enable: false, minbytes: '1024', minfiles: '1',   path: '/usr/local/bin/p4', threads: '4' ], pin: '', quiet: true, replace: true   ]  ){code}We get in the resultant client:{noformat}View: //depot/svrtools/mainline/sme-tools/jenkins_test //build-repo01-jenkins-test/jenkins_test{noformat}Which then fails to sync/checkout anything. The log output is attached as 'a.txt' Behaviour of this seems changed in :https://swarm.workshop.perforce.com/changes/24767 If we revert plugin to older, and then delete generated client, we see the difference in c.txt output.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google 

[JIRA] (JENKINS-56162) p4 plugin doesn't add '/...' to older p4sync calls.

2019-02-15 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-56162  
 
 
  p4 plugin doesn't add '/...' to older p4sync calls.   
 

  
 
 
 
 

 
Change By: 
 Matthew Hall  
 

  
 
 
 
 

 
 Updating our p4 plugin from 1.8.12 to 1.9.6, we find that jobs using the older p4sync, where the trailing '/...' was optional, fails to write out useful/working p4 clients. For p4sync call: {code:java}  p4sync(charset: 'none', credential: credential, depotPath: '//depot/svrtools/mainline/sme-tools/jenkins_test',   format: user + '-${NODE_NAME}-${JOB_NAME}', populate: [ $class: 'AutoCleanImpl', delete: true, modtime: false, parallel: [   enable: false, minbytes: '1024', minfiles: '1',   path: '/usr/local/bin/p4', threads: '4' ], pin: '', quiet: true, replace: true   ]  ) {code}   We get in the resultant client: {noformat} View: //depot/svrtools/mainline/sme-tools/jenkins_test //build-repo01-jenkins-test/jenkins_test {noformat}   Which then fails to sync/checkout anything. The log output is attached as 'a.txt' Behaviour of this seems changed in :https://swarm.workshop.perforce.com/changes/24767  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails 

[JIRA] (JENKINS-56162) p4 plugin doesn't add '/...' to older p4sync calls.

2019-02-15 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-56162  
 
 
  p4 plugin doesn't add '/...' to older p4sync calls.   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Attachments: 
 a.txt  
 
 
Components: 
 p4-plugin  
 
 
Created: 
 2019-02-15 21:49  
 
 
Priority: 
  Major  
 
 
Reporter: 
 Matthew Hall  
 

  
 
 
 
 

 
 Updating our p4 plugin from 1.8.12 to 1.9.6, we find that jobs using the older p4sync, where the trailing '/...' was optional, fails to write out useful/working p4 clients.  For p4sync call:  p4sync(charset: 'none', credential: credential, depotPath: '//depot/svrtools/mainline/sme-tools/jenkins_test', format: user + '${NODE_NAME}${JOB_NAME}', populate: [ $class: 'AutoCleanImpl', delete: true, modtime: false, parallel: [ enable: false, minbytes: '1024', minfiles: '1', path: '/usr/local/bin/p4', threads: '4' ], pin: '', quiet: true, replace: true ] ) We get in the resultant client: View: //depot/svrtools/mainline/sme-tools/jenkins_test //build-repo01-jenkins-test/jenkins_test Which then fails to sync/checkout anything.  The log output is attached as 'a.txt'  Behaviour of this seems changed in : https://swarm.workshop.perforce.com/changes/24767  
 

  
 
 
 
 

 
 
 

 
   

[JIRA] (JENKINS-51954) p4 plugin release2 messages

2018-09-26 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall commented on  JENKINS-51954  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: p4 plugin release2 messages   
 

  
 
 
 
 

 
 This message has since disappeared. These things were likely/possibly the cause :  1) Sheer number of builds configured (400+) with H/15 or H/5 polling. (every 15 or every 5 minute). Solution : Normalized polling to H/15 across all builds.  2) Limited nproc, which limited the # of java threads. Since each build consumes a polling thread, the larger the number of builds, the more likely to hit the limit. Solution : Raised nproc limit for the jenkins user.  Finally, we moved to a Poke model, with a backup "poll every 2 hours".  From observation, I think the "spike" at whatever H/15 or H/5 time for our builds (psuedo random), hitting the p4 server at once, was most likely the cause of the network issue.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-50800) workspace/* are not cleaned on SCM change.

2018-08-21 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall commented on  JENKINS-50800  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: workspace/* are not cleaned on SCM change.   
 

  
 
 
 
 

 
 Just so you know, any person with 'job change' permissions, and a jenkins server with config files stored in .git in $JENKINS_HOME, that user can effectively destroy/DOS the jenkins instance. Maybe someone will do something with this bug, because it's kind of dangerous.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-52613) cannot relaunch ssh agent, when node dies

2018-08-09 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall commented on  JENKINS-52613  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: cannot relaunch ssh agent, when node dies   
 

  
 
 
 
 

 
 OK, we applied the workaround you mentioned above, since the issue happened again today and it worked. What does that mean?   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-50800) workspace/* are not cleaned on SCM change.

2018-04-13 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-50800  
 
 
  workspace/* are not cleaned on SCM change.   
 

  
 
 
 
 

 
Change By: 
 Matthew Hall  
 

  
 
 
 
 

 
 When changing a Pipeline job from a Pipeline Perforce to a Pipeline git (just changing the SCM type) the workspace/* files and dirs should be cleaned up. Why? Because on the change from P4 -> Git, we can observe the following behaviour:Setup, Do an admin-like thing and make a git backup of your jenkins master home : cd into the Jenkins home directory (e.g., /var/lib/jenkins);git init && git add . && git commit -m `initial commit`Create a Pipeline job that pulls from Perforce to run a Jenkinsfile. Have it run once. Now change the Pipeline job to pull from Git (pretend you migrated your code or something). Run the job. Now see that most of the jenkins home is blown away.This is because when git encounters problems, git will traverse upwards looking for some usable .git directory. It will wind up in your jenkins home. The workaround, is that git or jenkins or pipeline should set "GIT_CEILING_DIRECTORIES" to prevent git from leaving the workspace directory.And cleanup the workspace/ on SCM change.
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 
 

[JIRA] (JENKINS-50800) workspace/* are not cleaned on SCM change.

2018-04-13 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-50800  
 
 
  workspace/* are not cleaned on SCM change.   
 

  
 
 
 
 

 
Change By: 
 Matthew Hall  
 

  
 
 
 
 

 
 When changing a Pipeline job from a Pipeline Perforce to a Pipeline git (just changing the SCM type) the workspace/* files and dirs should be cleaned up. Why? Because on the change from P4 -> Git, we can observe the following behaviour:Setup, Do an admin-like thing and make a git backup of your jenkins master home : cd into the Jenkins home directory (e.g., /var/lib/jenkins);git init && git add . && git commit -m `initial commit`Create a Pipeline job that pulls from Perforce to run a Jenkinsfile. Have it run once. Now change the Pipeline job to pull from Git (pretend you migrated your code or something). Run the job. Now see that most of the jenkins home is blown away.This is because when git encounters problems, git will traverse upwards looking for some usable .git directory. It will wind up in your jenkins home. The workaround, is that git or jenkins or pipeline should set "GIT_CEILING_DIRECTORIES" to prevent git from leaving the workspace directory. And cleanup the workspace/ * (@script in particular)  on SCM change.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

[JIRA] (JENKINS-50800) workspace/* are not cleaned on SCM change.

2018-04-13 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-50800  
 
 
  workspace/* are not cleaned on SCM change.   
 

  
 
 
 
 

 
Change By: 
 Matthew Hall  
 

  
 
 
 
 

 
  When changing a Pipeline job from a Pipeline Perforce to a Pipeline git (just changing the SCM type) the workspace/* files and dirs should be cleaned up. Why? Because on the change from P4 -> Git, we can observe the following behaviour:Setup, Do an admin-like thing and make a git backup of your jenkins master home : cd into the Jenkins home directory (e.g., /var/lib/jenkins);git init && git add . && git commit -m `initial commit`Create a Pipeline job that pulls from Perforce  to run a Jenkinsfile . Have it run once. Now change the Pipeline job to pull from Git (pretend you migrated your code or something). Run the job. Now see that most of the jenkins home is blown away.This is because when git encounters problems, git will traverse upwards looking for some usable .git directory. It will wind up in your jenkins home. The workaround, is that git or jenkins or pipeline should set "GIT_CEILING_DIRECTORIES" to prevent git from leaving the workspace directory.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

   

[JIRA] (JENKINS-50800) workspace/* are not cleaned on SCM change.

2018-04-13 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-50800  
 
 
  workspace/* are not cleaned on SCM change.   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Mark Waite  
 
 
Components: 
 git-plugin, pipeline  
 
 
Created: 
 2018-04-13 22:36  
 
 
Environment: 
 jenkins 2.89.3, pipeline 2.5, git 3.7.0  
 
 
Priority: 
  Major  
 
 
Reporter: 
 Matthew Hall  
 

  
 
 
 
 

 
 When changing a Pipeline job from a Pipeline Perforce to a Pipeline git (just changing the SCM type) the workspace/* files and dirs should be cleaned up.  Why? Because on the change from P4 -> Git, we can observe the following behaviour: Setup, Do an admin-like thing and make a git backup of your jenkins master home :  cd into the Jenkins home directory (e.g., /var/lib/jenkins); git init && git add . && git commit -m `initial commit` Create a Pipeline job that pulls from Perforce. Have it run once.  Now change the Pipeline job to pull from Git (pretend you migrated your code or something).  Run the job. Now see that most of the jenkins home is blown away. This is because when git encounters problems, git will traverse upwards looking for some usable .git directory. It will wind up in your jenkins home.  The workaround, is that git or jenkins or pipeline should set "GIT_CEILING_DIRECTORIES" to prevent git from leaving the workspace directory.   
 

  
 
 
 
 

 
 
 
   

[JIRA] (JENKINS-40356) NPE on p4 polling

2016-12-09 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall commented on  JENKINS-40356  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NPE on p4 polling   
 

  
 
 
 
 

 
 Polling appears to work fine with the Pipeline jobs, but with the Freestyle Project, it appears broken.  This seems odd.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40356) NPE on p4 polling

2016-12-09 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-40356  
 
 
  NPE on p4 polling   
 

  
 
 
 
 

 
Change By: 
 Matthew Hall  
 

  
 
 
 
 

 
 {noformat}Started on Dec 9, 2016 4:47:00 PMP4: Polling on: master with:build-master-b-anonymizer... p4 client -o build-master-b-anonymizer +... p4 info +P4 Task: establishing connection server: p4build.engr .tivo.com :1666... node: jmtest .tivo.com P4 Task: attempt: 1P4 Task: failed: java.lang.NullPointerExceptionP4 Task: failed: java.lang.NullPointerExceptionFATAL: AbortedDone. Took 4.6 secNo changes{noformat}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40356) NPE on p4 polling

2016-12-09 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall edited a comment on  JENKINS-40356  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NPE on p4 polling   
 

  
 
 
 
 

 
 This is from the jenkins.log :  {noformat}Dec 09, 2016 4:51:01 PM org.jenkinsci.plugins.p4.tasks.AbstractTask tryTaskSEVERE: P4 Task: attempt: 1java.lang.NullPointerException at org.jenkinsci.plugins.p4.client.ClientHelper.listHaveChanges(ClientHelper.java:1034) at org.jenkinsci.plugins.p4.tasks.PollTask.task(PollTask.java:52) at org.jenkinsci.plugins.p4.tasks.AbstractTask.tryTask(AbstractTask.java:209) at org.jenkinsci.plugins.p4.tasks.PollTask.invoke(PollTask.java:41) at org.jenkinsci.plugins.p4.tasks.PollTask.invoke(PollTask.java:25) at hudson.FilePath.act(FilePath.java:1018) at hudson.FilePath.act(FilePath.java:996) at org.jenkinsci.plugins.p4.PerforceScm.pollWorkspace(PerforceScm.java:352) at org.jenkinsci.plugins.p4.PerforceScm.compareRemoteRevisionWith(PerforceScm.java:297) at hudson.scm.SCM.compareRemoteRevisionWith(SCM.java:391) at hudson.scm.SCM.poll(SCM.java:408) at hudson.model.AbstractProject._poll(AbstractProject.java:1460) at hudson.model.AbstractProject.poll(AbstractProject.java:1363) at hudson.triggers.SCMTrigger$Runner.runPolling(SCMTrigger.java:528) at hudson.triggers.SCMTrigger$Runner.run(SCMTrigger.java:574) at hudson.util.SequentialExecutionQueue$QueueEntry.run(SequentialExecutionQueue.java:119) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745)Dec 09, 2016 4:51:04 PM org.jenkinsci.plugins.p4.tasks.AbstractTask tryTaskWARNING: P4 Task: failed: java.lang.NullPointerException{noformat}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

[JIRA] (JENKINS-40356) NPE on p4 polling

2016-12-09 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall commented on  JENKINS-40356  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: NPE on p4 polling   
 

  
 
 
 
 

 
 

 
Dec 09, 2016 4:51:01 PM org.jenkinsci.plugins.p4.tasks.AbstractTask tryTask
SEVERE: P4 Task: attempt: 1
java.lang.NullPointerException
	at org.jenkinsci.plugins.p4.client.ClientHelper.listHaveChanges(ClientHelper.java:1034)
	at org.jenkinsci.plugins.p4.tasks.PollTask.task(PollTask.java:52)
	at org.jenkinsci.plugins.p4.tasks.AbstractTask.tryTask(AbstractTask.java:209)
	at org.jenkinsci.plugins.p4.tasks.PollTask.invoke(PollTask.java:41)
	at org.jenkinsci.plugins.p4.tasks.PollTask.invoke(PollTask.java:25)
	at hudson.FilePath.act(FilePath.java:1018)
	at hudson.FilePath.act(FilePath.java:996)
	at org.jenkinsci.plugins.p4.PerforceScm.pollWorkspace(PerforceScm.java:352)
	at org.jenkinsci.plugins.p4.PerforceScm.compareRemoteRevisionWith(PerforceScm.java:297)
	at hudson.scm.SCM.compareRemoteRevisionWith(SCM.java:391)
	at hudson.scm.SCM.poll(SCM.java:408)
	at hudson.model.AbstractProject._poll(AbstractProject.java:1460)
	at hudson.model.AbstractProject.poll(AbstractProject.java:1363)
	at hudson.triggers.SCMTrigger$Runner.runPolling(SCMTrigger.java:528)
	at hudson.triggers.SCMTrigger$Runner.run(SCMTrigger.java:574)
	at hudson.util.SequentialExecutionQueue$QueueEntry.run(SequentialExecutionQueue.java:119)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
Dec 09, 2016 4:51:04 PM org.jenkinsci.plugins.p4.tasks.AbstractTask tryTask
WARNING: P4 Task: failed: java.lang.NullPointerException
 

  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
   

[JIRA] (JENKINS-40356) NPE on p4 polling

2016-12-09 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-40356  
 
 
  NPE on p4 polling   
 

  
 
 
 
 

 
Change By: 
 Matthew Hall  
 
 
Environment: 
 jdk 1.8.0_92, centos 5.8 jenkins master , p4 plugin 1.4.11  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40356) NPE on p4 polling

2016-12-09 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-40356  
 
 
  NPE on p4 polling   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Components: 
 p4-plugin  
 
 
Created: 
 2016/Dec/10 12:47 AM  
 
 
Environment: 
 jdk 1.8.0_92, centos 5.8 jenkins master  
 
 
Priority: 
  Critical  
 
 
Reporter: 
 Matthew Hall  
 

  
 
 
 
 

 
 

 
Started on Dec 9, 2016 4:47:00 PM
P4: Polling on: master with:build-master-b-anonymizer
... p4 client -o build-master-b-anonymizer +
... p4 info +

P4 Task: establishing connection.
... server: p4build.engr.tivo.com:1666
... node: jmtest.tivo.com
P4 Task: attempt: 1
P4 Task: failed: java.lang.NullPointerException
P4 Task: failed: java.lang.NullPointerException
FATAL: Aborted
Done. Took 4.6 sec
No changes
 

  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

[JIRA] (JENKINS-39806) poll on master filter has to exist and be true

2016-11-16 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall edited a comment on  JENKINS-39806  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: poll on master filter has to exist and be true   
 

  
 
 
 
 

 
 This looks A LOT like : JENKINS-38886 , except we don't use the matrix plugin  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-39806) poll on master filter has to exist and be true

2016-11-16 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall commented on  JENKINS-39806  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: poll on master filter has to exist and be true   
 

  
 
 
 
 

 
 This looks A LOT like : JENKINS-38886  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-39806) poll on master filter has to exist and be true

2016-11-16 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall edited a comment on  JENKINS-39806  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: poll on master filter has to exist and be true   
 

  
 
 
 
 

 
 (x) with no master polling config, or it being set to false we get this endlessly :{noformat}Started on Nov 16, 2016 5:27:00 PMP4: Polling on: master with:build-master-b-anonymizer2(p4):cmd:... p4 client -o build-master-b-anonymizer2p4 client -o build-master-b-anonymizer2(p4):stop:5(p4):cmd:... p4 infop4 info(p4):stop:6P4 Task: establishing connection server: p4build.engr:1666... node: jmtestP4: Polling with cstat: //build-master-b-anonymizer2/...(p4):cmd:... p4 cstat //build-master-b-anonymizer2/...p4 cstat //build-master-b-anonymizer2/...(p4):stop:7(p4):cmd:... p4 change -o 907153p4 change -o 907153(p4):stop:8... found change: 907153(p4):cmd:... p4 change -o 906764p4 change -o 906764(p4):stop:9... found change: 906764(p4):cmd:... p4 change -o 899757p4 change -o 899757(p4):stop:10... found change: 899757(p4):cmd:... p4 change -o 880387p4 change -o 880387(p4):stop:11... found change: 880387(p4):cmd:... p4 change -o 877423p4 change -o 877423(p4):stop:12... found change: 877423(p4):cmd:... p4 change -o 865976p4 change -o 865976(p4):stop:13... found change: 865976(p4):cmd:... p4 change -o 863525p4 change -o 863525(p4):stop:14... found change: 863525(p4):cmd:... p4 change -o 85p4 change -o 85(p4):stop:15... found change: 85(p4):cmd:... p4 change -o 854696p4 change -o 854696(p4):stop:16... found change: 854696(p4):cmd:... p4 change -o 853340p4 change -o 853340ETCDone. Took 2.5 secChanges found{noformat}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message 

[JIRA] (JENKINS-39806) poll on master filter has to exist and be true

2016-11-16 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall edited a comment on  JENKINS-39806  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: poll on master filter has to exist and be true   
 

  
 
 
 
 

 
 with no master polling config, or it being set to false we get  this endlessly  :{noformat}Started on Nov 16, 2016 5:27:00 PMP4: Polling on: master with:build-master-b-anonymizer2(p4):cmd:... p4 client -o build-master-b-anonymizer2p4 client -o build-master-b-anonymizer2(p4):stop:5(p4):cmd:... p4 infop4 info(p4):stop:6P4 Task: establishing connection server: p4build.engr:1666... node: jmtestP4: Polling with cstat: //build-master-b-anonymizer2/...(p4):cmd:... p4 cstat //build-master-b-anonymizer2/...p4 cstat //build-master-b-anonymizer2/...(p4):stop:7(p4):cmd:... p4 change -o 907153p4 change -o 907153(p4):stop:8... found change: 907153(p4):cmd:... p4 change -o 906764p4 change -o 906764(p4):stop:9... found change: 906764(p4):cmd:... p4 change -o 899757p4 change -o 899757(p4):stop:10... found change: 899757(p4):cmd:... p4 change -o 880387p4 change -o 880387(p4):stop:11... found change: 880387(p4):cmd:... p4 change -o 877423p4 change -o 877423(p4):stop:12... found change: 877423(p4):cmd:... p4 change -o 865976p4 change -o 865976(p4):stop:13... found change: 865976(p4):cmd:... p4 change -o 863525p4 change -o 863525(p4):stop:14... found change: 863525(p4):cmd:... p4 change -o 85p4 change -o 85(p4):stop:15... found change: 85(p4):cmd:... p4 change -o 854696p4 change -o 854696(p4):stop:16... found change: 854696(p4):cmd:... p4 change -o 853340p4 change -o 853340ETCDone. Took 2.5 secChanges found{noformat}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message 

[JIRA] (JENKINS-39806) poll on master filter has to exist and be true

2016-11-16 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall edited a comment on  JENKINS-39806  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: poll on master filter has to exist and be true   
 

  
 
 
 
 

 
  (/) with the correct master polling xml, the polling log looks like : {noformat}[root@jmtest b-anonymizer2]# more scm-polling.logStarted on Nov 16, 2016 5:59:00 PMP4: Polling on: master with:build-master-b-anonymizer2(p4):cmd:... p4 client -o build-master-b-anonymizer2p4 client -o build-master-b-anonymizer2(p4):stop:5(p4):cmd:... p4 infop4 info(p4):stop:6P4 Task: establishing connection server: p4build.engr:1666... node: jmtest.P4: Polling with range: 944905,now(p4):cmd:... p4 changes //build-master-b-anonymizer2/...@944905,nowp4 changes //build-master-b-anonymizer2/...@944905,nowChange 944905 on 2016/09/28 by@ '   Add some compile depende'(p4):stop:7Done. Took 1.7 secNo changes{noformat}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-39806) poll on master filter has to exist and be true

2016-11-16 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall commented on  JENKINS-39806  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: poll on master filter has to exist and be true   
 

  
 
 
 
 

 
 Note the difference in how p4 determines changes, one using p4 changes, the other using cstat ?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-39806) poll on master filter has to exist and be true

2016-11-16 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall commented on  JENKINS-39806  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: poll on master filter has to exist and be true   
 

  
 
 
 
 

 
 with no master polling config, or it being set to false we get : 

 
Started on Nov 16, 2016 5:27:00 PM
P4: Polling on: master with:build-master-b-anonymizer2
(p4):cmd:... p4 client -o build-master-b-anonymizer2
p4 client -o build-master-b-anonymizer2

(p4):stop:5
(p4):cmd:... p4 info
p4 info

(p4):stop:6

P4 Task: establishing connection.
... server: p4build.engr:1666
... node: jmtest
P4: Polling with cstat: //build-master-b-anonymizer2/...
(p4):cmd:... p4 cstat //build-master-b-anonymizer2/...
p4 cstat //build-master-b-anonymizer2/...

(p4):stop:7
(p4):cmd:... p4 change -o 907153
p4 change -o 907153

(p4):stop:8
... found change: 907153
(p4):cmd:... p4 change -o 906764
p4 change -o 906764

(p4):stop:9
... found change: 906764
(p4):cmd:... p4 change -o 899757
p4 change -o 899757

(p4):stop:10
... found change: 899757
(p4):cmd:... p4 change -o 880387
p4 change -o 880387

(p4):stop:11
... found change: 880387
(p4):cmd:... p4 change -o 877423
p4 change -o 877423

(p4):stop:12
... found change: 877423
(p4):cmd:... p4 change -o 865976
p4 change -o 865976

(p4):stop:13
... found change: 865976
(p4):cmd:... p4 change -o 863525
p4 change -o 863525

(p4):stop:14
... found change: 863525
(p4):cmd:... p4 change -o 85
p4 change -o 85

(p4):stop:15
... found change: 85
(p4):cmd:... p4 change -o 854696
p4 change -o 854696

(p4):stop:16
... found change: 854696
(p4):cmd:... p4 change -o 853340
p4 change -o 853340

ETC
Done. Took 2.5 sec
Changes found
 

  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   

[JIRA] (JENKINS-39806) poll on master filter has to exist and be true

2016-11-16 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall commented on  JENKINS-39806  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: poll on master filter has to exist and be true   
 

  
 
 
 
 

 
 with the correct master polling xml, the polling log looks like :  

 
[root@jmtest b-anonymizer2]# more scm-polling.log
Started on Nov 16, 2016 5:59:00 PM
P4: Polling on: master with:build-master-b-anonymizer2
(p4):cmd:... p4 client -o build-master-b-anonymizer2
p4 client -o build-master-b-anonymizer2

(p4):stop:5
(p4):cmd:... p4 info
p4 info

(p4):stop:6

P4 Task: establishing connection.
... server: p4build.engr:1666
... node: jmtest.
P4: Polling with range: 944905,now
(p4):cmd:... p4 changes //build-master-b-anonymizer2/...@944905,now
p4 changes //build-master-b-anonymizer2/...@944905,now

Change 944905 on 2016/09/28 by@ '   Add some compile depende'
(p4):stop:7
Done. Took 1.7 sec
No changes
 

  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-39806) poll on master filter has to exist and be true

2016-11-16 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-39806  
 
 
  poll on master filter has to exist and be true   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Components: 
 p4-plugin  
 
 
Created: 
 2016/Nov/17 1:59 AM  
 
 
Environment: 
 p4 plugin 1.4.9  jenkins lts 2.19.1  
 
 
Priority: 
  Major  
 
 
Reporter: 
 Matthew Hall  
 

  
 
 
 
 

 
 upgrading from 1.4.8, we find that our p4 polling jobs were endlessly polling, seeing new changes, and building. If the "poll on master" xml in the job/config.xml does not exist, this will loop builds into an endless check for changes, all changes are new, do build, repeat, loop.  workaround is to add the filter for poll on master, and enable it to true.  config.xml gets this added to it :  

 

  
true
  

 

 old behaviour of the plugin was to poll on node by default.   
 

  
 
 
 
 

 
 
 

 
 
   

[JIRA] (JENKINS-39257) p4 plugin escapes/converts plaintext to HTML

2016-10-25 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall commented on  JENKINS-39257  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: p4 plugin escapes/converts plaintext to HTML   
 

  
 
 
 
 

 
 The changelog.xml on disk looks like :  

 
[root@ 67]# pwd
/home/jenkins/jobs/b-monitoring/builds/67
[root@ 67]# more changelog.xml 


	
		953319
		redacted-monitoring
		   SUMMARY: Dont reuse variables.

   DETAILS: The code was trying to create a new properties dict
   for each topic, but was instead reusing the same one over and
   over. Make it use a new copy each time. This doesnt cause a
   functional change, but makes the code cleaner.

   OTS: redacted (visual OTS)

   TESTING: None

		redacted
		2016-10-25 14:20:04
		false
		
		
		
		
		
		
	

 

  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-39257) p4 plugin escapes/converts plaintext to HTML

2016-10-25 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall commented on  JENKINS-39257  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: p4 plugin escapes/converts plaintext to HTML   
 

  
 
 
 
 

 
 To be clear which URL/endpoint I'm referring to : 
 
 http://jenkins:8080/job/b-monitoring/changes (displays changes correctly) 
 http://jenkins:8080/job/b-monitoring/67/changes (renders the above wrong output) 
  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-39257) p4 plugin escapes/converts plaintext to HTML

2016-10-25 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall edited a comment on  JENKINS-39257  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: p4 plugin escapes/converts plaintext to HTML   
 

  
 
 
 
 

 
  This is what the change actually looks like when asking the p4 server : {noformat}$ p4 change -o 953319# A Perforce Change Specification.# #  Change:  The change number .  'new' on a new changelist . #  Date:The date this specification was last modified . #  Client:  The client on which the changelist was created.  Read-only.#  User:The user who created the changelist.#  Status:  Either 'pending' or 'submitted'. Read-only.#  Type:Either 'public' or 'restricted'. Default is 'public'.#  Description: Comments about the changelist.  Required.#  ImportedBy:  The user who fetched or pushed this change to this server.#  Identity:Identifier for this change.#  Jobs:What opened jobs are to be closed by this changelist.#   You may delete jobs from this list.  (New changelists only.)#  Files:   What opened files from the default changelist are to be added#   to this changelist.  You may delete files from this list.#   (New changelists only.) Change: 953319Date: 2016/10/25 14:20:04Client: redacted-monitoringUser: redactedStatus: submittedDescription:SUMMARY: Don't reuse variables. DETAILS: The code was trying to create a new properties dictfor each topic, but was instead reusing the same one over andover. Make it use a new copy each time. This doesn't cause afunctional change, but makes the code cleaner. OTS: redacted (visual OTS) TESTING: None{noformat}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

[JIRA] (JENKINS-39257) p4 plugin escapes/converts plaintext to HTML

2016-10-25 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall commented on  JENKINS-39257  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: p4 plugin escapes/converts plaintext to HTML   
 

  
 
 
 
 

 
 This is what the change actually looks like when asking the p4 server :  

 
$ p4 change -o 953319
# A Perforce Change Specification.
#
#  Change:  The change number. 'new' on a new changelist.
#  Date:The date this specification was last modified.
#  Client:  The client on which the changelist was created.  Read-only.
#  User:The user who created the changelist.
#  Status:  Either 'pending' or 'submitted'. Read-only.
#  Type:Either 'public' or 'restricted'. Default is 'public'.
#  Description: Comments about the changelist.  Required.
#  ImportedBy:  The user who fetched or pushed this change to this server.
#  Identity:Identifier for this change.
#  Jobs:What opened jobs are to be closed by this changelist.
#   You may delete jobs from this list.  (New changelists only.)
#  Files:   What opened files from the default changelist are to be added
#   to this changelist.  You may delete files from this list.
#   (New changelists only.)

Change:	953319

Date:	2016/10/25 14:20:04

Client:	redacted-monitoring

User:	redacted

Status:	submitted

Description:
	   SUMMARY: Don't reuse variables.
	
	   DETAILS: The code was trying to create a new properties dict
	   for each topic, but was instead reusing the same one over and
	   over. Make it use a new copy each time. This doesn't cause a
	   functional change, but makes the code cleaner.
	
	   OTS: redacted (visual OTS)
	
	   TESTING: None

 

  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 


[JIRA] (JENKINS-39257) p4 plugin escapes/converts plaintext to HTML

2016-10-25 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-39257  
 
 
  p4 plugin escapes/converts plaintext to HTML   
 

  
 
 
 
 

 
Change By: 
 Matthew Hall  
 
 
Summary: 
 p4 plugin escapes /converts plaintext to  HTML  in changelist  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-39257) p4 plugin escapes HTML in changelist

2016-10-25 Thread mh...@tivo.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthew Hall created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-39257  
 
 
  p4 plugin escapes HTML in changelist   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Components: 
 p4-plugin  
 
 
Created: 
 2016/Oct/25 11:04 PM  
 
 
Environment: 
 jenkins 2.19.1  p4 plugin 1.4.8  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Matthew Hall  
 

  
 
 
 
 

 
 p4 plugin, when inspecting the 'Changes' link, shows all output as escaped and barely readable plaintext with html mixed in.  

 
953319 by userredacted@userredacted-monitoring on Oct 25, 2016 2:20:04 PM
SUMMARY: Dont reuse variables. DETAILS: The code was trying to create a new properties dict for each topic, but was instead reusing the same one over and over. Make it use a new copy each time. This doesnt cause a functional change, but makes the code cleaner. OTS: userredacted (visual OTS) TESTING: None 
Submitted Files:
 //somepath/somefile.py #3