[JIRA] (JENKINS-40803) Endless Loop when "provisoning config files..." when run from a build promotion
Title: Message Title Michael Wiles commented on JENKINS-40803 Re: Endless Loop when "provisoning config files..." when run from a build promotion How do you suggest we get the owner? as JobProperty does not expose it (no getOwner method). There is a setOwner method but no getOwner. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40803) Endless Loop when "provisoning config files..." when run from a build promotion
Title: Message Title Michael Wiles commented on JENKINS-40803 Re: Endless Loop when "provisoning config files..." when run from a build promotion Some thoughts... My knee jerk reaction to what I'm seeing is to conclude that the folder "plugin" should not be a plugin. It has a very significant impact on the broader architecture of jenkins and to have to support both situations (without and without folder plugin) is going lead to a lot of clunky code. Folder is not part of the core model of jenkins but once a plugin has been changed to support folders it now depends on the folder plugin and you might find that so many plugins need to depend on Folder plugin... Although I guess it makes sense to migrate each plugin to support folders one at a time. Not having folders as a first class citizen does allow for some of this. What is pertinent is that the passed in JobPropertyImpl has an owner (project), which then has a parent (folder) and you can then get to the relevant config file via this folder (the way you do with the abstract folder). The issue is that each of the players, JobProperty, ItemGroup and Project all need some visibility into the existence of folders. I can't see how either promoted builds or config file provider plugins can be changed to solve this particular issue as it is not a folder that is passed in but something that exists in a folder. Ultimately both plugins need to change to somehow support folders but without folders being part of the core model I fear that change will go too deep and have too many side effects. Unless ItemGroup can somehow be made aware of its context we're not going to make much progress, and given that itemGroup is part of core I'm not sure how that is going to happen. At least the change I did stops the endless loop but it of course does not allow for config files in folders to be usable from the promoted builds plugin. As I've changed it only global config files are available for use in the promoted builds plugin. A limitation that I am happy with as I depend on promoted builds having exposure to config files. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
[JIRA] (JENKINS-40803) Endless Loop when "provisoning config files..." when run from a build promotion
Title: Message Title Michael Wiles commented on JENKINS-40803 Re: Endless Loop when "provisoning config files..." when run from a build promotion I suspected my change wouldn't work for all cases. How do you create a config not at global scope? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40803) Endless Loop when "provisoning config files..." when run from a build promotion
Title: Message Title
Michael Wiles commented on JENKINS-40803
Re: Endless Loop when "provisoning config files..." when run from a build promotion
support_2017-01-04_13.41.53.zip generated by Support Core Plugin. Unfortunately I could not call this plugin while the promotion was in the endless loop was happening as while I was debugging I managed to replace that code with code that works and now my jenkins can promote again so I don't want to undo that change. I was unable to roll back to a previous version so getting round this hang was my only option. I made it
if (itemGroup instanceof Item) {
itemGroup = Item.class.cast(itemGroup).getParent();
} else {
// we are on top scope...
return (T) GlobalConfigFiles.get().getById(configId);
}
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40803) Endless Loop when "provisoning config files..." when run from a build promotion
Title: Message Title Michael Wiles edited a comment on JENKINS-40803 Re: Endless Loop when "provisoning config files..." when run from a build promotion Config [^config .xml ] is now attached. [^config.xml] and you'll need [^org.jenkinsci.plugins.configfiles.GlobalConfigFiles.xml] which goes in the "root" of JenkinsAnd you'll need promoted builds and config file provider plugin.But to reproduce manually:# Install config provider plugin# Install promoted builds plugin# Create config file (custom config file)# Create job (freestyle - I made mine just execute a shell (echo something))# Create Promotion # Add as step provide configuration files# Run job (to make promotion available)# Run promotion - promotion will hang at provisioning configuration files. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40803) Endless Loop when "provisoning config files..." when run from a build promotion
Title: Message Title Michael Wiles commented on JENKINS-40803 Re: Endless Loop when "provisoning config files..." when run from a build promotion Config.xml is now attached. config.xml and you'll need org.jenkinsci.plugins.configfiles.GlobalConfigFiles.xml which goes in the "root" of Jenkins And you'll need promoted builds and config file provider plugin. But to reproduce manually: Install config provider plugin Install promoted builds plugin Create config file (custom config file) Create job (freestyle - I made mine just execute a shell (echo something)) Create Promotion Add as step provide configuration files Run job (to make promotion available) Run promotion - promotion will hang at provisioning configuration files. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit
[JIRA] (JENKINS-40803) Endless Loop when "provisoning config files..." when run from a build promotion
Title: Message Title Michael Wiles updated an issue Jenkins / JENKINS-40803 Endless Loop when "provisoning config files..." when run from a build promotion Change By: Michael Wiles Attachment: support_2017-01-04_13.41.53.zip Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40803) Endless Loop when "provisoning config files..." when run from a build promotion
Title: Message Title Michael Wiles updated an issue Jenkins / JENKINS-40803 Endless Loop when "provisoning config files..." when run from a build promotion Change By: Michael Wiles Attachment: config.xml Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40803) Endless Loop when "provisoning config files..." when run from a build promotion
Title: Message Title Michael Wiles updated an issue Jenkins / JENKINS-40803 Endless Loop when "provisoning config files..." when run from a build promotion Change By: Michael Wiles Attachment: org.jenkinsci.plugins.configfiles.GlobalConfigFiles.xml Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40803) Endless Loop when "provisoning config files..." when run from a build promotion
Title: Message Title Michael Wiles commented on JENKINS-40803 Re: Endless Loop when "provisoning config files..." when run from a build promotion Definitely top level. I have not used folders as yet. I suspect I'll be able to replicate this on a stand alone instance so I'll get it a go. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40803) Endless Loop when "provisoning config files..." when run from a build promotion
Title: Message Title
Michael Wiles updated an issue
Jenkins / JENKINS-40803
Endless Loop when "provisoning config files..." when run from a build promotion
Change By:
Michael Wiles
My symptom is when I click promote I get the following output:Started by user x...@mydomain.comBuilding on master in workspace /var/lib/jenkins/jobs/Package for Release /workspacePromoting JOB BEING PROMOTEDprovisoning config files...And it sits there... Part A snapshot of the stack trace is: {quote}at org.jenkinsci.plugins.configfiles.ConfigFiles.getByIdOrNull(ConfigFiles.java:82) at org.jenkinsci.plugins.configfiles.ConfigFiles.getByIdOrNull(ConfigFiles.java:103) at org.jenkinsci.plugins.configfiles.ConfigFiles.getByIdOrNull(ConfigFiles.java:114) at org.jenkinsci.plugins.configfiles.buildwrapper.ManagedFileUtil.provisionConfigFiles(ManagedFileUtil.java:81) at org.jenkinsci.plugins.configfiles.builder.ConfigFileBuildStep.perform(ConfigFileBuildStep.java:61) at hudson.plugins.promoted_builds.Promotion$RunnerImpl.build(Promotion.java:405) at hudson.plugins.promoted_builds.Promotion$RunnerImpl.doRun(Promotion.java:347) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:534) at hudson.model.Run.execute(Run.java:1729) at hudson.model.Run.run(Run.java:1688) at hudson.plugins.promoted_builds.Promotion.run(Promotion.java:286) at hudson.model.ResourceController.execute(ResourceController.java:98) at hudson.model.Executor.run(Executor.java:404){quote}This method: getByIdOrNull at the plugin version I'm on (config files provider: 2.15.1) is the following:{code:java}public static T getByIdOrNull(@Nullable ItemGroup itemGroup, @NonNull String configId) {while (itemGroup != null) {if (folderPluginInstalled() && itemGroup instanceof AbstractFolder) {final AbstractFolder folder = AbstractFolder.class.cast(itemGroup);ConfigFileStore store = folder.getProperties().get(FolderConfigFileProperty.class);if (store != null) {Config config = store.getById(configId);if (config != null) { return (T) config;}}}if (itemGroup instanceof Item) {itemGroup = Item.class.cast(itemGroup).getParent();}if (itemGroup instanceof Jenkins) {// we are on top scope...return (T) GlobalConfigFiles.get().getById(configId);} else {continue;}}return null;}{code}After attaching the debugger I've found that the reason I'm getting this behaviour is because this method does not return.It just loops around and around.The real type of the passed in itemGroup is hudson.plugins.promoted_builds.JobPropertyImpl # Folder Plugins is installed but itemGroup is not an instance of AbstractFolder# JobPropertyImpl is not an instance of Item# JobPropertyImpl is not an instance of Jenkins either.So this method will never
[JIRA] (JENKINS-40803) Endless Loop when "provisoning config files..." when run from a build promotion
Title: Message Title
Michael Wiles updated an issue
Jenkins / JENKINS-40803
Endless Loop when "provisoning config files..." when run from a build promotion
Change By:
Michael Wiles
My symptom is when I click promote I get Promote I get the following output:Started by user x...@mydomain.comBuilding on master in workspace /var/lib/jenkins/jobs/Package for Release /workspacePromoting JOB BEING PROMOTEDprovisoning config files...And it sits there...Part of the stack trace is: {quote}at org.jenkinsci.plugins.configfiles.ConfigFiles.getByIdOrNull(ConfigFiles.java:82) at org.jenkinsci.plugins.configfiles.ConfigFiles.getByIdOrNull(ConfigFiles.java:103) at org.jenkinsci.plugins.configfiles.ConfigFiles.getByIdOrNull(ConfigFiles.java:114) at org.jenkinsci.plugins.configfiles.buildwrapper.ManagedFileUtil.provisionConfigFiles(ManagedFileUtil.java:81) at org.jenkinsci.plugins.configfiles.builder.ConfigFileBuildStep.perform(ConfigFileBuildStep.java:61) at hudson.plugins.promoted_builds.Promotion$RunnerImpl.build(Promotion.java:405) at hudson.plugins.promoted_builds.Promotion$RunnerImpl.doRun(Promotion.java:347) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:534) at hudson.model.Run.execute(Run.java:1729) at hudson.model.Run.run(Run.java:1688) at hudson.plugins.promoted_builds.Promotion.run(Promotion.java:286) at hudson.model.ResourceController.execute(ResourceController.java:98) at hudson.model.Executor.run(Executor.java:404){quote}This method: getByIdOrNull at the plugin version I'm on (config files provider: 2.15.1) is the following:{code:java}public static T getByIdOrNull(@Nullable ItemGroup itemGroup, @NonNull String configId) {while (itemGroup != null) {if (folderPluginInstalled() && itemGroup instanceof AbstractFolder) {final AbstractFolder folder = AbstractFolder.class.cast(itemGroup);ConfigFileStore store = folder.getProperties().get(FolderConfigFileProperty.class);if (store != null) {Config config = store.getById(configId);if (config != null) { return (T) config;}}}if (itemGroup instanceof Item) {itemGroup = Item.class.cast(itemGroup).getParent();}if (itemGroup instanceof Jenkins) {// we are on top scope...return (T) GlobalConfigFiles.get().getById(configId);} else {continue;}}return null;}{code}After attaching the debugger I've found that the reason I'm getting this behaviour is because this method does not return.It just loops around and around.The real type of the passed in itemGroup is hudson.plugins.promoted_builds.JobPropertyImpl # Folder Plugins is installed but itemGroup is not an instance of AbstractFolder# JobPropertyImpl is not an instance of Item# JobPropertyImpl is not an instance of Jenkins either.So this method will never return.What
[JIRA] (JENKINS-40803) Endless Loop when "provisoning config files..." when run from a build promotion
Title: Message Title Michael Wiles created an issue Jenkins / JENKINS-40803 Endless Loop when "provisoning config files..." when run from a build promotion Issue Type: Bug Assignee: Dominik Bartholdi Components: config-file-provider-plugin Created: 2017/Jan/04 1:08 PM Labels: configuration_file promoted_builds endless_loop Priority: Minor Reporter: Michael Wiles My symptom is when I click promote I get Promote I get the following output: Started by user x...@mydomain.com Building on master in workspace /var/lib/jenkins/jobs/Package for Release /workspace Promoting JOB BEING PROMOTED provisoning config files... And it sits there... Part of the stack trace is: at org.jenkinsci.plugins.configfiles.ConfigFiles.getByIdOrNull(ConfigFiles.java:82) at org.jenkinsci.plugins.configfiles.ConfigFiles.getByIdOrNull(ConfigFiles.java:103) at org.jenkinsci.plugins.configfiles.ConfigFiles.getByIdOrNull(ConfigFiles.java:114) at org.jenkinsci.plugins.configfiles.buildwrapper.ManagedFileUtil.provisionConfigFiles(ManagedFileUtil.java:81) at org.jenkinsci.plugins.configfiles.builder.ConfigFileBuildStep.perform(ConfigFileBuildStep.java:61) at hudson.plugins.promoted_builds.Promotion$RunnerImpl.build(Promotion.java:405) at hudson.plugins.promoted_builds.Promotion$RunnerImpl.doRun(Promotion.java:347) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:534) at hudson.model.Run.execute(Run.java:1729) at hudson.model.Run.run(Run.java:1688) at hudson.plugins.promoted_builds.Promotion.run(Promotion.java:286) at hudson.model.ResourceController.execute(ResourceController.java:98) at hudson.model.Executor.run(Executor.java:404)
[JIRA] [deploy] (JENKINS-22010) Allow Deploy Plugin to be run more than once on a build
Michael Wiles created JENKINS-22010 Allow Deploy Plugin to be run more than once on a build Issue Type: Improvement Affects Versions: current Assignee: Unassigned Components: deploy Created: 03/Mar/14 7:16 AM Description: My build creates two WAR files. The deploy plugin is only able to deploy one of these as I want to customise the context-path in both cases. Would it not be possible to just allow the deploy plugin to be run more than once on a build? Project: Jenkins Priority: Minor Reporter: Michael Wiles This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
