[JIRA] (JENKINS-60229) Jenkins 2.205 unable to get updates / update details
Title: Message Title Pavel Roskin commented on JENKINS-60229 Re: Jenkins 2.205 unable to get updates / update details Good to know, thank you for clarification. The issue has just gone away, I assume it has been resolved. From the Jenkins log: Nov 20, 2019 1:38:15 PM INFO hudson.util.Retrier start Attempt #1 to do the action check updates server Nov 20, 2019 1:38:30 PM INFO hudson.model.UpdateSite updateData Obtained the latest update center data file for UpdateSource default Nov 20, 2019 1:38:31 PM INFO hudson.model.DownloadService$Downloadable load Obtained the updated data file for hudson.tasks.Maven.MavenInstaller Nov 20, 2019 1:38:31 PM INFO hudson.model.DownloadService$Downloadable load Obtained the updated data file for hudson.tasks.Ant.AntInstaller Nov 20, 2019 1:38:31 PM INFO hudson.model.DownloadService$Downloadable load Obtained the updated data file for hudson.plugins.nodejs.tools.NodeJSInstaller Nov 20, 2019 1:38:32 PM INFO hudson.model.DownloadService$Downloadable load Obtained the updated data file for hudson.tools.JDKInstaller Nov 20, 2019 1:38:32 PM INFO hudson.util.Retrier start Performed the action check updates server successfully at the attempt #1 Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203204.157429000.4690.1574286302404%40Atlassian.JIRA.
[JIRA] (JENKINS-60229) Jenkins 2.205 unable to get updates / update details
Title: Message Title Pavel Roskin commented on JENKINS-60229 Re: Jenkins 2.205 unable to get updates / update details Actually, Jenkins log indicates that there is an issue with an expired certificate: signature check failed for http://updates.jenkins.io/updates/hudson.tools.JDKInstaller.json ERROR: Signature verification failed in downloadable 'hudson.tools.JDKInstaller' (show details)java.security.cert.CertificateExpiredException: NotAfter: Tue Nov 19 21:21:39 UTC 2019 at sun.security.x509.CertificateValidity.valid(CertificateValidity.java:274) at sun.security.x509.X509CertImpl.checkValidity(X509CertImpl.java:629) at sun.security.provider.certpath.BasicChecker.verifyValidity(BasicChecker.java:190) at There is no https URL in the log. The date (Nov 19 21:21:39 UTC 2019) is clearly in the past. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203204.157429000.4540.1574266260226%40Atlassian.JIRA.
[JIRA] (JENKINS-60229) Jenkins 2.205 unable to get updates / update details
Title: Message Title Pavel Roskin edited a comment on JENKINS-60229 Re: Jenkins 2.205 unable to get updates / update details I'm getting the same error with [http://updates.jenkins.io/update-center.json] (not HTTPS). I downloaded that URL with wget, it starts with "updateCenter.post(" without quotes, then some valid JSON file, then ") : ; "That's not a valid JSON file. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203204.157429000.4530.1574265600803%40Atlassian.JIRA.
[JIRA] (JENKINS-60229) Jenkins 2.205 unable to get updates / update details
Title: Message Title Pavel Roskin commented on JENKINS-60229 Re: Jenkins 2.205 unable to get updates / update details I'm getting the same error with http://updates.jenkins.io/update-center.json (not HTTPS). I downloaded that URL with wget, it starts with "updateCenter.post(" without quotes, then some valid JSON file, then "):" That's not a valid JSON file. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203204.157429000.4518.1574265600551%40Atlassian.JIRA.
[JIRA] (JENKINS-59833) Stash Pull Request Builder Multiple PR in single build
Title: Message Title Pavel Roskin commented on JENKINS-59833 Re: Stash Pull Request Builder Multiple PR in single build Did you actually set up a job and verify that queue items don't get folded? By the way, I wasn't aware of "mvn hpi:run", that's a great way to verify changes quickly! I was able to configure a job and test it with two pull requests. I saw them in the queue, and they were run separately. I didn't see the Credentials menu the first time, but it appeared after the restart. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202568.1571346229000.13492.1571777520267%40Atlassian.JIRA.
[JIRA] (JENKINS-59833) Stash Pull Request Builder Multiple PR in single build
Title: Message Title Pavel Roskin commented on JENKINS-59833 Re: Stash Pull Request Builder Multiple PR in single build Maven is actually very good at reproducible builds. If the revision shown under Manage Jenkins -> Manage Plugins > Installed is the one you intended to test, (that would be d3bba2491043066fb793fb32fefa6f7dedf2aa0b currently), I assume it's a good test. You would see just the beginning of the hash, that's OK. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202568.1571346229000.13414.1571770740161%40Atlassian.JIRA.
[JIRA] (JENKINS-59833) Stash Pull Request Builder Multiple PR in single build
Title: Message Title Pavel Roskin commented on JENKINS-59833 Re: Stash Pull Request Builder Multiple PR in single build Fix posted: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/pull/151 Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202568.1571346229000.11461.1571613660188%40Atlassian.JIRA.
[JIRA] (JENKINS-59833) Stash Pull Request Builder Multiple PR in single build
Title: Message Title Pavel Roskin commented on JENKINS-59833 Re: Stash Pull Request Builder Multiple PR in single build Looking at the Jenkins code, specifically at Queue#scheduleInternal(), I see that there is a mechanism to decide whether to schedule a new build. Every item in the queue is asked whether to schedule a new build given the list of actions. If a queue item responds through shouldSchedule() that the new build should not be scheduled, that queue item absorbs the new actions without scheduling the build. Only actions that implement QueueAction interface are involved in deciding whether to schedule a build. That mechanism could be used to replace StashRepository#cancelPreviousJobsInQueueThatMatch() in a safer manner. Cancelling a queue item is risky because the new build can fail to be scheduled (e.g. Jenkins is being rebooted). Instead, the new build would replace data (StashCause) in the existing queue item. Git plugin implements RevisionParameterAction that is added to the actions when scheduling. It's responsible for deciding whether to schedule a new build based on the git revision. It could serve as an example. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202568.1571346229000.11098.1571554500150%40Atlassian.JIRA.
[JIRA] (JENKINS-59833) Stash Pull Request Builder Multiple PR in single build
Title: Message Title Pavel Roskin commented on JENKINS-59833 Re: Stash Pull Request Builder Multiple PR in single build I was able to reproduce the issue right away after downgrading Jenkins from 2.200 to 2.190.1. It was a full reinstall, so I'm not sure the issue is with the Jenkins code and not with some obscure configuration difference. Apparently, Jenkins decides that two different calls to ParameterizedJobMixIn.scheduleBuild2() in StashRepository#startJob() want to trigger the same build despite having the same causes. The parameters are the same (none). The environment is populated once the build exists. Adding the "sourceCommitHash" string parameter is an effective workaround, as it makes the builds different at the time when they are scheduled. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202568.1571346229000.11090.1571547720222%40Atlassian.JIRA.
[JIRA] (JENKINS-59833) Stash Pull Request Builder Multiple PR in single build
Title: Message Title Pavel Roskin commented on JENKINS-59833 Re: Stash Pull Request Builder Multiple PR in single build What's the version of the plugin? What's the version of Jenkins? I cannot reproduce the issue. It a build has multiple causes of the type StashCause, that breaks a lot of assumptions in the plugin. But I don't see how it can happen. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202568.1571346229000.11012.1571525100285%40Atlassian.JIRA.
[JIRA] (JENKINS-53957) hpi bundles transitive dependencies of test scope dependencies
Title: Message Title Pavel Roskin commented on JENKINS-53957 Re: hpi bundles transitive dependencies of test scope dependencies OK, I think I understand it. Posting here to help others understand similar issues. The dependency chain (without test dependencies) was: stashNotifier -> git 2.0 -> git-client 1.4.4 -> ssh-agent 1.3 -> sshd-core 0.8.0 Now it is: stashNotifier 1.19 -> git 3.0.0 -> git-client 2.0.0 git-client 2.0.0 doesn't depend on ssh-agent, so that cuts the non-test dependency chain and stops the bundling. The version of sshd-core (0.14.0) was determined by a shorter chain that involved test dependencies: stashNotifier 1.19 => plugin 3.40 -> jenkins-war 2.60.3 ~> sshd 1.11 -> sshd-core 0.14.0 I'm using => for a child-parent relationship (which doesn't count towards the length of the dependency chain) and ~> for a test dependency. mvn dependency:tree was showing a shorter dependency chain, but with the scope based on analyzing the whole tree, which made it look like a test dependency was pulling in a compile dependency. I don't see a way to make maven omit test dependencies or to show all paths leading to a transitive dependency. It would have helped with debugging the issue. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.194562.1539080849000.5744.1564687020324%40Atlassian.JIRA.
[JIRA] (JENKINS-53957) hpi bundles transitive dependencies of test scope dependencies
Title: Message Title Pavel Roskin commented on JENKINS-53957 Re: hpi bundles transitive dependencies of test scope dependencies Thank you, Jesse Glick! I was able to fix the issue in stash notifier with sshd-core bundling by updating the git dependency. It's very nice to see your PR merged already! Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.194562.1539080849000.4807.1564639800336%40Atlassian.JIRA.
[JIRA] (JENKINS-53957) hpi bundles transitive dependencies of test scope dependencies
Title: Message Title Pavel Roskin commented on JENKINS-53957 Re: hpi bundles transitive dependencies of test scope dependencies Bitbucket Server Notifier Plugin version 1.9 is also affected. It packages sshd-core-0.14.0.jar unnecessarily. "mvn dependency:tree" shows: [INFO] +- org.jenkins-ci.main:jenkins-war:executable-war:2.60.3:test [INFO] | +- org.jenkins-ci.modules:instance-identity:jar:2.1:test [INFO] | | \- io.github.stephenc.crypto:self-signed-cert-generator:jar:1.0.0:test [INFO] | +- org.jenkins-ci.modules:ssh-cli-auth:jar:1.4:test [INFO] | +- org.jenkins-ci.modules:slave-installer:jar:1.5:test [INFO] | +- org.jenkins-ci.modules:windows-slave-installer:jar:1.9:test [INFO] | +- org.jenkins-ci.modules:launchd-slave-installer:jar:1.2:test [INFO] | +- org.jenkins-ci.modules:upstart-slave-installer:jar:1.1:test [INFO] | +- org.jenkins-ci.modules:systemd-slave-installer:jar:1.1:test [INFO] | +- org.jenkins-ci.modules:sshd:jar:1.11:test [INFO] | | \- org.apache.sshd:sshd-core:jar:0.14.0:compile That goes against the rule that the dependencies of test dependencies are either test dependencies or not dependencies at all. A way to remove that dependency from the hpi is to declare it explicitly as a test dependency. However, that would be a hack, not a solution. maven-hpi-plugin should either follow the dependency rule or warn loudly (and fail optionally) if it cannot follow that rule for whatever reason, so that the issue could be mitigated right away. Please reopen the ticket, I don't see any reason to close it. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues"
[JIRA] (JENKINS-30558) Cron based jobs are no longer triggered
Title: Message Title Pavel Roskin commented on JENKINS-30558 Re: Cron based jobs are no longer triggered I see that the socket timeout and the request timeout were introduced in the same PR. Does anybody know a reason why request timeouts are needed in presence of socket timeouts? Running HTTP requests in separate threads adds a lot of complexity. Other plugins doesn't do it. I assume every request should use a limited number of packets sent over the socket, so the socket timeout should put a limit on the request duration. I'm going to move requests back to the main thread unless I hear any objections. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.165159.1442780746000.2470.1564366500441%40Atlassian.JIRA.
[JIRA] (JENKINS-55945) Got IllegalStateException while restart Jenkins
Title: Message Title Pavel Roskin commented on JENKINS-55945 Re: Got IllegalStateException while restart Jenkins Yes, I confirm that it works. I patched the code, installed the new jenkins.war, restarted Jenkins 5 times with constant refreshes, did not see the backtrace or the Evil Jenkins picture. Without the patch, the issue is reproducible every time. Here's the patch I used: diff --git a/core/src/main/java/hudson/security/HttpSessionContextIntegrationFilter2.java b/core/src/main/java/hudson/security/HttpSessionContextIntegrationFilter2.java index 7a67c77dd0..2084651432 100644 --- a/core/src/main/java/hudson/security/HttpSessionContextIntegrationFilter2.java +++ b/core/src/main/java/hudson/security/HttpSessionContextIntegrationFilter2.java @@ -84,7 +84,13 @@ public class HttpSessionContextIntegrationFilter2 extends HttpSessionContextInte return false; } . -User userFromSession = User.getById(authentication.getName(), false); +User userFromSession; +try { +userFromSession = User.getById(authentication.getName(), false); +} catch (IllegalStateException e) { +return false; +} + if (userFromSession == null) { // no requirement for further test as there is no user inside return false; Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit
[JIRA] (JENKINS-55945) Got IllegalStateException while restart Jenkins
Title: Message Title Pavel Roskin commented on JENKINS-55945 Re: Got IllegalStateException while restart Jenkins I can reproduce it every time. I just access the Jenkins URL with "/safeRestart", confirm restart and keep reloading the page every second. It shows the error approximately after 5 to 10 reloads. It's interesting that I don't see any stack trace in the console log. Jenkins 2.182 in a Docker container. 2019-06-28 21:20:09.963+ [id=318] INFO jenkins.model.Jenkins$23#run: Restart in 10 seconds 2019-06-28 21:20:19.964+ [id=318] INFO jenkins.model.Jenkins$23#run: Restarting VM as requested by roskinp 2019-06-28 21:20:19.965+ [id=318] INFO jenkins.model.Jenkins#cleanUp: Stopping Jenkins 2019-06-28 21:20:19.983+ [id=318] INFO jenkins.model.Jenkins$18#onAttained: Started termination 2019-06-28 21:20:19.993+ [id=318] INFO jenkins.model.Jenkins$18#onAttained: Completed termination 2019-06-28 21:20:19.993+ [id=318] INFO jenkins.model.Jenkins#_cleanUpDisconnectComputers: Starting node disconnection 2019-06-28 21:20:21.011+ [id=318] INFO jenkins.model.Jenkins#_cleanUpShutdownPluginManager: Stopping plugin manager 2019-06-28 21:20:21.026+ [id=318] INFO jenkins.model.Jenkins#_cleanUpPersistQueue: Persisting build queue 2019-06-28 21:20:21.028+ [id=318] INFO jenkins.model.Jenkins#_cleanUpAwaitDisconnects: Waiting for node disconnection completion 2019-06-28 21:20:21.033+ [id=318] INFO jenkins.model.Jenkins#cleanUp: Jenkins stopped Running from: /usr/share/jenkins/jenkins-stable.war webroot: EnvVars.masterEnvVars.get("JENKINS_HOME") 2019-06-28 21:20:23.482+ [id=1] INFO org.eclipse.jetty.util.log.Log#initialized: Logging initialized @595ms to org.eclipse.jetty.util.log.JavaUtilLog 2019-06-28 21:20:23.606+ [id=1] INFO winstone.Logger#logInternal: Beginning extraction from war file 2019-06-28 21:20:23.642+ [id=1] WARNING o.e.j.s.handler.ContextHandler#setContextPath: Empty contextPath 2019-06-28 21:20:23.704+ [id=1] INFO org.eclipse.jetty.server.Server#doStart: jetty-9.4.z-SNAPSHOT; built: 2019-05-02T00:04:53.875Z; git: e1bc35120a6617ee3df052294e433f3a25ce7097; jvm 1.8.0_181-8u181-b13-2~deb9u1-b13 2019-06-28 21:20:24.033+ [id=1] INFO o.e.j.w.StandardDescriptorProcessor#visitServlet: NO JSP Support for /, did not find org.eclipse.jetty.jsp.JettyJspServlet 2019-06-28 21:20:24.087+ [id=1] INFO o.e.j.s.s.DefaultSessionIdManager#doStart: DefaultSessionIdManager workerName=node0 2019-06-28 21:20:24.088+ [id=1] INFO o.e.j.s.s.DefaultSessionIdManager#doStart: No SessionScavenger set, using defaults 2019-06-28 21:20:24.091+ [id=1] INFO o.e.j.server.session.HouseKeeper#startScavenging: node0 Scavenging every 66ms Jenkins home directory: /var/jenkins_home found at: EnvVars.masterEnvVars.get("JENKINS_HOME") Here's what I see on the page. The same Jenkins container. java.lang.IllegalStateException: Expected 1 instance of hudson.model.User$AllUsers but got 0 at hudson.ExtensionList.lookupSingleton(ExtensionList.java:451) at hudson.model.User$AllUsers.getInstance(User.java:1080) at hudson.model.User$AllUsers.get(User.java:1098) at hudson.model.User$AllUsers.access$100(User.java:1061) at hudson.model.User.getOrCreateById(User.java:517) at hudson.model.User.getById(User.java:615) at hudson.security.HttpSessionContextIntegrationFilter2.hasInvalidSessionSeed(HttpSessionContextIntegrationFilter2.java:87) at hudson.security.HttpSessionContextIntegrationFilter2.doFilter(HttpSessionContextIntegrationFilter2.java:60) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:90)
[JIRA] (JENKINS-58173) Multi-configuration projects are not restartable
Title: Message Title Pavel Roskin created an issue Jenkins / JENKINS-58173 Multi-configuration projects are not restartable Issue Type: New Feature Assignee: Kohsuke Kawaguchi Components: matrix-project-plugin Created: 2019-06-25 00:40 Environment: Jenkins 2.176.1, Matrix project plugin 1.14 Labels: restart matrix-project Priority: Minor Reporter: Pavel Roskin When I request Jenkins safe restart while a matrix project is building, all configurations of that project are built before Jenkins restarts. That is, the matrix project behaves like a free-style project, i.e. the whole matrix runs without interruption. That seems an artificial limitation to me. The top level build is pure Java, it should be able to save its state and continue after the restart. When the restart is requested, the top level build should stop running new configuration builds, wait until the running configuration builds complete and restart. That would greatly help with Jenkins updates on systems with large matrix projects.
[JIRA] (JENKINS-56012) stash-pullrequest-builder-plugin variables not seen in multi-configuration jobs unless listed in safeParameters
Title: Message Title Pavel Roskin updated JENKINS-56012 Jenkins / JENKINS-56012 stash-pullrequest-builder-plugin variables not seen in multi-configuration jobs unless listed in safeParameters Change By: Pavel Roskin Status: Fixed but Unreleased Resolved Released As: 1.9 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.197430.1549508713000.12715.1558988700287%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-46605) Stash-pullrequest-builder-plugin has no variable for GIT URL
Title: Message Title Pavel Roskin updated an issue Jenkins / JENKINS-46605 Stash-pullrequest-builder-plugin has no variable for GIT URL Change By: Pavel Roskin Comment: What's wrong with the GIT_URL variable? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.184937.1504343091000.12712.1558988580108%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41771) Post-build comment serializes concurrent builds waiting for checkpoint
Title: Message Title Pavel Roskin updated JENKINS-41771 Jenkins / JENKINS-41771 Post-build comment serializes concurrent builds waiting for checkpoint Change By: Pavel Roskin Status: Fixed but Unreleased Resolved Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.178612.1486408862000.12709.1558988400521%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41771) Post-build comment serializes concurrent builds waiting for checkpoint
Title: Message Title Pavel Roskin updated JENKINS-41771 Fixed in git and released in version 1.9 Jenkins / JENKINS-41771 Post-build comment serializes concurrent builds waiting for checkpoint Change By: Pavel Roskin Status: In Review Fixed but Unreleased Resolution: Fixed Released As: 1.9 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.178612.1486408862000.12707.1558988400492%40Atlassian.JIRA. For more
[JIRA] (JENKINS-56071) Pipeline (workflow job) support
Title: Message Title Pavel Roskin updated an issue Jenkins / JENKINS-56071 Pipeline (workflow job) support Change By: Pavel Roskin Summary: Workflow Pipeline (workflow job ) support Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.197496.1549797931000.1752.1557768840143%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56071) Workflow job support
Title: Message Title Pavel Roskin commented on JENKINS-56071 Re: Workflow job support PR #69 will add pipeline support. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.197496.1549797931000.1750.1557768660135%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55945) Got IllegalStateException while restart Jenkins
Title: Message Title Pavel Roskin commented on JENKINS-55945 Re: Got IllegalStateException while restart Jenkins I understand the reason is an attempt to authenticate the http request after the user list is destroyed. A simple fix would be to catch IllegalStateException in User#getOrCreateById and return null. A better solution would be to create a nullable ExtensionList#lookupSingletonOrNull, use it from User.java and handle null properly in all callers. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41771) Post-build comment serializes concurrent builds waiting for checkpoint
Title: Message Title Pavel Roskin started work on JENKINS-41771 Change By: Pavel Roskin Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41771) Post-build comment serializes concurrent builds waiting for checkpoint
Title: Message Title Pavel Roskin updated an issue Jenkins / JENKINS-41771 Post-build comment serializes concurrent builds waiting for checkpoint Fix submitted for review: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/pull/64 Change By: Pavel Roskin URL: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/pull/64 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41771) Post-build comment serializes concurrent builds waiting for checkpoint
Title: Message Title Pavel Roskin updated JENKINS-41771 Jenkins / JENKINS-41771 Post-build comment serializes concurrent builds waiting for checkpoint Change By: Pavel Roskin Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-46605) Stash-pullrequest-builder-plugin has no variable for GIT URL
Title: Message Title Pavel Roskin commented on JENKINS-46605 Re: Stash-pullrequest-builder-plugin has no variable for GIT URL What's wrong with the GIT_URL variable? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41771) Post-build comment serializes concurrent builds waiting for checkpoint
Title: Message Title Pavel Roskin assigned an issue to Pavel Roskin Jenkins / JENKINS-41771 Post-build comment serializes concurrent builds waiting for checkpoint Change By: Pavel Roskin Assignee: Jakub Bochenski Pavel Roskin Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56012) stash-pullrequest-builder-plugin variables not seen in multi-configuration jobs unless listed in safeParameters
Title: Message Title Pavel Roskin assigned an issue to Pavel Roskin Jenkins / JENKINS-56012 stash-pullrequest-builder-plugin variables not seen in multi-configuration jobs unless listed in safeParameters Change By: Pavel Roskin Assignee: Jakub Bochenski Pavel Roskin Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55853) Customized Post Build Comment ignored for multi-configuration projects
Title: Message Title Pavel Roskin updated JENKINS-55853 Jenkins / JENKINS-55853 Customized Post Build Comment ignored for multi-configuration projects Change By: Pavel Roskin Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56012) stash-pullrequest-builder-plugin variables not seen in multi-configuration jobs unless listed in safeParameters
Title: Message Title Pavel Roskin updated JENKINS-56012 Fixed in https://github.com/jenkinsci/stash-pullrequest-builder-plugin/pull/44 Jenkins / JENKINS-56012 stash-pullrequest-builder-plugin variables not seen in multi-configuration jobs unless listed in safeParameters Change By: Pavel Roskin Status: Open Fixed but Unreleased Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56012) stash-pullrequest-builder-plugin variables not seen in multi-configuration jobs unless listed in safeParameters
Title: Message Title Pavel Roskin commented on JENKINS-56012 Re: stash-pullrequest-builder-plugin variables not seen in multi-configuration jobs unless listed in safeParameters The issue is resolved as originally stated. The issue of warnings from historic builds will be reported and addressed separately. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56337) Stash Pull Request Builder ignores quiet time
Title: Message Title Pavel Roskin updated JENKINS-56337 Jenkins / JENKINS-56337 Stash Pull Request Builder ignores quiet time Change By: Pavel Roskin Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56349) Stash Pull Request Builder can throw in StashBuildTrigger#run
Title: Message Title Pavel Roskin updated JENKINS-56349 Jenkins / JENKINS-56349 Stash Pull Request Builder can throw in StashBuildTrigger#run Change By: Pavel Roskin Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-46606) Stash-pullrequest-builder-plugin describes the job with verbatim HTML markup
Title: Message Title Pavel Roskin commented on JENKINS-46606 Re: Stash-pullrequest-builder-plugin describes the job with verbatim HTML markup I don't see any issues with the text posted to the Stash PR pages. The job descriptions in Jenkins GUI are indeed not rendered by default. To make them show correctly, install "OWASP Markup Formatter Plugin" and enable HTML markup in Manage Jenkins -> Configure Global Security. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55853) Customized Post Build Comment ignored for multi-configuration projects
Title: Message Title Pavel Roskin updated an issue Jenkins / JENKINS-55853 Customized Post Build Comment ignored for multi-configuration projects Change By: Pavel Roskin URL: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/pull/43 Labels: configuration matrix stash Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56071) Workflow job support
Title: Message Title Pavel Roskin commented on JENKINS-56071 Re: Workflow job support JENKINS-56349 should take care of the crash issue. The rest of the PR #21 should be updated for the current code. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56349) Stash Pull Request Builder can throw in StashBuildTrigger#run
Title: Message Title Pavel Roskin updated an issue Jenkins / JENKINS-56349 Stash Pull Request Builder can throw in StashBuildTrigger#run Change By: Pavel Roskin Labels: NPE stash trigger Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56337) Stash Pull Request Builder ignores quiet time
Title: Message Title Pavel Roskin updated an issue Jenkins / JENKINS-56337 Stash Pull Request Builder ignores quiet time Change By: Pavel Roskin Issue Type: New Feature Bug URL: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/pull/46 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56349) Stash Pull Request Builder can throw in StashBuildTrigger#run
Title: Message Title Pavel Roskin updated an issue Jenkins / JENKINS-56349 Stash Pull Request Builder can throw in StashBuildTrigger#run Change By: Pavel Roskin URL: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/pull/48 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56349) Stash Pull Request Builder can throw in StashBuildTrigger#run
Title: Message Title Pavel Roskin updated JENKINS-56349 Jenkins / JENKINS-56349 Stash Pull Request Builder can throw in StashBuildTrigger#run Change By: Pavel Roskin Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56349) Stash Pull Request Builder can throw in StashBuildTrigger#run
Title: Message Title Pavel Roskin updated an issue Jenkins / JENKINS-56349 Stash Pull Request Builder can throw in StashBuildTrigger#run Change By: Pavel Roskin Issue Type: New Feature Bug Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56349) Stash Pull Request Builder can throw in StashBuildTrigger#run
Title: Message Title Pavel Roskin started work on JENKINS-56349 Change By: Pavel Roskin Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56349) Stash Pull Request Builder can throw in StashBuildTrigger#run
Title: Message Title Pavel Roskin updated an issue Jenkins / JENKINS-56349 Stash Pull Request Builder can throw in StashBuildTrigger#run Change By: Pavel Roskin There is a report in the Wiki about the plugin crashing in StashBuildTrigger#run[https://wiki.jenkins.io/display/JENKINS/Stash+pullrequest+builder+plugin]The documentation for Trigger#run() says:{quote}Maybe run even before [{{start(hudson.model.Item, boolean)}}|https://javadoc.jenkins.io/hudson/triggers/Trigger.html#start-J-boolean-], prepare for it.{quote}[https://javadoc.jenkins.io/hudson/triggers/Trigger.html#run--]We are definitely not prepared. I don't think running start() from run() would be a good idea, but being defensive and avoiding long chains of method calls would help.While at that, the "Build started" could be really improved, it's probably the only "happy case" INFO message from the plugin, and it's woefully non-informative. Also, make sure stop() reverts the effects of start() and makes run() fail before start() is run again. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56349) Stash Pull Request Builder can throw in StashBuildTrigger#run
Title: Message Title Pavel Roskin created an issue Jenkins / JENKINS-56349 Stash Pull Request Builder can throw in StashBuildTrigger#run Issue Type: New Feature Assignee: Pavel Roskin Components: stash-pullrequest-builder-plugin Created: 2019-03-01 18:43 Priority: Major Reporter: Pavel Roskin There is a report in the Wiki about the plugin crashing in StashBuildTrigger#run https://wiki.jenkins.io/display/JENKINS/Stash+pullrequest+builder+plugin The documentation for Trigger#run() says: Maybe run even before start(hudson.model.Item, boolean), prepare for it. https://javadoc.jenkins.io/hudson/triggers/Trigger.html#run-- We are definitely not prepared. I don't think running start() from run() would be a good idea, but being defensive and avoiding long chains of method calls would help. While at that, the "Build started" could be really improved, it's probably the only "happy case" INFO message from the plugin, and it's woefully non-informative. Add Comment
[JIRA] (JENKINS-56337) Stash Pull Request Builder ignores quiet time
Title: Message Title Pavel Roskin commented on JENKINS-56337 Re: Stash Pull Request Builder ignores quiet time In review: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/pull/46 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56337) Stash Pull Request Builder ignores quiet time
Title: Message Title Pavel Roskin started work on JENKINS-56337 Change By: Pavel Roskin Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56337) Stash Pull Request Builder ignores quiet time
Title: Message Title Pavel Roskin updated JENKINS-56337 Jenkins / JENKINS-56337 Stash Pull Request Builder ignores quiet time Change By: Pavel Roskin Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56337) Stash Pull Request Builder ignores quiet time
Title: Message Title Pavel Roskin updated an issue Jenkins / JENKINS-56337 Stash Pull Request Builder ignores quiet time Change By: Pavel Roskin The call to scheduleBuild2() in StashBuildTrigger.java passes 0 as the first argument (quiet period). This ignores the quiet time settings supplied by the user.There are two places where the quiet time can be set. One is the global configuration, another is the configuration for the Job under "Advanced Project Options". Ignoring the later is particularly bad. If the user sets the quiet time for the job, that job should respect it. Why else would the user set it? It doesn't matter that the trigger is cron driven and that some time has passed since the PR was created.I understand when the quiet period is skipped when the user clicks a button or when a command line interface is used, but the normal use should respect the settings.The global configuration is used if the setting for the job is not set (I checked that). There is no checkbox whether to +use+ the global setting. The checkbox is whether to +customize+ the global setting. So we should simply respect the setting for the job, whatever is set by the Jenkins core.Other PR builders use this.getInstance().getQuietPeriod(). They are wrong, it gives the global setting and ignored ignores the per-job setting. We should use job.getQuietPeriod() and set an example for others. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
[JIRA] (JENKINS-56337) Stash Pull Request Builder ignores quiet time
Title: Message Title Pavel Roskin updated an issue Jenkins / JENKINS-56337 Stash Pull Request Builder ignores quiet time Change By: Pavel Roskin The call to scheduleBuild2() in StashBuildTrigger.java passes 0 as the first argument (quiet period). This ignores the quiet time settings supplied by the user.There are two places where the quiet time can be set. One is the global configuration, another is the configuration for the Job under "Advanced Project Options". Ignoring the later is particularly bad. If the user sets the quiet time for the job, that job should respect it. Why else would the user set it? It doesn't matter that the trigger is cron driven and that some time has passed since the PR was created.I understand when the quiet period is skipped when the user clicks a button or when a command line interface is used, but the normal use should respect the settings.The global configuration is used if the setting for the job is not set (I checked that). There is no checkbox whether to +use+ the global setting. The checkbox is whether to +customize+ the global setting. So we should simply respect the setting for the job, whatever is set by the Jenkins core.Other PR builders use this.getInstance().getQuietPeriod(). They are wrong, it gives the global setting and ignored the per-job setting . We should use job.getQuietPeriod() and set an example for others. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
[JIRA] (JENKINS-56337) Stash Pull Request Builder ignores quiet time
Title: Message Title Pavel Roskin updated an issue Jenkins / JENKINS-56337 Stash Pull Request Builder ignores quiet time Change By: Pavel Roskin The call to scheduleBuild2() in StashBuildTrigger.java passes 0 as the first argument (quiet period). This ignores the quiet time settings supplied by the user.There are two places where the quiet time can be set. One is the global configuration, another is the configuration for the Job under "Advanced Project Options". Ignoring the later is particularly bad. If the user sets the quiet time for the job, that job should respect it. Why else would the user set it? It doesn't matter that the trigger is cron driven and that some time has passed since the PR was created.I understand when the quiet period is skipped when the user clicks a button or when a command line interface is used, but the normal use should respect the settings.The global configuration is used if the setting for the job is not set (I checked that). There is no checkbox whether to +use+ the global setting. The checkbox is whether to +customize+ the global setting. So we should simply respect the setting for the job and trust that , whatever is set by the user and the Jenkins core do it right .Other PR builders use this.getInstance().getQuietPeriod(). They are wrong, it gives the global setting. We should use job.getQuietPeriod() and set an example for others. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
[JIRA] (JENKINS-56337) Stash Pull Request Builder ignores quiet time
Title: Message Title Pavel Roskin updated an issue Jenkins / JENKINS-56337 Stash Pull Request Builder ignores quiet time Change By: Pavel Roskin The call to scheduleBuild2() in StashBuildTrigger.java passes 0 as the first argument (quiet period). This ignores the quiet time settings supplied by the user.There are two places where the quiet time can be set. One is the global configuration, another is the configuration for the Job under "Advanced Project Options". Ignoring the later is particularly bad. If the user sets the quiet time for the job, that job should respect it. Why else would the user set it? It doesn't matter that the trigger is cron driven and that some time has passed since the PR was created.I understand when the quiet period is skipped when the user clicks a button or when a command line interface is used, but the normal use should respect the settings.The global configuration is used if the setting for the job is not set (I checked that). There is no checkbox whether to +use+ the global setting. The checkbox is whether to +customize+ the global setting. So we should simply respect the setting for the job and trust that the use user and the Jenkins core do it right.Other PR builders use this.getInstance().getQuietPeriod(). They are wrong, it gives the global setting. We should use job.getQuietPeriod() and set an example for others. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
[JIRA] (JENKINS-56337) Stash Pull Request Builder ignores quiet time
Title: Message Title Pavel Roskin created an issue Jenkins / JENKINS-56337 Stash Pull Request Builder ignores quiet time Issue Type: New Feature Assignee: Pavel Roskin Components: stash-pullrequest-builder-plugin Created: 2019-02-28 21:45 Environment: Jenkins 2.166, stash-pull-request-builder 1.8 Labels: pullrequestbuilder time config Priority: Minor Reporter: Pavel Roskin The call to scheduleBuild2() in StashBuildTrigger.java passes 0 as the first argument (quiet period). This ignores the quiet time settings supplied by the user. There are two places where the quiet time can be set. One is the global configuration, another is the configuration for the Job under "Advanced Project Options". Ignoring the later is particularly bad. If the user sets the quiet time for the job, that job should respect it. Why else would the user set it? It doesn't matter that the trigger is cron driven and that some time has passed since the PR was created. I understand when the quiet period is skipped when the user clicks a button or when a command line interface is used, but the normal use should respect the settings. The global configuration is used if the setting for the job is not set (I checked that). There is no checkbox whether to use the global setting. The checkbox is whether to customize the global setting. So we should simply respect the setting for the job and trust that the use and the Jenkins core do it right. Other PR builders use this.getInstance().getQuietPeriod(). They are wrong, it gives the global setting. We should use job.getQuietPeriod() and set an example for
[JIRA] (JENKINS-56012) stash-pullrequest-builder-plugin variables not seen in multi-configuration jobs unless listed in safeParameters
Title: Message Title Pavel Roskin commented on JENKINS-56012 Re: stash-pullrequest-builder-plugin variables not seen in multi-configuration jobs unless listed in safeParameters It looks like the remaining warnings are a migration issue. They happen when the new plugin (i.e. the one with PR44 merged) loads builds created with the old (pre-PR44) plugin. I made Jenkins dump stack after reporting the SECURITY-170 warning, and here's what it shows. WARNING: Skipped parameter `sourceCommitHash` as it is undefined on `TestRepository_Matrix_PR_Builder`. Set `-Dhudson.model.ParametersAction.keepUndefinedParameters=true` to allow undefined parameters to be injected as environment variables or `-Dhudson.model.ParametersAction.safeParameters=[comma-separated list]` to whitelist specific parameter names, even though it represents a security breach or `-Dhudson.model.ParametersAction.keepUndefinedParameters=false` to no longer show this message. java.lang.Exception: Stack trace at java.lang.Thread.dumpStack(Thread.java:1336) at hudson.model.ParametersAction.filter(ParametersAction.java:333) at hudson.model.ParametersAction.getParameters(ParametersAction.java:183) at hudson.matrix.MatrixChildParametersAction.onLoad(MatrixChildParametersAction.java:87) at hudson.model.Run.onLoad(Run.java:364) at hudson.model.RunMap.retrieve(RunMap.java:225) at hudson.model.RunMap.retrieve(RunMap.java:57) at jenkins.model.lazy.AbstractLazyLoadRunMap.load(AbstractLazyLoadRunMap.java:501) at jenkins.model.lazy.AbstractLazyLoadRunMap.load(AbstractLazyLoadRunMap.java:483) at jenkins.model.lazy.AbstractLazyLoadRunMap.getByNumber(AbstractLazyLoadRunMap.java:381) at jenkins.model.lazy.AbstractLazyLoadRunMap.search(AbstractLazyLoadRunMap.java:346) at jenkins.model.lazy.LazyLoadRunMapEntrySet$1.next(LazyLoadRunMapEntrySet.java:74) at jenkins.model.lazy.LazyLoadRunMapEntrySet$1.next(LazyLoadRunMapEntrySet.java:63) at java.util.AbstractMap$2$1.next(AbstractMap.java:418) at hudson.matrix.LinkedLogRotator.perform(LinkedLogRotator.java:69) at hudson.model.Job.logRotate(Job.java:468) at hudson.model.Run.execute(Run.java:1880) at hudson.matrix.MatrixRun.run(MatrixRun.java:153) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:429) Maybe stash-pullrequest-builder-plugin should still use and recognize the parameters? I see that the GitHub pull request builder took a different approach and used a class derived from ParametersAction. I know, that plugin is obsolete, but I'm sure it was getting more attention than stash-pullrequest-builder-plugin. Add Comment
[JIRA] (JENKINS-56064) Matrix project plugin - add a shell script to be run in top-level executor only
Title: Message Title Pavel Roskin closed an issue as Won't Fix After learning something about Jenkins internals, I'm going to close it this issue without resolving. The top-level build is considered light-weight, it runs without an executor, so adding any non-trivial jobs should be discouraged. The right solution would be to have a pipeline. If it's not working now, it should be fixed. Jenkins / JENKINS-56064 Matrix project plugin - add a shell script to be run in top-level executor only Change By: Pavel Roskin Status: Open Closed Resolution: Won't Fix Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51480) SECURITY-170 message about Stash Pull Request Builder variables not being build args swamps the logs
Title: Message Title Pavel Roskin resolved as Fixed Resolved in https://github.com/jenkinsci/stash-pullrequest-builder-plugin/pull/44 for freestyle projects. Multi-configuration projects still generate warnings, will be addressed in JENKINS-56012. Jenkins / JENKINS-51480 SECURITY-170 message about Stash Pull Request Builder variables not being build args swamps the logs Change By: Pavel Roskin Status: Open Resolved Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56012) stash-pullrequest-builder-plugin variables not seen in multi-configuration jobs unless listed in safeParameters
Title: Message Title Pavel Roskin commented on JENKINS-56012 Re: stash-pullrequest-builder-plugin variables not seen in multi-configuration jobs unless listed in safeParameters The issue of missing environment variables has been addressed by https://github.com/jenkinsci/stash-pullrequest-builder-plugin/pull/44 The warnings are still there. For a 2-configuration project with consecutive execution, the second child job generates 150 variables, 15 per variable. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56012) stash-pullrequest-builder-plugin variables not seen in multi-configuration jobs unless listed in safeParameters
Title: Message Title Pavel Roskin commented on JENKINS-56012 Re: stash-pullrequest-builder-plugin variables not seen in multi-configuration jobs unless listed in safeParameters I tried fixing the issues with the environment. There are multiple issues. One issue that is specific to multi-configuration builds is that StashAditionalParameterEnvironmentContributor#buildEnvironmentFor() uses getCause(StashCause.class). The cause of child builds is the top-level build, not StashCause. That should be considered. That said, it is likely that this issue and JENKINS-51480 would be fixed together. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55853) Customized Post Build Comment ignored for multi-configuration projects
Title: Message Title Pavel Roskin assigned an issue to Pavel Roskin Jenkins / JENKINS-55853 Customized Post Build Comment ignored for multi-configuration projects Change By: Pavel Roskin Assignee: Pavel Roskin Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55853) Customized Post Build Comment ignored for multi-configuration projects
Title: Message Title Pavel Roskin started work on JENKINS-55853 Change By: Pavel Roskin Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55853) Customized Post Build Comment ignored for multi-configuration projects
Title: Message Title Pavel Roskin updated JENKINS-55853 Jenkins / JENKINS-55853 Customized Post Build Comment ignored for multi-configuration projects Change By: Pavel Roskin Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55853) Customized Post Build Comment ignored for multi-configuration projects
Title: Message Title Pavel Roskin commented on JENKINS-55853 Re: Customized Post Build Comment ignored for multi-configuration projects Indeed, it's possible to get the StashPostBuildComment object from the project using getPublishersList(). PR posted: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/pull/43 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55853) Customized Post Build Comment ignored for multi-configuration projects
Title: Message Title Pavel Roskin commented on JENKINS-55853 Re: Customized Post Build Comment ignored for multi-configuration projects I tried to fix the issue, but my knowledge of Jenkins internals is insufficient. Let's me just describe where I stopped. One approach is to introduce a dependency on the Matrix plugin. email-ext-plugins is an example of such code. It can select whether the post-build action happens in child builds, in the top-level build or in both. But I would rather avoid adding a dependency. I believe that StashPostBuildComment.perform() is not the best place to publish the configuration of StashPostBuildComment, as it happens in a child build. But I've noticed getRootProject() and getRootBuild(), I'll see if they would help. A cleaner approach would be to examine the project for an object of the given class, just like it's done for the trigger. StashBuild.onCompleted() calls StashBuildTrigger.getTrigger(build.getProject()), which is implemented using project's getTrigger(). That would make it possible to read the StashPostBuildComment configuration from the project. But I don't see such method for post-build actions. Another approach would be to make StashPostBuildComment listen to some event that happens for the top-level build and publish its configuration with addAction to that build. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55853) Customized Post Build Comment ignored for multi-configuration projects
Title: Message Title Pavel Roskin commented on JENKINS-55853 Re: Customized Post Build Comment ignored for multi-configuration projects As I suspected, there is some data that is created in the child builds but consumed in the top level build. Specifically, StashPostBuildComment.perform() is run in child executors and creates StashPostBuildCommentAction objects. Then StashBuilds.onCompleted() is run in the top level project and tries to get comments from StashPostBuildCommentAction. It gets null, quite expectedly. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55945) Got IllegalStateException while restart Jenkins
Title: Message Title Pavel Roskin commented on JENKINS-55945 Re: Got IllegalStateException while restart Jenkins I got this when I loaded a locally compiled version of the Stash pull request builder plugin and selected the "Restart Jenkins" checkbox. I saw that message. I reloaded the page after a few seconds, Jenkins is working normally. Jenkins 2.164 in Docker. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56063) git-plugin fails to expand variables in refspec on initial clone
Title: Message Title Pavel Roskin commented on JENKINS-56063 Re: git-plugin fails to expand variables in refspec on initial clone Thank you. I was able to set up my Stash pull request builders in a way that they don't trigger this issue. But I lost a lot of time before I came to a working setup. I wanted to use strict settings during testing to avoid interference with the previously run tests. It was very disorienting when that strict setup triggered this issue with variable expansion. It's good that git commands are logged when the installed git binary is used. With jgit, nothing is logged, making it unclear what is expanded and what is not. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31978) Option to select if each matrix job should report back to stash
Title: Message Title Pavel Roskin commented on JENKINS-31978 Re: Option to select if each matrix job should report back to stash I opened a similar issue on GitHub: https://github.com/jenkinsci/stashnotifier-plugin/issues/220 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56064) Matrix project plugin - add a shell script to be run in top-level executor only
Title: Message Title Pavel Roskin created an issue Jenkins / JENKINS-56064 Matrix project plugin - add a shell script to be run in top-level executor only Issue Type: New Feature Assignee: Kohsuke Kawaguchi Components: matrix-project-plugin Created: 2019-02-08 23:35 Environment: Jenkins 2.150.2, Matrix Project Plugin 1.13 Labels: matrix-project multi-configuration script Priority: Minor Reporter: Pavel Roskin It would be very convenient for me to have an option to run a shell command in the top-level executor before the matrix jobs are run. I want to use it to run style checks on a pull request before compilers are started. Failing the sanity check should fail the job without wasting time compiling non-conforming code. What I considered: Running style check on all executors - suboptimal and confusing. The checker does not depend on any axis parameters. Pre-SCM plugin - not good, as I need to run the checker after the code checkout, obviously. Existing code checker plugins - they all run known checkers (like cppcheck), I want to run a custom script). Multiple jobs in parallel - doesn't address the issue of time saving. Also, I want a single PR builder to talk to Stash and to post one single result at the end to prevent confusion.
[JIRA] (JENKINS-56063) git-plugin fails to expand variables in refspec on initial clone
Title: Message Title Pavel Roskin created an issue Jenkins / JENKINS-56063 git-plugin fails to expand variables in refspec on initial clone Issue Type: Bug Assignee: Mark Waite Attachments: git-clone-config.xml Components: git-plugin Created: 2019-02-08 22:23 Environment: Jenkins 2.150.2 Git plugin 4.0.0-rc Labels: git-plugin variables expansion Priority: Major Reporter: Pavel Roskin Git plugin fails to expand variables in the refspec setting. A sure way to trigger the bug is to enable both "Honor refspec on initial clone" and "Wipe out repository & force clone". The config is attached. Here's an excerpt from the log to the top-level job: > git fetch --no-tags --progress http://stash/scm/rob/testrepository.git +refs/heads/master:refs/remotes/origin/master${BUILD_ID} # timeout=10 > git config remote.origin.url http://stash/scm/rob/testrepository.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/master:refs/remotes/origin/master${BUILD_ID} # timeout=10 > git config remote.origin.url http://stash/scm/rob/testrepository.git # timeout=10 Cleaning workspace > git rev-parse --verify HEAD # timeout=10 No valid HEAD. Skipping the resetting > git clean -fdx #
[JIRA] (JENKINS-56012) stash-pullrequest-builder-plugin variables not seen in multi-configuration jobs unless listed in safeParameters
Title: Message Title Pavel Roskin commented on JENKINS-56012 Re: stash-pullrequest-builder-plugin variables not seen in multi-configuration jobs unless listed in safeParameters I don't think it's the same. There is no mention of matrix builds. `-Dhudson.model.ParametersAction...`is too imprecise. In my case, listing all 10 variables exported by the plugin in `-Dhudson.model.ParametersAction.safeParameters` was insufficient to suppress the logs. I had to add `-Dhudson.model.ParametersAction.keepUndefinedParameters=false` in addition to that. I would rather not do it, as it suppresses all warnings about all undefined variables from all plugins. Fortunately I don't have any, but I'd rather have those warnings in the log if I even need to debug another issue with variables. I looked what variables are passed to the jobs for individual parameter combinations. `GIT_COMMIT` is one such variable. It must be comping from the git-plugin, so it could probably serve as an example. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56012) stash-pullrequest-builder-plugin variables not seen in multi-configuration jobs unless listed in safeParameters
Title: Message Title Pavel Roskin created an issue Jenkins / JENKINS-56012 stash-pullrequest-builder-plugin variables not seen in multi-configuration jobs unless listed in safeParameters Issue Type: Bug Assignee: Jakub Bochenski Components: stash-pullrequest-builder-plugin Created: 2019-02-07 03:05 Environment: Jenkins 2.150.2. stash-pullrequest-builder-plugin built locally from current git (6115a02e9c081b6ee02325d93608e89bf78be93a) Labels: stash multi-configuration variable Priority: Minor Reporter: Pavel Roskin stash-pullrequest-builder-plugin defines 10 variables, such as `sourceCommitHash`. Those variables are not available in multi-configuration jobs apart from the top-level process. Those variable can be made available to the jobs by listing them in hudson.model.ParametersAction.safeParameters on the java command line. That's a workaround for SECURITY-170 that is no longer needed for free-style jobs. Even with that workaround, Jenkins spams logs with messages like this: WARNING: Skipped parameter `sourceCommitHash` as it is undefined on `TestRepository_pull_request_builder`. Set `-Dhudson.model.ParametersAction.keepUndefinedParameters=true` to allow undefined parameters to be injected as environment variables or `-Dhudson.model.ParametersAction.safeParameters=[comma-separated list]` to whitelist specific parameter names, even though it represents a security breach or `-Dhudson.model.ParametersAction.keepUndefinedParameters=false` to no
[JIRA] (JENKINS-55853) Customized Post Build Comment ignored for multi-configuration projects
Title: Message Title Pavel Roskin created an issue Jenkins / JENKINS-55853 Customized Post Build Comment ignored for multi-configuration projects Issue Type: Bug Assignee: Unassigned Components: stash-pullrequest-builder-plugin Created: 2019-01-30 06:49 Environment: Jenkins 2.138.4, stash-pullrequest-builder-plugin 1.7.0. Labels: configuration Priority: Minor Reporter: Pavel Roskin The "Post Build Comment" settings are ignored for some jobs. Instead, Jenkins posts the default comments to Stash. I tried customizing several jobs, and I see that the customization is ignored if and only if it's a multi-configuration project. Free-style projects support customized messages. Add Comment
[JIRA] (JENKINS-55222) JDK Installer certificate expiry
Title: Message Title Pavel Roskin commented on JENKINS-55222 Re: JDK Installer certificate expiry Updating plugins gets me to a page with the text " None of the tool installer metadata passed the signature check". This started recently. jenkins.log includes: "java.security.cert.CertificateExpiredException: NotAfter: Sat Dec 15 08:54:02 PST 2018". That's the same time in a different timezone. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-53514) 'Keep me signed in' combobox do not visible in compatibility mode ie11
Title: Message Title Pavel Roskin commented on JENKINS-53514 Re: 'Keep me signed in' combobox do not visible in compatibility mode ie11 I'm seeing the same issue with Jenkins 2.140. It's not a regression in 2.141. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36624) Make combination filter multi-line if necessary
Title: Message Title Pavel Roskin commented on JENKINS-36624 Re: Make combination filter multi-line if necessary I use 3 axes, with 9*2*2 = 36 builds (soon 9 * 3 * 2 = 54 builds). It takes hours to compile the whole matrix, which means a slow turnaround for pull request. I want to have a good coverage of every axis value without testing every combination of the values. Also, I want explicit control over the combinations, I don't want randomness in pull request testing. The combination filter is totally out of control, it's a huge single line. It would be even better to have a GUI where I could use checkboxes to select the builds. Add Comment This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.