[JIRA] (JENKINS-58184) Jacoco delta threshold failures if coverage *increases* over threshold

2019-06-25 Thread raino.k...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Raino Kolk commented on  JENKINS-58184  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Jacoco delta threshold failures if coverage *increases* over threshold   
 

  
 
 
 
 

 
 Why not check before abs that coverage delta is negative? It should be ok to ignore positive delta from that check.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200238.1561460352000.8013.1561462080119%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-58184) Jacoco delta threshold failures if coverage *increases* over threshold

2019-06-25 Thread raino.k...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Raino Kolk created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-58184  
 
 
  Jacoco delta threshold failures if coverage *increases* over threshold   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Ognjen Bubalo  
 
 
Components: 
 jacoco-plugin  
 
 
Created: 
 2019-06-25 10:59  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Raino Kolk  
 

  
 
 
 
 

 
 Jacoco delta threshold got failure if some coverage metrics decreases less than delta threshold but some increases over delta threshold. Problematic code is  JacocoPublisher.java 

 

public Result checkBuildOverBuildResult(Run run, PrintStream logger){

JacocoDeltaCoverageResultSummary deltaCoverageResultSummary = JacocoDeltaCoverageResultSummary.build(run);
logger.println("[JaCoCo plugin] Delta coverage: class: " + deltaCoverageResultSummary.getClassCoverage()
+ ", method: " + deltaCoverageResultSummary.getMethodCoverage()
+ ", line: " + deltaCoverageResultSummary.getLineCoverage()
+ ", branch: " + deltaCoverageResultSummary.getBranchCoverage()
+ ", instruction: " + deltaCoverageResultSummary.getInstructionCoverage()
+ ", complexity: " + deltaCoverageResultSummary.getComplexityCoverage());

if(Math.abs(deltaCoverageResultSummary.getInstructionCoverage()) <= deltaHealthReport.getDeltaInstruction() &&
Math.abs(deltaCoverageResultSummary.getBranchCoverage()) <= deltaHealthReport.getDeltaBranch() &&
Math.abs(deltaCoverageResultSummary.getComplexityCoverage()) <= deltaHealthReport.getDeltaComplexity() &&
Math.abs(deltaCoverageResultSummary.getLineCoverage()) <= deltaHealthReport.getDeltaLine() &&
Math.abs(deltaCoverageResultSummary.getMethodCoverage()) <= deltaHealthReport.getDeltaMethod() &&
Math.abs(deltaCoverageResultSummary.getClassCoverage()) 

[JIRA] (JENKINS-33983) Multibranch Pipeline with git uses jgit, but should use git installation that is configured

2016-06-17 Thread raino.k...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Raino Kolk edited a comment on  JENKINS-33983  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Multibranch Pipeline with git uses jgit, but should use git installation that is configured   
 

  
 
 
 
 

 
 I had same issue.Seems that it is related somehow how you defined git credentials in jenkins.No problem if you  copyd  copied  PK directly to credential.No problem if you give full path of private key: /usr/lib/jenkins/.ssh/id_rsa for exampleProblem occured when using relative path ~/.ssh/id_rsaHope this helps someone  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-33983) Multibranch Pipeline with git uses jgit, but should use git installation that is configured

2016-06-17 Thread raino.k...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Raino Kolk commented on  JENKINS-33983  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Multibranch Pipeline with git uses jgit, but should use git installation that is configured   
 

  
 
 
 
 

 
 I had same issue. Seems that it is related somehow how you defined git credentials in jenkins. No problem if you copyd PK directly to credential. No problem if you give full path of private key: /usr/lib/jenkins/.ssh/id_rsa for example Problem occured when using relative path ~/.ssh/id_rsa Hope this helps someone  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.