[JIRA] (JENKINS-19022) GIT Plugin (any version) heavily bloats memory use and size of build.xml with "BuildData" fields
Title: Message Title tzafrir commented on JENKINS-19022 Re: GIT Plugin (any version) heavily bloats memory use and size of build.xml with "BuildData" fields The buildData is also required for gitlab plugin. gitlab plugin pipeline step "gitlabCommitStatus" isn't working anymore with 4.0.0-rc It does not find any BuildData object. Had to downgrade to 3.9.3 where all was working fine. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-35310) ComputedFolder shows BuildAuthorizationToken configuration but does not actually support it
Title: Message Title tzafrir edited a comment on JENKINS-35310 Re: ComputedFolder shows BuildAuthorizationToken configuration but does not actually support it > bq. This should be done with the webhook for the Git plugin, /git/notifyCommit. [~jglick] I ended up doing just that and it works fine without requiring special permission. Yet post message to this address (as what gilab webhook provides) result with "no valid crumb was included in the request" Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-35310) ComputedFolder shows BuildAuthorizationToken configuration but does not actually support it
Title: Message Title tzafrir commented on JENKINS-35310 Re: ComputedFolder shows BuildAuthorizationToken configuration but does not actually support it > This should be done with the webhook for the Git plugin, /git/notifyCommit. I ended up doing just that and it works fine without requiring special permission. Yet post message to this address (as what gilab webhook provides) result with "no valid crumb was included in the request" Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40023) JGit changelog list no changes prior to merge commit
Title: Message Title
tzafrir updated an issue
Jenkins / JENKINS-40023
JGit changelog list no changes prior to merge commit
Change By:
tzafrir
git-client version 2.1.0 Adding Jgit changelog does not work well when setting max revisions limit, if the below test case in GitAPITestCase revisions containt merge commits . java fails with JGit but passes with CliGit. For JGit it seems that after That is because RevWalker check will only return the merge commit at HEAD number of revision as set by limitations , it finds no prior commits but ChangelogCommand default behaviour is to list and show skip merge commits. Resulting in returning less commits then requested by the changelog user . Whereas This can be seen by the CliGit does find below test case (for GitApiTestCase class) where JGit returns empty changelog if the head commit with the message "commit1" is a merge commit, and returns it's SHA1 max limit was set to 1. The test will pass if the max limit is increased to 2. {code}public void test_changelog_with_merge_commit test_changelog_with_merge_commit_and_max_log_history () throws Exception {w.init();w.commitEmpty("init");// First commit to branch1w.git.branch("branch1");w.git.checkout("branch1");w.touch("file1", "content1");w.git.add("file1");w.git.commit("commit1");String commitSha1 = w.git.revParse("HEAD").name();// Merge branch1 into masterw.git.checkout("master");String mergeMessage = "Merge message to be tested.";w.git.merge().setMessage(mergeMessage).setGitPluginFastForwardMode(MergeCommand.GitPluginFastForwardMode.NO_FF).setRevisionToMerge(w.git.getHeadRev(w.repoPath(), "branch1")).execute(); // Obtain last commit messageString mergeSha1 StringWriter writer = new StringWriter(); w.git. revParse changelog ( "HEAD" ). name max ( 1 ) .to(writer).execute() ; // Changing max limit to 2 will pass the test check_changelog_sha1 assertThat ( commitSha1 writer.toString() , "master" not(isEmptyString( ) )) ;} {code}
Add Comment
[JIRA] (JENKINS-40023) JGit changelog max limit not working well with merge commits
Title: Message Title tzafrir updated an issue Jenkins / JENKINS-40023 JGit changelog max limit not working well with merge commits Change By: tzafrir Summary: JGit changelog list no changes prior to max limit not working well with merge commit commits Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40023) JGit changelog list no changes prior to merge commit
Title: Message Title
tzafrir created an issue
Jenkins / JENKINS-40023
JGit changelog list no changes prior to merge commit
Issue Type:
Bug
Assignee:
Mark Waite
Components:
git-client-plugin
Created:
2016/Nov/24 7:23 PM
Priority:
Minor
Reporter:
tzafrir
git-client version 2.1.0 Adding the below test case in GitAPITestCase.java fails with JGit but passes with CliGit. For JGit it seems that after RevWalker check the merge commit at HEAD, it finds no prior commits to list and show in the changelog. Whereas the CliGit does find the commit with the message "commit1" and returns it's SHA1
public void test_changelog_with_merge_commit() throws Exception {
w.init();
w.commitEmpty("init");
// First commit to branch1
w.git.branch("branch1");
w.git.checkout("branch1");
w.touch("file1", "content1");
w.git.add("file1");
w.git.commit("commit1");
String commitSha1 = w.git.revParse("HEAD").name();
// Merge branch1 into master
w.git.checkout("master");
String mergeMessage = "Merge message to be tested.";
w.git.merge().setMessage(mergeMessage).setGitPluginFastForwardMode(MergeCommand.GitPluginFastForwardMode.NO_FF).setRevisionToMerge(w.git.getHeadRev(w.repoPath(), "branch1")).execute();
// Obtain last commit message
String mergeSha1 = w.git.revParse("HEAD").name();
check_changelog_sha1(commitSha1, "master");
}
[JIRA] (JENKINS-33210) EOFException when using Static Analysis Collector
Title: Message Title tzafrir commented on JENKINS-33210 Re: EOFException when using Static Analysis Collector I had the same problem. Fixed it by setting up a new maven installation in Global settings. If jenkins was directed to use maven installed on my laptop, I got this error. But when I changed the settings to download new installation of maven from apache, and set it up and /opt it worked just fine. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
