[JIRA] (JENKINS-60316) Git client plugin doesn't quote file locations in askpass wrappers
Title: Message Title
Waldemar Zurowski edited a comment on JENKINS-60316
Re: Git client plugin doesn't quote file locations in askpass wrappers
Also - this is wrong, as well. You cannot escape a single quote that way at all. Perhaps {{org.apache.commons.text.StringEscapeUtils. Builder escape XSI }} should be used instead
Add Comment
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203313.1574939216000.10169.1575302160271%40Atlassian.JIRA.
[JIRA] (JENKINS-60316) Git client plugin doesn't quote file locations in askpass wrappers
Title: Message Title Waldemar Zurowski commented on JENKINS-60316 Re: Git client plugin doesn't quote file locations in askpass wrappers Also - this is wrong, as well. You cannot escape a single quote that way at all. Perhaps org.apache.commons.text.StringEscapeUtils.Builder should be used instead Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203313.1574939216000.10156.1575301260208%40Atlassian.JIRA.
[JIRA] (JENKINS-60316) Git client plugin doesn't quote file locations in askpass wrappers
Title: Message Title Waldemar Zurowski commented on JENKINS-60316 Re: Git client plugin doesn't quote file locations in askpass wrappers This line of code doesn't change anything because the quoting backslash is consumed by regexp handling so in the end it replaces a single quote with identical single quote. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203313.1574939216000.9668.1575213600118%40Atlassian.JIRA.
[JIRA] (JENKINS-60316) Git client plugin doesn't quote file locations in askpass wrappers
Title: Message Title
Waldemar Zurowski commented on JENKINS-60316
Re: Git client plugin doesn't quote file locations in askpass wrappers
Also further to my note, the culprit seems to be:
filename = filename.replaceAll("'", "\\'");
in the unixArgEncodeFileName method (and others) which doesn't appear to actually do anything.
Add Comment
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203313.1574939216000.9457.1575042780162%40Atlassian.JIRA.
[JIRA] (JENKINS-60316) Git client plugin doesn't quote file locations in askpass wrappers
Title: Message Title
Waldemar Zurowski commented on JENKINS-60316
Re: Git client plugin doesn't quote file locations in askpass wrappers
Also one more clarification - this happens when Jenkinsfile uses external libraries
@Library('existing-build-control')
and this library is defined as a Github repository, fetched over HTTPS
Add Comment
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203313.1574939216000.9429.1575040320650%40Atlassian.JIRA.
[JIRA] (JENKINS-60316) Git client plugin doesn't quote file locations in askpass wrappers
Title: Message Title Waldemar Zurowski commented on JENKINS-60316 Re: Git client plugin doesn't quote file locations in askpass wrappers Mark - is there any way I could dump an actual content of that jenkins-gitclient-pass file? Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203313.1574939216000.9379.1575032460216%40Atlassian.JIRA.
[JIRA] (JENKINS-60316) Git client plugin doesn't quote file locations in askpass wrappers
Title: Message Title Waldemar Zurowski commented on JENKINS-60316 Re: Git client plugin doesn't quote file locations in askpass wrappers I checked the master branch in Github and the problem was still there. Anyhow - the version we use is 3.0.0 Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203313.1574939216000.9029.1574959380117%40Atlassian.JIRA.
[JIRA] (JENKINS-60316) Git client plugin doesn't quote file locations in askpass wrappers
Title: Message Title Waldemar Zurowski updated an issue Jenkins / JENKINS-60316 Git client plugin doesn't quote file locations in askpass wrappers Change By: Waldemar Zurowski Summary: Git client plugin doesn't quote file locations in askpass wrappers Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203313.1574939216000.8642.1574939280631%40Atlassian.JIRA.
[JIRA] (JENKINS-60316) Git client doesn't quote file locations in askpass wrappers
Title: Message Title Waldemar Zurowski created an issue Jenkins / JENKINS-60316 Git client doesn't quote file locations in askpass wrappers Issue Type: Bug Assignee: Mark Waite Components: git-client-plugin Created: 2019-11-28 11:06 Priority: Minor Reporter: Waldemar Zurowski We have a project which uses blank spaces and other characters for its name. This name is used to create a temporary folder for files containing username and password consumed by a script generated by CliGitAPIImpl class. Because these names of these files are not quoted in the generated shell script, a script has a syntax errors and we run into following problem: using GIT_ASKPASS to set credentials token to authenticate with github for XXX > git fetch --no-tags --force --progress -- https://github.com/corda/XXX.git +refs/heads/master:refs/remotes/origin/master # timeout=10 ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from https://github.com/corda/XXX.git at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:899) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1114) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1145) at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:124) at org.jenkinsci.plugins.workflow.libs.SCMSourceRetriever.lambda$doRetrieve$1(SCMSourceRetriever.java:154) at org.jenkinsci.plugins.workflow.libs.SCMSourceRetriever.retrySCMOperation(SCMSourceRetriever.java:104) at org.jenkinsci.plugins.workflow.libs.SCMSourceRetriever.doRetrieve(SCMSourceRetriever.java:153) at org.jenkinsci.plugins.workflow.libs.SCMSourceRetriever.retrieve(SCMSourceRetriever.java:93) at org.jenkinsci.plugins.workflow.libs.LibraryAdder.retrieve(LibraryAdder.java:157) at
