[JIRA] (JENKINS-12730) Going to pages via global shortcuts doesn't use the current url/url set in config
Mandeep Rai created JENKINS-12730: - Summary: Going to pages via global shortcuts doesn't use the current url/url set in config Key: JENKINS-12730 URL: https://issues.jenkins-ci.org/browse/JENKINS-12730 Project: Jenkins Issue Type: Bug Components: keyboard-shortcuts Affects Versions: current Reporter: Mandeep Rai Assignee: jieryn I have my jenkins running on port 8001 (ie: http://builds:8001) using a prefix of "builds" (ie: http://builds:8001/builds). I also have an Apache instance that is forwarding from port 80 to jenkins (ie: http://builds.mydomain.com/builds). In the jenkins main config, I have the "Jenkins URL" in the system config set to the proper apache forwarded address (ie: http://builds.mydomain.com/builds), as is the JENKINS_URL. If I use the keyboard shortcut to go to a job, instead of http://builds.mydomain.com/builds/job/, it goes to http://builds:8001/builds/job/, and as a result of the url change, I am no longer logged in, unless I manually change the host in the location bar from builds:8001 to builds.mydomain.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12730) Going to pages via global shortcuts doesn't use the current url/url set in config
[ https://issues.jenkins-ci.org/browse/JENKINS-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159064#comment-159064 ] jieryn commented on JENKINS-12730: -- This is really weird.. As you can see in the plugin, we are exploiting getRootUrlFromRequest: https://github.com/jenkinsci/keyboard-shortcuts-plugin/blob/master/src/main/java/org/jenkins/ci/plugins/keyboard_shortcuts/KeyboardShortcutsPageDecorator.java#L118 And the javadoc for that method suggests it is immune to these kinds of issues: http://javadoc.jenkins-ci.org/jenkins/model/Jenkins.html#getRootUrlFromRequest() So... I am quite confused why this is happening. > Going to pages via global shortcuts doesn't use the current url/url set in > config > - > > Key: JENKINS-12730 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12730 > Project: Jenkins > Issue Type: Bug > Components: keyboard-shortcuts >Affects Versions: current >Reporter: Mandeep Rai >Assignee: jieryn > > I have my jenkins running on port 8001 (ie: http://builds:8001) using a > prefix of "builds" (ie: http://builds:8001/builds). > I also have an Apache instance that is forwarding from port 80 to jenkins > (ie: http://builds.mydomain.com/builds). > In the jenkins main config, I have the "Jenkins URL" in the system config set > to the proper apache forwarded address (ie: > http://builds.mydomain.com/builds), as is the JENKINS_URL. > If I use the keyboard shortcut to go to a job, instead of > http://builds.mydomain.com/builds/job/, it goes to > http://builds:8001/builds/job/, and as a result of the url change, I am > no longer logged in, unless I manually change the host in the location bar > from builds:8001 to builds.mydomain.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12730) Going to pages via global shortcuts doesn't use the current url/url set in config
[ https://issues.jenkins-ci.org/browse/JENKINS-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159437#comment-159437 ] Cees Bos commented on JENKINS-12730: We have an Apache configured which is serving the public URL, in our case http://buildmaster-nl That does a re-route in Apache: ProxyRequests On ProxyPass /jenkins http://localhost:8090/jenkins ProxyPassReverse /jenkins http://localhost:8090/jenkins The keyboard plugin uses that url http://localhost:8090/jenkins in my case, so the plugin does not work for us. > Going to pages via global shortcuts doesn't use the current url/url set in > config > - > > Key: JENKINS-12730 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12730 > Project: Jenkins > Issue Type: Bug > Components: keyboard-shortcuts >Affects Versions: current >Reporter: Mandeep Rai >Assignee: jieryn > > I have my jenkins running on port 8001 (ie: http://builds:8001) using a > prefix of "builds" (ie: http://builds:8001/builds). > I also have an Apache instance that is forwarding from port 80 to jenkins > (ie: http://builds.mydomain.com/builds). > In the jenkins main config, I have the "Jenkins URL" in the system config set > to the proper apache forwarded address (ie: > http://builds.mydomain.com/builds), as is the JENKINS_URL. > If I use the keyboard shortcut to go to a job, instead of > http://builds.mydomain.com/builds/job/, it goes to > http://builds:8001/builds/job/, and as a result of the url change, I am > no longer logged in, unless I manually change the host in the location bar > from builds:8001 to builds.mydomain.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12730) Going to pages via global shortcuts doesn't use the current url/url set in config
[ https://issues.jenkins-ci.org/browse/JENKINS-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159438#comment-159438 ] Alex Lehmann commented on JENKINS-12730: wouldn't it be easier to use getRootPath() ? @Cees Bos: did you set the external Jenkins url in the config page? > Going to pages via global shortcuts doesn't use the current url/url set in > config > - > > Key: JENKINS-12730 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12730 > Project: Jenkins > Issue Type: Bug > Components: keyboard-shortcuts >Affects Versions: current >Reporter: Mandeep Rai >Assignee: jieryn > > I have my jenkins running on port 8001 (ie: http://builds:8001) using a > prefix of "builds" (ie: http://builds:8001/builds). > I also have an Apache instance that is forwarding from port 80 to jenkins > (ie: http://builds.mydomain.com/builds). > In the jenkins main config, I have the "Jenkins URL" in the system config set > to the proper apache forwarded address (ie: > http://builds.mydomain.com/builds), as is the JENKINS_URL. > If I use the keyboard shortcut to go to a job, instead of > http://builds.mydomain.com/builds/job/, it goes to > http://builds:8001/builds/job/, and as a result of the url change, I am > no longer logged in, unless I manually change the host in the location bar > from builds:8001 to builds.mydomain.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12730) Going to pages via global shortcuts doesn't use the current url/url set in config
[ https://issues.jenkins-ci.org/browse/JENKINS-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159438#comment-159438 ] Alex Lehmann edited comment on JENKINS-12730 at 2/23/12 1:50 PM: - sorry, my previous message was completely wrong. I'll try to write a better answer tonight, after properly checking the issue. was (Author: alexlehm): wouldn't it be easier to use getRootPath() ? @Cees Bos: did you set the external Jenkins url in the config page? > Going to pages via global shortcuts doesn't use the current url/url set in > config > - > > Key: JENKINS-12730 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12730 > Project: Jenkins > Issue Type: Bug > Components: keyboard-shortcuts >Affects Versions: current >Reporter: Mandeep Rai >Assignee: jieryn > > I have my jenkins running on port 8001 (ie: http://builds:8001) using a > prefix of "builds" (ie: http://builds:8001/builds). > I also have an Apache instance that is forwarding from port 80 to jenkins > (ie: http://builds.mydomain.com/builds). > In the jenkins main config, I have the "Jenkins URL" in the system config set > to the proper apache forwarded address (ie: > http://builds.mydomain.com/builds), as is the JENKINS_URL. > If I use the keyboard shortcut to go to a job, instead of > http://builds.mydomain.com/builds/job/, it goes to > http://builds:8001/builds/job/, and as a result of the url change, I am > no longer logged in, unless I manually change the host in the location bar > from builds:8001 to builds.mydomain.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12730) Going to pages via global shortcuts doesn't use the current url/url set in config
[ https://issues.jenkins-ci.org/browse/JENKINS-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159446#comment-159446 ] Mandeep Rai commented on JENKINS-12730: --- Reading the Javadoc, it seems like getRootUrlFromRequest ignores the manually configured public url, which is why it would redirect from the nice configured url (ie: http://builds.mydomain.com/builds) to the proxy'd address instead (ie: http://builds-pc-1249:8001/builds) May I suggest to using getRootUrl() instead, which does use the configured url, instead of trying to glean it from the request, which may pass through a proxy server? > Going to pages via global shortcuts doesn't use the current url/url set in > config > - > > Key: JENKINS-12730 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12730 > Project: Jenkins > Issue Type: Bug > Components: keyboard-shortcuts >Affects Versions: current >Reporter: Mandeep Rai >Assignee: jieryn > > I have my jenkins running on port 8001 (ie: http://builds:8001) using a > prefix of "builds" (ie: http://builds:8001/builds). > I also have an Apache instance that is forwarding from port 80 to jenkins > (ie: http://builds.mydomain.com/builds). > In the jenkins main config, I have the "Jenkins URL" in the system config set > to the proper apache forwarded address (ie: > http://builds.mydomain.com/builds), as is the JENKINS_URL. > If I use the keyboard shortcut to go to a job, instead of > http://builds.mydomain.com/builds/job/, it goes to > http://builds:8001/builds/job/, and as a result of the url change, I am > no longer logged in, unless I manually change the host in the location bar > from builds:8001 to builds.mydomain.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12730) Going to pages via global shortcuts doesn't use the current url/url set in config
[ https://issues.jenkins-ci.org/browse/JENKINS-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] SCM/JIRA link daemon resolved JENKINS-12730. Resolution: Fixed > Going to pages via global shortcuts doesn't use the current url/url set in > config > - > > Key: JENKINS-12730 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12730 > Project: Jenkins > Issue Type: Bug > Components: keyboard-shortcuts >Affects Versions: current >Reporter: Mandeep Rai >Assignee: jieryn > > I have my jenkins running on port 8001 (ie: http://builds:8001) using a > prefix of "builds" (ie: http://builds:8001/builds). > I also have an Apache instance that is forwarding from port 80 to jenkins > (ie: http://builds.mydomain.com/builds). > In the jenkins main config, I have the "Jenkins URL" in the system config set > to the proper apache forwarded address (ie: > http://builds.mydomain.com/builds), as is the JENKINS_URL. > If I use the keyboard shortcut to go to a job, instead of > http://builds.mydomain.com/builds/job/, it goes to > http://builds:8001/builds/job/, and as a result of the url change, I am > no longer logged in, unless I manually change the host in the location bar > from builds:8001 to builds.mydomain.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12730) Going to pages via global shortcuts doesn't use the current url/url set in config
[ https://issues.jenkins-ci.org/browse/JENKINS-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159450#comment-159450 ] dogfood commented on JENKINS-12730: --- Integrated in !http://ci.jenkins-ci.org/images/16x16/blue.png! [plugins_keyboard-shortcuts #19|http://ci.jenkins-ci.org/job/plugins_keyboard-shortcuts/19/] [FIXED JENKINS-12730] rootUrl vs rootUrlFromRequest -- rev. proxies (Revision 81c894d6ca46e678304613fe8efb1842c1708dc3) Result = SUCCESS Jesse Farinacci : Files : * src/main/java/org/jenkins/ci/plugins/keyboard_shortcuts/KeyboardShortcutsPageDecorator.java > Going to pages via global shortcuts doesn't use the current url/url set in > config > - > > Key: JENKINS-12730 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12730 > Project: Jenkins > Issue Type: Bug > Components: keyboard-shortcuts >Affects Versions: current >Reporter: Mandeep Rai >Assignee: jieryn > > I have my jenkins running on port 8001 (ie: http://builds:8001) using a > prefix of "builds" (ie: http://builds:8001/builds). > I also have an Apache instance that is forwarding from port 80 to jenkins > (ie: http://builds.mydomain.com/builds). > In the jenkins main config, I have the "Jenkins URL" in the system config set > to the proper apache forwarded address (ie: > http://builds.mydomain.com/builds), as is the JENKINS_URL. > If I use the keyboard shortcut to go to a job, instead of > http://builds.mydomain.com/builds/job/, it goes to > http://builds:8001/builds/job/, and as a result of the url change, I am > no longer logged in, unless I manually change the host in the location bar > from builds:8001 to builds.mydomain.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12730) Going to pages via global shortcuts doesn't use the current url/url set in config
[ https://issues.jenkins-ci.org/browse/JENKINS-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159449#comment-159449 ] SCM/JIRA link daemon commented on JENKINS-12730: Code changed in jenkins User: Jesse Farinacci Path: src/main/java/org/jenkins/ci/plugins/keyboard_shortcuts/KeyboardShortcutsPageDecorator.java http://jenkins-ci.org/commit/keyboard-shortcuts-plugin/81c894d6ca46e678304613fe8efb1842c1708dc3 Log: [FIXED JENKINS-12730] rootUrl vs rootUrlFromRequest -- rev. proxies > Going to pages via global shortcuts doesn't use the current url/url set in > config > - > > Key: JENKINS-12730 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12730 > Project: Jenkins > Issue Type: Bug > Components: keyboard-shortcuts >Affects Versions: current >Reporter: Mandeep Rai >Assignee: jieryn > > I have my jenkins running on port 8001 (ie: http://builds:8001) using a > prefix of "builds" (ie: http://builds:8001/builds). > I also have an Apache instance that is forwarding from port 80 to jenkins > (ie: http://builds.mydomain.com/builds). > In the jenkins main config, I have the "Jenkins URL" in the system config set > to the proper apache forwarded address (ie: > http://builds.mydomain.com/builds), as is the JENKINS_URL. > If I use the keyboard shortcut to go to a job, instead of > http://builds.mydomain.com/builds/job/, it goes to > http://builds:8001/builds/job/, and as a result of the url change, I am > no longer logged in, unless I manually change the host in the location bar > from builds:8001 to builds.mydomain.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12730) Going to pages via global shortcuts doesn't use the current url/url set in config
[ https://issues.jenkins-ci.org/browse/JENKINS-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159452#comment-159452 ] jieryn commented on JENKINS-12730: -- Mandeep: Would you please try to run with this updated hpi? http://ci.jenkins-ci.org/job/plugins_keyboard-shortcuts/19/org.jenkins-ci.plugins$keyboard-shortcuts-plugin/artifact/org.jenkins-ci.plugins/keyboard-shortcuts-plugin/1.1-SNAPSHOT/keyboard-shortcuts-plugin-1.1-SNAPSHOT.hpi Let me know if it works for you, if it does, I will push out a 1.1 release incorporating it.. > Going to pages via global shortcuts doesn't use the current url/url set in > config > - > > Key: JENKINS-12730 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12730 > Project: Jenkins > Issue Type: Bug > Components: keyboard-shortcuts >Affects Versions: current >Reporter: Mandeep Rai >Assignee: jieryn > > I have my jenkins running on port 8001 (ie: http://builds:8001) using a > prefix of "builds" (ie: http://builds:8001/builds). > I also have an Apache instance that is forwarding from port 80 to jenkins > (ie: http://builds.mydomain.com/builds). > In the jenkins main config, I have the "Jenkins URL" in the system config set > to the proper apache forwarded address (ie: > http://builds.mydomain.com/builds), as is the JENKINS_URL. > If I use the keyboard shortcut to go to a job, instead of > http://builds.mydomain.com/builds/job/, it goes to > http://builds:8001/builds/job/, and as a result of the url change, I am > no longer logged in, unless I manually change the host in the location bar > from builds:8001 to builds.mydomain.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12730) Going to pages via global shortcuts doesn't use the current url/url set in config
[ https://issues.jenkins-ci.org/browse/JENKINS-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159454#comment-159454 ] Mandeep Rai commented on JENKINS-12730: --- Almost, it looks like it's appending an extra '/'. ie: configured url: http://builds.mydomain.com/builds/ pressing g-C: http://builds.mydomain.com/builds//configure > Going to pages via global shortcuts doesn't use the current url/url set in > config > - > > Key: JENKINS-12730 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12730 > Project: Jenkins > Issue Type: Bug > Components: keyboard-shortcuts >Affects Versions: current >Reporter: Mandeep Rai >Assignee: jieryn > > I have my jenkins running on port 8001 (ie: http://builds:8001) using a > prefix of "builds" (ie: http://builds:8001/builds). > I also have an Apache instance that is forwarding from port 80 to jenkins > (ie: http://builds.mydomain.com/builds). > In the jenkins main config, I have the "Jenkins URL" in the system config set > to the proper apache forwarded address (ie: > http://builds.mydomain.com/builds), as is the JENKINS_URL. > If I use the keyboard shortcut to go to a job, instead of > http://builds.mydomain.com/builds/job/, it goes to > http://builds:8001/builds/job/, and as a result of the url change, I am > no longer logged in, unless I manually change the host in the location bar > from builds:8001 to builds.mydomain.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12730) Going to pages via global shortcuts doesn't use the current url/url set in config
[ https://issues.jenkins-ci.org/browse/JENKINS-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159460#comment-159460 ] SCM/JIRA link daemon commented on JENKINS-12730: Code changed in jenkins User: Jesse Farinacci Path: src/main/webapp/js/keyboard-shortcuts.js http://jenkins-ci.org/commit/keyboard-shortcuts-plugin/7189d9cb9dd5db5dfde666f2b7528e12486fe9d3 Log: [JENKINS-12730] redundant / in set window location href > Going to pages via global shortcuts doesn't use the current url/url set in > config > - > > Key: JENKINS-12730 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12730 > Project: Jenkins > Issue Type: Bug > Components: keyboard-shortcuts >Affects Versions: current >Reporter: Mandeep Rai >Assignee: jieryn > > I have my jenkins running on port 8001 (ie: http://builds:8001) using a > prefix of "builds" (ie: http://builds:8001/builds). > I also have an Apache instance that is forwarding from port 80 to jenkins > (ie: http://builds.mydomain.com/builds). > In the jenkins main config, I have the "Jenkins URL" in the system config set > to the proper apache forwarded address (ie: > http://builds.mydomain.com/builds), as is the JENKINS_URL. > If I use the keyboard shortcut to go to a job, instead of > http://builds.mydomain.com/builds/job/, it goes to > http://builds:8001/builds/job/, and as a result of the url change, I am > no longer logged in, unless I manually change the host in the location bar > from builds:8001 to builds.mydomain.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12730) Going to pages via global shortcuts doesn't use the current url/url set in config
[ https://issues.jenkins-ci.org/browse/JENKINS-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159462#comment-159462 ] jieryn commented on JENKINS-12730: -- Mandeep, please try: http://ci.jenkins-ci.org/job/plugins_keyboard-shortcuts/20/org.jenkins-ci.plugins$keyboard-shortcuts-plugin/artifact/org.jenkins-ci.plugins/keyboard-shortcuts-plugin/1.1-SNAPSHOT/keyboard-shortcuts-plugin-1.1-SNAPSHOT.hpi > Going to pages via global shortcuts doesn't use the current url/url set in > config > - > > Key: JENKINS-12730 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12730 > Project: Jenkins > Issue Type: Bug > Components: keyboard-shortcuts >Affects Versions: current >Reporter: Mandeep Rai >Assignee: jieryn > > I have my jenkins running on port 8001 (ie: http://builds:8001) using a > prefix of "builds" (ie: http://builds:8001/builds). > I also have an Apache instance that is forwarding from port 80 to jenkins > (ie: http://builds.mydomain.com/builds). > In the jenkins main config, I have the "Jenkins URL" in the system config set > to the proper apache forwarded address (ie: > http://builds.mydomain.com/builds), as is the JENKINS_URL. > If I use the keyboard shortcut to go to a job, instead of > http://builds.mydomain.com/builds/job/, it goes to > http://builds:8001/builds/job/, and as a result of the url change, I am > no longer logged in, unless I manually change the host in the location bar > from builds:8001 to builds.mydomain.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12730) Going to pages via global shortcuts doesn't use the current url/url set in config
[ https://issues.jenkins-ci.org/browse/JENKINS-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159461#comment-159461 ] dogfood commented on JENKINS-12730: --- Integrated in !http://ci.jenkins-ci.org/images/16x16/blue.png! [plugins_keyboard-shortcuts #20|http://ci.jenkins-ci.org/job/plugins_keyboard-shortcuts/20/] [JENKINS-12730] redundant / in set window location href (Revision 7189d9cb9dd5db5dfde666f2b7528e12486fe9d3) Result = SUCCESS Jesse Farinacci : Files : * src/main/webapp/js/keyboard-shortcuts.js > Going to pages via global shortcuts doesn't use the current url/url set in > config > - > > Key: JENKINS-12730 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12730 > Project: Jenkins > Issue Type: Bug > Components: keyboard-shortcuts >Affects Versions: current >Reporter: Mandeep Rai >Assignee: jieryn > > I have my jenkins running on port 8001 (ie: http://builds:8001) using a > prefix of "builds" (ie: http://builds:8001/builds). > I also have an Apache instance that is forwarding from port 80 to jenkins > (ie: http://builds.mydomain.com/builds). > In the jenkins main config, I have the "Jenkins URL" in the system config set > to the proper apache forwarded address (ie: > http://builds.mydomain.com/builds), as is the JENKINS_URL. > If I use the keyboard shortcut to go to a job, instead of > http://builds.mydomain.com/builds/job/, it goes to > http://builds:8001/builds/job/, and as a result of the url change, I am > no longer logged in, unless I manually change the host in the location bar > from builds:8001 to builds.mydomain.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12730) Going to pages via global shortcuts doesn't use the current url/url set in config
[
https://issues.jenkins-ci.org/browse/JENKINS-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159550#comment-159550
]
Mandeep Rai commented on JENKINS-12730:
---
pressing g-C from the homepage ("http://builds.mydomain.com/builds/";) goes to
"http://builds.mydomain.com/buildsconfigure";
g-m from homepage goes to "/builds//manage"
g-C from manage page ("http://builds.mydomain.com/builds/manage"; OR
"http://builds.mydomain.com/builds//manage";) goes to "builds//configure"
Also, if I go to the Configure page, the loading grey box stays up forever (I
am at Jenkins 1.451)
> Going to pages via global shortcuts doesn't use the current url/url set in
> config
> -
>
> Key: JENKINS-12730
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12730
> Project: Jenkins
> Issue Type: Bug
> Components: keyboard-shortcuts
>Affects Versions: current
>Reporter: Mandeep Rai
>Assignee: jieryn
>
> I have my jenkins running on port 8001 (ie: http://builds:8001) using a
> prefix of "builds" (ie: http://builds:8001/builds).
> I also have an Apache instance that is forwarding from port 80 to jenkins
> (ie: http://builds.mydomain.com/builds).
> In the jenkins main config, I have the "Jenkins URL" in the system config set
> to the proper apache forwarded address (ie:
> http://builds.mydomain.com/builds), as is the JENKINS_URL.
> If I use the keyboard shortcut to go to a job, instead of
> http://builds.mydomain.com/builds/job/, it goes to
> http://builds:8001/builds/job/, and as a result of the url change, I am
> no longer logged in, unless I manually change the host in the location bar
> from builds:8001 to builds.mydomain.com
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12730) Going to pages via global shortcuts doesn't use the current url/url set in config
[ https://issues.jenkins-ci.org/browse/JENKINS-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159628#comment-159628 ] Alex Lehmann commented on JENKINS-12730: this is still not working in plugin release 1.0 > Going to pages via global shortcuts doesn't use the current url/url set in > config > - > > Key: JENKINS-12730 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12730 > Project: Jenkins > Issue Type: Bug > Components: keyboard-shortcuts >Affects Versions: current >Reporter: Mandeep Rai >Assignee: jieryn > > I have my jenkins running on port 8001 (ie: http://builds:8001) using a > prefix of "builds" (ie: http://builds:8001/builds). > I also have an Apache instance that is forwarding from port 80 to jenkins > (ie: http://builds.mydomain.com/builds). > In the jenkins main config, I have the "Jenkins URL" in the system config set > to the proper apache forwarded address (ie: > http://builds.mydomain.com/builds), as is the JENKINS_URL. > If I use the keyboard shortcut to go to a job, instead of > http://builds.mydomain.com/builds/job/, it goes to > http://builds:8001/builds/job/, and as a result of the url change, I am > no longer logged in, unless I manually change the host in the location bar > from builds:8001 to builds.mydomain.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12730) Going to pages via global shortcuts doesn't use the current url/url set in config
[ https://issues.jenkins-ci.org/browse/JENKINS-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Lehmann reopened JENKINS-12730: > Going to pages via global shortcuts doesn't use the current url/url set in > config > - > > Key: JENKINS-12730 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12730 > Project: Jenkins > Issue Type: Bug > Components: keyboard-shortcuts >Affects Versions: current >Reporter: Mandeep Rai >Assignee: jieryn > > I have my jenkins running on port 8001 (ie: http://builds:8001) using a > prefix of "builds" (ie: http://builds:8001/builds). > I also have an Apache instance that is forwarding from port 80 to jenkins > (ie: http://builds.mydomain.com/builds). > In the jenkins main config, I have the "Jenkins URL" in the system config set > to the proper apache forwarded address (ie: > http://builds.mydomain.com/builds), as is the JENKINS_URL. > If I use the keyboard shortcut to go to a job, instead of > http://builds.mydomain.com/builds/job/, it goes to > http://builds:8001/builds/job/, and as a result of the url change, I am > no longer logged in, unless I manually change the host in the location bar > from builds:8001 to builds.mydomain.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12730) Going to pages via global shortcuts doesn't use the current url/url set in config
[ https://issues.jenkins-ci.org/browse/JENKINS-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159641#comment-159641 ] Alex Lehmann commented on JENKINS-12730: the head version works, looks like the fix didn't make it into version 1.0 > Going to pages via global shortcuts doesn't use the current url/url set in > config > - > > Key: JENKINS-12730 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12730 > Project: Jenkins > Issue Type: Bug > Components: keyboard-shortcuts >Affects Versions: current >Reporter: Mandeep Rai >Assignee: jieryn > > I have my jenkins running on port 8001 (ie: http://builds:8001) using a > prefix of "builds" (ie: http://builds:8001/builds). > I also have an Apache instance that is forwarding from port 80 to jenkins > (ie: http://builds.mydomain.com/builds). > In the jenkins main config, I have the "Jenkins URL" in the system config set > to the proper apache forwarded address (ie: > http://builds.mydomain.com/builds), as is the JENKINS_URL. > If I use the keyboard shortcut to go to a job, instead of > http://builds.mydomain.com/builds/job/, it goes to > http://builds:8001/builds/job/, and as a result of the url change, I am > no longer logged in, unless I manually change the host in the location bar > from builds:8001 to builds.mydomain.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12730) Going to pages via global shortcuts doesn't use the current url/url set in config
[ https://issues.jenkins-ci.org/browse/JENKINS-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Lehmann resolved JENKINS-12730. Resolution: Fixed > Going to pages via global shortcuts doesn't use the current url/url set in > config > - > > Key: JENKINS-12730 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12730 > Project: Jenkins > Issue Type: Bug > Components: keyboard-shortcuts >Affects Versions: current >Reporter: Mandeep Rai >Assignee: jieryn > > I have my jenkins running on port 8001 (ie: http://builds:8001) using a > prefix of "builds" (ie: http://builds:8001/builds). > I also have an Apache instance that is forwarding from port 80 to jenkins > (ie: http://builds.mydomain.com/builds). > In the jenkins main config, I have the "Jenkins URL" in the system config set > to the proper apache forwarded address (ie: > http://builds.mydomain.com/builds), as is the JENKINS_URL. > If I use the keyboard shortcut to go to a job, instead of > http://builds.mydomain.com/builds/job/, it goes to > http://builds:8001/builds/job/, and as a result of the url change, I am > no longer logged in, unless I manually change the host in the location bar > from builds:8001 to builds.mydomain.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12730) Going to pages via global shortcuts doesn't use the current url/url set in config
[ https://issues.jenkins-ci.org/browse/JENKINS-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mandeep Rai reopened JENKINS-12730: --- As per my comment (https://issues.jenkins-ci.org/browse/JENKINS-12730?focusedCommentId=159550&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-159550) I don't think this issue is Resolved yet > Going to pages via global shortcuts doesn't use the current url/url set in > config > - > > Key: JENKINS-12730 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12730 > Project: Jenkins > Issue Type: Bug > Components: keyboard-shortcuts >Affects Versions: current >Reporter: Mandeep Rai >Assignee: jieryn > > I have my jenkins running on port 8001 (ie: http://builds:8001) using a > prefix of "builds" (ie: http://builds:8001/builds). > I also have an Apache instance that is forwarding from port 80 to jenkins > (ie: http://builds.mydomain.com/builds). > In the jenkins main config, I have the "Jenkins URL" in the system config set > to the proper apache forwarded address (ie: > http://builds.mydomain.com/builds), as is the JENKINS_URL. > If I use the keyboard shortcut to go to a job, instead of > http://builds.mydomain.com/builds/job/, it goes to > http://builds:8001/builds/job/, and as a result of the url change, I am > no longer logged in, unless I manually change the host in the location bar > from builds:8001 to builds.mydomain.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12730) Going to pages via global shortcuts doesn't use the current url/url set in config
[ https://issues.jenkins-ci.org/browse/JENKINS-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159664#comment-159664 ] jieryn commented on JENKINS-12730: -- As per my comment (https://issues.jenkins-ci.org/browse/JENKINS-12730?focusedCommentId=159462&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-159462) please attempt to use the 1.1-SNAPSHOT I prepared which I think resolves this problem. http://ci.jenkins-ci.org/job/plugins_keyboard-shortcuts/20/org.jenkins-ci.plugins$keyboard-shortcuts-plugin/artifact/org.jenkins-ci.plugins/keyboard-shortcuts-plugin/1.1-SNAPSHOT/keyboard-shortcuts-plugin-1.1-SNAPSHOT.hpi > Going to pages via global shortcuts doesn't use the current url/url set in > config > - > > Key: JENKINS-12730 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12730 > Project: Jenkins > Issue Type: Bug > Components: keyboard-shortcuts >Affects Versions: current >Reporter: Mandeep Rai >Assignee: jieryn > > I have my jenkins running on port 8001 (ie: http://builds:8001) using a > prefix of "builds" (ie: http://builds:8001/builds). > I also have an Apache instance that is forwarding from port 80 to jenkins > (ie: http://builds.mydomain.com/builds). > In the jenkins main config, I have the "Jenkins URL" in the system config set > to the proper apache forwarded address (ie: > http://builds.mydomain.com/builds), as is the JENKINS_URL. > If I use the keyboard shortcut to go to a job, instead of > http://builds.mydomain.com/builds/job/, it goes to > http://builds:8001/builds/job/, and as a result of the url change, I am > no longer logged in, unless I manually change the host in the location bar > from builds:8001 to builds.mydomain.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-12730) Going to pages via global shortcuts doesn't use the current url/url set in config
[ https://issues.jenkins-ci.org/browse/JENKINS-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jieryn closed JENKINS-12730. Resolution: Fixed This is fixed in v1.1 - http://maven.jenkins-ci.org/content/repositories/releases/org/jenkins-ci/plugins/keyboard-shortcuts-plugin/1.1/ > Going to pages via global shortcuts doesn't use the current url/url set in > config > - > > Key: JENKINS-12730 > URL: https://issues.jenkins-ci.org/browse/JENKINS-12730 > Project: Jenkins > Issue Type: Bug > Components: keyboard-shortcuts >Affects Versions: current >Reporter: Mandeep Rai >Assignee: jieryn > > I have my jenkins running on port 8001 (ie: http://builds:8001) using a > prefix of "builds" (ie: http://builds:8001/builds). > I also have an Apache instance that is forwarding from port 80 to jenkins > (ie: http://builds.mydomain.com/builds). > In the jenkins main config, I have the "Jenkins URL" in the system config set > to the proper apache forwarded address (ie: > http://builds.mydomain.com/builds), as is the JENKINS_URL. > If I use the keyboard shortcut to go to a job, instead of > http://builds.mydomain.com/builds/job/, it goes to > http://builds:8001/builds/job/, and as a result of the url change, I am > no longer logged in, unless I manually change the host in the location bar > from builds:8001 to builds.mydomain.com -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
