[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
SCM/JIRA link daemon commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings Code changed in jenkins User: Ulli Hafner Path: src/main/java/hudson/plugins/checkstyle/CheckStyleMavenResultAction.java src/main/resources/hudson/plugins/checkstyle/CheckStylePublisher/config.jelly src/main/resources/hudson/plugins/checkstyle/CheckStyleReporter/config.jelly http://jenkins-ci.org/commit/checkstyle-plugin/d8c652dc9f5826e7ed72a255b3776b60bca4c0f2 Log: JENKINS-15037: Upgrade to new API in order to compute warnings only for stable builds (if option is checked). This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
SCM/JIRA link daemon commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings Code changed in jenkins User: Ulli Hafner Path: src/main/java/hudson/plugins/warnings/WarningsAnnotationsAggregator.java src/main/java/hudson/plugins/warnings/WarningsBuildHistory.java src/main/java/hudson/plugins/warnings/WarningsProjectAction.java src/main/java/hudson/plugins/warnings/WarningsPublisher.java src/main/java/hudson/plugins/warnings/WarningsResult.java src/main/resources/hudson/plugins/warnings/WarningsPublisher/config.jelly src/test/java/hudson/plugins/warnings/WarningsPublisherTest.java http://jenkins-ci.org/commit/warnings-plugin/559c94f82212c265803bd14efa5fe5c3d00f172d Log: JENKINS-15037: Upgrade to new API in order to compute warnings only for stable builds (if option is checked). This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
SCM/JIRA link daemon commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings Code changed in jenkins User: Ulli Hafner Path: src/main/java/hudson/plugins/tasks/MavenTasksResultAction.java src/main/java/hudson/plugins/tasks/TasksAnnotationsAggregator.java src/main/java/hudson/plugins/tasks/TasksMavenResult.java src/main/java/hudson/plugins/tasks/TasksMavenResultAction.java src/main/java/hudson/plugins/tasks/TasksPublisher.java src/main/java/hudson/plugins/tasks/TasksReporter.java src/main/java/hudson/plugins/tasks/TasksReporterResult.java src/main/java/hudson/plugins/tasks/TasksResult.java src/main/java/hudson/plugins/tasks/TasksResultAction.java src/main/resources/hudson/plugins/tasks/FixedTasksDetail/index.jelly http://jenkins-ci.org/commit/tasks-plugin/7fc0ef593e20049dd7f627834945f22ce8d5f6ff Log: JENKINS-15037: Upgrade to new API in order to compute warnings only for stable builds (if option is checked). This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
SCM/JIRA link daemon commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings Code changed in jenkins User: Ulli Hafner Path: plugin/src/main/java/hudson/plugins/findbugs/FindBugsAnnotationsAggregator.java plugin/src/main/java/hudson/plugins/findbugs/FindBugsMavenResult.java plugin/src/main/java/hudson/plugins/findbugs/FindBugsMavenResultAction.java plugin/src/main/java/hudson/plugins/findbugs/FindBugsPublisher.java plugin/src/main/java/hudson/plugins/findbugs/FindBugsReporter.java plugin/src/main/java/hudson/plugins/findbugs/FindBugsReporterResult.java plugin/src/main/java/hudson/plugins/findbugs/FindBugsResult.java plugin/src/main/java/hudson/plugins/findbugs/FindBugsResultAction.java plugin/src/main/java/hudson/plugins/findbugs/MavenFindBugsResultAction.java plugin/src/main/resources/hudson/plugins/findbugs/FindBugsPublisher/config.jelly plugin/src/main/resources/hudson/plugins/findbugs/FindBugsResult/index.jelly http://jenkins-ci.org/commit/findbugs-plugin/070456af4914838b5bb3dd16bd9f1aef242056a0 Log: JENKINS-15037: Upgrade to new API in order to compute warnings only for stable builds (if option is checked). This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
SCM/JIRA link daemon commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings Code changed in jenkins User: Ulli Hafner Path: src/main/java/hudson/plugins/pmd/MavenPmdResultAction.java src/main/java/hudson/plugins/pmd/PmdAnnotationsAggregator.java src/main/java/hudson/plugins/pmd/PmdMavenResult.java src/main/java/hudson/plugins/pmd/PmdMavenResultAction.java src/main/java/hudson/plugins/pmd/PmdPublisher.java src/main/java/hudson/plugins/pmd/PmdReporter.java src/main/java/hudson/plugins/pmd/PmdReporterResult.java src/main/java/hudson/plugins/pmd/PmdResult.java src/main/java/hudson/plugins/pmd/PmdResultAction.java src/main/resources/hudson/plugins/pmd/PmdReporter/config.jelly http://jenkins-ci.org/commit/pmd-plugin/fba349e969bfdfaebfdfaa9785dd6b9d4841c88e Log: JENKINS-15037: Upgrade to new API in order to compute warnings only for stable builds (if option is checked). This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
SCM/JIRA link daemon commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings Code changed in jenkins User: Ulli Hafner Path: src/main/java/hudson/plugins/dry/DryAnnotationsAggregator.java src/main/java/hudson/plugins/dry/DryMavenResult.java src/main/java/hudson/plugins/dry/DryMavenResultAction.java src/main/java/hudson/plugins/dry/DryPublisher.java src/main/java/hudson/plugins/dry/DryReporter.java src/main/java/hudson/plugins/dry/DryReporterResult.java src/main/java/hudson/plugins/dry/DryResult.java src/main/java/hudson/plugins/dry/DryResultAction.java src/main/java/hudson/plugins/dry/MavenDryResultAction.java src/main/resources/hudson/plugins/dry/DryPublisher/config.jelly src/main/resources/hudson/plugins/dry/DryReporter/config.jelly http://jenkins-ci.org/commit/dry-plugin/a715b62caf14f978da2e50dd89fc48beabe2356f Log: JENKINS-15037: Upgrade to new API in order to compute warnings only for stable builds (if option is checked). This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
SCM/JIRA link daemon commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings Code changed in jenkins User: Ulli Hafner Path: src/main/java/hudson/plugins/analysis/collector/AnalysisAnnotationsAggregator.java src/main/java/hudson/plugins/analysis/collector/AnalysisPublisher.java src/main/java/hudson/plugins/analysis/collector/AnalysisResult.java src/main/java/hudson/plugins/analysis/collector/AnalysisResultAction.java src/main/resources/hudson/plugins/analysis/collector/AnalysisPublisher/config.jelly http://jenkins-ci.org/commit/analysis-collector-plugin/019fe5126b9ee42fff7ffeae9d322eec2582e17e Log: JENKINS-15037: Upgrade to new API in order to compute warnings only for stable builds (if option is checked). This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
SCM/JIRA link daemon commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings Code changed in jenkins User: Ulli Hafner Path: src/main/resources/util/thresholds_de.properties http://jenkins-ci.org/commit/analysis-core-plugin/fa56e0b8a18c476e956da4f071daab813cf2d780 Log: JENKINS-15037 Added flag to consider stable reference builds only. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
SCM/JIRA link daemon commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings Code changed in jenkins User: Ulli Hafner Path: src/main/java/hudson/plugins/checkstyle/CheckStyleAnnotationsAggregator.java src/main/java/hudson/plugins/checkstyle/CheckStyleMavenResult.java src/main/java/hudson/plugins/checkstyle/CheckStyleMavenResultAction.java src/main/java/hudson/plugins/checkstyle/CheckStylePublisher.java src/main/java/hudson/plugins/checkstyle/CheckStyleReporter.java src/main/java/hudson/plugins/checkstyle/CheckStyleReporterResult.java src/main/java/hudson/plugins/checkstyle/CheckStyleResult.java http://jenkins-ci.org/commit/checkstyle-plugin/3839a1d61430a3d0d878d54d75b7e40e15d3de02 Log: JENKINS-15037 Added flag to consider stable reference builds only. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
SCM/JIRA link daemon commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings Code changed in jenkins User: Ulli Hafner Path: src/main/java/hudson/plugins/analysis/core/AbstractProjectAction.java src/main/java/hudson/plugins/analysis/core/AnnotationsAggregator.java src/main/java/hudson/plugins/analysis/core/BuildHistory.java src/main/java/hudson/plugins/analysis/core/BuildResult.java src/main/java/hudson/plugins/analysis/core/HealthAwarePublisher.java src/main/java/hudson/plugins/analysis/core/HealthAwareRecorder.java src/main/java/hudson/plugins/analysis/core/HealthAwareReporter.java src/main/java/hudson/plugins/analysis/core/NullBuildHistory.java src/test/java/hudson/plugins/analysis/core/BuildHistoryTest.java http://jenkins-ci.org/commit/analysis-core-plugin/e9fbcb2fc9769f9cde9f073be92c39525b64e635 Log: JENKINS-15037 Added flag to consider stable reference builds only. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
David Pärsson commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings Ok, sure! While we're somewhat eager to get this, we of course understand that you must take your time to do it properly. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
Ulli Hafner commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings I tried to remove the deprecated constructors in the checkstyle plug-in now, but that is not that easy. Seems that I still need to think on how to distribute the new boolean flag to the maven and matrix classes... So please be patient until this will be released, I want to minimize the work in the other plug-ins (and maintain backward compatibility for other plugins that depend on analysis core). This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
SCM/JIRA link daemon commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings Code changed in jenkins User: David Pärsson Path: pom.xml src/main/java/hudson/plugins/checkstyle/CheckStylePublisher.java src/main/java/hudson/plugins/checkstyle/CheckStyleReporter.java src/main/java/hudson/plugins/checkstyle/CheckStyleResult.java http://jenkins-ci.org/commit/checkstyle-plugin/6dd279810046a986945ced3d3922cfbab4d3a388 Log: JENKINS-15037 Optionally consider only stable builds as reference builds This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
SCM/JIRA link daemon commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings Code changed in jenkins User: Ulli Hafner Path: pom.xml src/main/java/hudson/plugins/checkstyle/CheckStylePublisher.java src/main/java/hudson/plugins/checkstyle/CheckStyleReporter.java src/main/java/hudson/plugins/checkstyle/CheckStyleResult.java http://jenkins-ci.org/commit/checkstyle-plugin/cd2daf490dc04cc28d97285d85269848d1505421 Log: Merge pull request #3 from davidparsson/master JENKINS-15037 Added flag to consider stable reference builds only. Compare: https://github.com/jenkinsci/checkstyle-plugin/compare/73c898ef1890...cd2daf490dc0 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
SCM/JIRA link daemon resolved JENKINS-15037 as Fixed Option to consider only stable builds when calculating new warnings Change By: SCM/JIRA link daemon (17/Sep/12 1:13 PM) Status: Open Resolved Resolution: Fixed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
SCM/JIRA link daemon commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings Code changed in jenkins User: David Pärsson Path: src/main/java/hudson/plugins/analysis/core/BuildHistory.java src/main/java/hudson/plugins/analysis/core/HealthAwarePublisher.java src/main/java/hudson/plugins/analysis/core/HealthAwareReporter.java src/main/resources/util/thresholds.jelly src/main/resources/util/thresholds.properties src/test/java/hudson/plugins/analysis/core/BuildHistoryTest.java http://jenkins-ci.org/commit/analysis-core-plugin/f73958097bad7344fb12c75d8aa2928572a51c60 Log: JENKINS-15037 Optionally consider only stable builds as reference builds This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
SCM/JIRA link daemon commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings Code changed in jenkins User: Ulli Hafner Path: src/main/java/hudson/plugins/analysis/core/BuildHistory.java src/main/java/hudson/plugins/analysis/core/HealthAwarePublisher.java src/main/java/hudson/plugins/analysis/core/HealthAwareReporter.java src/main/resources/util/thresholds.jelly src/main/resources/util/thresholds.properties src/test/java/hudson/plugins/analysis/core/BuildHistoryTest.java http://jenkins-ci.org/commit/analysis-core-plugin/b4bf0441cd3ec069687ea06ee2d9acff22b687af Log: Merge pull request #14 from davidparsson/master [FIXED JENKINS-15037] Added flag to consider only stable reference builds. Compare: https://github.com/jenkinsci/analysis-core-plugin/compare/37339d98c253...b4bf0441cd3e This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
Ulli Hafner commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings I see. I forgot that the reference build is used not only during evaluation of the build result but also when computing the new and fixed warnings. I.e., your approach with the new constructor is the only possible solution. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
David Pärsson commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings It seems the CheckStyleResult computes the result of the build, compared to a reference build, before I'm able to set the boolean on the history in HealthAwarePublisher.perform(). I'm currently supplying the boolean flag to the BuildHistory constructor (via CheckStylePublisher and CheckStyleResult). I've created pull requests with my changes. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
Ulli Hafner commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings I think if the checkbox is set then an unstable build should be completely ignored. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
David Pärsson edited a comment on JENKINS-15037 Option to consider only stable builds when calculating new warnings Hm.. What should happen when a project has different warning priorities and one of them increases and another decreases? Ideally when this new option would be enabled, I wouldn't want to decrease any reference warning count for any priority. Using a single build as reference build would however not allow this, and this might complicate things even further. I think it's more clear to just use the stable build as a reference, and ignore the fact that deltas might get messed up as stated in my comment above. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
David Pärsson commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings Hm.. What should happen when a project has different warning priorities and one of them increases and another decreases? Ideally when this new option would be enabled, I wouldn't want to decrease any reference warning count for any priority. Using a single build as reference build would however not allow this, and this might complicate things even further. I think it's more clear to just use the stable build as a reference, and ignore the fact that deltas might get messed up as stated in my comment above. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
David Pärsson commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings Thanks, great instructions! This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
Ulli Hafner edited a comment on JENKINS-15037 Option to consider only stable builds when calculating new warnings That makes sense for me. You need to change: In analysis-core: thresholds.jelly: add a new checkbox after the delta computation in HealthAwarePublisher and HealthAwareReporter: Add a new constructor with new boolean property Add a new boolean field (current behavior must be false to be backward compatible) (automatic persistence) In method perform(): the new flag in the build history needs to be set in BuildHistory: add a boolean setter to toggle the reference build computation add reference build computation based on your algorithm In checkstyle: Change pom dependency to analysis-core to SNAPSHOT so that your changes from above will be seen Add a new boolean property in CheckStylePublisher and CheckStyleReporter constructors Call new super constructor This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
Ulli Hafner edited a comment on JENKINS-15037 Option to consider only stable builds when calculating new warnings That makes sense for me. You need to change: analysis-core: thresholds.jelly: add a new checkbox after the delta computation in HealthAwarePublisher and HealthAwareReporter: Add a new constructor with new boolean property Add a new boolean field (current behavior must be false to be backward compatible) (automatic persistence) In method perform(): the new flag in the build history needs to be set in BuildHistory: add a boolean setter to toggle the reference build computation add reference build computation based on your algorithm checkstyle: Add a new boolean property in CheckStylePublisher and CheckStyleReporter constructors Call new super constructor This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
Ulli Hafner commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings That makes sense for me. You need to change: analysis-core: thresholds.jelly: add a new checkbox after the delta computation in HealthAwarePublisher and HealthAwareReporter: Add a new constructor with new boolean property Add a new boolean field (current behavior must be false to be backward compatible) (automatic persistence) In method perform(): the new flag in the build history needs to be set in BuildHistory: add a boolean setter to toggle the reference build computation add reference build computation based on your algorithm checkstyle: Add a new boolean property in CheckStylePublisher and CheckStyleReporter constructors Call new super constructor This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
David Pärsson commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings Could you possibly point me in a direction where to start? Which class persists these thresholds? I've tried but I can't seem to understand where it's done. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
David Pärsson commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings This could include adding a checkbox in the section under "Compute new warnings (based on reference build)", which says something like "Only lower reference warning count if build is stable". This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
David Pärsson edited a comment on JENKINS-15037 Option to consider only stable builds when calculating new warnings You have a good point! The first option might make more sense. I however came up with a case where this would cause a weird behavior. Consider this: 1. The system is configured to allow one new Checkstyle warning per commit (delta) 2. A build is green 3. The build becomes UNSTABLE (reason doesn't matter) 4. Given that only stable builds are reference builds, the Checkstyle would mark each build as unstable if the sum of new Checkstyle warnings added since the last stable is greater than one. Maybe a more complicated rule is desirable, like this one: The only case where the reference build should NOT be changed is when the build is unstable (for other reasons) and the number of warnings has decreased. In other words, don't allow the reference warning count to decrease when the build is unstable. Comments? This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
David Pärsson commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings You have a good point! The first option might make more sense. I however came up with a case where this would cause a weird behavior. Consider this: 1. The system is configured to allow one new Checkstyle warning per commit (delta) 2. A build is green 3. The build becomes UNSTABLE (reason doesn't matter) 4. Given that only stable builds are reference builds, the Checkstyle would mark each build as unstable if the sum of new Checkstyle warnings added since the last stable is greater than one. Maybe a more complicated rule is desirable: The only case where the reference build shouldn't be changed is when the build is unstable (for other reasons) and the number of warnings has decreased. In other words, don't allow the reference warning count to decrease when the build is unstable. Comments? This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
Ulli Hafner commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings After thinking again about this issue I'm not sure if option 2 still is a good solution. If you set the radio button to SUCCESS then checkstyle will not be started, e.g., after FindBugs has set the build status to UNSTABLE. (Or even worse it depends on the order of the analysis plugins). This makes not much sense. What do you think? This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
David Pärsson commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings Thanks for your suggestions. I'll look into it and get back to you with a pull request. I'll probably go with the second suggestion (with radio buttons). This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
Ulli Hafner updated JENKINS-15037 Option to consider only stable builds when calculating new warnings Change By: Ulli Hafner (06/Sep/12 9:53 AM) Component/s: analysis-core This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
Ulli Hafner commented on JENKINS-15037 Option to consider only stable builds when calculating new warnings I think this is not possible yet. There are two ways to implement that feature: either do not consider unstable builds when computing the reference build number (which is used for comparison). Or don't compute a checkstyle result when a build is unstable (currently there already is an option to run the analysis for "UNSTABLE or SUCCESS", or "UNSTABLE or SUCCESS or FAILURE"). I.e. the checkbox needs to be replaced by a radio button. If you are interested in contributing please provide a pull request. It would be nice if the change could be made as part of the analysis-core plug-in thus that all other analysis plug-ins will inherit the new behavior. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
David Pärsson updated JENKINS-15037 Option to consider only stable builds when calculating new warnings Change By: David Pärsson (04/Sep/12 3:29 PM) Description: I'd like an option to only consider stable builds when computing the number of allowed warnings. Justification follows.Consider this scenario, where a job is configured to become unstable if the number checkstyle warnings increase by 5 or more compared to the previous build:1. The last Jenkins build is stable2. A developer commits a failing test and 10 fixed checkstyle issues. The failing test makes the build unstable.3. The developer reverts the commit, thus removing the failing test but increasing the number of checkstyle warnings back to the number of warnings in 1 . , and above the new limit computed in 2. The build is now unstable because of the checkstyle warnings.Is there a way to prevent a case like step 3 from failing the build? If not, I'd like the option described above. If you won't have the time to implement this in a near future, I think I could look into it. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15037) Option to consider only stable builds when calculating new warnings
David Pärsson created JENKINS-15037 Option to consider only stable builds when calculating new warnings Issue Type: New Feature Assignee: Ulli Hafner Components: checkstyle Created: 04/Sep/12 3:28 PM Description: I'd like an option to only consider stable builds when computing the number of allowed warnings. Justification follows. Consider this scenario, where a job is configured to become unstable if the number checkstyle warnings increase by 5 or more compared to the previous build: 1. The last Jenkins build is stable 2. A developer commits a failing test and 10 fixed checkstyle issues. The failing test makes the build unstable. 3. The developer reverts the commit, thus removing the failing test but increasing the number of checkstyle warnings back to the number of warnings in 1., and above the new limit computed in 2. The build is now unstable because of the checkstyle warnings. Is there a way to prevent a case like step 3 from failing the build? If not, I'd like the option described above. If you won't have the time to implement this in a near future, I think I could look into it. Project: Jenkins Priority: Major Reporter: David Pärsson This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
