[JIRA] (JENKINS-15440) Emailing users at the end of a failed build very slow for big Jenkins instance using subversion
SCM/JIRA link daemon commented on JENKINS-15440 Emailing users at the end of a failed build very slow for big Jenkins instance using subversion Code changed in jenkins User: Nicolas De Loof Path: src/main/java/hudson/scm/SubversionMailAddressResolverImpl.java http://jenkins-ci.org/commit/subversion-plugin/b2451c01790b19ab665a880857e641a46ed89828 Log: JENKINS-15440 MailAddressResolverImpl moved to subversion-mail-address-resolver-plugin This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15440) Emailing users at the end of a failed build very slow for big Jenkins instance using subversion
Nicolas De Loof commented on JENKINS-15440 Emailing users at the end of a failed build very slow for big Jenkins instance using subversion MailAddressResolverImpl moved to https://github.com/jenkinsci/subversion-mail-address-resolver-plugin, just in case someone want to keep a 100% compatible jenkins. To be released after subversion 1.45 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15440) Emailing users at the end of a failed build very slow for big Jenkins instance using subversion
kutzi commented on JENKINS-15440 Emailing users at the end of a failed build very slow for big Jenkins instance using subversion Sounds great. I'll push a svn-plugin release today or tomorrow. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15440) Emailing users at the end of a failed build very slow for big Jenkins instance using subversion
kutzi commented on JENKINS-15440 Emailing users at the end of a failed build very slow for big Jenkins instance using subversion This just completely killed our server, because this also seems to be triggered by requests to //job/JOBNAME/api/json I have to figure out where these request come from, but generally I think that this resolving 'feature' is after all a very bad idea. I'd really like to remove it altogether as I cannot really think of any scenario where this would have been actually useful (given the legacy state of the previously used hard-coded svn repositories) This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15440) Emailing users at the end of a failed build very slow for big Jenkins instance using subversion
Jesse Glick commented on JENKINS-15440 Emailing users at the end of a failed build very slow for big Jenkins instance using subversion As mentioned in JENKINS-16342 I agree that this needs to be either rewritten or deleted outright. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15440) Emailing users at the end of a failed build very slow for big Jenkins instance using subversion
SCM/JIRA link daemon commented on JENKINS-15440 Emailing users at the end of a failed build very slow for big Jenkins instance using subversion Code changed in jenkins User: Jesse Glick Path: src/main/resources/hudson/scm/SubversionMailAddressResolverImpl/global.jelly http://jenkins-ci.org/commit/subversion-plugin/d5f9fb5a4a30aeebb379c3214508ecf80c387382 Log: JENKINS-15440 Warning about using mail resolver rules. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15440) Emailing users at the end of a failed build very slow for big Jenkins instance using subversion
SCM/JIRA link daemon commented on JENKINS-15440 Emailing users at the end of a failed build very slow for big Jenkins instance using subversion Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/scm/SubversionMailAddressResolverImpl.java src/main/resources/hudson/scm/SubversionMailAddressResolverImpl/global.jelly http://jenkins-ci.org/commit/subversion-plugin/ad7882e97d026827a21d206e7731bfb61e746839 Log: Removed very old legacy svn repositories which where configured as defaults for mail address resolving, but are very unlikely to be of use to anyoneFIXED JENKINS-15440 Compare: https://github.com/jenkinsci/subversion-plugin/compare/1795b677b3fd...ad7882e97d02 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15440) Emailing users at the end of a failed build very slow for big Jenkins instance using subversion
SCM/JIRA link daemon resolved JENKINS-15440 as Fixed Emailing users at the end of a failed build very slow for big Jenkins instance using subversion Change By: SCM/JIRA link daemon (29/Dec/12 11:41 AM) Status: Open Resolved Resolution: Fixed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15440) Emailing users at the end of a failed build very slow for big Jenkins instance using subversion
kutzi assigned JENKINS-15440 to kutzi Emailing users at the end of a failed build very slow for big Jenkins instance using subversion Change By: kutzi (18/Dec/12 11:08 AM) Assignee: kutzi This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15440) Emailing users at the end of a failed build very slow for big Jenkins instance using subversion
SCM/JIRA link daemon commented on JENKINS-15440 Emailing users at the end of a failed build very slow for big Jenkins instance using subversion Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/scm/SubversionMailAddressResolverImpl.java http://jenkins-ci.org/commit/subversion-plugin/c7086b3d551e2bf4abc56fe841358b6e06258901 Log: JENKINS-15440 stop as early as possible if there're no rules defined. Getting all projects of a user can be very expensive. Compare: https://github.com/jenkinsci/subversion-plugin/compare/9d8d24463bb9...c7086b3d551e This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15440) Emailing users at the end of a failed build very slow for big Jenkins instance using subversion
kutzi commented on JENKINS-15440 Emailing users at the end of a failed build very slow for big Jenkins instance using subversion Uh, these svn servers which are used by default in SubversionMailAddressResolverImpl.findMailAddressFor are very old. I'd suggest to remove them altogether even if that would mean a minor backword compatibility break - I cannot imagine that someone is really still relying on this feature. Also it would be an improvement to check first if there are any resolver rules and only if iterate over all jobs! This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15440) Emailing users at the end of a failed build very slow for big Jenkins instance using subversion
SCM/JIRA link daemon commented on JENKINS-15440 Emailing users at the end of a failed build very slow for big Jenkins instance using subversion Code changed in jenkins User: Nicolas De loof Path: src/main/java/hudson/scm/SubversionMailAddressResolverImpl.java src/main/resources/hudson/scm/SubversionMailAddressResolverImpl/global.jelly http://jenkins-ci.org/commit/subversion-plugin/bb61a4c321313b4e396ea69dd66ef0f1a89bfa14 Log: Merge pull request #21 from ndeloof/master JENKINS-15440 Compare: https://github.com/jenkinsci/subversion-plugin/compare/82377581f16c...bb61a4c32131 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15440) Emailing users at the end of a failed build very slow for big Jenkins instance using subversion
SCM/JIRA link daemon commented on JENKINS-15440 Emailing users at the end of a failed build very slow for big Jenkins instance using subversion Code changed in jenkins User: Nicolas De Loof Path: src/main/java/hudson/scm/SubversionMailAddressResolverImpl.java src/main/resources/hudson/scm/SubversionMailAddressResolverImpl/global.jelly http://jenkins-ci.org/commit/subversion-plugin/458fa792ef9756a97f9f04d0731a7bd005dcc840 Log: JENKINS-15440 make mail address resolver rules configurable This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15440) Emailing users at the end of a failed build very slow for big Jenkins instance using subversion
Nicolas De Loof commented on JENKINS-15440 Emailing users at the end of a failed build very slow for big Jenkins instance using subversion SubversionMailAddressResolverImpl.findMailAddressFor is a "last chance" strategy to retrieve user email from svn, based on commonly used (but outdated) svn hosting services that offer mail service. Based on your security settings, you should have user populated with email address from company LDAP. As a workaround, just populate users with an email in jenkins user database. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-15440) Emailing users at the end of a failed build very slow for big Jenkins instance using subversion
Will Thames created JENKINS-15440 Emailing users at the end of a failed build very slow for big Jenkins instance using subversion Issue Type: Bug Affects Versions: current Assignee: Unassigned Attachments: jenkins-threaddump.txt Components: subversion Created: 09/Oct/12 6:52 AM Description: At the end of a failing build, the hudson.tasks.MailSender.buildCulpritList determines who to email. The problem comes when hudson.scm.SubversionMailAddressResolverImpl.findMailAddressFor determines the email address of the user by finding all builds a user has committed to. This is done by iterating over every single Jenkins project (hudson.model.User.getProjects() first finds all projects and then uses AbstractProject.hasParticipant - which reads the changelog to see if the user participated). For a large system (we have tens of thousands of builds), this is not at all efficient. Unfortunately findMailAddressFor takes a user and not a project (as the obvious implementation would be to work out the email address from the commit). Also, the results aren't cached and so this is run for every user every time. I'm not sure if this can be resolved with just a fix to the subversion-plugin Environment: Jenkins 1.447 LTS Subversion 1.35 Although both Jenkins and subversion plugin are not latest version, I have browsed github for latest versions and I believe this issue to still be present. Project: Jenkins Priority: Minor Reporter: Will Thames This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
