[JIRA] (JENKINS-16232) !build abort works even if bot doesn't have cancel permissions

2013-01-01 Thread scm_issue_l...@java.net (JIRA) 














































SCM/JIRA link daemon
 commented on  JENKINS-16232


!build abort works even if bot doesnt have cancel permissions















Code changed in jenkins
User: Christoph Kutzinski
Path:
 src/main/java/hudson/plugins/im/bot/AbortCommand.java
 src/main/java/hudson/plugins/im/bot/AbstractSingleJobCommand.java
 src/main/java/hudson/plugins/im/bot/CommentCommand.java
http://jenkins-ci.org/commit/instant-messaging-plugin/5889fcc93a959a70b447cbaf4d504bf1edec8d34
Log:
  Check permissions for abort and command commands FIXED JENKINS-16232































This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[JIRA] (JENKINS-16232) !build abort works even if bot doesn't have cancel permissions

2013-01-01 Thread ku...@gmx.de (JIRA) 














































kutzi
 commented on  JENKINS-16232


!build abort works even if bot doesnt have cancel permissions















Thanks for pointing this out!

Can you append the message where the bot complains that it couldn't abort the build? I couldn't see any permission checking there and wonder where this message comes from.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[JIRA] (JENKINS-16232) !build abort works even if bot doesn't have cancel permissions

2013-01-01 Thread jenkins-ci....@jephir.com (JIRA) 














































jephir
 updated  JENKINS-16232


!build abort works even if bot doesnt have cancel permissions
















Change By:


jephir
(01/Jan/13 6:22 PM)




Description:


Issuingthe!buildabortcommandworksevenifthebotdoesnthavecancelpermissionsinJenkins.Thebotcomplainsthatitcouldntabortthebuild,buttheabortstillsucceeds.Thiscanbetestedbygivingthebotonlyreadpermissions.
{quote}Jephir!buildabortmy_projectBuildBotJephir:couldntabortmy_project.Idontknowwhythishappened.{quote}



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[JIRA] (JENKINS-16232) !build abort works even if bot doesn't have cancel permissions

2013-01-01 Thread jenkins-ci....@jephir.com (JIRA) 














































jephir
 commented on  JENKINS-16232


!build abort works even if bot doesnt have cancel permissions















This is the error message:

Jephir !build abort my_project
BuildBot Jephir:  couldn't abort my_project. I don't know why this happened.
The bot complains it couldn't abort, but looking in Jenkins, it had still succeeded in aborting the build even without cancel permissions.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[JIRA] (JENKINS-16232) !build abort works even if bot doesn't have cancel permissions

2013-01-01 Thread ku...@gmx.de (JIRA) 














































kutzi
 commented on  JENKINS-16232


!build abort works even if bot doesnt have cancel permissions















Thanks, that pointed me to another minor bug that the bug would always print this - regardless if the abort succeeded or not.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[JIRA] (JENKINS-16232) !build abort works even if bot doesn't have cancel permissions

2012-12-31 Thread jenkins-ci....@jephir.com (JIRA) 














































jephir
 created  JENKINS-16232


!build abort works even if bot doesnt have cancel permissions















Issue Type:


Bug



Affects Versions:


current



Assignee:


kutzi



Components:


instant-messaging, ircbot



Created:


31/Dec/12 11:23 PM



Description:


Issuing the !build abort command works even if the bot doesn't have cancel permissions in Jenkins. The bot complains that it couldn't abort the build, but the abort still succeeds.

This can be tested by giving the bot only read permissions.




Project:


Jenkins



Priority:


Critical



Reporter:


jephir

























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira