[JIRA] (JENKINS-16561) Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull
dogfood commented on JENKINS-16561 Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull Integrated in jenkins_main_trunk #2274 Result = SUCCESS This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-16561) Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull
SCM/JIRA link daemon resolved JENKINS-16561 as Fixed Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull Change By: SCM/JIRA link daemon (13/Feb/13 1:45 AM) Status: Open Resolved Resolution: Fixed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-16561) Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull
SCM/JIRA link daemon
commented on JENKINS-16561
Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull
Code changed in jenkins
User: Kohsuke Kawaguchi
Path:
changelog.html
war/src/main/webapp/scripts/hudson-behavior.js
http://jenkins-ci.org/commit/jenkins/3f48eff1ee39e772bd0c1c097ff99fb62786e69f
Log:
[FIXED JENKINS-16561]
eval("") is no-op in IE but window.execScript("") isn't.
So bring the uniformity outside
–
You received this message because you are subscribed to the Google Groups "Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-16561) Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull
Kohsuke Kawaguchi
commented on JENKINS-16561
Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull
Confirmed. In script console,
> eval("")
undefined
> window.execScript("")
(x) "Invalid argument."
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-16561) Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull
Kohsuke Kawaguchi
commented on JENKINS-16561
Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull
This also explains why this bug depends on the servlet container. Jetty must be handlin addHeader("script",null) as removing the header while Winstone must be treating it like addHeader("script","");
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-16561) Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull
Kohsuke Kawaguchi commented on JENKINS-16561 Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull So what script fragment is causing "invalid argument"? It seems like the root cause is that there's an empty value in the script header, not the use of geval. I'm fixing this by adding s!="" check. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-16561) Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull
suresh nallamilli stopped work on JENKINS-16561 Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull Change By: suresh nallamilli (31/Jan/13 12:33 AM) Status: In Progress Open This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-16561) Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull
suresh nallamilli started work on JENKINS-16561 Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull Change By: suresh nallamilli (31/Jan/13 12:32 AM) Status: Open In Progress This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-16561) Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull
suresh nallamilli stopped work on JENKINS-16561 Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull Change By: suresh nallamilli (30/Jan/13 11:48 PM) Status: In Progress Open This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-16561) Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull
suresh nallamilli started work on JENKINS-16561 Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull Change By: suresh nallamilli (30/Jan/13 11:48 PM) Status: Open In Progress This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-16561) Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull
suresh nallamilli commented on JENKINS-16561 Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull I was asked my Jesse Glick to mark this issue as "blocking" JENKINS-15617 to capture the relationship. I am not sure how to do that. Can some one take care of this This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-16561) Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull
suresh nallamilli created JENKINS-16561 Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull Issue Type: Bug Affects Versions: current Assignee: suresh nallamilli Attachments: popupErrorMsg.jpg Components: core Created: 30/Jan/13 11:45 PM Description: Getting warning message in a popup saying "Failed to evaluate. Invalid arguments" for jelly form control validateButton. I am getting this pop up irrespective of actual result of validation. This is happening only in Internet Explorer(8 and 9). This is not getting reproduced when running jenkins using "mvn hpi:run" but getting reproduced when running jenkins using command "java -jar jenkins.war" and then manually importing hpi file from advanced tab. For complete details , refer to discussion in https://groups.google.com/forum/#!topic/jenkinsci-dev/h4vlO8SkA60 Sample to reproduce this issue is available in my github https://github.com/sureshreddygithub/jenkinssamples.git or alternatively you can install https://wiki.jenkins-ci.org/display/JENKINS/SCTMExecutor plugin and try to validate in global configuration in IE. Root cause: For validate button form control , implementation is available @ scripts/hudson-behavior.js In validate function , we are using a custom function geval which is causing the issue. If i replace geval with eval i see that everything works as expected in IE as well. I will be submitting the fix in git shortly Environment: Windows 2008 R2 64 bit , Internet Explorer (8 and 9) Project: Jenkins Labels: plugin _javascript_ Priority: Blocker Reporter: suresh nallamilli This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
