[JIRA] (JENKINS-17009) Parameters with newlines should be stored as TextParameterValue
centic commented on JENKINS-17009 Parameters with newlines should be stored as TextParameterValue Done: https://github.com/jenkinsci/parameterized-trigger-plugin/pull/36 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-17009) Parameters with newlines should be stored as TextParameterValue
cjo9900 commented on JENKINS-17009 Parameters with newlines should be stored as TextParameterValue Can you create a pull request on github for this? Thanks This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-17009) Parameters with newlines should be stored as TextParameterValue
centic assigned JENKINS-17009 to huybrechts Parameters with newlines should be stored as TextParameterValue Change By: centic (01/Mar/13 3:30 PM) Assignee: ragesh_nair huybrechts This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-17009) Parameters with newlines should be stored as TextParameterValue
centic
updated JENKINS-17009
Parameters with newlines should be stored as TextParameterValue
Change By:
centic
(01/Mar/13 3:30 PM)
Summary:
Parameterswithnewlines
arenotappliedcorrectlywhentriggeringarebuild
shouldbestoredasTextParameterValue
Description:
ForoneofmyJobsIneedmultiplelinesoftextinoneparameter,e.g.IntheparameterizedbuildtriggerpluginIspecifythisparameterwith\n:{quote}PROJECTPROPERTIES=sonar.projectKey=preismonitor-lokal\nsonar.projectName=preismonitor-lokal{quote}
This
The\n
correctlypassestheparameterwithnewlinecharactersto
thesecondbuild
anupcomingbiuld
.Inthebuild.xmlofthejenkins-build,thenewlinesarestorednormally
,howeverthereareproblemslateronifotherpluginsworkwiththisdatabecausetheparameter-typeisStringParameterValueinsteadofTextParameterValue:
{code:xml}hudson.model.StringParameterValuenamePROJECTPROPERTIES/namevaluesonar.projectKey=preismonitor-lokalsonar.projectName=preismonitor-lokal/value/hudson.model.StringParameterValue{code}
However
E.g.
ifIusetherebuild-plugintore-triggerthebuildlateron,itseemstocutoffthenewlinesandpassthestringinonesingleline,whichcausestherebuildtofail:{quote}...-Dsonar.projectKey=preismonitor-lokalsonar.projectName=preismonitor-lokal...{quote}
IwillattachapatchwhichcreatesaTextParameterValueifthevaluecontainsnewlines.Thismakesthisworkinallcases.
Component/s:
parameterized-trigger
Component/s:
rebuild
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-17009) Parameters with newlines should be stored as TextParameterValue
centic
updated JENKINS-17009
Parameters with newlines should be stored as TextParameterValue
Change By:
centic
(01/Mar/13 3:31 PM)
Description:
ForoneofmyJobsIneedmultiplelinesoftextinoneparameter,e.g.IntheparameterizedbuildtriggerpluginIspecifythisparameterwith\n:{quote}PROJECTPROPERTIES=sonar.projectKey=preismonitor-lokal\nsonar.projectName=preismonitor-lokal{quote}The\ncorrectlypassestheparameterwithnewlinecharacterstoanupcomingbiuld.Inthebuild.xmlofthejenkins-build,thenewlinesarestorednormally,howeverthereareproblemslateronifotherpluginsworkwiththisdatabecausetheparameter-typeisStringParameterValueinsteadofTextParameterValue:{code:xml}hudson.model.StringParameterValuenamePROJECTPROPERTIES/namevaluesonar.projectKey=preismonitor-lokalsonar.projectName=preismonitor-lokal/value/hudson.model.StringParameterValue{code}E.g.ifIusetherebuild-plugintore-triggerthebuildlateron,itseemstocutoffthenewlinesandpassthestringinonesingleline,whichcausestherebuildtofail:{quote}...-Dsonar.projectKey=preismonitor-lokalsonar.projectName=preismonitor-lokal...{quote}
Iwillattacha
Thefollowing
patch
which
createsaTextParameterValueifthevaluecontainsnewlines.Thismakesthiswork
inallcases
locallyforme:{code}diff--gita/src/main/java/hudson/plugins/parameterizedtrigger/PredefinedBuildParameters
.
javab/src/main/java/hudson/plugins/parameterizedtrigger/PredefinedBuildParameters.javaindexb1cbc73..26f2e50100644---a/src/main/java/hudson/plugins/parameterizedtrigger/PredefinedBuildParameters.java+++b/src/main/java/hudson/plugins/parameterizedtrigger/PredefinedBuildParameters.java@@-2,13+2,14@@importhudson.EnvVars;importhudson.Extension;-importhudson.model.AbstractBuild;importhudson.model.Action;-importhudson.model.Descriptor;importhudson.model.ParameterValue;+importhudson.model.TaskListener;+importhudson.model.AbstractBuild;+importhudson.model.Descriptor;importhudson.model.ParametersAction;importhudson.model.StringParameterValue;-importhudson.model.TaskListener;+importhudson.model.TextParameterValue;importjava.io.IOException;importjava.util.ArrayList;@@-38,8+39,14@@ ListParameterValuevalues=newArrayListParameterValue(); for(Map.EntryObject,Objectentry:p.entrySet()){- values.add(newStringParameterValue(entry.getKey().toString(),- env.expand(entry.getValue().toString(;+ //supportmulti-lineparameterscorrectly+ if(entry.getValue().toString().contains(\n)){+values.add(newTextParameterValue(entry.getKey().toString(),+ env.expand(entry.getValue().toString(;+ }else{+values.add(newStringParameterValue(entry.getKey().toString(),+ env.expand(entry.getValue().toString(;+ } } returnnewParametersAction(values);{code}
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
