[JIRA] (JENKINS-17199) import statement doesn't work Build flow DSL

2013-03-14 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-17199


import statement doesnt work Build flow DSL















Code changed in jenkins
User: Nicolas De loof
Path:
 src/main/groovy/com/cloudbees/plugins/flow/FlowDSL.groovy
 src/test/groovy/com/cloudbees/plugins/flow/BindingTest.groovy
 src/test/groovy/com/cloudbees/plugins/flow/BuildTest.groovy
http://jenkins-ci.org/commit/build-flow-plugin/a810876d7cbe1c8e2d7a79221c6cd2b89048dec8
Log:
  Merge pull request #21 from jenkinsci/JENKINS-17199

Fixed JENKINS-17199


Compare: https://github.com/jenkinsci/build-flow-plugin/compare/e8af7da1bd05...a810876d7cbe

 
You received this message because you are subscribed to the Google Groups "Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.






























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] (JENKINS-17199) import statement doesn't work Build flow DSL

2013-03-13 Thread k...@kohsuke.org (JIRA)














































Kohsuke Kawaguchi
 created  JENKINS-17199


import statement doesnt work Build flow DSL















Issue Type:


Bug



Assignee:


Nicolas De Loof



Components:


build-flow



Created:


13/Mar/13 6:50 PM



Description:


Looks like the plugin is doing string manipulation on the user-written script, which makes the import statement illegal since it won't be the first in the script.

I know a better way to do it, so I'd like to fix this.

This is more of a reminder to myself.




Project:


Jenkins



Priority:


Major



Reporter:


Kohsuke Kawaguchi

























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] (JENKINS-17199) import statement doesn't work Build flow DSL

2013-03-13 Thread scm_issue_l...@java.net (JIRA)















































SCM/JIRA link daemon
 resolved  JENKINS-17199 as Fixed


import statement doesnt work Build flow DSL
















Change By:


SCM/JIRA link daemon
(13/Mar/13 9:14 PM)




Status:


Open
Resolved





Resolution:


Fixed



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] (JENKINS-17199) import statement doesn't work Build flow DSL

2013-03-13 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-17199


import statement doesnt work Build flow DSL















Code changed in jenkins
User: Kohsuke Kawaguchi
Path:
 src/main/groovy/com/cloudbees/plugins/flow/FlowDSL.groovy
 src/test/groovy/com/cloudbees/plugins/flow/BindingTest.groovy
 src/test/groovy/com/cloudbees/plugins/flow/BuildTest.groovy
http://jenkins-ci.org/commit/build-flow-plugin/f10be22bdc7693e3e12137ae8fab1fe05788b3a7
Log:
  FIXED JENKINS-17199

To inject DSL into the script being parsed, the common technique used
elsewhere (for example in Spring bean builder Groovy DSL) is to set
the DSL object as a delegate. This avoids the need to do string
manipulation, and there's no ExpandoMetaClass hack necessary.

I'v moved the bindings to FlowDelegate. This resolves
the conflict between "build" as a variable and "build" as a function
(since binding gets found more quickly it tries to evaluate that
variable as a Callable), and it'll also make it easier for people to
find all the available DSL methods/variables in one place.



 
You received this message because you are subscribed to the Google Groups "Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.






























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] (JENKINS-17199) import statement doesn't work Build flow DSL

2013-03-13 Thread k...@kohsuke.org (JIRA)














































Kohsuke Kawaguchi
 commented on  JENKINS-17199


import statement doesnt work Build flow DSL















Created https://github.com/jenkinsci/build-flow-plugin/pull/21



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.