[JIRA] (JENKINS-26583) Env-inject plugin suppress variables contributed by extension points
Title: Message Title
Trey Owens updated an issue
Jenkins / JENKINS-26583
Env-inject plugin suppress variables contributed by extension points
Change By:
Trey Owens
Whenever envvar is available on slave (either inherited from system or configured on slave), its value can not be overridden during build by envvar contributing extension points:- {{EnvironmentContributor}}- {{BuildWrapper}}- possibly othersThis works correctly when envinject is _not_ installed. The culprit seems to seemsto be that {{EnvInjectPluginAction}} retains _all_ envvars (not only those envinject contributed) early in the build and put this values back as it implements {{EnvironmentContributingAction}}. Any value that was overridden by a plugin is then reset to its original value.
Add Comment
This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26583) Env-inject plugin suppress variables contributed by extension points
Title: Message Title Oleg Nenashev assigned an issue to Unassigned Jenkins / JENKINS-26583 Env-inject plugin suppress variables contributed by extension points Change By: Oleg Nenashev Assignee: Oleg Nenashev Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26583) Env-inject plugin suppress variables contributed by extension points
Title: Message Title Oleg Nenashev commented on JENKINS-26583 Re: Env-inject plugin suppress variables contributed by extension points I have no short-time plans to work on this, unfortunately. No time && the plugin is open for adoption for more then one year Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26583) Env-inject plugin suppress variables contributed by extension points
Title: Message Title Nikolas Falco commented on JENKINS-26583 Re: Env-inject plugin suppress variables contributed by extension points This bug it's a real pain in the @$$, I have 8/9 bug open on nodejs component due to this. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26583) Env-inject plugin suppress variables contributed by extension points
Title: Message Title Robby Pocase assigned an issue to Oleg Nenashev Jenkins / JENKINS-26583 Env-inject plugin suppress variables contributed by extension points Change By: Robby Pocase Assignee: Robby Pocase Oleg Nenashev Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26583) Env-inject plugin suppress variables contributed by extension points
Title: Message Title Robby Pocase assigned an issue to Robby Pocase Jenkins / JENKINS-26583 Env-inject plugin suppress variables contributed by extension points Change By: Robby Pocase Assignee: Robby Pocase Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26583) Env-inject plugin suppress variables contributed by extension points
Title: Message Title Nikolas Falco edited a comment on JENKINS-26583 Re: Env-inject plugin suppress variables contributed by extension points [~afischer] see my previous post I wrote the class that cause this issue. The git hub ( [ PR37|https://github.com/jenkinsci/envinject-plugin/pull/37 ) ] it's a good start point with a lot of UnitTest for this issue.[~swf] In nodejs github repo there is a branch named workaround-26583 for this issue. You can make a custom build and move into 1.1 snapshot Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26583) Env-inject plugin suppress variables contributed by extension points
Title: Message Title Nikolas Falco commented on JENKINS-26583 Re: Env-inject plugin suppress variables contributed by extension points Alexander Fischer see my previous post I wrote the class that cause this issue. The git hub (PR37|https://github.com/jenkinsci/envinject-plugin/pull/37) it's a good start point with a lot of UnitTest for this issue. Yves Schumann In nodejs github repo there is a branch named workaround-26583 for this issue. You can make a custom build and move into 1.1 snapshot Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26583) Env-inject plugin suppress variables contributed by extension points
Title: Message Title Oliver Gondža commented on JENKINS-26583 Re: Env-inject plugin suppress variables contributed by extension points Alexander Fischer, see attached PR. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26583) Env-inject plugin suppress variables contributed by extension points
Title: Message Title Alexander Fischer commented on JENKINS-26583 Re: Env-inject plugin suppress variables contributed by extension points Can you describe some good starting points for search and modifications in the source? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26583) Env-inject plugin suppress variables contributed by extension points
Title: Message Title Oliver Gondža commented on JENKINS-26583 Re: Env-inject plugin suppress variables contributed by extension points I did not managed to do a real progress on this thing and I do not see I will have time to get back to this any time soon. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26583) Env-inject plugin suppress variables contributed by extension points
Title: Message Title Oliver Gondža assigned an issue to Unassigned Jenkins / JENKINS-26583 Env-inject plugin suppress variables contributed by extension points Change By: Oliver Gondža Assignee: Oliver Gondža Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26583) Env-inject plugin suppress variables contributed by extension points
Title: Message Title Yves Schumann commented on JENKINS-26583 Re: Env-inject plugin suppress variables contributed by extension points Any news on this issue? When will it be fixed? We are currently blocked on updating NodeJS plugin from 0.2.2 to 1.1.0 because it will no longer work together with EnvInject plugin. So right now we are stuck on NodeJS plugin 0.2.2. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26583) Env-inject plugin suppress variables contributed by extension points
Title: Message Title Nikolas Falco commented on JENKINS-26583 Re: Env-inject plugin suppress variables contributed by extension points EnvInjectPluginAction#buildEnvVars I do not know the reason of this action, anyway it save an initial environment and put it back After that all buildwrappeer has contribuire the initial environment. So new variables are not affected by this problem, instead changed variables like PATH are restore to its initial value. Maybe this behaviour / action should be done/registered only if "Override environment variables" is selected in the job configuration page. There is also a PR in github provides a lot of tests for an eventual solution Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26583) Env-inject plugin suppress variables contributed by extension points
Title: Message Title Alexander Fischer commented on JENKINS-26583 Re: Env-inject plugin suppress variables contributed by extension points Are there any ideas for fixing this problem? Workarounds in all other plugins are not good ideas... Where in the code we can start inspecting the problem? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26583) Env-inject plugin suppress variables contributed by extension points
Title: Message Title Nikolas Falco commented on JENKINS-26583 Re: Env-inject plugin suppress variables contributed by extension points Sorry, I've rename personal branch for a dedicated workarounf on NodeJS plugin so JIRA should not bother anymore Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26583) Env-inject plugin suppress variables contributed by extension points
Title: Message Title SCM/JIRA link daemon commented on JENKINS-26583 Re: Env-inject plugin suppress variables contributed by extension points Code changed in jenkins User: Nikolas Falco Path: pom.xml src/main/java/jenkins/plugins/nodejs/NodeJSCommandInterpreter.java src/main/java/jenkins/plugins/nodejs/NodeJSPlugin.java src/main/java/jenkins/plugins/nodejs/configfiles/NPMConfig.java src/main/java/jenkins/plugins/nodejs/configfiles/NPMRegistry.java src/main/java/jenkins/plugins/nodejs/configfiles/Npmrc.java src/main/java/jenkins/plugins/nodejs/tools/CPU.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstallation.java src/main/resources/lib/nodejs/select.jelly src/test/java/jenkins/plugins/nodejs/NodeJSBuildWrapperTest.java src/test/java/jenkins/plugins/nodejs/configfiles/NPMConfigTest.java src/test/java/jenkins/plugins/nodejs/configfiles/NPMConfigValidationTest.java http://jenkins-ci.org/commit/nodejs-plugin/bf452be060c0a723991de990ac6833181ef6089d Log: Merge branch 'master' into JENKINS-26583 Compare: https://github.com/jenkinsci/nodejs-plugin/compare/2d08527b32e7...bf452be060c0 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26583) Env-inject plugin suppress variables contributed by extension points
Title: Message Title SCM/JIRA link daemon commented on JENKINS-26583 Re: Env-inject plugin suppress variables contributed by extension points Code changed in jenkins User: Nikolas Falco Path: src/main/java/jenkins/plugins/nodejs/NodeJSBuildWrapper.java src/main/java/jenkins/plugins/nodejs/NodeJSCommandInterpreter.java src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/FixEnvVarEnvironmentContributingAction.java http://jenkins-ci.org/commit/nodejs-plugin/dfd4018b3202898d8a20207df996a5ae111bcd1a Log: Workaround for JENKINS-26583 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26583) Env-inject plugin suppress variables contributed by extension points
Title: Message Title SCM/JIRA link daemon commented on JENKINS-26583 Re: Env-inject plugin suppress variables contributed by extension points Code changed in jenkins User: Nikolas Falco Path: src/main/java/jenkins/plugins/nodejs/NodeJSBuildWrapper.java src/main/java/jenkins/plugins/nodejs/NodeJSCommandInterpreter.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstallation.java src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/FixEnvVarEnvironmentContributingAction.java http://jenkins-ci.org/commit/nodejs-plugin/06c1c1b56865bdf93dad79b5440e822ec680191b Log: Workaround for JENKINS-26583 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26583) Env-inject plugin suppress variables contributed by extension points
Title: Message Title Nikolas Falco commented on JENKINS-26583 Re: Env-inject plugin suppress variables contributed by extension points any news on this?? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26583) Env-inject plugin suppress variables contributed by extension points
Title: Message Title
Nikolas Falco commented on JENKINS-26583
Re: Env-inject plugin suppress variables contributed by extension points
same here I confirm that the EnvInjectPluginAction.buildEnvVars() overrides all enviroment variables contribuited to the context (for example by NodeJS plugin in master code in a SimpleBuildWrapper) in the AbstractBuild.getEnvironment() method when cycles on actions. So the PATH variable contributed by context.env("PATH+NODEJS", path) is override with old one. Now this is blocking because no command are available in the shell resetting any action of the plugin.
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
