[JIRA] (JENKINS-31425) should be able to specify multiple users or groups for the submitter of an input step
Title: Message Title Roman Pickl commented on JENKINS-31425 Re: should be able to specify multiple users or groups for the submitter of an input step thanks! Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31425) should be able to specify multiple users or groups for the submitter of an input step
Title: Message Title Jesse Glick updated JENKINS-31425 Jenkins / JENKINS-31425 should be able to specify multiple users or groups for the submitter of an input step Change By: Jesse Glick Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31425) should be able to specify multiple users or groups for the submitter of an input step
Title: Message Title SCM/JIRA link daemon commented on JENKINS-31425 Re: should be able to specify multiple users or groups for the submitter of an input step Code changed in jenkins User: Jesse Glick Path: .gitignore src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStep.java src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java src/main/resources/org/jenkinsci/plugins/workflow/support/steps/input/InputStep/help-submitter.html src/test/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepTest.java http://jenkins-ci.org/commit/pipeline-input-step-plugin/01c72d7b53c857e0fa7de796a7fefce35260c4fc Log: Merge pull request #6 from escoem/JENKINS-31425 JENKINS-31425 should be able to specify multiple users or groups for the submitter of an input step Compare: https://github.com/jenkinsci/pipeline-input-step-plugin/compare/114a36be8362...01c72d7b53c8 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31425) should be able to specify multiple users or groups for the submitter of an input step
Title: Message Title SCM/JIRA link daemon commented on JENKINS-31425 Re: should be able to specify multiple users or groups for the submitter of an input step Code changed in jenkins User: Emilio Escobar Path: src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStep.java src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java src/main/resources/org/jenkinsci/plugins/workflow/support/steps/input/InputStep/help-submitter.html src/test/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepTest.java http://jenkins-ci.org/commit/pipeline-input-step-plugin/e2563fbbac634b6c9f64cd00755478064fcdd2bf Log: JENKINS-31425 multiple submitters are allowed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31425) should be able to specify multiple users or groups for the submitter of an input step
Title: Message Title
Roman Pickl commented on JENKINS-31425
Re: should be able to specify multiple users or groups for the submitter of an input step
See https://www.cloudbees.com/sites/default/files/2016-jenkins-world-no_you_shouldnt_do_that_lessons_from_using_pipeline.pdf last slide on how people currently try to cope with this limitation. def magicValue node { withCredentials([ [$class: 'StringBinding', credentialsId: 'production_magic', variable: 'tmpMagicValue' ] ]) { magicValue = env.tmpMagicValue } } while (true) { def pass = input id: 'PushToProduction', message: 'Please enter the magic value for publishing to production ', parameters: [[$class: 'com.michelin.cio.hudson.plugins.passwordparam.PasswordParameterDefinition', defaultValue: 'wibble', description: 'The magic token to show you have rights to push to production', name: 'authentication token']] if (magicValue != pass) { echo "incorrect value entered" } else { echo "Push to production approved by magic" break } Please fix this.
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31425) should be able to specify multiple users or groups for the submitter of an input step
Title: Message Title Jesse Glick updated an issue Jenkins / JENKINS-31425 should be able to specify multiple users or groups for the submitter of an input step Change By: Jesse Glick Issue Type: Bug Improvement Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31425) should be able to specify multiple users or groups for the submitter of an input step
Title: Message Title Jesse Glick started work on JENKINS-31425 Change By: Jesse Glick Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31425) should be able to specify multiple users or groups for the submitter of an input step
Title: Message Title Jesse Glick assigned an issue to Emilio Escobar Jenkins / JENKINS-31425 should be able to specify multiple users or groups for the submitter of an input step Change By: Jesse Glick Assignee: Jesse Glick Emilio Escobar Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31425) should be able to specify multiple users or groups for the submitter of an input step
Title: Message Title Jesse Glick updated JENKINS-31425 Jenkins / JENKINS-31425 should be able to specify multiple users or groups for the submitter of an input step Change By: Jesse Glick Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31425) should be able to specify multiple users or groups for the submitter of an input step
Title: Message Title Jesse Glick updated JENKINS-31425 Jenkins / JENKINS-31425 should be able to specify multiple users or groups for the submitter of an input step Change By: Jesse Glick Status: Reopened Open Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31425) should be able to specify multiple users or groups for the submitter of an input step
Title: Message Title
Sam Gleske edited a comment on JENKINS-31425
Re: should be able to specify multiple users or groups for the submitter of an input step
{quote}Dependencies on specific authorization strategies will not be entertained.{quote}I'm not sure how you came to the conclusion that this request is dependent on a specific authorization strategy. Right now, only one Jenkins Group or one User is allowed for the input step. The actual request is one or more Jenkins Groups (agnostic to the strategy being used). Most authorization strategies (like the GitHub Authorization Strategy) surface their authorizations as Jenkins Groups.{quote}not the “multiple” part per se.{quote}The original purpose for this request is just the "'multiple' part".Also after reading JENKINS-27134, it I ' s d say it's not good for how my team works. We don't want "one person or group of people" to approve all parts of the pipeline. There's a whole approval process at my place of work (like Dev deployer, QA teams deploying, and an entire separate permission for production deployments). The current behavior is good enough.JENKINS-27134 is not a good proposal for how my teams work.
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31425) should be able to specify multiple users or groups for the submitter of an input step
Title: Message Title
Sam Gleske edited a comment on JENKINS-31425
Re: should be able to specify multiple users or groups for the submitter of an input step
{quote}Dependencies on specific authorization strategies will not be entertained.{quote}I'm not sure how you came to the conclusion that this request is dependent on a specific authorization strategy. Right now, only one Jenkins Group or one User is allowed for the input step. The actual request is one or more Jenkins Groups (agnostic to the strategy being used). Most authorization strategies (like the GitHub Authorization Strategy) surface their authorizations as Jenkins Groups.{quote}not the “multiple” part per se.{quote}The original purpose for this request is just the "'multiple' part". Also after reading JENKINS-27134, it's say it's not good for how my team works. We don't want "one person or group of people" to approve all parts of the pipeline. There's a whole approval process at my place of work (like Dev deployer, QA teams deploying, and an entire separate permission for production deployments). The current behavior is good enough.JENKINS-27134 is not a good proposal for how my teams work.
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31425) should be able to specify multiple users or groups for the submitter of an input step
Title: Message Title
Sam Gleske edited a comment on JENKINS-31425
Re: should be able to specify multiple users or groups for the submitter of an input step
{quote}Dependencies on specific authorization strategies will not be entertained.{quote}I'm not sure how you came to the conclusion that this request is dependent on a specific authorization strategy. Right now, only one Jenkins Group or one User is allowed for the input step. The actual request is one or more Jenkins Groups (agnostic to the strategy being used). Most authorization strategies (like the GitHub Authorization Strategy) surface their authorizations as Jenkins Groups. {quote}not the “multiple” part per se.{quote}The original purpose for this request is just the "'multiple' part".
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31425) should be able to specify multiple users or groups for the submitter of an input step
Title: Message Title Sam Gleske commented on JENKINS-31425 Re: should be able to specify multiple users or groups for the submitter of an input step Dependencies on specific authorization strategies will not be entertained. I'm not sure how you came to the conclusion that this request is dependent on a specific authorization strategy. Right now, only one Jenkins Group or one User is allowed for the input step. The actual request is one or more Jenkins Groups (agnostic to the strategy being used). Most authorization strategies (like the GitHub Authorization Strategy) surface their authorizations as Jenkins Groups. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31425) should be able to specify multiple users or groups for the submitter of an input step
Title: Message Title Jesse Glick commented on JENKINS-31425 Re: should be able to specify multiple users or groups for the submitter of an input step Anyway most of the discussion here is actually about JENKINS-27134, not the “multiple” part per se. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31425) should be able to specify multiple users or groups for the submitter of an input step
Title: Message Title Jesse Glick commented on JENKINS-31425 Re: should be able to specify multiple users or groups for the submitter of an input step Dependencies on specific authorization strategies will not be entertained. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31425) should be able to specify multiple users or groups for the submitter of an input step
Title: Message Title
UHP edited a comment on JENKINS-31425
Re: should be able to specify multiple users or groups for the submitter of an input step
Would it be possible for you as a first step to extend{quote}private boolean canSettle(Authentication a) {String submitter = input.getSubmitter();if (submitter==null || a.getName().equals(submitter)) {return true;}for (GrantedAuthority ga : a.getAuthorities()) {if (ga.getAuthority().equals(submitter)) {return true;}}return false;}{quote}by iterating over all roles of the submitting user for the _RoleBasedAuthorizationStrategy_ Plugin? If not it would help if we can get the approver back as a result so we can implement any strategy on our own (seems to be wished for 3 years already: http://stackoverflow.com/questions/39451358/how-to-know-which-user-answered-a-jenkins-pipeline-input-step#comment66251982_39465711)
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31425) should be able to specify multiple users or groups for the submitter of an input step
Title: Message Title
UHP edited a comment on JENKINS-31425
Re: should be able to specify multiple users or groups for the submitter of an input step
Would it be possible for you as a first step to extend{quote}private boolean canSettle(Authentication a) {String submitter = input.getSubmitter();if (submitter==null || a.getName().equals(submitter)) {return true;}for (GrantedAuthority ga : a.getAuthorities()) {if (ga.getAuthority().equals(submitter)) {return true;}}return false;}{quote}by iterating over all roles of the submitting user for the _RoleBasedAuthorizationStrategy_ Plugin?
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31425) should be able to specify multiple users or groups for the submitter of an input step
Title: Message Title
UHP commented on JENKINS-31425
Re: should be able to specify multiple users or groups for the submitter of an input step
Would it be possible for you as a first step to extend
private boolean canSettle(Authentication a) { String submitter = input.getSubmitter(); if (submitter==null || a.getName().equals(submitter))
Unknown macro: { return true; }
for (GrantedAuthority ga : a.getAuthorities()) { if (ga.getAuthority().equals(submitter))
Unknown macro: { return true; }
} return false; }
by iterating over all roles of submitting user for the RoleBasedAuthorizationStrategy Plugin?
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31425) should be able to specify multiple users or groups for the submitter of an input step
Title: Message Title Jesse Glick updated an issue Jenkins / JENKINS-31425 should be able to specify multiple users or groups for the submitter of an input step Change By: Jesse Glick Component/s: pipeline-input-step-plugin Component/s: pipeline Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
