[JIRA] (JENKINS-3265) Reload Configuration from Disk (or POSTing config.xml) loses info on running builds
Ville Nummela commented on JENKINS-3265 Reload Configuration from Disk (or POSTing config.xml) loses info on running builds Is this hotfix included in 1.507? I get that NullPointerException with 1.507 so either the fix is not there or it doesn't work. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-3265) Reload Configuration from Disk (or POSTing config.xml) loses info on running builds
Jesse Glick commented on JENKINS-3265 Reload Configuration from Disk (or POSTing config.xml) loses info on running builds @vige I am not sure what build gets the hotfix but I think not 1.507. This got filed as JENKINS-17337. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-3265) Reload Configuration from Disk (or POSTing config.xml) loses info on running builds
SCM/JIRA link daemon commented on JENKINS-3265 Reload Configuration from Disk (or POSTing config.xml) loses info on running builds Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/matrix/MatrixProject.java http://jenkins-ci.org/commit/jenkins/6b1f8d1aaa2179c99af33a8d60851abd032442ac Log: FIXED JENKINS-3265 Hotfix for regression in matrix project loading from 25084f5.(cherry picked from commit 3370e6edf5e0e7c7a8cf22e4a7a5decc24c45205) This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-3265) Reload Configuration from Disk (or POSTing config.xml) loses info on running builds
dogfood commented on JENKINS-3265 Reload Configuration from Disk (or POSTing config.xml) loses info on running builds Integrated in jenkins_main_trunk #2411 FIXED JENKINS-3265 Hotfix for regression in matrix project loading from 25084f5.(cherry picked from commit 3370e6edf5e0e7c7a8cf22e4a7a5decc24c45205) (Revision 6b1f8d1aaa2179c99af33a8d60851abd032442ac) Result = SUCCESS kohsuke : 6b1f8d1aaa2179c99af33a8d60851abd032442ac Files : core/src/main/java/hudson/matrix/MatrixProject.java This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-3265) Reload Configuration from Disk (or POSTing config.xml) loses info on running builds
Jesse Glick reopened JENKINS-3265 Reload Configuration from Disk (or POSTing config.xml) loses info on running builds This change broke loading (not reloading!) of matrix projects: java.lang.NullPointerException at hudson.matrix.MatrixProject.getItem(MatrixProject.java:669) at hudson.matrix.MatrixProject.getItem(MatrixProject.java:662) at hudson.matrix.MatrixProject.getItem(MatrixProject.java:98) at hudson.model.AbstractProject.onLoad(AbstractProject.java:291) at hudson.model.Project.onLoad(Project.java:83) at hudson.matrix.MatrixConfiguration.onLoad(MatrixConfiguration.java:89) at hudson.matrix.MatrixProject.loadConfigurations(MatrixProject.java:541) at hudson.matrix.MatrixProject.rebuildConfigurations(MatrixProject.java:585) at hudson.matrix.MatrixProject.onLoad(MatrixProject.java:476) at hudson.model.Items.load(Items.java:221) at jenkins.model.Jenkins$17.run(Jenkins.java:2552) Change By: Jesse Glick (19/Mar/13 10:30 PM) Resolution: Fixed Status: Resolved Reopened This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-3265) Reload Configuration from Disk (or POSTing config.xml) loses info on running builds
SCM/JIRA link daemon commented on JENKINS-3265 Reload Configuration from Disk (or POSTing config.xml) loses info on running builds Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/matrix/MatrixProject.java http://jenkins-ci.org/commit/jenkins/3370e6edf5e0e7c7a8cf22e4a7a5decc24c45205 Log: FIXED JENKINS-3265 Hotfix for regression in matrix project loading from 25084f5. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-3265) Reload Configuration from Disk (or POSTing config.xml) loses info on running builds
SCM/JIRA link daemon resolved JENKINS-3265 as Fixed Reload Configuration from Disk (or POSTing config.xml) loses info on running builds Change By: SCM/JIRA link daemon (19/Mar/13 10:40 PM) Status: Reopened Resolved Resolution: Fixed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-3265) Reload Configuration from Disk (or POSTing config.xml) loses info on running builds
dogfood commented on JENKINS-3265 Reload Configuration from Disk (or POSTing config.xml) loses info on running builds Integrated in jenkins_main_trunk #2389 FIXED JENKINS-3265 Hotfix for regression in matrix project loading from 25084f5. (Revision 3370e6edf5e0e7c7a8cf22e4a7a5decc24c45205) Result = SUCCESS Jesse Glick : 3370e6edf5e0e7c7a8cf22e4a7a5decc24c45205 Files : core/src/main/java/hudson/matrix/MatrixProject.java This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-3265) Reload Configuration from Disk (or POSTing config.xml) loses info on running builds
SCM/JIRA link daemon commented on JENKINS-3265 Reload Configuration from Disk (or POSTing config.xml) loses info on running builds Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/model/AbstractProject.java core/src/main/java/jenkins/model/Jenkins.java http://jenkins-ci.org/commit/jenkins/25084f528208a5ab8e0f1ebd9ae80527bf0099d1 Log: FIXED JENKINS-3265 Made the in-flight build survive the reload from the disk. You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-3265) Reload Configuration from Disk (or POSTing config.xml) loses info on running builds
SCM/JIRA link daemon resolved JENKINS-3265 as Fixed Reload Configuration from Disk (or POSTing config.xml) loses info on running builds Change By: SCM/JIRA link daemon (14/Mar/13 5:10 PM) Status: Reopened Resolved Resolution: Fixed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-3265) Reload Configuration from Disk (or POSTing config.xml) loses info on running builds
dogfood commented on JENKINS-3265 Reload Configuration from Disk (or POSTing config.xml) loses info on running builds Integrated in jenkins_main_trunk #2372 FIXED JENKINS-3265 (Revision 25084f528208a5ab8e0f1ebd9ae80527bf0099d1) Result = SUCCESS kohsuke : 25084f528208a5ab8e0f1ebd9ae80527bf0099d1 Files : core/src/main/java/jenkins/model/Jenkins.java changelog.html core/src/main/java/hudson/model/AbstractProject.java This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-3265) Reload Configuration from Disk (or POSTing config.xml) loses info on running builds
Patrick Byrne commented on JENKINS-3265 Reload Configuration from Disk (or POSTing config.xml) loses info on running builds Seeing this in 1.492 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-3265) Reload Configuration from Disk (or POSTing config.xml) loses info on running builds
Kevin Scaldeferri reopened JENKINS-3265 Reload Configuration from Disk (or POSTing config.xml) loses info on running builds The bug still manifests as described in the initial report, and in my previous message. Change By: Kevin Scaldeferri (29/Jan/13 6:06 PM) Resolution: Fixed Status: Resolved Reopened This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-3265) Reload Configuration from Disk (or POSTing config.xml) loses info on running builds
Kevin Scaldeferri commented on JENKINS-3265 Reload Configuration from Disk (or POSTing config.xml) loses info on running builds We are running 1.479 and I still see this bug. I'd like to suggest that it should be reopened. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group, send email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-3265) Reload Configuration from Disk (or POSTing config.xml) loses info on running builds
Jesse Glick commented on JENKINS-3265 Reload Configuration from Disk (or POSTing config.xml) loses info on running builds @kscaldef best to have a fully reproducible test case, ideally based on a trunk version. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-3265) Reload Configuration from Disk (or POSTing config.xml) loses info on running builds
Kevin Scaldeferri commented on JENKINS-3265 Reload Configuration from Disk (or POSTing config.xml) loses info on running builds Jesse, I'm a little unclear what constitutes a "fully reproducible test case" in this situation. The description of this bug seems pretty well detailed and matches exactly what I see on our installation. To summarize: while builds are running, click the "Reload configuration from disk" link, the existing builds continue to show as in progress on the front page, but are gone from the project page, and the links to the builds from the front page are broken (404). If I log into the machine, all the builds appear to be present, but those that were running when I reloaded the config aren't available from the UI. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] (JENKINS-3265) Reload Configuration from Disk (or POSTing config.xml) loses info on running builds
Kohsuke Kawaguchi resolved JENKINS-3265 as Fixed Reload Configuration from Disk (or POSTing config.xml) loses info on running builds This problem was fixed in 1.473 under JENKINS-12318. Change By: Kohsuke Kawaguchi (10/Oct/12 12:07 AM) Status: Open Resolved Resolution: Fixed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-3265) Reload Configuration from Disk (or POSTing config.xml) loses info on running builds
Martin dAnjou commented on JENKINS-3265 Reload Configuration from Disk (or POSTing config.xml) loses info on running builds At the very least, do not let the administrator reload the configuration from disk without a warning saying that in-flight jobs will be lost. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-3265) Reload Configuration from Disk (or POSTing config.xml) loses info on running builds
Jeremy Frank commented on JENKINS-3265 Reload Configuration from Disk (or POSTing config.xml) loses info on running builds Any application can halt without warning, due to power out, hardware defect, OS bugs, malicious software, you-name-it, even well-intentioned code in the application itself. Therefore important state information must be persisted upon every change. Anything else risks losing that data. So by this logic, I agree that saving the state of running builds is "eminently reasonable" as you say. You have my vote . This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-3265) Reload Configuration from Disk (or POSTing config.xml) loses info on running builds
Matt Mitchell commented on JENKINS-3265 Reload Configuration from Disk (or POSTing config.xml) loses info on running builds Change is here: https://github.com/antifun/jenkins/commit/2793ce3721de8c6a1e9d7912b92e437d6e827b2e This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-3265) Reload Configuration from Disk (or POSTing config.xml) loses info on running builds
Matt Mitchell commented on JENKINS-3265 Reload Configuration from Disk (or POSTing config.xml) loses info on running builds I did some investigation into this, and here's what's going on: The Reload Configuration operation from the UI attempts to load up all the jobs and runs it can find. It loads runs from disk based on the presence of a build.xml in the directory for a particular build number (cf. RunMap.load()). Runs that are in progress do not have a build.xml written to the directory in the course of normal operations (problem #1). Attempt 1: write a piece of code that, at the start of the reload operation (Jenkins.reload()), looks at all running Executors and forces them to marshal their state to disk (creating a build.xml). This would then allow Jenkins to notice those jobs running when it restarts. Then I discovered that the unmarshal procedure for build.xml - Run assumes that any build.xml it sees is for a run that is in State.COMPLETED. The State is not itself persisted as there's no getState() for xstream to call. Attempt 2: Make the State of a run persist appropriately so that it can be recovered when Jenkins reloads the configuration. This seems to work OK at least in limited tests, and I intend to put up a pull request to let people see the changes I'm proposing in the code. I do wonder, though, what the justification for doing it this way in the first place was; it seems likely that you would not in all cases want Jenkins to totally "trust" the state on disk when starting up, for example if there were a large time or configuration delta between the stop and start. I do, however, think that the specific case of mashing the "Reload Configuration" link should be able to assume that what was running before is still running. Things that could possibly go wrong now would mostly be in the arena of jobs that Jenkins now thinks are running but actually aren't anymore. In a reload case, you can probably expect that to happen minimally (if at all). Another idea I had was based on the fact that the executors clearly are reporting back the fact that they are running a particular job, even if Jenkins doesn't believe that run actually exists due to this bug. It might be possible/better to, instead of persisting everything to disk on the Jenkins master side, have it query the slaves for running jobs when it comes back up and use the information it gets from them to reconstruct its own idea of what is currently running. I don't know how people feel about potential for abuse there, given that it would require the master to "trust" the slaves to tell it what they were working on when it restarted. A combination of the two approaches might be best (trust, but verify). This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-3265) Reload Configuration from Disk (or POSTing config.xml) loses info on running builds
[ https://issues.jenkins-ci.org/browse/JENKINS-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=162673#comment-162673 ] Kalle Mäkelä commented on JENKINS-3265: --- We were facing this problem when after Reload we wanted to trigger another jobs. I configured the Reload Job to be run as shell script like this and this seems to work: curl http://localhost:80/reload sleep 25 curl http://localhost:80/job/$Job_name/build?delay=0sec Reload Configuration from Disk (or POSTing config.xml) loses info on running builds --- Key: JENKINS-3265 URL: https://issues.jenkins-ci.org/browse/JENKINS-3265 Project: Jenkins Issue Type: Bug Components: core Affects Versions: current Environment: Platform: PC, OS: Windows XP Reporter: pcampbell Assignee: Kohsuke Kawaguchi Executing the Reload Configuration from Disk while builds are running causes information about those builds to be lost. POSTing a new configuration to /job/JOBNAME/config.xml also causes the exact same problem. Yet editing job configuration interactively using the web form does not show the problem. I had two builds running when I reloaded configuration to pick up manual changes to one project (not running a build) config.xml file. When the browser refreshed, the builds were still shown as actively building in the Build Executor Status frame but the status indicators were no longer blinking and the project pages did not show any builds running for those projects. It appears that part of Hudson thought that the builds had been canceled because they were queued, blocked by themselves. The original builds appeared to finsish normally and then the queued builds ran. There was no record of the original build that had been running when the config reloaded. Note: If Jenkins is completely restarted, by shutting down and starting up the service, the missing build re-appears. (Of course, doing that each time is unacceptable, just trying to help focus the debugging.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
