[JIRA] (JENKINS-34637) pipeline DSL: timeout() does not work if withEnv() is enclosed
Title: Message Title SCM/JIRA link daemon commented on JENKINS-34637 Re: pipeline DSL: timeout() does not work if withEnv() is enclosed Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepExecution.java src/test/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepRunTest.java http://jenkins-ci.org/commit/workflow-basic-steps-plugin/5d2b2327b7ae5daec98bf747520c2960c8685f0c Log: Merge pull request #24 from jglick/timeout-block-JENKINS-34637 JENKINS-34637 Test for timeout bug Compare: https://github.com/jenkinsci/workflow-basic-steps-plugin/compare/f541cd2cda5f...5d2b2327b7ae Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-34637) pipeline DSL: timeout() does not work if withEnv() is enclosed
Title: Message Title SCM/JIRA link daemon commented on JENKINS-34637 Re: pipeline DSL: timeout() does not work if withEnv() is enclosed Code changed in jenkins User: Jesse Glick Path: pom.xml src/test/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepRunTest.java http://jenkins-ci.org/commit/workflow-basic-steps-plugin/ae8b586e824294f687ebdf40cadddff599c597bc Log: JENKINS-34637 Verifying behavior of timeout step around other block-scoped steps. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-34637) pipeline DSL: timeout() does not work if withEnv() is enclosed
Title: Message Title SCM/JIRA link daemon commented on JENKINS-34637 Re: pipeline DSL: timeout() does not work if withEnv() is enclosed Code changed in jenkins User: Christopher Orr Path: src/test/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepRunTest.java http://jenkins-ci.org/commit/workflow-basic-steps-plugin/55488ff554d7edfd966b73ee11b35c4ab2d8811b Log: Add test case to reproduce JENKINS-34637. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-34637) pipeline DSL: timeout() does not work if withEnv() is enclosed
Title: Message Title Jesse Glick updated JENKINS-34637 Jenkins / JENKINS-34637 pipeline DSL: timeout() does not work if withEnv() is enclosed Change By: Jesse Glick Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-34637) pipeline DSL: timeout() does not work if withEnv() is enclosed
Title: Message Title SCM/JIRA link daemon commented on JENKINS-34637 Re: pipeline DSL: timeout() does not work if withEnv() is enclosed Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/CpsBodyExecution.java src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinition.java src/main/java/org/jenkinsci/plugins/workflow/cps/CpsStepContext.java src/main/java/org/jenkinsci/plugins/workflow/cps/CpsThread.java src/main/java/org/jenkinsci/plugins/workflow/cps/steps/ParallelStep.java src/test/java/org/jenkinsci/plugins/workflow/cps/CpsBodyExecutionTest.java src/test/java/org/jenkinsci/plugins/workflow/cps/CpsThreadDumpTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/bee2879e1e133bc05d3f127b7221a08529fdcb1e Log: Merge pull request #76 from jglick/timeout-block-JENKINS-34637 JENKINS-34637 Failure to kill bodies from timeout Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/b5c8ca8c7118...bee2879e1e13 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-34637) pipeline DSL: timeout() does not work if withEnv() is enclosed
Title: Message Title SCM/JIRA link daemon commented on JENKINS-34637 Re: pipeline DSL: timeout() does not work if withEnv() is enclosed Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/CpsBodyExecution.java src/main/java/org/jenkinsci/plugins/workflow/cps/CpsStepContext.java src/test/java/org/jenkinsci/plugins/workflow/cps/CpsBodyExecutionTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/6933a4925a47b07206eaf059484b37c069aebe62 Log: [FIXED JENKINS-34637] CpsBodyExecution.cancel was failing to interrupt the innermost execution, and block-scoped StepExecution.stop does not generally kill its body (JENKINS-26148). getCurrentExecutions was also in direct violation of its Javadoc, though it does not appear to have ever been called, much less tested. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-34637) pipeline DSL: timeout() does not work if withEnv() is enclosed
Title: Message Title Jesse Glick commented on JENKINS-34637 Re: pipeline DSL: timeout() does not work if withEnv() is enclosed That is an unrelated issue: JENKINS-38380 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-34637) pipeline DSL: timeout() does not work if withEnv() is enclosed
Title: Message Title
Steve Prentice commented on JENKINS-34637
Re: pipeline DSL: timeout() does not work if withEnv() is enclosed
Not sure if this is a different issue or another manifestation of the issue with CpsBodyExecution, but passing a submitter into input is enough to trigger this issue with timeout for me.
timeout(time: 3, unit: 'SECONDS') {
// input will hang forever.
input submitter: 'user'
}
timeout(time: 3, unit: 'SECONDS') {
// will timeout as expected
input()
}
If this is a different issue, let me know and I'll submit a new issue.
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-34637) pipeline DSL: timeout() does not work if withEnv() is enclosed
Title: Message Title Jesse Glick updated JENKINS-34637 Jenkins / JENKINS-34637 pipeline DSL: timeout() does not work if withEnv() is enclosed Change By: Jesse Glick Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-34637) pipeline DSL: timeout() does not work if withEnv() is enclosed
Title: Message Title Jesse Glick commented on JENKINS-34637 Re: pipeline DSL: timeout() does not work if withEnv() is enclosed Yes the bug is not in timeout or withEnv, it is more general. I am working on it. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-34637) pipeline DSL: timeout() does not work if withEnv() is enclosed
Title: Message Title
Domingo K edited a comment on JENKINS-34637
Re: pipeline DSL: timeout() does not work if withEnv() is enclosed
[~jglick] - Would this only affect `withEnv` code paths or have other consequences?I'm seeing a similar issue Confirmed with code below where the timeout is never being triggered for another example without "withEnv" . I am debating opening a different issue, just don't have enough data yet. {code:java}def disableClusterRoutingAllocation(node){timeout(time: 10, unit: "SECONDS"){waitUntil{try {sh "curl -XPUT -sS http://$node/_cluster/settings -d '{ \"transient\" : { \"cluster.routing.allocation.enable\" : \"none\" } }' | grep \"acknowledged\":true"return true} catch(exception){return false}}}}{code}
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-34637) pipeline DSL: timeout() does not work if withEnv() is enclosed
Title: Message Title
Domingo K commented on JENKINS-34637
Re: pipeline DSL: timeout() does not work if withEnv() is enclosed
Jesse Glick - Would this only affect `withEnv` code paths or have other consequences? I'm seeing a similar issue with code below where the timeout is never being triggered. I am debating opening a different issue, just don't have enough data yet.
def disableClusterRoutingAllocation(node){
timeout(time: 10, unit: "SECONDS"){
waitUntil{
try {
sh "curl -XPUT -sS http://$node/_cluster/settings -d '{ \"transient\" : { \"cluster.routing.allocation.enable\" : \"none\" } }' | grep \"acknowledged\":true"
return true
} catch(exception){
return false
}
}
}
}
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-34637) pipeline DSL: timeout() does not work if withEnv() is enclosed
Title: Message Title Jesse Glick commented on JENKINS-34637 Re: pipeline DSL: timeout() does not work if withEnv() is enclosed Indeed the problem is in CpsBodyExecution, not timeout. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-34637) pipeline DSL: timeout() does not work if withEnv() is enclosed
Title: Message Title Jesse Glick updated an issue Jenkins / JENKINS-34637 pipeline DSL: timeout() does not work if withEnv() is enclosed Change By: Jesse Glick Component/s: workflow-cps-plugin Priority: Major Critical Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-34637) pipeline DSL: timeout() does not work if withEnv() is enclosed
Title: Message Title Jesse Glick started work on JENKINS-34637 Change By: Jesse Glick Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-34637) pipeline DSL: timeout() does not work if withEnv() is enclosed
Title: Message Title Jesse Glick commented on JENKINS-34637 Re: pipeline DSL: timeout() does not work if withEnv() is enclosed I suspect this is rather a bug in workflow-cps-plugin, specifically CpsBodyExecution.cancel. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-34637) pipeline DSL: timeout() does not work if withEnv() is enclosed
Title: Message Title Antonio Muñiz updated an issue Jenkins / JENKINS-34637 pipeline DSL: timeout() does not work if withEnv() is enclosed Change By: Antonio Muñiz Priority: Minor Major Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-34637) pipeline DSL: timeout() does not work if withEnv() is enclosed
Title: Message Title Antonio Muñiz commented on JENKINS-34637 Re: pipeline DSL: timeout() does not work if withEnv() is enclosed This looks pretty severe to me as anything "durable" inside a timeout will fail to be cancelled, right? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-34637) pipeline DSL: timeout() does not work if withEnv() is enclosed
Title: Message Title Jesse Glick updated an issue Jenkins / JENKINS-34637 pipeline DSL: timeout() does not work if withEnv() is enclosed Change By: Jesse Glick Component/s: workflow-basic-steps-plugin Component/s: workflow-durable-task-step-plugin Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-34637) pipeline DSL: timeout() does not work if withEnv() is enclosed
Title: Message Title
Christopher Orr commented on JENKINS-34637
Re: pipeline DSL: timeout() does not work if withEnv() is enclosed
I think this belongs rather to the workflow-basic-steps-plugin component. I am seeing the same problem with withEnv, in which I have a long-running sh './gradlew ...', but I can also reproduce it with other blocks such as stage.
timeout(time: 5, unit: 'SECONDS') {
stage('weird') {
sleep 7
echo 'Huh, build should have timed out'
}
}
Results in a successful build:
[Pipeline] timeout
[Pipeline] {
[Pipeline] stage
[Pipeline] { (weird)
[Pipeline] sleep
Sleeping for 7 sec
[Pipeline] echo
Huh, build should have timed out
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timeout
[Pipeline] End of Pipeline
Finished: SUCCESS
Jenkins 2.23 Pipeline: Basic Steps 2.1
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving
[JIRA] (JENKINS-34637) pipeline DSL: timeout() does not work if withEnv() is enclosed
Title: Message Title Jesse Glick updated an issue Jenkins / JENKINS-34637 pipeline DSL: timeout() does not work if withEnv() is enclosed Change By: Jesse Glick Component/s: workflow-durable-task-step-plugin Component/s: pipeline Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
