[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title Thorsten Scherler commented on JENKINS-36171 Re: Steps with no logs should not be expandable Michael Neale yeah as @vivek stated we would need to actually fetch the log (at least the header) and see whether length is >0 and then could decide about the caret, however that is IMO way too much effort for the one/two steps that COULD provide a log but do not use that. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title Thorsten Scherler updated JENKINS-36171 Jenkins / JENKINS-36171 Steps with no logs should not be expandable Change By: Thorsten Scherler Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title SCM/JIRA link daemon commented on JENKINS-36171 Re: Steps with no logs should not be expandable Code changed in jenkins User: Thorsten Scherler Path: src/test/js/log-karaoke/noStages.js src/test/resources/test_scripts/no-stages.groovy http://jenkins-ci.org/commit/blueocean-acceptance-test/ca4cd5454f2d24a0f1af1e99ed5c8d390363f31c Log: Jenkins 36171 Steps with no logs should not be expandable (#24) Debug logging of SSE events More on logging (client and server side) Better SSE connection disconnect cleanup Update to latest SSE gateway client api Use a relative path to logging.properties file Remove misleading seleium docs in readme (#11) [master] Fix last test by turning on cssPath again before finishing last test [master] try to fix freestyle error validation on server [master] comment the flaky test until I come up with something better. stop karaoke is covered in other tests as well [master] Add more comments to code [master] Change test to test positive. stop karaoke via keyUp is tested in noStage JENKINS-36171 implement test to see that steps that do not have logs neither are expandable
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title Michael Neale commented on JENKINS-36171 Re: Steps with no logs should not be expandable Right, if we don't know up front it has no log, I don't think we can do anything "nicely", and we just live with it. There are common steps that don't have a log and we know that up front, and the change set for this addresses that, which is enough for me. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title Vivek Pandey commented on JENKINS-36171 Re: Steps with no logs should not be expandable James Dumay We get it from core, looking at the code it does File.length(), not sure how performant it is underneath. Keeping performance thing aside, that is even if for each step we give log file length size, it will only work for complete steps. for steps in progress or not yet run the log file length could be zero in that snapshot but later might or might not produce any log. so how do you intend to handle that case? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title James Dumay commented on JENKINS-36171 Re: Steps with no logs should not be expandable Can we make stats on those files cheap? Whats the penalty? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title Vivek Pandey commented on JENKINS-36171 Re: Steps with no logs should not be expandable Michael Neale You are right, some steps are never going to have logs, its already fixed in API. Maybe I misunderstood your comment about 0 length bug that what needs to be fixed. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title Michael Neale edited a comment on JENKINS-36171 Re: Steps with no logs should not be expandable [~vivek] may be my incorrect assumption: I was assuming that some step types were ALWAYS known to not have a log, if this is a not the case, ignore my comment . Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title Michael Neale commented on JENKINS-36171 Re: Steps with no logs should not be expandable Vivek Pandey may be my incorrect assumption: I was assuming that some step types were ALWAYS known to not have a log, if this is a case, ignore. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title Vivek Pandey commented on JENKINS-36171 Re: Steps with no logs should not be expandable Michael Neale you mean this fix in steps API? that is steps API reflects there is 0 length log for completed steps? It won't solve visualization problem as there might be steps that are not run yet or are in progress, there is no right way to reflect the log size or you can't really depend on it to show the steps correctly, unless UI keeps fetching all the steps which is expensive. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title Michael Neale commented on JENKINS-36171 Re: Steps with no logs should not be expandable OK, given that the "common" case is taken care of, I think we can close this off, open a new ticket for the edge case of 0 length logs and move on (it really doesn't trouble me for now, unless it turns out to be common, in which case really we should fix it at the source anyway). Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title Vivek Pandey commented on JENKINS-36171 Re: Steps with no logs should not be expandable Michael Neale yes, thats what JENKINS-36170 does. Otherwise its hard to say if there is associated log or not without checking the log file for that step. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title Michael Neale edited a comment on JENKINS-36171 Re: Steps with no logs should not be expandable [~tscherler] right - if a step is finished and there is X-Text-Size of 0 - can make it unexpandable? Is this only in some cases? If it is "edge" cases then this isn't super high priority, but it would make sense if it has finished running, and there is 0 size, to make it unexpandable if this doesn't mess things up too much ... ([~vivek] are there some cases where we know up front, even before finished, there will never be a log?) Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title Michael Neale commented on JENKINS-36171 Re: Steps with no logs should not be expandable Thorsten Scherler right - if a step is finished and there is X-Text-Size of 0 - can make it unexpandable? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title Vivek Pandey commented on JENKINS-36171 Re: Steps with no logs should not be expandable Thorsten Scherler James Dumay As part of /steps API computation of whether a step has actual log or not can be expensive - might results in to touching file system. API can return length of the log file in that instance (remember the step might not still be running or might be in RUNNING state but might not logged anything yet. So you have that condition as well. Wonder if you could disable expanding if X-Text-Size header size is 0? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title Thorsten Scherler updated JENKINS-36171 Jenkins / JENKINS-36171 Steps with no logs should not be expandable Change By: Thorsten Scherler Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title Thorsten Scherler commented on JENKINS-36171 Re: Steps with no logs should not be expandable https://ci.blueocean.io/blue/rest/organizations/jenkins/pipelines/jenkins-design-language/branches/master/runs/109/nodes/5/steps/ shows that e.g. step id 8 has the capability to show logs but there is a small problem: https://ci.blueocean.io/blue/rest/organizations/jenkins/pipelines/jenkins-design-language/branches/master/runs/109/nodes/5/steps//8/log/ returns an empty log. What should we do in that case? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title Thorsten Scherler started work on JENKINS-36171 Change By: Thorsten Scherler Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title James Dumay assigned an issue to Thorsten Scherler Jenkins / JENKINS-36171 Steps with no logs should not be expandable Change By: James Dumay Assignee: Thorsten Scherler Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-36171 Steps with no logs should not be expandable Change By: James Dumay Priority: Major Critical Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title James Dumay assigned an issue to Unassigned Jenkins / JENKINS-36171 Steps with no logs should not be expandable Change By: James Dumay Assignee: Thorsten Scherler Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-36171 Steps with no logs should not be expandable Change By: James Dumay Sprint: 1.0- m14 m13 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-36171 Steps with no logs should not be expandable Change By: James Dumay Sprint: 1.0- m13 m14 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-36171 Steps with no logs should not be expandable Change By: James Dumay Sprint: 1.0- m12 m13 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-36171 Steps with no logs should not be expandable Change By: James Dumay Sprint: 1.0-m12 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-36171 Steps with no logs should not be expandable Change By: James Dumay Priority: Minor Major Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-36171 Steps with no logs should not be expandable Change By: James Dumay Sprint: 1.0-m12 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-36171 Steps with no logs should not be expandable Change By: James Dumay Sprint: 1.0- m11 m12 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title James Dumay assigned an issue to Thorsten Scherler Jenkins / JENKINS-36171 Steps with no logs should not be expandable Change By: James Dumay Assignee: James Dumay Thorsten Scherler Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-36171 Steps with no logs should not be expandable Change By: James Dumay Sprint: 1.0-m11 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title Michael Neale commented on JENKINS-36171 Re: Steps with no logs should not be expandable We don't know yet if they have logs via the api until fetched... Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36171) Steps with no logs should not be expandable
Title: Message Title James Dumay created an issue Jenkins / JENKINS-36171 Steps with no logs should not be expandable Issue Type: Bug Assignee: James Dumay Attachments: Jenkins Blue Ocean 2016-06-23 16-59-50.png, React Storybook 2016-06-23 17-00-40.png Components: blueocean-plugin Created: 2016/Jun/23 7:03 AM Priority: Minor Reporter: James Dumay Some steps do not come with logs Example It would be good if we had a similar style for any log that was not expandable. Steps that were not run in storybook have a style that could be reused. In the case of steps with no logs we should hide the expander icon. Add Comment
