[JIRA] (JENKINS-37880) Starting, stopping and replaying a run in quick succession does not work
Title: Message Title James Dumay resolved as Duplicate Jenkins / JENKINS-37880 Starting, stopping and replaying a run in quick succession does not work Change By: James Dumay Status: Reopened Resolved Resolution: Duplicate Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37880) Starting, stopping and replaying a run in quick succession does not work
Title: Message Title James Dumay reopened an issue Jenkins / JENKINS-37880 Starting, stopping and replaying a run in quick succession does not work Change By: James Dumay Resolution: Won't Do Status: Resolved Reopened Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37880) Starting, stopping and replaying a run in quick succession does not work
Title: Message Title James Dumay resolved as Won't Do Jenkins / JENKINS-37880 Starting, stopping and replaying a run in quick succession does not work Change By: James Dumay Status: Open Resolved Resolution: Won't Do Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37880) Starting, stopping and replaying a run in quick succession does not work
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-37880 Starting, stopping and replaying a run in quick succession does not work Change By: James Dumay Sprint: atlantic Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37880) Starting, stopping and replaying a run in quick succession does not work
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-37880 Starting, stopping and replaying a run in quick succession does not work Change By: James Dumay Sprint: 1.0- b07/b08 beta-5 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37880) Starting, stopping and replaying a run in quick succession does not work
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-37880 Starting, stopping and replaying a run in quick succession does not work Change By: James Dumay Sprint: 1.0-b07/b08 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37880) Starting, stopping and replaying a run in quick succession does not work
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-37880 Starting, stopping and replaying a run in quick succession does not work Change By: James Dumay Sprint: 1.0-b05/b-06 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37880) Starting, stopping and replaying a run in quick succession does not work
Title: Message Title James Dumay commented on JENKINS-37880 Re: Starting, stopping and replaying a run in quick succession does not work Vivek Pandey yes, all of these cases received a 500. Ivan Meredith / Vivek Pandey it would be nice we could sidestep this stuff for replay. Take the commit Ids from the run that is being replayed, ask Jenkins to build those, etc (allowing it to read the Jenkinsfile again instead of using the previous pipeline state). Probably easier said than done? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37880) Starting, stopping and replaying a run in quick succession does not work
Title: Message Title Vivek Pandey edited a comment on JENKINS-37880 Re: Starting, stopping and replaying a run in quick succession does not work [~jamesdumay] In this case 500 is correct error, no? Its un-replayble - what do you mean, is it 500 error every time you click replay or something else? Might be worth checking with [~imeredith], think he wrote replay functionality in pipeline plugin. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37880) Starting, stopping and replaying a run in quick succession does not work
Title: Message Title Vivek Pandey commented on JENKINS-37880 Re: Starting, stopping and replaying a run in quick succession does not work James Dumay In this case 500 is correct error, no? Its un-replayble - what do you mean, is it 500 error every time you click replay or something else? Might be worth checking with Ivan Meredith, think he wrote replay functionality in pipeline plugin. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37880) Starting, stopping and replaying a run in quick succession does not work
Title: Message Title James Dumay commented on JENKINS-37880 Re: Starting, stopping and replaying a run in quick succession does not work Michael Neale replay seems to only work if the flow graph was persisted correctly to disk. If it is not there (in the case of there being no flow nodes in the last example) then it fails. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37880) Starting, stopping and replaying a run in quick succession does not work
Title: Message Title Michael Neale commented on JENKINS-37880 Re: Starting, stopping and replaying a run in quick succession does not work So perhaps not trivial? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37880) Starting, stopping and replaying a run in quick succession does not work
Title: Message Title James Dumay commented on JENKINS-37880 Re: Starting, stopping and replaying a run in quick succession does not work Vivek Pandey Michael Neale I found another case where replay doesn't work (500 is received). I believe this run had a problem connecting to Github and is now un-replayable. Started by user James Dumay Connecting to https://api.github.com using i386/** > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from 2 remote Git repositories > git config remote.origin.url https://github.com/i386/app-store-demo.git # timeout=10 Fetching upstream changes from https://github.com/i386/app-store-demo.git > git --version # timeout=10 using .gitcredentials to set credentials > git config --local credential.username i386 # timeout=10 > git config --local credential.helper store --file=/var/folders/11/5vmtkd9j6kd3w6sbrsrw0sh8gn/T/git561487727535648502.credentials # timeout=10 > git -c core.askpass=true fetch --tags --progress https://github.com/i386/app-store-demo.git +refs/heads/*:refs/remotes/origin/* > git config --local --remove-section credential # timeout=10 ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from https://github.com/i386/app-store-demo.git at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:799) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1055) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1086) at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:109) at org.jenkinsci.plugins.workflow.cps.CpsScmFlowDefinition.create(CpsScmFlowDefinition.java:108) at org.jenkinsci.plugins.workflow.multibranch.SCMBinder.create(SCMBinder.java:85) at org.jenkinsci.plugins.workflow.job.WorkflowRun.run(WorkflowRun.java:207) at hudson.model.ResourceController.execute(ResourceController.java:98) at hudson.model.Executor.run(Executor.java:404) Caused by: hudson.plugins.git.GitException: Command "git -c core.askpass=true fetch --tags --progress https://github.com/i386/app-store-demo.git +refs/heads/*:refs/remotes/origin/*" returned status code 128: stdout: stderr: fatal: unable to access 'https://github.com/i386/app-store-demo.git/': Couldn't connect to server at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1740) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1476) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:63) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:314) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:797) ... 8 more GitHub has been notified of this commit’s build result ERROR: null Finished: FAILURE
[JIRA] (JENKINS-37880) Starting, stopping and replaying a run in quick succession does not work
Title: Message Title James Dumay commented on JENKINS-37880 Re: Starting, stopping and replaying a run in quick succession does not work Vivek Pandey cool - this can wait until another sprint to pick up. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37880) Starting, stopping and replaying a run in quick succession does not work
Title: Message Title Vivek Pandey commented on JENKINS-37880 Re: Starting, stopping and replaying a run in quick succession does not work Right, this needs to be fixed in underlying pipeline plugin, once it's thrown as exception then BO API can send that error back to UI. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37880) Starting, stopping and replaying a run in quick succession does not work
Title: Message Title James Dumay commented on JENKINS-37880 Re: Starting, stopping and replaying a run in quick succession does not work Vivek Pandey I think bubbling more info up to the client here would be the right way to go. Then we can follow up with a UI story to display the error to the user. WDYT? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37880) Starting, stopping and replaying a run in quick succession does not work
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-37880 Starting, stopping and replaying a run in quick succession does not work Change By: James Dumay Priority: Minor Trivial Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37880) Starting, stopping and replaying a run in quick succession does not work
Title: Message Title
Vivek Pandey edited a comment on JENKINS-37880
Re: Starting, stopping and replaying a run in quick succession does not work
[~jamesdumay] It looks legit failure. In debugger I see it its logging with FINE level "java.util.concurrent.ExecutionException: org.jenkinsci.plugins.github_branch_source.RateLimitExceededException: GitHub API rate limit exceeded" and eats away the exception . Perhaps it should be logged as error and maybe thrown as exception so that callers know what went wrong instead of getting null execution instance.{code:java}@Override public FlowExecution getOrNull() {try {ListenableFuture promise = run().getExecutionPromise();if (promise.isDone()) {return promise.get();}} catch (Exception x) {LOGGER.log(/* not important */Level.FINE, null, x); //Vivek: This is where its print what went wrong}{code}
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37880) Starting, stopping and replaying a run in quick succession does not work
Title: Message Title
Vivek Pandey commented on JENKINS-37880
Re: Starting, stopping and replaying a run in quick succession does not work
James Dumay It looks legit failure. In debugger I see it logging with FINE level "java.util.concurrent.ExecutionException: org.jenkinsci.plugins.github_branch_source.RateLimitExceededException: GitHub API rate limit exceeded". Perhaps it should be logged as error and maybe thrown as exception so that callers know what went wrong instead of getting null execution instance.
@Override public FlowExecution getOrNull() {
try {
ListenableFuture promise = run().getExecutionPromise();
if (promise.isDone()) {
return promise.get();
}
} catch (Exception x) {
LOGGER.log(/* not important */Level.FINE, null, x); //Vivek: This is where its print what went wrong
}
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37880) Starting, stopping and replaying a run in quick succession does not work
Title: Message Title Vivek Pandey commented on JENKINS-37880 Re: Starting, stopping and replaying a run in quick succession does not work James Dumay that code looks alright, instanceof is false if the value being checked is null. I need to look in to it whats causing this failure. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37880) Starting, stopping and replaying a run in quick succession does not work
Title: Message Title
James Dumay created an issue
Jenkins / JENKINS-37880
Starting, stopping and replaying a run in quick succession does not work
Issue Type:
Bug
Assignee:
Vivek Pandey
Components:
blueocean-plugin
Created:
2016/Sep/01 4:22 AM
Priority:
Minor
Reporter:
James Dumay
Steps to reproduce
Create a new multi-branch pipeline using https://github.com/i386/hellonode
Go to the branches screen
Trigger a new build for master
Open the run and click stop
Then click replay again
The goal here is to try starting, stopping then replaying really quickly. You will get a 500 error back from the replay action PUT http://localhost:8080/jenkins/blue/rest/organizations/jenkins/pipelines/hellonode/branches/master/runs/23/replay/ 500 (Server Error)
Unknown macro: { "message" }
I attached a debugger when reproducing and got org.jenkinsci.plugins.workflow.cps.replay.ReplayAction#run2 returning null. Digging deeper it appears we can't get the flow owner
private @CheckForNull CpsFlowExecution getExecution() {
FlowExecutionOwner owner = ((FlowExecutionOwner.Executable)
