[JIRA] (JENKINS-38224) The html select element added by the dropdownlist.jelly form control needs to have a name attribute

2016-09-28 Thread sridevi.sanga...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Sridevi Sangaiah edited a comment on  JENKINS-38224  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: The html select element added by the dropdownlist.jelly form control needs to have a name attribute   
 

  
 
 
 
 

 
  I realized that when creating this enhancement I mentioned Id attribute instead of name attribute. Fixed it now. Sorry for the confusion. Explaining the requested enhancement with more details, below. Copying below a snippet from https://github.com/jenkinsci/ui-samples-plugin/blob/master/src/main/resources/jenkins/plugins/ui_samples/DropdownList/index.jelly{code:xml}selected="${fruit!=null}" staplerClass="${descriptor.clazz.name}">   {code} This jelly, after processing, will be converted to the following html structure.{code:xml}FruitsApple Banana        {code}  Notice that the name specified on the dropdownList jelly tag is set as the name for the table control that contains the html block for the current dropdown selection. The select element doesn't have any identifier. This is not a problem when doing a submit/save as the html controls are parsed and the data is formatted to json before it is sent to the server. From the formatted data it will be possible to identify the current selection in the dropdown. But in case of validation, say I have to validate some behavior depending on the current selection in the dropdown, there is no way to get the current selection as the select element doesn't have a name attribute.  https://wiki.jenkins-ci.org/display/JENKINS/Jelly+form+controls - clearly states that there should be a name associated with the input control, for it to be sent to the server for validation. I believe this is because validate uses the html form submit to pass data to the server, which would in turn do a lookup of html controls with the specified name.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 

[JIRA] (JENKINS-38224) The html select element added by the dropdownlist.jelly form control needs to have a name attribute

2016-09-28 Thread sridevi.sanga...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Sridevi Sangaiah commented on  JENKINS-38224  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: The html select element added by the dropdownlist.jelly form control needs to have a name attribute   
 

  
 
 
 
 

 
  I realized that when creating this enhancement I mentioned Id attribute instead of name attribute. Fixed it now. Sorry for the confusion. Explaining the requested enhancement with more details, below.  Copying below a snippet from https://github.com/jenkinsci/ui-samples-plugin/blob/master/src/main/resources/jenkins/plugins/ui_samples/DropdownList/index.jelly 

 

		"fruit" title="Fruits">
		  
		  "descriptor" items="${it.fruitDescriptors}" varStatus="loop">
			
			"fruit" value="${descriptor==currentFruit.descriptor?currentFruit:null}"/>
			"${descriptor.displayName}" value="${loop.index}"
 selected="${fruit!=null}" staplerClass="${descriptor.clazz.name}">
			  
			  "${descriptor.configPage}" from="${descriptor}"/>
			
		  
		
 

  This jelly, after processing, will be converted to the following html structure. 

 

		
			"setting-leftspace">
			"setting-name">Fruits
			"setting-main">
"setting-input dropdownList">
	"0">Apple
	"1">Banana

			
			"setting-no-help">
		
		
		"dropdownList-container">
			"2">
			"2">
"100%" name="fruit">
	
		"dropdownList-start rowvg-start">
			
		"dropdownList-end rowvg-end">
		"dropdownList-start rowvg-start" style="display: none;" field-disabled="true">
			
		"dropdownList-end rowvg-end">
	

			
		
 

  Notice that the name specified on the dropdownList jelly tag is set as the name for the table control that contains the html block for the current dropdown selection. The select element doesn't have any identifier. This is not a problem when doing a submit/save as the html controls are parsed and the data is formatted to json before it is sent to the server. From the formatted data it will be possible to identify the current selection in the dropdown.  But in case of validation, say I have to validate some behavior depending on the current selection in the dropdown, there is no way to get the current selection as the select element doesn't have a name attribute.   https://wiki.jenkins-ci.org/display/JENKINS/Jelly+form+controls - clearly states that there should be a name associated with the input control, for it to be sent to the server for validation. I believe this is because validate uses the html form submit to pass data to the server, which would in turn do a lookup of html controls with the specified name.  
 

  
 
 
 
 

 
 
 

   

[JIRA] (JENKINS-38224) The html select element added by the dropdownlist.jelly form control needs to have a name attribute

2016-09-28 Thread sridevi.sanga...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Sridevi Sangaiah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-38224  
 
 
  The html select element added by the dropdownlist.jelly form control needs to have a name attribute   
 

  
 
 
 
 

 
Change By: 
 Sridevi Sangaiah  
 
 
Comment: 
 I realized that when creating this enhancement I mentioned Id attribute instead of name attribute. Fixed it now. Sorry for the confusion. Explaining the requested enhancement with more details, below.Copying below a snippet from https://github.com/jenkinsci/ui-samples-plugin/blob/master/src/main/resources/jenkins/plugins/ui_samples/DropdownList/index.jelly selected="${fruit!=null}" staplerClass="${descriptor.clazz.name}">  This jelly, after processing, will be converted to the following html structure. Fruits AppleBanana        Notice that the name specified on the dropdownList jelly tag is set as the name for the table control that contains the html block for the current dropdown selection. The select element doesn't have any identifier. This is not a problem when doing a submit/save as the html controls are parsed and the data is formatted to json before it is sent to the server. From the formatted data it will be possible to identify the current selection in the dropdown.But in case of validation, say I have to validate some behavior depending on the current selection in the dropdown, there is no way to get the current selection as the select element doesn't have a name attribute. https://wiki.jenkins-ci.org/display/JENKINS/Jelly+form+controls - clearly states that there should be a name associated with the input control, for it to be sent to the server for validation. I believe this is because validate uses the html form submit to pass data to the server, which would in turn do a lookup of html controls with the specified name.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

[JIRA] (JENKINS-38224) The html select element added by the dropdownlist.jelly form control needs to have a name attribute

2016-09-28 Thread sridevi.sanga...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Sridevi Sangaiah commented on  JENKINS-38224  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: The html select element added by the dropdownlist.jelly form control needs to have a name attribute   
 

  
 
 
 
 

 
 I realized that when creating this enhancement I mentioned Id attribute instead of name attribute. Fixed it now. Sorry for the confusion. Explaining the requested enhancement with more details, below. Copying below a snippet from https://github.com/jenkinsci/ui-samples-plugin/blob/master/src/main/resources/jenkins/plugins/ui_samples/DropdownList/index.jelly" varStatus="loop">  "/> " value="$ {loop.index} " selected="$ {fruit!=null} " staplerClass="$ {descriptor.clazz.name} ">  " from="$ {descriptor} "/>This jelly, after processing, will be converted to the following html structure.     Fruits   Apple BananaHere goes the html when Apple is selected->   Here goes the html when Banana is selected->  Notice that the name specified on the dropdownList jelly tag is set as the name for the table control that contains the html block for the current dropdown selection. The select element doesn't have any identifier. This is not a problem when doing a submit/save as the html controls are parsed and the data is formatted to json before it is sent to the server. From the formatted data it will be possible to identify the current selection in the dropdown. But in case of validation, say I have to validate some behavior depending on the current selection in the dropdown, there is no way to get the current selection as the select element doesn't have a name attribute.  https://wiki.jenkins-ci.org/display/JENKINS/Jelly+form+controls - clearly states that there should be a name associated with the input control, for it to be sent to the server for validation. I believe this is because validate uses the html form submit to pass data to the server, which would in turn do a lookup of html controls with the specified name.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   

[JIRA] (JENKINS-38224) The html select element added by the dropdownlist.jelly form control needs to have a name attribute

2016-09-28 Thread sridevi.sanga...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Sridevi Sangaiah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-38224  
 
 
  The html select element added by the dropdownlist.jelly form control needs to have a name attribute   
 

  
 
 
 
 

 
Change By: 
 Sridevi Sangaiah  
 
 
Comment: 
 I realized that when creating this enhancement I mentioned Id attribute instead of name attribute. Fixed it now. Sorry for the confusion. Explaining the requested enhancement with more details, below.Copying below a snippet from [https://github.com/jenkinsci/ui-samples-plugin/blob/master/src/main/resources/jenkins/plugins/ui_samples/DropdownList/index.jelly] {{selected="${fruit!=null}" staplerClass="${descriptor.clazz.name}">  }}This jelly, after processing, will be converted to the following html structure. {{Fruits AppleBanana       }} Notice that the name="fruit" specified on the dropdownList jelly tag is set as the name for the table control that contains the html block for the current dropdown selection. The select element doesn't have any identifier. This is not a problem when doing a submit/save, as the html controls are parsed and the data is formatted to json before it is sent to the server. From the formatted data it will be possible to identify the current selection in the dropdown.But in case of validation, say I have to validate some behavior depending on the current selection in the dropdown, there is no way to get the current selection as the select element doesn't have a name attribute. [https://wiki.jenkins-ci.org/display/JENKINS/Jelly+form+controls] - clearly states that there should be a name associated with the input control, for it to be sent to the server for validation. I believe this is because validate uses the html form submit to pass data to the server, which would in turn do a lookup of html controls with the specified name.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
  

[JIRA] (JENKINS-38224) The html select element added by the dropdownlist.jelly form control needs to have a name attribute

2016-09-28 Thread sridevi.sanga...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Sridevi Sangaiah commented on  JENKINS-38224  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: The html select element added by the dropdownlist.jelly form control needs to have a name attribute   
 

  
 
 
 
 

 
 I realized that when creating this enhancement I mentioned Id attribute instead of name attribute. Fixed it now. Sorry for the confusion. Explaining the requested enhancement with more details, below. Copying below a snippet from [https://github.com/jenkinsci/ui-samples-plugin/blob/master/src/main/resources/jenkins/plugins/ui_samples/DropdownList/index.jelly ] {{  " varStatus="loop">  "/> " value="$ {loop.index} " selected="$ {fruit!=null} " staplerClass="$ {descriptor.clazz.name} ">  " from="$ {descriptor} "/>   }} This jelly, after processing, will be converted to the following html structure.  {{   Fruits   Apple BananaHere goes the html when Apple is selected->   Here goes the html when Banana is selected-> }} Notice that the name="fruit" specified on the dropdownList jelly tag is set as the name for the table control that contains the html block for the current dropdown selection. The select element doesn't have any identifier. This is not a problem when doing a submit/save, as the html controls are parsed and the data is formatted to json before it is sent to the server. From the formatted data it will be possible to identify the current selection in the dropdown. But in case of validation, say I have to validate some behavior depending on the current selection in the dropdown, there is no way to get the current selection as the select element doesn't have a name attribute.  [ https://wiki.jenkins-ci.org/display/JENKINS/Jelly+form+controls] - clearly states that there should be a name associated with the input control, for it to be sent to the server for validation. I believe this is because validate uses the html form submit to pass data to the server, which would in turn do a lookup of html controls with the specified name.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

   

[JIRA] (JENKINS-38224) The html select element added by the dropdownlist.jelly form control needs to have a name attribute

2016-09-28 Thread sridevi.sanga...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Sridevi Sangaiah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-38224  
 
 
  The html select element added by the dropdownlist.jelly form control needs to have a name attribute   
 

  
 
 
 
 

 
Change By: 
 Sridevi Sangaiah  
 

  
 
 
 
 

 
 The html select element added by the dropdownlist.jelly form control needs to have  an id  a name  attribute. In the validation flow, unlike save, the data submitted is not formatted. So, without the id attribute it is not possible to get the current selection in the validation flow  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-38224) The html select element added by the dropdownlist.jelly form control needs to have a name attribute

2016-09-28 Thread sridevi.sanga...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Sridevi Sangaiah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-38224  
 
 
  The html select element added by the dropdownlist.jelly form control needs to have a name attribute   
 

  
 
 
 
 

 
Change By: 
 Sridevi Sangaiah  
 
 
Summary: 
 The html select element added by the dropdownlist.jelly form control needs to have  an id  a name  attribute  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-38224) The html select element added by the dropdownlist.jelly form control needs to have a name attribute

2016-09-28 Thread sridevi.sanga...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Sridevi Sangaiah updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-38224  
 
 
  The html select element added by the dropdownlist.jelly form control needs to have a name attribute   
 

  
 
 
 
 

 
Change By: 
 Sridevi Sangaiah  
 

  
 
 
 
 

 
 The html select element added by the dropdownlist.jelly form control needs to have a name attribute. In the validation flow, unlike save, the data submitted is not formatted. So, without the  id  name  attribute it is not possible to get the current selection in the validation flow  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.