[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title Tom FENNELLY resolved as Fixed Jenkins / JENKINS-39345 Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle Change By: Tom FENNELLY Status: In Progress Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-39345 Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle Change By: Tom FENNELLY Component/s: js-builder Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title Tom FENNELLY started work on JENKINS-39345 Change By: Tom FENNELLY Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-39345 Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle Change By: James Dumay Priority: Major Critical Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title Michael Neale updated an issue Jenkins / JENKINS-39345 Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle Change By: Michael Neale A.K.A "translation keys instead of content keep showing up and flashing to the localised version on first load" Use new/extended js-modules/js-builder API delivered as part of JENKINS-39322 to automatically coordinate the async loading of i18n translations as part of the loading of a blueocean bundle that depends on the translation.This will allow synchronous access to the translations at runtime (because we can guarantee that they are already loaded in the browser), which in turn allows a much nicer programming model around i18n, removing the need to tie translation resource loading into react lifecycle etc (i.e. no need for e.g. react-i18next shim for react components - would need something else for non react components).Assigned to [~tfennelly] for now, but should be doable by anyone if we get JENKINS-39322 right. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title Tom FENNELLY commented on JENKINS-39345 Re: Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle I think we should bring this forward It was puzzling me how making the "Quick Language Switcher" work could have been higher priority than getting BO itself to switch language properly. So yes, bringing this forward seems consistent to me Tom - how "destructive" will these changes be? hard to say? Hmmm ... atm I don't think it will be destructive. I would expect/hope the component _javascript_ code to not change at all. The plugins might have to "declare" their i18n bundles e.g. in the same yaml file as they declare Extension Points. We (the build) could auto-detect the default bundle, which atm is all any of the core BO plugins are using afaik. The bigger changes would be in js-modules and js-builder, building in generic hooks (so we can potentially do this for other "stuff" e.g. Keith Zantow did some work for extension decorators that would be able to use something like this too) to allow us hook into the bundle loading process i.e. to allow us inject resource loading "functions" that return a Promise that needs to be fullfilled along with the normal _javascript_ loading stuff before the bundle can start executing. After that, we wire the above into blue ocean's plugin for js-builder and get it to inject resource loading for i18n resources. That resource loading would load i18next with the resource bundle it's told to load (declared by the plugin - detected by js-builder plugin etc) and would only resolve its promise once that's done, blocking the dependant/owner _javascript_ bundle from executing. I'm sure there'll be kinks that need working out, but that's the general idea. Add Comment This message was sent by Atlassian JIRA
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title James Dumay commented on JENKINS-39345 Re: Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle ... and is there any way for us to try it before committing to master? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title Michael Neale commented on JENKINS-39345 Re: Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle I think we should bring this forward, Tom FENNELLY is right, this one will bite (cliff is seeing it with creation flow). Tom - how "destructive" will these changes be? hard to say? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-39345 Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle Change By: James Dumay Sprint: indian, arctic, tasman, panthalassa pannonian Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-39345 Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle Change By: James Dumay Sprint: indian, arctic, tasman, release candidate panthalassa Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title James Dumay commented on JENKINS-39345 Re: Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle OK good stuff. I've added this to the release-candidate queue but we need to get to some other things first. Will re-review on monday. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-39345 Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle Change By: James Dumay Sprint: indian, arctic, tasman , release candidate Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title Ivan Meredith commented on JENKINS-39345 Re: Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle You can see this issue in action if you set your browser to german default, then go to ci.blueocean.io/blue . The Dashboard label first shows as English then switches to german. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title
Cliff Meyers edited a comment on JENKINS-39345
Re: Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle
[~jamesdumay] just to clarify the need / benefits:1. Right now, the UI will render with whatever "defaultValue" in specified in the JS code and then re-render after the language bundle loads (async, after the initial render). So for anyone that doesn't have English set as their language, they will see the UI paint in English and then repaint in their language a moment later.2. Every string displayed in the UI needs that defaultValue specified. So all i18n code looks like this: {code}{t('creation.git.step1.title'), { defaultValue: "Connect to Git" })}{code}After making this change it could simply be {code}{t('creation.git.step1.title')}{code}This would be a huge benefit from a maintainability standpoint. 2. Right now, the UI will render with whatever "defaultValue" in specified in the JS code and then re-render after the language bundle loads (async, after the initial render). So for anyone that doesn't have English set as their language, they will see the UI paint in English and then repaint in their language a moment later. 3. Anywhere that we might access localized strings in a more programmatic fashion (outside of JSX, e.g. in a list of radio buttons where we build up the button labels in JS code) we will have to introduce some pattern to delay the execution of that code until after the bundle loads, otherwise the defaultValue string will display instead of the correct value.
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title
Cliff Meyers commented on JENKINS-39345
Re: Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle
James Dumay just to clarify the need / benefits: 1. Right now, the UI will render with whatever "defaultValue" in specified in the JS code and then re-render after the language bundle loads (async, after the initial render). So for anyone that doesn't have English set as their language, they will see the UI paint in English and then repaint in their language a moment later. 2. Every string displayed in the UI needs that defaultValue specified. So all i18n code looks like this:
{t('creation.git.step1.title'), { defaultValue: "Connect to Git" })}
After making this change it could simply be
{t('creation.git.step1.title')}
This would be a huge benefit from a maintainability standpoint. 3. Anywhere that we might access localized strings in a more programmatic fashion (outside of JSX, e.g. in a list of radio buttons where we build up the button labels in JS code) we will have to introduce some pattern to delay the execution of that code until after the bundle loads, otherwise the defaultValue string will display instead of the correct value.
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title Tom FENNELLY commented on JENKINS-39345 Re: Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle Yeah, it looks a bit ugly now in spots. This was always an issue but is more obvious/visible now because of recent changes in core-js. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title Cliff Meyers commented on JENKINS-39345 Re: Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle Michael Neale James Dumay we discussed this issue as a group in today's meeting and agreed this should be addressed as soon as is feasible. Can we pull this one into the sprint? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title Tom FENNELLY edited a comment on JENKINS-39345 Re: Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle Issues around async loading of translations are becoming more apparent now (guessing because we've made the page loading times faster). When a user switches lang then they initially still see English after the page loads. They need to start clicking around before the text changes. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title Tom FENNELLY commented on JENKINS-39345 Re: Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle Issues around async loading of translations are becoming more apparent now (guessing because we've made the page loading times faster). When a user switches lang then initially still see English after the page loads. They need to start clicking around before the text changes. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-39345 Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle Change By: Tom FENNELLY Priority: Minor Major Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-39345 Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle Change By: James Dumay Priority: Major Minor Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-39345 Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle Change By: James Dumay Sprint: indian, arctic, tasman , tethys Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-39345 Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle Change By: James Dumay Sprint: indian, arctic, tasman , frank Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-39345 Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle Change By: James Dumay Sprint: indian, arctic, tasman , tethys Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-39345 Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle Change By: James Dumay Sprint: indian, arctic, tasman , frank Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-39345 Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle Change By: James Dumay Sprint: indian, arctic , tasman Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-39345 Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle Change By: James Dumay Sprint: indian , arctic Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39345) Use js-modules to coordinate async loading of i18n translation bundles as part of dependant JavaScript bundle
Title: Message Title Tom FENNELLY created an issue Jenkins / JENKINS-39345 Use js-modules to coordinate async loading of i18n translation bundles as part of dependant _javascript_ bundle Issue Type: Task Assignee: Tom FENNELLY Components: blueocean-plugin Created: 2016/Oct/28 7:51 AM Priority: Major Reporter: Tom FENNELLY Use new/extended js-modules/js-builder API delivered as part of JENKINS-39322 to automatically coordinate the async loading of i18n translations as part of the loading of a blueocean bundle that depends on the translation. This will allow synchronous access to the translations at runtime (because we can guarantee that they are already loaded in the browser), which in turn allows a much nicer programming model around i18n, removing the need to tie translation resource loading into react lifecycle etc (i.e. no need for e.g. react-i18next shim for react components - would need something else for non react components). Assigned to Tom FENNELLY for now, but should be doable by anyone if we get JENKINS-39322 right. Add Comment
