[JIRA] (JENKINS-39684) Use docker images from private registry
Title: Message Title Liam Newman closed an issue as Fixed Bulk closing resolved issues. Jenkins / JENKINS-39684 Use docker images from private registry Change By: Liam Newman Status: Resolved Closed Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.176261.1478901096000.17871.1571801073181%40Atlassian.JIRA.
[JIRA] (JENKINS-39684) Use docker images from private registry
Title: Message Title Peter Leibiger commented on JENKINS-39684 Re: Use docker images from private registry Works for me. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39684) Use docker images from private registry
Title: Message Title Andrew Bayer updated JENKINS-39684 Jenkins / JENKINS-39684 Use docker images from private registry Change By: Andrew Bayer Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39684) Use docker images from private registry
Title: Message Title SCM/JIRA link daemon commented on JENKINS-39684 Re: Use docker images from private registry Code changed in jenkins User: Andrew Bayer Path: pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/DockerPipeline.java pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/DockerPipelineFromDockerfile.java pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/DockerPipelineFromDockerfileScript.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/DockerPipelineScript.groovy http://jenkins-ci.org/commit/pipeline-model-definition-plugin/d76175b8b7d302fe46cccfda2bca36eb9f857974 Log: [FIXED JENKINS-39684] Add registryUrl and registryCredentialsId Added to both docker and dockerfile agent types. Not sure how to test this, honestly. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39684) Use docker images from private registry
Title: Message Title Peter Leibiger commented on JENKINS-39684 Re: Use docker images from private registry I can probably test this sometime this week. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39684) Use docker images from private registry
Title: Message Title Andrew Bayer started work on JENKINS-39684 Change By: Andrew Bayer Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39684) Use docker images from private registry
Title: Message Title Andrew Bayer commented on JENKINS-39684 Re: Use docker images from private registry Preliminary PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/86 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39684) Use docker images from private registry
Title: Message Title Andrew Bayer updated JENKINS-39684 Jenkins / JENKINS-39684 Use docker images from private registry Change By: Andrew Bayer Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39684) Use docker images from private registry
Title: Message Title Peter Leibiger commented on JENKINS-39684 Re: Use docker images from private registry Michael Neale I already commented on that PR regarding this issue: https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/73#issuecomment-267946020 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39684) Use docker images from private registry
Title: Message Title Michael Neale commented on JENKINS-39684 Re: Use docker images from private registry Peter Leibiger I know Andrew Bayer was looking at making the agent syntax more extensible: https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/73 - so perhaps that is the place to add in registry support? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39684) Use docker images from private registry
Title: Message Title Peter Leibiger commented on JENKINS-39684 Re: Use docker images from private registry Maybe the agent syntax always needs to be a closure, away from strings. In the future there might be a lot of parameters for different kinds of agents. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39684) Use docker images from private registry
Title: Message Title Peter Leibiger commented on JENKINS-39684 Re: Use docker images from private registry Current syntax looks like this withDockerRegistry([credentialsId: 'foo', url: 'https://docker.foo.com']). Tried to add it as wrapper but obviously that didn't work out. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39684) Use docker images from private registry
Title: Message Title Michael Neale commented on JENKINS-39684 Re: Use docker images from private registry that looks reasonable. I am not aware how registry works today with withCredentials, but perhaps its a matter of takign a credentialId as an option? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39684) Use docker images from private registry
Title: Message Title
Andrew Bayer edited a comment on JENKINS-39684
Re: Use docker images from private registry
I tell a lie - there's no viable way to fit non- closure {{ String}} {{ agent}} values into the AST. Grr. We *could* do maps, though. So I'd lean towards this syntax:{code}agent docker:'foo', registry:[url:'http://...', username:'...', password:'...']{code}Still need to think how we'd fit credentials into that, though.
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39684) Use docker images from private registry
Title: Message Title Andrew Bayer commented on JENKINS-39684 Re: Use docker images from private registry I tell a lie - there's no viable way to fit non-String agent values into the AST. Grr. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39684) Use docker images from private registry
Title: Message Title Andrew Bayer commented on JENKINS-39684 Re: Use docker images from private registry Ok, turns out it's technically possible, but I'm really unsure about the syntactic feel. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39684) Use docker images from private registry
Title: Message Title Andrew Bayer commented on JENKINS-39684 Re: Use docker images from private registry Hrm. I don't like the idea of mixing closures with string values in the agent config. That ship has already sailed, I think. I'll play around with it, but I don't think it'll work well. Most likely, we'll need straight key/value pairings. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39684) Use docker images from private registry
Title: Message Title
Michael Neale commented on JENKINS-39684
Re: Use docker images from private registry
Patrick Wolf Andrew Bayer I think the agent syntax was made flexible enough to cater for this. agent docker:"foo" registry: {... config for registry} would something like that work? or the docker item take a block in that case with all the config needed? (Andrew would be able to comment on what is best)
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39684) Use docker images from private registry
Title: Message Title Patrick Wolf commented on JENKINS-39684 Re: Use docker images from private registry Michael Neale James Dumay Do you guys have any suggestions for the syntax? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39684) Use docker images from private registry
Title: Message Title
Patrick Wolf created an issue
Jenkins / JENKINS-39684
Use docker images from private registry
Issue Type:
Story
Assignee:
Andrew Bayer
Components:
pipeline-model-definition-plugin
Created:
2016/Nov/11 9:51 PM
Priority:
Minor
Reporter:
Patrick Wolf
When using an agent directive in Declarative Pipeline there is no way to specify the Docker Registry to use. In Scripted Pipline this is available via the withRegistry wrapper
docker.withRegistry('https://docker.mycorp.com/', 'docker-login') {
git '…'
docker.build('myapp').push('latest')
}
For Declarative we should allow admins to create a default registry to be used by all Pipelines at the master level or the folder level. We should also allow a specific registry setting in the language itself via the agent directive.
Add Comment
