[JIRA] (JENKINS-39950) Incorrect URLs for job actions if job is within a Folder
Title: Message Title
Sergey Zhemzhitsky edited a comment on JENKINS-39950
Re: Incorrect URLs for job actions if job is within a Folder
[~drulli]: I've attached the screenshots demonstrating what's going wrong (I'm using multi-branch pipeline, folders, nested view and dashboard view plugins)The hierarchy of the folders is the following{code:none}authentication-service » build-multi » DMC-2273-continuous-delivery{code}... where * authentication-service - is the manually created folder (Folders plugin)* build-multi - is the name of the multi-branch pipeline job* DMC-2273-continuous-delivery - is the name of the automatically created job from the corresponding branchI've configured a nested view *develop-main* with the dashboard and this view has the following URL{code:none}https://host:port/view/REPORTS/view/develop-main/{code} Here is the screenshot that shows the original behavior of the analysis-collector-plugin's Dashboard. !jenkins_dashboard_links_folders_incorrect.png|thumbnail! The URLs which lead us to the corresponding warnings page look like the following{code:none}https://host:port/view/REPORTS/view/develop-main/job/DMC-2273-continuous-delivery/tasks{code}... where * REPORTS is the name of the view* develop-main is the name of the multi-branch pipeline job* DMC-2273-continuous-delivery is the name of the job that was created automaticallyUpdated plugin with the applied pull request leads to generation of the following URLs !jenkins_dashboard_links_folders_correct.png|thumbnail! {code:none}https://host:port/view/REPORTS/view/develop-main/job/authentication-service/job/build-multi/job/DMC-2273-continuous-delivery/tasks{code}So as you can see in case of unapplied and applied patch the URLs are different{code:none}https://host:port/view/REPORTS/view/develop-main/job/DMC-2273-continuous-delivery/tasks// vshttps://host:port/view/REPORTS/view/develop-main/job/authentication-service/job/build-multi/job/DMC-2273-continuous-delivery/tasks{code}... and we can see that in the first case all the intermediate folders (manually created one, and multi-branch pipeline's one) are missed.The missed folders lead us to 404 errors, and applying a patch makes the dashboard generate correct URLs. It also seems that according to the [verifyPortlet|https://github.com/jenkinsci/acceptance-test-harness/commit/02c3799d89681b2447cffaa5380f45f803db9959#diff-fc3a7583cae9f42abed87b75c9786b4fR125] and [verifyColumn|https://github.com/jenkinsci/acceptance-test-harness/commit/02c3799d89681b2447cffaa5380f45f803db9959#diff-fc3a7583cae9f42abed87b75c9786b4fR153] methods of the ATH only link text is verified, but not its href attribute.
Add Comment
[JIRA] (JENKINS-39950) Incorrect URLs for job actions if job is within a Folder
Title: Message Title Sergey Zhemzhitsky commented on JENKINS-39950 Re: Incorrect URLs for job actions if job is within a Folder Ulli Hafner: I've attached the screenshots demonstrating what's going wrong (I'm using multi-branch pipeline, folders, nested view and dashboard view plugins) The hierarchy of the folders is the following authentication-service » build-multi » DMC-2273-continuous-delivery ... where authentication-service - is the manually created folder (Folders plugin) build-multi - is the name of the multi-branch pipeline job DMC-2273-continuous-delivery - is the name of the automatically created job from the corresponding branch I've configured a nested view develop-main with the dashboard and this view has the following URL https://host:port/view/REPORTS/view/develop-main/ Here is the screenshot that shows the original behavior of the analysis-collector-plugin's Dashboard. The URLs which lead us to the corresponding warnings page look like the following https://host:port/view/REPORTS/view/develop-main/job/DMC-2273-continuous-delivery/tasks ... where REPORTS is the name of the view develop-main is the name of the multi-branch pipeline job DMC-2273-continuous-delivery is the name of the job that was created automatically Updated plugin with the applied pull request leads to generation of the following URLs https://host:port/view/REPORTS/view/develop-main/job/authentication-service/job/build-multi/job/DMC-2273-continuous-delivery/tasks So as you can see in case of unapplied and applied patch the URLs are different https://host:port/view/REPORTS/view/develop-main/job/DMC-2273-continuous-delivery/tasks // vs https://host:port/view/REPORTS/view/d
[JIRA] (JENKINS-39950) Incorrect URLs for job actions if job is within a Folder
Title: Message Title Sergey Zhemzhitsky updated an issue Jenkins / JENKINS-39950 Incorrect URLs for job actions if job is within a Folder Change By: Sergey Zhemzhitsky Attachment: jenkins_dashboard_links_folders_correct.png Attachment: jenkins_dashboard_links_folders_incorrect.png Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39950) Incorrect URLs for job actions if job is within a Folder
Title: Message Title Ulli Hafner commented on JENKINS-39950 Re: Incorrect URLs for job actions if job is within a Folder Sergey Zhemzhitsky: Can you please have a look at the test case I have added to the ATH. Seems to work. Which link is exactly broken in this issue? Is something different in your setup? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39950) Incorrect URLs for job actions if job is within a Folder
Title: Message Title SCM/JIRA link daemon commented on JENKINS-39950 Re: Incorrect URLs for job actions if job is within a Folder Code changed in jenkins User: Ulli Hafner Path: src/main/java/org/jenkinsci/test/acceptance/plugins/analysis_core/AnalysisAction.java src/main/java/org/jenkinsci/test/acceptance/po/Container.java src/main/java/org/jenkinsci/test/acceptance/po/Folder.java src/main/java/org/jenkinsci/test/acceptance/po/FolderItem.java src/main/java/org/jenkinsci/test/acceptance/po/Jenkins.java src/main/java/org/jenkinsci/test/acceptance/po/TopLevelItem.java src/main/java/org/jenkinsci/test/acceptance/po/WorkflowMultiBranchJob.java src/test/java/plugins/AbstractAnalysisTest.java src/test/java/plugins/AnalysisCollectorPluginTest.java src/test/java/plugins/CheckStylePluginTest.java src/test/java/plugins/FindBugsPluginTest.java src/test/java/plugins/FolderPluginTest.java src/test/java/plugins/PmdPluginTest.java src/test/java/plugins/TaskScannerPluginTest.java src/test/java/plugins/WarningsPluginTest.java http://jenkins-ci.org/commit/acceptance-test-harness/02c3799d89681b2447cffaa5380f45f803db9959 Log: Added test case to expose JENKINS-39947 JENKINS-39950. The test case runs the static analysis plugins for a job that is part of a folder. Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/87a407ef80af...02c3799d8968 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
[JIRA] (JENKINS-39950) Incorrect URLs for job actions if job is within a Folder
Title: Message Title Ulli Hafner commented on JENKINS-39950 Re: Incorrect URLs for job actions if job is within a Folder We need to verify that this change does not break JENKINS-21723. (And that the ATH test cases in AbstractAnalysisTest#should_have_trend_graph_with_relative_links_in_freestyle_job will succeed). Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-39950) Incorrect URLs for job actions if job is within a Folder
Title: Message Title Sergey Zhemzhitsky created an issue Jenkins / JENKINS-39950 Incorrect URLs for job actions if job is within a Folder Issue Type: Bug Assignee: Ulli Hafner Components: analysis-collector-plugin Created: 2016/Nov/22 10:20 PM Environment: Jenkins 2.33 Ubuntu 14.04 LTS Priority: Major Reporter: Sergey Zhemzhitsky For jobs contained withing folders action urls (urls to access warnings are generated) incorrectly leading to 404 http status codes. There is a pull request that fixes this issue by changing jobs' shortUrl to absoluteUrl to work correctly for jobs contained in folders. Add Comment
