[JIRA] (JENKINS-40226) Dockerfile build failures do not trigger failure post section
Title: Message Title Liam Newman closed an issue as Fixed Bulk closing resolved issues. Jenkins / JENKINS-40226 Dockerfile build failures do not trigger failure post section Change By: Liam Newman Status: Resolved Closed Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.176876.1480957764000.17040.1571801060138%40Atlassian.JIRA.
[JIRA] (JENKINS-40226) Dockerfile build failures do not trigger failure post section
Title: Message Title SCM/JIRA link daemon commented on JENKINS-40226 Re: Dockerfile build failures do not trigger failure post section Code changed in jenkins User: Andrew Bayer Path: pipeline-model-definition/pom.xml pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/Utils.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ModelInterpreter.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/DockerPipelineFromDockerfileScript.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/DockerPipelineScript.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/LabelScript.groovy pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/BasicModelDefTest.java pipeline-model-definition/src/test/resources/failureBeforeStages.groovy pipeline-model-definition/src/test/resources/skippedStagesForFailure.groovy http://jenkins-ci.org/commit/pipeline-model-definition-plugin/9bc4f82364f7562799716b3e95c5d52bb1ccb8e5 Log: Merge pull request #64 from abayer/jenkins-40226 [FIXED JENKINS-40226] Make sure non-within-stage failures are real. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit
[JIRA] (JENKINS-40226) Dockerfile build failures do not trigger failure post section
Title: Message Title Andrew Bayer updated JENKINS-40226 Jenkins / JENKINS-40226 Dockerfile build failures do not trigger failure post section Change By: Andrew Bayer Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40226) Dockerfile build failures do not trigger failure post section
Title: Message Title SCM/JIRA link daemon commented on JENKINS-40226 Re: Dockerfile build failures do not trigger failure post section Code changed in jenkins User: Andrew Bayer Path: pipeline-model-definition/pom.xml pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/Utils.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ModelInterpreter.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/DockerPipelineFromDockerfileScript.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/DockerPipelineScript.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/LabelScript.groovy pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/BasicModelDefTest.java pipeline-model-definition/src/test/resources/failureBeforeStages.groovy pipeline-model-definition/src/test/resources/skippedStagesForFailure.groovy http://jenkins-ci.org/commit/pipeline-model-definition-plugin/3cdc1032649e64244be3f3ebee7a1280188e0009 Log: [FIXED JENKINS-40226] Make sure non-within-stage failures are real. More notably, make sure we still end up doing a `post` for them if needed and that the build status is correct at that time. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to
[JIRA] (JENKINS-40226) Dockerfile build failures do not trigger failure post section
Title: Message Title Andrew Bayer updated JENKINS-40226 Jenkins / JENKINS-40226 Dockerfile build failures do not trigger failure post section Change By: Andrew Bayer Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40226) Dockerfile build failures do not trigger failure post section
Title: Message Title Andrew Bayer commented on JENKINS-40226 Re: Dockerfile build failures do not trigger failure post section PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/64 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40226) Dockerfile build failures do not trigger failure post section
Title: Message Title Andrew Bayer started work on JENKINS-40226 Change By: Andrew Bayer Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40226) Dockerfile build failures do not trigger failure post section
Title: Message Title
Gavin Llewellyn created an issue
Jenkins / JENKINS-40226
Dockerfile build failures do not trigger failure post section
Issue Type:
Bug
Assignee:
Andrew Bayer
Components:
pipeline-model-definition-plugin
Created:
2016/Dec/05 5:09 PM
Environment:
Jenkins 2.19.3, pipeline-model-definition-plugin 0.6
Priority:
Minor
Reporter:
Gavin Llewellyn
I am using the new Dockerfile support added in JENKINS-39216. I also have a "post" section within "pipeline" in my Jenkinsfile set up to send notifications of the build result:
pipeline {
// Build environment is defined by the Dockerfile
agent dockerfile:true
stages {
stage('package') {
steps {
// Do build
}
}
}
post {
success {
hipchatSend color: "GREEN", message: "SUCCESS: ${currentBuild.absoluteUrl}\">${currentBuild.fullDisplayName}"
}
failure {
hipchatSend color: "RED", message: "FAILURE: ${currentBuild.absoluteUrl}\">${currentBuild.fullDisplayName}", notify: true
}
unstable {
hipchatSend color: "YELLOW", message: "UNSTABLE: ${currentBuild.absoluteUrl}\">${currentBuild.fullDisplayName}", notify: true
}
}
}
However, if a failure occurs during the Dockerfile image build (e.g. a non-zero return code from a RUN step), the build is marked as failed but no notification is sent.
