[JIRA] (JENKINS-40286) EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of reimplementing it
Title: Message Title Oleg Nenashev edited a comment on JENKINS-40286 Re: EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of reimplementing it Released it in jenkins-2.37 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40286) EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of reimplementing it
Title: Message Title Oleg Nenashev updated JENKINS-40286 Released it jenkins-2.37 Jenkins / JENKINS-40286 EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of reimplementing it Change By: Oleg Nenashev Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit
[JIRA] (JENKINS-40286) EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of reimplementing it
Title: Message Title SCM/JIRA link daemon commented on JENKINS-40286 Re: EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of reimplementing it Code changed in jenkins User: kbrowder Path: core/src/main/java/jenkins/slaves/EncryptedSlaveAgentJnlpFile.java http://jenkins-ci.org/commit/jenkins/37806a53c87855cbdd9eda073600ad828ec6f5c0 Log: [FIXED JENKINS-40286] - Delegate JnlpMac computation to SlaveComputers if possible (#2658) [FIXED JENKINS-40286] - Delegate JnlpMac computation to SlaveComputers if possible Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40286) EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of reimplementing it
Title: Message Title Kevin Browder commented on JENKINS-40286 Re: EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of reimplementing it I dropped this into the review state, the tests all pass. Thanks in advance for whoever reviews this PR. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40286) EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of reimplementing it
Title: Message Title Kevin Browder updated JENKINS-40286 Jenkins / JENKINS-40286 EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of reimplementing it Change By: Kevin Browder Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40286) EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of reimplementing it
Title: Message Title Kevin Browder started work on JENKINS-40286 Change By: Kevin Browder Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40286) EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of reimplementing it
Title: Message Title Kevin Browder commented on JENKINS-40286 Re: EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of reimplementing it I think https://github.com/jenkinsci/jenkins/pull/2658 should fix this. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40286) EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of reimplementing it
Title: Message Title Daniel Beck updated an issue Jenkins / JENKINS-40286 EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of reimplementing it Change By: Daniel Beck Issue Type: Bug Improvement Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40286) EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of reimplementing it
Title: Message Title
Kevin Browder commented on JENKINS-40286
Re: EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of reimplementing it
Specifically i think EncryptedSlaveAgentJnlpFile should change it from being an AccessControlled to being a SlaveComputer and the line with JnlpSlaveAgentProtocol.SLAVE_SECRET.mac(slaveName.getBytes("UTF-8")) should become byte[] jnlpMac = Util.fromHexString(it.getJnlpMac()) Thus making the SlaveComputer the one-and-only authority on the secret.
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-40286) EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of reimplementing it
Title: Message Title Kevin Browder updated an issue Jenkins / JENKINS-40286 EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of reimplementing it Change By: Kevin Browder Summary: EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of implementing reimplementing it Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
