[JIRA] (JENKINS-41439) Github /organizations API returns 500 when using credentialId tied to revoked Github personal access token
Title: Message Title Vivek Pandey updated JENKINS-41439 Jenkins / JENKINS-41439 Github /organizations API returns 500 when using credentialId tied to revoked Github personal access token Change By: Vivek Pandey Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41439) Github /organizations API returns 500 when using credentialId tied to revoked Github personal access token
Title: Message Title Vivek Pandey updated JENKINS-41439 Jenkins / JENKINS-41439 Github /organizations API returns 500 when using credentialId tied to revoked Github personal access token Change By: Vivek Pandey Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41439) Github /organizations API returns 500 when using credentialId tied to revoked Github personal access token
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-41439 Github /organizations API returns 500 when using credentialId tied to revoked Github personal access token Change By: James Dumay Sprint: iapetus , 1.0 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41439) Github /organizations API returns 500 when using credentialId tied to revoked Github personal access token
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-41439 Github /organizations API returns 500 when using credentialId tied to revoked Github personal access token Change By: James Dumay Sprint: iapetus , 1.0 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41439) Github /organizations API returns 500 when using credentialId tied to revoked Github personal access token
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-41439 Github /organizations API returns 500 when using credentialId tied to revoked Github personal access token Change By: James Dumay Sprint: iapetus , 1.0 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41439) Github /organizations API returns 500 when using credentialId tied to revoked Github personal access token
Title: Message Title Cliff Meyers commented on JENKINS-41439 Re: Github /organizations API returns 500 when using credentialId tied to revoked Github personal access token Cool, 428 error would make it easier for the UI logic to be more precise. I will work on JENKINS-42103 once this one is ready. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41439) Github /organizations API returns 500 when using credentialId tied to revoked Github personal access token
Title: Message Title Vivek Pandey started work on JENKINS-41439 Change By: Vivek Pandey Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41439) Github /organizations API returns 500 when using credentialId tied to revoked Github personal access token
Title: Message Title James Dumay commented on JENKINS-41439 Re: Github /organizations API returns 500 when using credentialId tied to revoked Github personal access token As part of this ticket if the request to GH fail because the token is invalid or does not exist as a credential, we send the caller a "428 Precondition Required". Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41439) Github /organizations API returns 500 when using credentialId tied to revoked Github personal access token
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-41439 Github /organizations API returns 500 when using credentialId tied to revoked Github personal access token Change By: James Dumay Priority: Major Critical Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41439) Github /organizations API returns 500 when using credentialId tied to revoked Github personal access token
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-41439 Github /organizations API returns 500 when using credentialId tied to revoked Github personal access token Change By: James Dumay Sprint: iapetus Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41439) Github /organizations API returns 500 when using credentialId tied to revoked Github personal access token
Title: Message Title Vivek Pandey commented on JENKINS-41439 Re: Github /organizations API returns 500 when using credentialId tied to revoked Github personal access token Cliff Meyers Yes, not so sure about 1 but #2 is surely a bug, it should definitely be returning 403. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41439) Github /organizations API returns 500 when using credentialId tied to revoked Github personal access token
Title: Message Title
Cliff Meyers created an issue
Jenkins / JENKINS-41439
Github /organizations API returns 500 when using credentialId tied to revoked Github personal access token
Issue Type:
Bug
Assignee:
Vivek Pandey
Components:
blueocean-plugin
Created:
2017/Jan/25 4:48 PM
Priority:
Major
Reporter:
Cliff Meyers
Steps to reproduce:
Generate a valid Github access token
Use the /scm/github/validate endpoint to validate and create the credential
Return to Github UI and revoke the access token
Call /scm/github and note the credential is returned
Call /scm/github/organizations?credentialId=github and note the 500 error
Response body:
{
"message" : "Server returned HTTP response code: 401, message: 'Unauthorized' for URL: https://api.github.com/user",
"code" : 500,
"errors" : [ ]
}
Possible solutions
I think ideally the /scm/github would re-validate the credential and return an error response if Github indicates the access token is invalid. From the UI's standpoint it would be helpful to discover this as early in the flow as possible. However, I know there would be a performance or rate-limit impact to doing this every time, so I
