[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-09 Thread mne...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Neale commented on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 Update center is currently a bit broken, so this isn't avialable to everyone yet but will be.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-08 Thread tom.fenne...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom FENNELLY resolved as Fixed  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 merged upstream  
 

  
 
 
 
 

 
 Jenkins /  JENKINS-41832  
 
 
  master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
Change By: 
 Tom FENNELLY  
 
 
Status: 
 In Progress Resolved  
 
 
Resolution: 
 Fixed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit 

[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-08 Thread mne...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Neale commented on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 Thanks for PR and release quickly all!  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-08 Thread tom.fenne...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom FENNELLY commented on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 pubsub released and PR on blueocean: https://github.com/jenkinsci/blueocean-plugin/pull/799 People will be able to update this plugin without updating everything else. Thanks for the fix Szymon J.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-08 Thread scm_issue_l...@java.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 SCM/JIRA link daemon commented on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 Code changed in jenkins User: Szymon Jakubczak Path: src/main/java/org/jenkinsci/plugins/pubsub/listeners/SyncQueueListener.java http://jenkins-ci.org/commit/pubsub-light-module/71fa32f717d2dc1feee65478043baa507a1a4dfc Log: JENKINS-41832 Fix spinning in SyncQueueListener (#6) Fixes spinning at 100% when none of the tasks are done.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-08 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay commented on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 This ticket should not be closed until master depends on the new release.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-08 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay assigned an issue to Tom FENNELLY  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41832  
 
 
  master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 
 
Priority: 
 Minor Blocker  
 
 
Sprint: 
 panthalassa iapetus  
 
 
Assignee: 
 Vivek Pandey Tom FENNELLY  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-08 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay started work on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 James Dumay  
 
 
Status: 
 Open In Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-08 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay commented on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 PR https://github.com/jenkinsci/pubsub-light-module/pull/6  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-08 Thread tom.fenne...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom FENNELLY commented on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 Well ... the changes you made in your PR should fix this issue I think. Launching a thread for each just isn't an option. The BlockingQueue doesn't help in the classic sense of how it might normally be used (wait for something put into it .. remove and process it ... wait for the next), but it could be used as a mechanism to drive the processing thread. It is messy though, I agree. Hopefully your PR sorts it anyway   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-08 Thread s...@szym.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Szymon J commented on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 It seems that the problem you are addressing with SyncQueueListener is that of the POSIX `select` or `poll`, which is to monitor a number of items for their readiness. So a blocking queue would not help here. As far as I can tell the only way to wait on a number of java.concurrent.Future is to launch a number of threads each waiting on one Future and updating a synchronized object. http://stackoverflow.com/questions/117690/wait-until-any-of-futuret-is-done  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-08 Thread tom.fenne...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom FENNELLY commented on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 I'm also wondering would it make things a bit easier/clearer if we just used the blocking queue (with no timeouts) to drive the adding/checking/removing of a separate "tracking list". The blocking queue could get populated with "command" objects. One would be an "AddTask" command that gets put in for new tasks. Another would be "CheckTasks" command that gets put in by a timer of some sort. Just thinking out loud.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-08 Thread tom.fenne...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom FENNELLY commented on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 Szymon J awesome thanks a lot.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-08 Thread s...@szym.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Szymon J commented on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 Created https://github.com/jenkinsci/pubsub-light-module/pull/6  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-08 Thread s...@szym.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Szymon J edited a comment on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 The bug happens when there is more than one item in the queue and none of the futures is done.1. // queue has 2 items, tryQueue has 0 items2. leftItem = queue.poll()  // queue has 1, tryQueue has 03. tryQueue.drainTo(queue) // queue has 1, tryQueue has 04. !isDone => tryQueue.put(leftItem) // queue has 1, tryQueue has 15. leftItem = queue.poll()  // queue has 0, tryQueue has 16. tryQueue.drainTo(queue) // queue has 1, tryQueue has 07. !isDone =>tryQueue.put(leftItem) // queue has 1, tryQueue has 1...  spin  we're back in 4. spinning.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-08 Thread s...@szym.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Szymon J commented on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 The bug happens when there is more than one item in the queue and none of the futures is done. 1. // queue has 2 items, tryQueue has 0 items 2. leftItem = queue.poll() // queue has 1, tryQueue has 0 3. tryQueue.drainTo(queue) // queue has 1, tryQueue has 0 4. !isDone => tryQueue.put(leftItem) // queue has 1, tryQueue has 1 5. leftItem = queue.poll() // queue has 0, tryQueue has 1 6. tryQueue.drainTo(queue) // queue has 1, tryQueue has 0 7. !isDone =>tryQueue.put(leftItem) // queue has 1, tryQueue has 1 ... spin  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-08 Thread s...@szym.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Szymon J edited a comment on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 If I understand the intention of SyncQueueListener, it just has a small bug.{code:java}leftItem = queueTaskLeftPublishQueue.poll(...)if (leftItem!= null) {  // FIXME: This is a bug. Don't drain tryLater unless the future is done.  tryLaterQueueTaskLeftQueue.drainTo(queueTaskLeftPublishQueue);  if (leftItem.getFuture().isDone()) {//  ..//  TODO: FIXME: This is a good place to drain the tryLater queue publish(...);   } else {tryLaterQueueTaskLeftQueue.put(leftItem);  }} else {  tryLaterQueueTaskLeftQueue.drainTo(queueTaskLeftPublishQueue);}{code}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-08 Thread s...@szym.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Szymon J commented on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 If I understand the intention of SyncQueueListener, it just has a small bug. 

 

leftItem = queueTaskLeftPublishQueue.poll(...)
if (leftItem!= null) {
  // FIXME: This is a bug. Don't drain tryLater unless the future is done.
  tryLaterQueueTaskLeftQueue.drainTo(queueTaskLeftPublishQueue);
  if (leftItem.getFuture().isDone()) {
// ..
  } else {
tryLaterQueueTaskLeftQueue.put(leftItem);
  }
} else {
  tryLaterQueueTaskLeftQueue.drainTo(queueTaskLeftPublishQueue);
}
 

  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-08 Thread s...@szym.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Szymon J edited a comment on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 If I understand the intention of SyncQueueListener, it just has a small bug.{code:java}leftItem = queueTaskLeftPublishQueue.poll(...)if (leftItem!= null) {  // FIXME: This is a bug. Don't drain tryLater unless the future is done.  tryLaterQueueTaskLeftQueue.drainTo(queueTaskLeftPublishQueue);  if (leftItem.getFuture().isDone()) {// .. // TODO: FIXME: This is a good place to drain the tryLater queue   } else {tryLaterQueueTaskLeftQueue.put(leftItem);  }} else {  tryLaterQueueTaskLeftQueue.drainTo(queueTaskLeftPublishQueue);}{code}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-08 Thread tom.fenne...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom FENNELLY commented on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 James Dumay And how would you know when the queue tasks are complete? There's only one event we can use in all of this, which is the event that feeds the tasks into queue. After that we have nothing to tell us when those tasks are done/complete. Hence the need to periodically check their state. In effect, that queue is really just a list of tasks that we are tracking the state of i.e. not really a "queue" in the producer/consumer sense that I think you are thinking of. Obviously it needs to be reworked though.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-08 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay commented on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 Tom FENNELLY sorry to but in but could you use a producer/consumer queue and avoid the creation that single thread for processing? You could use a pull on that queue to pump the queues and avoids having to keep that thread looping.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-08 Thread tom.fenne...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom FENNELLY edited a comment on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 Ah bumber ... this is the thread we added for checking the MBP indexing. Must be getting into  tight  a  tight  retry loop.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-07 Thread tom.fenne...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom FENNELLY commented on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 Ah bumber ... this is the thread we added for checking the MBP indexing. Must be getting into tight a retry loop.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-07 Thread mne...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Neale updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41832  
 
 
  master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
Change By: 
 Michael Neale  
 

  
 
 
 
 

 
 During a build with a heavy log the master pubsub publisher thread has one core pegged at 100% in:org.jenkinsci.plugins.pubsub.listeners.SyncQueueListener$1.run(SyncQueueListener.java:103)Note that no browser is connected to jenkins over HTTP at the time.This warrants investigation  cc [~tfennelly]   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-07 Thread s...@szym.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Szymon J commented on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 I should explain that the log is heavy in size (10k lines), but the output rate is not that big (few lines per sec).  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-07 Thread s...@szym.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Szymon J edited a comment on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 This is using pipeline script, one node, three stages. The step in progress  was  is  sh("bazel build ...") This happens in every build.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-07 Thread s...@szym.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Szymon J commented on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 This is using pipeline script, one node, three stages. The step in progress was sh("bazel build ...")  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-07 Thread mne...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Neale commented on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 Szymon J can you provide more detail on the job run? How many steps - one step, lots of parallel?   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-07 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay commented on  JENKINS-41832  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
 Szymon J thanks for filing this ticket. Would we be able to get a full thread dump of the Jenkins server under the condition that you have listed?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-07 Thread mne...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Neale updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41832  
 
 
  master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
Change By: 
 Michael Neale  
 
 
Sprint: 
 panthalassa  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-07 Thread mne...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Neale updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41832  
 
 
  master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
Change By: 
 Michael Neale  
 

  
 
 
 
 

 
 During a build with a heavy log the master pubsub publisher thread has one core pegged at 100% in:org.jenkinsci.plugins.pubsub.listeners.SyncQueueListener$1.run(SyncQueueListener.java:103)Note that no browser is connected to jenkins over HTTP at the time. This warrants investigation  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-07 Thread mne...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Neale assigned an issue to Tom FENNELLY  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41832  
 
 
  master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
Change By: 
 Michael Neale  
 
 
Assignee: 
 Tom FENNELLY  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-07 Thread mne...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Neale assigned an issue to Vivek Pandey  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41832  
 
 
  master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
Change By: 
 Michael Neale  
 
 
Assignee: 
 Tom FENNELLY Vivek Pandey  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41832) master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()

2017-02-07 Thread s...@szym.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Szymon J created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41832  
 
 
  master uses 100% cpu in jenkinsci.plugins.pubsub.listeners.SyncQueueListener()   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Components: 
 blueocean-plugin  
 
 
Created: 
 2017/Feb/08 1:22 AM  
 
 
Environment: 
 jenkins 52.0  blueocean 1.0.0-b22  pubsub-light 1.6   OS: ubuntu 16.04 xenial  JAVA: openjdk 1.8.0  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Szymon J  
 

  
 
 
 
 

 
 During a build with a heavy log the master pubsub publisher thread has one core pegged at 100% in: org.jenkinsci.plugins.pubsub.listeners.SyncQueueListener$1.run(SyncQueueListener.java:103) Note that no browser is connected to jenkins over HTTP at the time.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment