[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title Diego Russo commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries All, thanks for your support and help in solving this ticket. Much appreciated. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title Mark Waite closed an issue as Fixed Included in git plugin 3.9.0 released 12 May 2018 Jenkins / JENKINS-48061 git plugin 3.6.4 regression with shared libraries Change By: Mark Waite Status: Resolved Closed Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title Mark Waite commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Confirmed by testing a pre-release of git plugin 3.9.0 that the "modern Git" implementation is able to read Pipeline shared library references by SHA1. Confirmed by testing a pre-release of git plugin 3.9.0 that the "modern GitHub" implementation is unable to read Pipeline shared library references by SHA1. That was not intended to be covered in this fix, and is not covered in this fix. Confirmed by testing a pre-release of git plugin 3.9.0 that the "legacy Git" implementation is unable to read Pipeline shared library references by SHA1. That was not intended to be covered in this fix, and is not covered in this fix. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: Mark Waite Path: Jenkinsfile http://jenkins-ci.org/commit/hello-world-plugin/cd774efec0b23bea3ee49511b7893ebb6c363d50 Log: Use JENKINS-48061-no-tag-no-branch branch in test Jenkinsfile *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: Mark Waite Path: Jenkinsfile http://jenkins-ci.org/commit/hello-world-plugin/96ae30edf0efe2cd54b419c80815a41a60aa8e90 Log: test JENKINS-48061 no tag, no branch Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title rsandell updated JENKINS-48061 Jenkins / JENKINS-48061 git plugin 3.6.4 regression with shared libraries Change By: rsandell Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: Mark Waite Path: README.md pom.xml src/main/java/hudson/plugins/git/browser/AssemblaWeb.java src/main/java/hudson/plugins/git/browser/BitbucketWeb.java src/main/java/hudson/plugins/git/browser/CGit.java src/main/java/hudson/plugins/git/browser/FisheyeGitRepositoryBrowser.java src/main/java/hudson/plugins/git/browser/GitBlitRepositoryBrowser.java src/main/java/hudson/plugins/git/browser/GitLab.java src/main/java/hudson/plugins/git/browser/GitList.java src/main/java/hudson/plugins/git/browser/GitWeb.java src/main/java/hudson/plugins/git/browser/GithubWeb.java src/main/java/hudson/plugins/git/browser/Gitiles.java src/main/java/hudson/plugins/git/browser/GitoriousWeb.java src/main/java/hudson/plugins/git/browser/GogsGit.java src/main/java/hudson/plugins/git/browser/KilnGit.java src/main/java/hudson/plugins/git/browser/Phabricator.java src/main/java/hudson/plugins/git/browser/RedmineWeb.java src/main/java/hudson/plugins/git/browser/RhodeCode.java src/main/java/hudson/plugins/git/browser/Stash.java src/main/java/hudson/plugins/git/browser/TFS2013GitRepositoryBrowser.java src/main/java/hudson/plugins/git/browser/ViewGitWeb.java src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java src/main/java/jenkins/plugins/git/GitBranchSCMHead.java src/main/java/jenkins/plugins/git/GitBranchSCMRevision.java src/main/java/jenkins/plugins/git/GitRefSCMHead.java src/main/java/jenkins/plugins/git/GitRefSCMRevision.java src/main/java/jenkins/plugins/git/GitSCMBuilder.java src/main/java/jenkins/plugins/git/GitSCMHeadMixin.java src/main/java/jenkins/plugins/git/GitSCMSource.java src/main/java/jenkins/plugins/git/GitSCMSourceContext.java src/main/java/jenkins/plugins/git/GitSCMTelescope.java src/main/java/jenkins/plugins/git/traits/DiscoverOtherRefsTrait.java src/main/resources/jenkins/plugins/git/traits/DiscoverOtherRefsTrait/config.jelly src/main/resources/jenkins/plugins/git/traits/DiscoverOtherRefsTrait/help-nameMapping.html src/main/resources/jenkins/plugins/git/traits/DiscoverOtherRefsTrait/help-ref.html src/main/resources/jenkins/plugins/git/traits/DiscoverOtherRefsTrait/help.html src/main/resources/jenkins/plugins/git/traits/Messages.properties src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTest.java src/test/java/jenkins/plugins/git/GitBranchSCMHeadTest.java src/test/java/jenkins/plugins/git/GitSCMFileSystemTest.java src/test/java/jenkins/plugins/git/GitSCMSourceTest.java src/test/java/jenkins/plugins/git/traits/DiscoverOtherRefsTraitTest.java src/test/resources/jenkins/plugins/git/GitBranchSCMHeadTest/testMigrationNoBuildStorm.zip src/test/resources/jenkins/plugins/git/GitBranchSCMHeadTest/testMigrationNoBuildStorm_repositories.zip http://jenkins-ci.org/commit/git-plugin/927c8295d326a755cc7443f1834d7ff9ede37ee2 Log: Merge pull request #577 from rsandell/JENKINS-48061 JENKINS-48061 Add new "Discover other refs" trait, GitBranchSCMHead and GitRefSCMHead Compare: https://github.com/jenkinsci/git-plugin/compare/bd8d2b9a9546...927c8295d326 *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTest.java http://jenkins-ci.org/commit/git-plugin/6ffc5710f70a58e42873d2f3d94d887b557685a9 Log: JENKINS-48061 Added a test to verify we can retrieve a commit that is not on the head of a custom ref Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java http://jenkins-ci.org/commit/git-plugin/1340f867c7de5f2474fa3866a3d5c9f4c38fcba5 Log: JENKINS-48061 That logging might be a bit too informative Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java src/main/java/jenkins/plugins/git/GitSCMSourceContext.java src/main/java/jenkins/plugins/git/traits/DiscoverOtherRefsTrait.java src/main/resources/jenkins/plugins/git/traits/DiscoverOtherRefsTrait/config.jelly src/main/resources/jenkins/plugins/git/traits/DiscoverOtherRefsTrait/help-nameMapping.html src/main/resources/jenkins/plugins/git/traits/DiscoverOtherRefsTrait/help-ref.html src/main/resources/jenkins/plugins/git/traits/DiscoverOtherRefsTrait/help.html src/main/resources/jenkins/plugins/git/traits/Messages.properties src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTest.java src/test/java/jenkins/plugins/git/traits/DiscoverOtherRefsTraitTest.java http://jenkins-ci.org/commit/git-plugin/75177c492f12ef59e65e118ea4b6c62daa7dd5c2 Log: JENKINS-48061 Adding DiscoverOtherRefsTrait Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: src/test/java/jenkins/plugins/git/GitBranchSCMHeadTest.java http://jenkins-ci.org/commit/git-plugin/d21ba4ea1011168e53bf82feb2466295a3da118e Log: JENKINS-48061 Clean up after test Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java src/main/java/jenkins/plugins/git/GitBranchSCMHead.java src/main/java/jenkins/plugins/git/GitRefSCMHead.java src/main/java/jenkins/plugins/git/GitSCMBuilder.java src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTest.java src/test/java/jenkins/plugins/git/GitSCMFileSystemTest.java src/test/java/jenkins/plugins/git/GitSCMSourceTest.java http://jenkins-ci.org/commit/git-plugin/d6862539704655da7158385710e1a69e4ce9b20f Log: JENKINS-48061 regrouping and more tests Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java http://jenkins-ci.org/commit/git-plugin/1d312b647aa7a6ab256296551863760fdb61 Log: Revert "JENKINS-48061 Non GitSCMHeadMixin should be a branch" This reverts commit 68a956f9c3180e75b8c3c1b7d43ca2f870a82e9d. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTest.java http://jenkins-ci.org/commit/git-plugin/887ac3394c48e844147de591277a0457adb345a3 Log: JENKINS-48061 retrieveRevisions Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java http://jenkins-ci.org/commit/git-plugin/bcd0e206edebd84a7f069bd0dd083d7b18158d6c Log: JENKINS-48061 Make the comment an actual comment Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java http://jenkins-ci.org/commit/git-plugin/2cc15228d0b34bfcc13d4f1e58dcd79344faaa3c Log: JENKINS-48061 Move HEAD check to top Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java src/main/java/jenkins/plugins/git/GitSCMSourceContext.java src/main/java/jenkins/plugins/git/traits/DiscoverOtherRefsTrait.java src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTest.java http://jenkins-ci.org/commit/git-plugin/f67a66ec0900c83d6785955d32de32b1f17f4724 Log: JENKINS-48061 Retrieve other refs Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java http://jenkins-ci.org/commit/git-plugin/cb2e753cd81be123af628c7f502681ef6b2a9a34 Log: JENKINS-48061 Motivate withoutRefspec Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java src/main/java/jenkins/plugins/git/GitSCMSourceContext.java src/main/java/jenkins/plugins/git/traits/DiscoverOtherRefsTrait.java http://jenkins-ci.org/commit/git-plugin/36a307a5e128e5f47d2284317a6cf1e0cb4595e5 Log: JENKINS-48061 rename WantedOtherRefs to RefNameMapping Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java http://jenkins-ci.org/commit/git-plugin/191cf5562d801a0d8749c847451595271872b6a8 Log: JENKINS-48061 Resolve other ref before tag name So we don't have to check timestamps on the tag Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: pom.xml src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java src/main/java/jenkins/plugins/git/GitSCMSourceContext.java src/main/java/jenkins/plugins/git/GitSCMTelescope.java http://jenkins-ci.org/commit/git-plugin/4a7cba88498ba5f5cdc1c4a76fac17fa0faa4f99 Log: JENKINS-48061 Cleaned up comments and todos Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: pom.xml http://jenkins-ci.org/commit/git-plugin/0cc223cec6d13d64cf6ac4c94065afbe83b29ff8 Log: JENKINS-48061 More finageling with dependencies Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java http://jenkins-ci.org/commit/git-plugin/68a956f9c3180e75b8c3c1b7d43ca2f870a82e9d Log: JENKINS-48061 Non GitSCMHeadMixin should be a branch Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: src/main/java/jenkins/plugins/git/GitBranchSCMHead.java http://jenkins-ci.org/commit/git-plugin/ceabe36d1f379bad4e37573a9f6094e4e06e2525 Log: JENKINS-48061 final GitBranchSCMHead.getRef let's not let anyone hijack branch for a non-branch Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: src/main/java/jenkins/plugins/git/GitRefSCMHead.java src/main/java/jenkins/plugins/git/GitRefSCMRevision.java src/main/java/jenkins/plugins/git/GitSCMHeadMixin.java http://jenkins-ci.org/commit/git-plugin/79a5e1a0bbf5bb8f949c4108f059a3551d3e417e Log: JENKINS-48061 MIT headers and a todo Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java http://jenkins-ci.org/commit/git-plugin/ac97524ab61e1cd2caf4ef9e1419bc410f3c0658 Log: JENKINS-48061 Do something when it's a plain ref Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: pom.xml src/test/java/jenkins/plugins/git/GitBranchSCMHeadTest.java src/test/resources/jenkins/plugins/git/GitBranchSCMHeadTest/testMigrationNoBuildStorm.zip src/test/resources/jenkins/plugins/git/GitBranchSCMHeadTest/testMigrationNoBuildStorm_repositories.zip http://jenkins-ci.org/commit/git-plugin/54115890411a10e0a853da0ad4ec3d3c214e628c Log: JENKINS-48061 Add a test for buildstorm check This required a newer ish shared libraries plugin in the test scope which required a slightly newer jenkins core Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java src/main/java/jenkins/plugins/git/GitBranchSCMHead.java src/main/java/jenkins/plugins/git/GitRefSCMHead.java src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTest.java http://jenkins-ci.org/commit/git-plugin/eb8f3788eac9cca440c82f2f9f9f2903f634fd39 Log: Merge commit '919b7bf3f194eefa739e68bf27e059abc002cc2a' into JENKINS-48061 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java src/main/java/jenkins/plugins/git/GitBranchSCMHead.java src/main/java/jenkins/plugins/git/GitRefSCMHead.java src/main/java/jenkins/plugins/git/GitSCMHeadMixin.java src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTest.java http://jenkins-ci.org/commit/git-plugin/d49fec4bb795a573112aae0bce2b979d19066eca Log: JENKINS-48061 GitSCMHeadMixin and discover all published refs Since it seems like the git protocol doesn't allow discovering unpublished refs anyway, we can do ahead and find the sha among all published refs instead Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: src/main/java/jenkins/plugins/git/GitBranchSCMHead.java src/main/java/jenkins/plugins/git/GitRefSCMHead.java src/main/java/jenkins/plugins/git/GitSCMHeadMixin.java http://jenkins-ci.org/commit/git-plugin/54c5a0306b690bdf5ae2676cdaf816d6970fcd48 Log: JENKINS-48061 Use constants not literals Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java src/main/java/jenkins/plugins/git/GitBranchSCMHead.java src/main/java/jenkins/plugins/git/GitBranchSCMRevision.java src/main/java/jenkins/plugins/git/GitSCMSource.java src/main/java/jenkins/plugins/git/GitSCMTelescope.java src/test/java/jenkins/plugins/git/GitSCMFileSystemTest.java src/test/java/jenkins/plugins/git/GitSCMSourceTest.java http://jenkins-ci.org/commit/git-plugin/50e4690cd0e32c35111dfd52e6a1d26eb9995468 Log: JENKINS-48061 Introduce GitBranchSCMHead And migrate old usage of plain SCMHead Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title SCM/JIRA link daemon commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Code changed in jenkins User: rsandell Path: src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java src/main/java/jenkins/plugins/git/GitRefSCMHead.java src/main/java/jenkins/plugins/git/GitRefSCMRevision.java src/main/java/jenkins/plugins/git/GitSCMBuilder.java src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTest.java http://jenkins-ci.org/commit/git-plugin/2eee3e5afa0b759f124da6439bd4652bfd3399af Log: JENKINS-48061 Introduce GitRefSCMHead Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title
Hugh Saunders edited a comment on JENKINS-48061
Re: git plugin 3.6.4 regression with shared libraries
{color:#ff}*This failure was due to my config error, see my next comment.*{color} Hey [~markewaite], I built [~rsandell]'s branch at 887ac3394c48e844147de591277a0457adb345a3 but it didn't solve my problem. Version:{code:java}Git pluginThis plugin integrates Git with Jenkins.3.8.1-SNAPSHOT (private-887ac339-hughsaunders) Downgrade to 3.6.3{code}Console:{code:java}GitHub pull request #719 of commit f35de294eaebcbe5aecd824b444d1d901777814a, no merge conflicts.Setting status of f35de294eaebcbe5aecd824b444d1d901777814a to PENDING with url https://rpc.jenkins.cit.rackspace.net/job/RPC-Pull-Request-Issue-Link_rpc_gating/1806/ and message: 'Build started sha1 is merged.'Using context: CIT/issue-linkRunning in Durability level: PERFORMANCE_OPTIMIZED[Pipeline] libraryLoading library rpc-gating@origin/pr/719/mergeAttempting to resolve origin/pr/719/merge from remote references... > git --version # timeout=10using GIT_ASKPASS to set credentials github_account_rpc_jenkins_svc > git ls-remote -h https://github.com/rcbops/rpc-gating.git # timeout=10Could not find origin/pr/719/merge in remote references. Pulling heads to local for deep search... > git rev-parse --is-inside-work-tree # timeout=10Setting origin to https://github.com/rcbops/rpc-gating.git > git config remote.origin.url https://github.com/rcbops/rpc-gating.git # timeout=10Fetching origin...Fetching upstream changes from origin > git --version # timeout=10using GIT_ASKPASS to set credentials github_account_rpc_jenkins_svc > git fetch --tags --progress origin +refs/heads/*:refs/remotes/origin/* +refs/pull/*:refs/heads/origin/pr/* > git rev-parse origin/pr/719/merge^{commit} # timeout=10 > git branch -a -v --no-abbrev --contains 10939c10d74f2284e1078a7371d49587d71858a1 # timeout=10Could not find a branch containing commit 10939c10d74f2284e1078a7371d49587d71858a1[Pipeline] End of Pipeline[BFA] Scanning build for known causes...[BFA] No failure causes found[BFA] Done. 0sSetting status of f35de294eaebcbe5aecd824b444d1d901777814a to FAILURE with url https://rpc.jenkins.cit.rackspace.net/job/RPC-Pull-Request-Issue-Link_rpc_gating/1806/ and message: 'Build finished. 'Using context: CIT/issue-linkERROR: No version origin/pr/719/merge found for library rpc-gatingFinished: FAILURE{code}Its frustrating because the ref is obviously valid as{code:java} git rev-parse origin/pr/719/merge^{commit}{code}successfully translates it to a SHA.As before, when running the commands manually, a branch is found:{code:java}10:08 $ git fetch --tags --progress origin +refs/heads/*:refs/remotes/origin/* +refs/pull/*:refs/heads/origin/pr/*remote: Counting objects: 1319, done.remote: Compressing objects: 100% (12/12), done.remote: Total 1319 (delta 755), reused 753 (delta 752), pack-reused 555Receiving objects: 100% (1319/1319), 232.31 KiB | 1.40 MiB/s, done.Resolving deltas: 100% (830/830), completed with 453 local objects.From github.com:rcbops/rpc-gating* [new ref] refs/pull/1/head -> origin/pr/1/head* [new ref] refs/pull/10/head -> origin/pr/10/head* [new ref] refs/pull/100/head -> origin/pr/100/head...10:08 $ git branch -a -v --no-abbrev --contains 10939c10d74f2284e1078a7371d49587d71858a1origin/pr/719/merge 10939c10d74f2284e1078a7371d49587d71858a1 Merge f35de294eaebcbe5aecd824b444d1d901777814a into b0359387d639b5d7df8267f4fa09c0bba798a286{code}
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title
Hugh Saunders edited a comment on JENKINS-48061
Re: git plugin 3.6.4 regression with shared libraries
Update... I forgot to add the new trait, which explains the failure in my above comment. I retried, switching from github to git retrieval method and adding the new trait. I also removed the additional refspecs I had defined previously.Current config:!Screen Shot 2018-04-23 at 11.20.22.png!It now library checkout from a PR works again :D{code:java}GitHub pull request #719 of commit f35de294eaebcbe5aecd824b444d1d901777814a, no merge conflicts. Setting status of f35de294eaebcbe5aecd824b444d1d901777814a to PENDING with url https://rpc.jenkins.cit.rackspace.net/job/RPC-Pull-Request-Issue-Link_rpc_gating/1814/ and message: 'Build started sha1 is merged.' Using context: CIT/issue-link Running in Durability level: PERFORMANCE_OPTIMIZED [Pipeline] library Loading library rpc-gating@origin/pr/719/merge Attempting to resolve origin/pr/719/merge from remote references... > git --version # timeout=10 using GIT_ASKPASS to set credentials github_account_rpc_jenkins_svc > git ls-remote https://github.com/rcbops/rpc-gating.git # timeout=10 Could not find origin/pr/719/merge in remote references. Pulling heads to local for deep search... > git rev-parse --is-inside-work-tree # timeout=10 Setting origin to https://github.com/rcbops/rpc-gating.git > git config remote.origin.url https://github.com/rcbops/rpc-gating.git # timeout=10 Fetching origin... Fetching upstream changes from origin > git --version # timeout=10 using GIT_ASKPASS to set credentials github_account_rpc_jenkins_svc > git fetch --tags --progress origin +refs/heads/*:refs/remotes/origin/* +refs/origin/pull/*/merge:refs/remotes/origin/origin/pull/*/merge > git rev-parse origin/pr/719/merge^{commit} # timeout=10 > git branch -a -v --no-abbrev --contains 10939c10d74f2284e1078a7371d49587d71858a1 # timeout=10 Selected match: pr/719/merge revision 10939c10d74f2284e1078a7371d49587d71858a1 > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/rcbops/rpc-gating.git # timeout=10 Fetching without tags Fetching upstream changes from https://github.com/rcbops/rpc-gating.git > git --version # timeout=10 using GIT_ASKPASS to set credentials github_account_rpc_jenkins_svc > git fetch --no-tags --progress https://github.com/rcbops/rpc-gating.git +refs/heads/*:refs/remotes/origin/* +refs/origin/pull/*/merge:refs/remotes/origin/origin/pull/*/merge JENKINS-19022: warning: possible memory leak due to Git plugin usage; see: https://wiki.jenkins-ci.org/display/JENKINS/Remove+Git+Plugin+BuildsByBranch+BuildData Checking out Revision 10939c10d74f2284e1078a7371d49587d71858a1 (pr/719/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 10939c10d74f2284e1078a7371d49587d71858a1 Commit message: "Merge f35de294eaebcbe5aecd824b444d1d901777814a into b0359387d639b5d7df8267f4fa09c0bba798a286" > git rev-list --no-walk 1ab31cb8abfe1386c699bf6fbdb406f8105af82d # timeout=10 {code}
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title
Hugh Saunders edited a comment on JENKINS-48061
Re: git plugin 3.6.4 regression with shared libraries
Update... I forgot to add the new trait, which explains the failure in my above comment. I retried, switching from github to git retrieval method and adding the new trait. I also removed the additional refspecs I had defined previously.Current config:!Screen Shot 2018-04-23 at 11.20.22.png! It now Now library checkout from a PR works again :D{code:java}GitHub pull request #719 of commit f35de294eaebcbe5aecd824b444d1d901777814a, no merge conflicts.Setting status of f35de294eaebcbe5aecd824b444d1d901777814a to PENDING with url https://rpc.jenkins.cit.rackspace.net/job/RPC-Pull-Request-Issue-Link_rpc_gating/1814/ and message: 'Build started sha1 is merged.'Using context: CIT/issue-linkRunning in Durability level: PERFORMANCE_OPTIMIZED[Pipeline] libraryLoading library rpc-gating@origin/pr/719/mergeAttempting to resolve origin/pr/719/merge from remote references... > git --version # timeout=10using GIT_ASKPASS to set credentials github_account_rpc_jenkins_svc > git ls-remote https://github.com/rcbops/rpc-gating.git # timeout=10Could not find origin/pr/719/merge in remote references. Pulling heads to local for deep search... > git rev-parse --is-inside-work-tree # timeout=10Setting origin to https://github.com/rcbops/rpc-gating.git > git config remote.origin.url https://github.com/rcbops/rpc-gating.git # timeout=10Fetching origin...Fetching upstream changes from origin > git --version # timeout=10using GIT_ASKPASS to set credentials github_account_rpc_jenkins_svc > git fetch --tags --progress origin +refs/heads/*:refs/remotes/origin/* +refs/origin/pull/*/merge:refs/remotes/origin/origin/pull/*/merge > git rev-parse origin/pr/719/merge^{commit} # timeout=10 > git branch -a -v --no-abbrev --contains 10939c10d74f2284e1078a7371d49587d71858a1 # timeout=10Selected match: pr/719/merge revision 10939c10d74f2284e1078a7371d49587d71858a1 > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/rcbops/rpc-gating.git # timeout=10Fetching without tagsFetching upstream changes from https://github.com/rcbops/rpc-gating.git > git --version # timeout=10using GIT_ASKPASS to set credentials github_account_rpc_jenkins_svc > git fetch --no-tags --progress https://github.com/rcbops/rpc-gating.git +refs/heads/*:refs/remotes/origin/* +refs/origin/pull/*/merge:refs/remotes/origin/origin/pull/*/mergeJENKINS-19022: warning: possible memory leak due to Git plugin usage; see: https://wiki.jenkins-ci.org/display/JENKINS/Remove+Git+Plugin+BuildsByBranch+BuildDataChecking out Revision 10939c10d74f2284e1078a7371d49587d71858a1 (pr/719/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 10939c10d74f2284e1078a7371d49587d71858a1Commit message: "Merge f35de294eaebcbe5aecd824b444d1d901777814a into b0359387d639b5d7df8267f4fa09c0bba798a286" > git rev-list --no-walk 1ab31cb8abfe1386c699bf6fbdb406f8105af82d # timeout=10{code}
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title
Hugh Saunders commented on JENKINS-48061
Re: git plugin 3.6.4 regression with shared libraries
Update... I forgot to add the new trait, which explains the failure in my above comment. I retried, switching from github to git retrieval method and adding the new trait. I also removed the additional refspecs I had defined previously. Current config: It now library checkout from a PR works again
GitHub pull request #719 of commit f35de294eaebcbe5aecd824b444d1d901777814a, no merge conflicts. Setting status of f35de294eaebcbe5aecd824b444d1d901777814a to PENDING with url https://rpc.jenkins.cit.rackspace.net/job/RPC-Pull-Request-Issue-Link_rpc_gating/1814/ and message: 'Build started sha1 is merged.' Using context: CIT/issue-link Running in Durability level: PERFORMANCE_OPTIMIZED [Pipeline] library Loading library rpc-gating@origin/pr/719/merge Attempting to resolve origin/pr/719/merge from remote references... > git --version # timeout=10 using GIT_ASKPASS to set credentials github_account_rpc_jenkins_svc > git ls-remote https://github.com/rcbops/rpc-gating.git # timeout=10 Could not find origin/pr/719/merge in remote references. Pulling heads to local for deep search... > git rev-parse --is-inside-work-tree # timeout=10 Setting origin to https://github.com/rcbops/rpc-gating.git > git config remote.origin.url https://github.com/rcbops/rpc-gating.git # timeout=10 Fetching origin... Fetching upstream changes from origin > git --version # timeout=10 using GIT_ASKPASS to set credentials github_account_rpc_jenkins_svc > git fetch --tags --progress origin +refs/heads/*:refs/remotes/origin/* +refs/origin/pull/*/merge:refs/remotes/origin/origin/pull/*/merge > git rev-parse origin/pr/719/merge^{commit} # timeout=10 > git branch -a -v --no-abbrev --contains 10939c10d74f2284e1078a7371d49587d71858a1 # timeout=10 Selected match: pr/719/merge revision 10939c10d74f2284e1078a7371d49587d71858a1 > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/rcbops/rpc-gating.git # timeout=10 Fetching without tags Fetching upstream changes from https://github.com/rcbops/rpc-gating.git > git --version # timeout=10 using GIT_ASKPASS to set credentials github_account_rpc_jenkins_svc > git fetch --no-tags --progress https://github.com/rcbops/rpc-gating.git +refs/heads/*:refs/remotes/origin/* +refs/origin/pull/*/merge:refs/remotes/origin/origin/pull/*/merge JENKINS-19022: warning: possible memory leak due to Git plugin usage; see: https://wiki.jenkins-ci.org/display/JENKINS/Remove+Git+Plugin+BuildsByBranch+BuildData Checking out Revision 10939c10d74f2284e1078a7371d49587d71858a1 (pr/719/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 10939c10d74f2284e1078a7371d49587d71858a1 Commit message: "Merge f35de294eaebcbe5aecd824b444d1d901777814a into b0359387d639b5d7df8267f4fa09c0bba798a286" > git rev-list --no-walk 1ab31cb8abfe1386c699bf6fbdb406f8105af82d # timeout=10
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title Hugh Saunders updated an issue Jenkins / JENKINS-48061 git plugin 3.6.4 regression with shared libraries Change By: Hugh Saunders Attachment: Screen Shot 2018-04-23 at 11.20.22.png Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title
Hugh Saunders edited a comment on JENKINS-48061
Re: git plugin 3.6.4 regression with shared libraries
Hey [~markewaite], I built [~rsandell]'s branch at 887ac3394c48e844147de591277a0457adb345a3 but it didn't solve my problem. Version:{code:java}Git pluginThis plugin integrates Git with Jenkins.3.8.1-SNAPSHOT (private-887ac339-hughsaunders) Downgrade to 3.6.3{code}Console:{code:java}GitHub pull request #719 of commit f35de294eaebcbe5aecd824b444d1d901777814a, no merge conflicts.Setting status of f35de294eaebcbe5aecd824b444d1d901777814a to PENDING with url https://rpc.jenkins.cit.rackspace.net/job/RPC-Pull-Request-Issue-Link_rpc_gating/1806/ and message: 'Build started sha1 is merged.'Using context: CIT/issue-linkRunning in Durability level: PERFORMANCE_OPTIMIZED[Pipeline] libraryLoading library rpc-gating@origin/pr/719/mergeAttempting to resolve origin/pr/719/merge from remote references... > git --version # timeout=10using GIT_ASKPASS to set credentials github_account_rpc_jenkins_svc > git ls-remote -h https://github.com/rcbops/rpc-gating.git # timeout=10Could not find origin/pr/719/merge in remote references. Pulling heads to local for deep search... > git rev-parse --is-inside-work-tree # timeout=10Setting origin to https://github.com/rcbops/rpc-gating.git > git config remote.origin.url https://github.com/rcbops/rpc-gating.git # timeout=10Fetching origin...Fetching upstream changes from origin > git --version # timeout=10using GIT_ASKPASS to set credentials github_account_rpc_jenkins_svc > git fetch --tags --progress origin +refs/heads/*:refs/remotes/origin/* +refs/pull/*:refs/heads/origin/pr/* > git rev-parse origin/pr/719/merge^{commit} # timeout=10 > git branch -a -v --no-abbrev --contains 10939c10d74f2284e1078a7371d49587d71858a1 # timeout=10Could not find a branch containing commit 10939c10d74f2284e1078a7371d49587d71858a1[Pipeline] End of Pipeline[BFA] Scanning build for known causes...[BFA] No failure causes found[BFA] Done. 0sSetting status of f35de294eaebcbe5aecd824b444d1d901777814a to FAILURE with url https://rpc.jenkins.cit.rackspace.net/job/RPC-Pull-Request-Issue-Link_rpc_gating/1806/ and message: 'Build finished. 'Using context: CIT/issue-linkERROR: No version origin/pr/719/merge found for library rpc-gatingFinished: FAILURE{code}Its frustrating because the ref is obviously valid as{code:java} git rev-parse origin/pr/719/merge^{commit}{code}successfully translates it to a SHA. As before, when running the commands manually, a branch is found:{code:java}10:08 $ git fetch --tags --progress origin +refs/heads/*:refs/remotes/origin/* +refs/pull/*:refs/heads/origin/pr/*remote: Counting objects: 1319, done.remote: Compressing objects: 100% (12/12), done.remote: Total 1319 (delta 755), reused 753 (delta 752), pack-reused 555Receiving objects: 100% (1319/1319), 232.31 KiB | 1.40 MiB/s, done.Resolving deltas: 100% (830/830), completed with 453 local objects.From github.com:rcbops/rpc-gating* [new ref] refs/pull/1/head -> origin/pr/1/head* [new ref] refs/pull/10/head -> origin/pr/10/head* [new ref] refs/pull/100/head -> origin/pr/100/head...10:08 $ git branch -a -v --no-abbrev --contains 10939c10d74f2284e1078a7371d49587d71858a1origin/pr/719/merge 10939c10d74f2284e1078a7371d49587d71858a1 Merge f35de294eaebcbe5aecd824b444d1d901777814a into b0359387d639b5d7df8267f4fa09c0bba798a286{code}
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title
Hugh Saunders commented on JENKINS-48061
Re: git plugin 3.6.4 regression with shared libraries
Hey Mark Waite, I built rsandell's branch at 887ac3394c48e844147de591277a0457adb345a3 but it didn't solve my problem. Version:
Git plugin
This plugin integrates Git with Jenkins.
3.8.1-SNAPSHOT (private-887ac339-hughsaunders)
Downgrade to 3.6.3
Console:
GitHub pull request #719 of commit f35de294eaebcbe5aecd824b444d1d901777814a, no merge conflicts.
Setting status of f35de294eaebcbe5aecd824b444d1d901777814a to PENDING with url https://rpc.jenkins.cit.rackspace.net/job/RPC-Pull-Request-Issue-Link_rpc_gating/1806/ and message: 'Build started sha1 is merged.'
Using context: CIT/issue-link
Running in Durability level: PERFORMANCE_OPTIMIZED
[Pipeline] library
Loading library rpc-gating@origin/pr/719/merge
Attempting to resolve origin/pr/719/merge from remote references...
> git --version # timeout=10
using GIT_ASKPASS to set credentials github_account_rpc_jenkins_svc
> git ls-remote -h https://github.com/rcbops/rpc-gating.git # timeout=10
Could not find origin/pr/719/merge in remote references. Pulling heads to local for deep search...
> git rev-parse --is-inside-work-tree # timeout=10
Setting origin to https://github.com/rcbops/rpc-gating.git
> git config remote.origin.url https://github.com/rcbops/rpc-gating.git # timeout=10
Fetching origin...
Fetching upstream changes from origin
> git --version # timeout=10
using GIT_ASKPASS to set credentials github_account_rpc_jenkins_svc
> git fetch --tags --progress origin +refs/heads/*:refs/remotes/origin/* +refs/pull/*:refs/heads/origin/pr/*
> git rev-parse origin/pr/719/merge^{commit} # timeout=10
> git branch -a -v --no-abbrev --contains 10939c10d74f2284e1078a7371d49587d71858a1 # timeout=10
Could not find a branch containing commit 10939c10d74f2284e1078a7371d49587d71858a1
[Pipeline] End of Pipeline
[BFA] Scanning build for known causes...
[BFA] No failure causes found
[BFA] Done. 0s
Setting status of f35de294eaebcbe5aecd824b444d1d901777814a to FAILURE with url https://rpc.jenkins.cit.rackspace.net/job/RPC-Pull-Request-Issue-Link_rpc_gating/1806/ and message: 'Build finished. '
Using context: CIT/issue-link
ERROR: No version origin/pr/719/merge found for library rpc-gating
Finished: FAILURE
Its frustrating because the ref is obviously valid as
git rev-parse origin/pr/719/merge^{commit}
successfully translates it to a SHA.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title Mark Waite commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Hugh Saunders and Michael Krotscheck I would appreciate very much if you would test drive the plugin build from the pull request in your environments, with the additional trait "Discover other refs" as advised by rsandell . It worked for Robin Smith and I hope you can confirm that it works for you as well. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title
Hugh Saunders commented on JENKINS-48061
Re: git plugin 3.6.4 regression with shared libraries
In the code added in 3.6.4 there are 6 cases laid out for resolving the version, they are:
branch (or SHA that it points to)
tag (or SHA that it points to)
SHA
(Abbreviated SHAs are also covered) The option thats conspicuously absent is a ref that isn't a branch, tag or SHA. A SHA is a direct object hash, a branch is a ref under refs/heads or refs/remotes/*/ and a Tag is a ref under refs/tags So where does a ref that isn't under heads, remotes or tags fit in? for example:
refs/pull/90/merge
Note that this type of ref used to work, with the appropriate refspec in global config. I use
+refs/pull/*:refs/remotes/@{remote}/pr/*
and
+refs/heads/*:refs/remotes/@{remote}/*
Successful log (old version, sorry I don't know the exact version, I know thats super unhelpful.):
GitHub pull request #705 of commit c5d1bbcf93933149cfd705f029c62d7da6926820, no merge conflicts.
Setting status of c5d1bbcf93933149cfd705f029c62d7da6926820 to PENDING with url https://rpc.jenkins.cit.rackspace.net/job/RPC-Pull-Request-Issue-Link_rpc_gating/1768/ and message: 'Build started sha1 is merged.'
Using context: CIT/issue-link
Running in Durability level: PERFORMANCE_OPTIMIZED
[Pipeline] library
Loading library rpc-gating@origin/pr/705/merge
Attempting to resolve origin/pr/705/merge from remote references...
> git --version # timeout=10
using GIT_ASKPASS to set credentials github_account_rpc_jenkins_svc
> git ls-remote -h -t https://github.com/rcbops/rpc-gating.git # timeout=10
Could not find origin/pr/705/merge in remote references. Pulling heads to local for deep search...
> git rev-parse --is-inside-work-tree # timeout=10
Setting origin to https://github.com/rcbops/rpc-gating.git
> git config remote.origin.url https://github.com/rcbops/rpc-gating.git # timeout=10
Fetching origin...
Fetching upstream changes from origin
> git --version # timeout=10
using GIT_ASKPASS to set credentials github_account_rpc_jenkins_svc
> git fetch --tags --progress origin +refs/heads/*:refs/remotes/origin/* +refs/pull/*:refs/heads/origin/pr/*
> git rev-parse origin/pr/705/merge^{commit} # timeout=10
> git branch -v --no-abbrev --contains bc2e7318899dab969fd1453a298f0682d540b850 # t
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title
Michael Krotscheck edited a comment on JENKINS-48061
Re: git plugin 3.6.4 regression with shared libraries
Well, the short answer is no: I can't set up a whole public infrastructure for you that will allow you to test this use case. I mucked around to see if I can get a similar effect by trying this, however I can't seem to get the GIT_COMMIT environment variable into the declarative pipeline itself - that's probably an artifact of the Gerrit plugin and how it assigns a trigger events' parameters to a job.{{libraries \{}}{{ lib("kangaroo-jenkins@$\{env.GIT_COMMIT}")}}{{}}}But, what I _can_ do, is tell you where the "bug" is and the appropriate gerrit workaround. The issue seems to be in AbstractGitSCMSource around 'Could not find a branch containing' The assumption the plugin makes is that remote branches will _all_ live under refs/remotes/$\{context}/, and filters out anything else. As such, gerritt's usage of `refs/changes/` etc is entirely ignored.The workaround is - when declaring the library in jenkins - to also include the following refspec mappings. In our case, we're doing this in the System Library Configuration:{code:java}+refs/heads/*:refs/remotes/@{remote}/* # Remote master, for regular library usage.+refs/changes/*:refs/changes/* # So that rev-parse works on gerrit refspec parameters.+refs/changes/*:refs/remotes/@{remote}/changes/* # To bypass the filter exclusion in AbstractGitSCMSource{code}The above makes the current plugin work for me (And now I know far more about refspecs than I ever wanted). {color:#ff}EDIT: {color:#33}Also, I don't see why this couldn't work for bitbucket, github, etc. Others would have to confirm that though.{color}{color}
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title
Michael Krotscheck commented on JENKINS-48061
Re: git plugin 3.6.4 regression with shared libraries
Well, the short answer is no: I can't set up a whole public infrastructure for you that will allow you to test this use case. I mucked around to see if I can get a similar effect by trying this, however I can't seem to get the GIT_COMMIT environment variable into the declarative pipeline itself - that's probably an artifact of the Gerrit plugin and how it assigns a trigger events' parameters to a job. libraries { lib("kangaroo-jenkins@${env.GIT_COMMIT}") } But, what I can do, is tell you where the "bug" is and the appropriate gerrit workaround. The issue seems to be in AbstractGitSCMSource around 'Could not find a branch containing' The assumption the plugin makes is that remote branches will all live under refs/remotes/${context}/, and filters out anything else. As such, gerritt's usage of `refs/changes/` etc is entirely ignored. The workaround is - when declaring the library in jenkins - to also include the following refspec mappings. In our case, we're doing this in the System Library Configuration:
+refs/heads/*:refs/remotes/@{remote}/* # Remote master, for regular library usage.
+refs/changes/*:refs/changes/* # So that rev-parse works on gerrit refspec parameters.
+refs/changes/*:refs/remotes/@{remote}/changes/* # To bypass the filter exclusion in AbstractGitSCMSource
The above makes the current plugin work for me (And now I know far more about refspecs than I ever wanted).
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title Mark Waite commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Michael Krotscheck can you provide detailed steps that describe your working case, preferably using a public repository and without requiring that I install and configure a Gerrit server? I can't verify it works (or fails) at the moment, because it is not apparent to me how to duplicate the case you're describing. I could spend hours guessing, with the risk of wrong guesses, or I could follow steps you provide to reduce my guessing. I appreciate the desire to have the gerrit use case work, but I'm not yet sure that the gerrit use case should be done as a standard part of the plugin, rather than as an extension point that is enabled by installing an additional plugin to implement that extension. The more we can explore the use case you've been using, the better we are able to understand the best location to modify. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title
Michael Krotscheck commented on JENKINS-48061
Re: git plugin 3.6.4 regression with shared libraries
Another +1 here for the gerrit use case. We run our shared jenkins groovy library through CI/CD testing before merging to master, to make sure we don't introduce regressions. That requires checking out either based on the gerrit refspec (`refs/changes/*`) or directly on the sha from one of those refspecs. Neither of these works anymore. Our current system jenkins library configuration for refspecs is:
+refs/heads/:refs/remotes/@{remote}/
+refs/changes/:refs/changes/
Relevant log output: using GIT_SSH to set credentials Key to access gerrit > git fetch --tags --progress origin +refs/heads/:refs/remotes/origin/ +refs/changes/:refs/changes/ > git rev-parse refs/changes/58/30058/11^{commit} # timeout=10 > git branch -a -v --no-abbrev --contains d471affea1e4847a3d06d974e373632181ff5872 # timeout=10 Could not find a branch containing commit d471affea1e4847a3d06d974e373632181ff5872 I've played around with various different refspec structures, but nothing obvious seems to work.
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title
Robin Smith commented on JENKINS-48061
Re: git plugin 3.6.4 regression with shared libraries
Mark Waite rsandell I still have the same problem, after installing that plugin:
> git fetch --tags --progress origin +refs/heads/*:refs/remotes/origin/* +refs/pull-requests/*/from:refs/remotes/origin/pr/*
> git rev-parse pr/33^{commit} # timeout=10
ERROR: Could not resolve pr/33
hudson.plugins.git.GitException: Command "git rev-parse pr/33^{commit}" returned status code 128:
stdout: pr/33^{commit}
stderr: fatal: ambiguous argument 'pr/33^{commit}': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git [...] -- [...]'
at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1996)
at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1964)
at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1960)
at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1597)
at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1609)
at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.revParse(CliGitAPIImpl.java:794)
at hudson.plugins.git.GitAPI.revParse(GitAPI.java:316)
at jenkins.plugins.git.AbstractGitSCMSource$10.run(AbstractGitSCMSource.java:859)
at jenkins.plugins.git.AbstractGitSCMSource$10.run(AbstractGitSCMSource.java:853)
at jenkins.plugins.git.AbstractGitSCMSource.doRetrieve(AbstractGitSCMSource.java:352)
at jenkins.plugins.git.AbstractGitSCMSource.retrieve(AbstractGitSCMSource.java:853)
at jenkins.scm.api.SCMSource.fetch(SCMSource.java:598)
at org.jenkinsci.plugins.workflow.libs.SCMSourceRetriever.retrieve(SCMSourceRetriever.java:80)
at org.jenkinsci.plugins.workflow.libs.LibraryAdder.retrieve(LibraryAdder.java:153)
at org.jenkinsci.plugins.workflow.libs.LibraryAdder.add(LibraryAdder.java:134)
at org.jenkinsci.plugins.workflow.libs.LibraryDecorator$1.call(LibraryDecorator.java:125)
at org.codehaus.groovy.control.CompilationUnit.applyToPrimaryClassNodes(CompilationUnit.java:1065)
at org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:603)
at org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:581)
at org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:558)
at groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader.java:298)
at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:268)
at groovy.lang.GroovyShell.parseClass(GroovyShell.java:688)
at groovy.lang.GroovyShell.parse(GroovyShell.java:700)
at org.jenkinsci.plugins.workflow.cps.CpsGroovyShell.doParse(CpsGroovyShell.java:129)
at org.jenkinsci.plugins.workflow.cps.CpsGroovyShell.reparse(CpsGroovyShell.java:123)
at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.parseScript(CpsFlowExecution.java:517)
at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.start(CpsFlowExecution.java:480)
at org.jenkinsci.plugins.workflow.job.WorkflowRun.run(WorkflowRun.java:269)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:421)
ERROR: No version pr/33 found for library forgerock-pipeline-libs
org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
WorkflowScript: Loading libraries failed
1 error
at org.codehaus.groovy.control.ErrorCollector.failIfErrors(ErrorCollector.java:310)
at org.codehaus.groovy.control.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title Robin Smith commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Thanks Mark Waite, I'll do that now! Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title Mark Waite commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Robin Smith you can test the plugin containing the pull request in your environment and help assure that everyone understands the fix. If you can do that, please also report your results on the pull request. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title Robin Smith edited a comment on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries [~rsandell] will your changes fix loading shared libraries from a Bitbucket PR? Or should I raise a separate issue for that? It was [ possible to [ do this|https://issues.jenkins-ci.org/browse/JENKINS-48061?focusedCommentId=327443&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-327443] until version 3.6.4 of the plugin Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title Robin Smith commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries rsandell will your changes fix loading shared libraries from a Bitbucket PR? Or should I raise a separate issue for that? It was possible to do this until version 3.6.4 of the plugin Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title rsandell updated JENKINS-48061 Jenkins / JENKINS-48061 git plugin 3.6.4 regression with shared libraries Change By: rsandell Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title Sorin Sbarnea commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Few minutes ago I raised https://issues.jenkins-ci.org/browse/JENKINS-50433 which states that there is no way to tell git plugin to pull gerrit branches because there is no way to convince it to remove "-h" from "git ls-remote". Any tricks/workarounds to make this work? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title Mark Waite commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Thanks Bill Hamilton! Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title Bill Hamilton commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Mark WaiteStephen Connolly Guys, I just want to confirm the use cases that should be tested around this: Both the @Library directive, and the library() DSL step, should insure that specifying branches, PRs, tags, and hashes all work Thanks, -Bill Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title Bill Hamilton commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Stephen Connolly Stephen, I did have it configured as GitHub...BUT, I also had a preceding PSL defined using Git, so they seemed to have conflicted. So I removed the preceding. I also tweaked the settings to be inline with yours. And finally I realized that one of our masters had an older version of GH Branch Source Plugin, it was 2.2.6 and needed 2.3.2. So I think we are all set, thank you Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title Stephen Connolly commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries Bill Hamilton respectfully but those console log lines are coming from GitSCMSource not GitHubSCMSource... For example... When I configure the shared library to use GitHubSCMSource, e.g. like this: I get a console log like this: Conversely, when I configure the shared library to use GitSCMSource, e.g. like this: I get a console log like this:Specifically the highlighted text Attempting to resolve PR-2 from remote references... > git --version # timeout=10 > git ls-remote -h -t https://github.com/cloudbeers/multibranch-demo-lib.git # timeout=10 Can only come from GitSCMSource as GitHubSCMSource does not invoke the super method So are you absolutely sure you have configured to use the GitHubSCMSource? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title Stephen Connolly updated an issue Jenkins / JENKINS-48061 git plugin 3.6.4 regression with shared libraries Change By: Stephen Connolly Attachment: Screen Shot 2018-03-08 at 09.35.06.png Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title Stephen Connolly updated an issue Jenkins / JENKINS-48061 git plugin 3.6.4 regression with shared libraries Change By: Stephen Connolly Attachment: Screen Shot 2018-03-08 at 09.34.32.png Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title Stephen Connolly updated an issue Jenkins / JENKINS-48061 git plugin 3.6.4 regression with shared libraries Change By: Stephen Connolly Attachment: Screen Shot 2018-03-08 at 09.33.55.png Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title Stephen Connolly updated an issue Jenkins / JENKINS-48061 git plugin 3.6.4 regression with shared libraries Change By: Stephen Connolly Attachment: image-2018-03-08-09-35-47-511.png Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title
Bill Hamilton edited a comment on JENKINS-48061
Re: git plugin 3.6.4 regression with shared libraries
[~stephenconnolly] Stephen, I am using GitHib as the SCM for the shared library configuration. And none of the following work:library("PSL@pr-111")library("PSL@PR-111")This all worked before we upgraded to Jenkins 2.89.I added +refs/pull/ \ */head:refs/remotes/origin/ \ * to the PSL Git refspec, since I noticed it was missing from the fetch. But it still doesnt work.Here is the log output if that helps:Loading library PSL@PR-111Attempting to resolve PR-111 from remote references... > git --version # timeout=30using GIT_ASKPASS to set credentials ORS folder scan user > git ls-remote -h -t https://git.autodesk.com/Pipeline-Community/PSL.git # timeout=30Could not find PR-111 in remote references. Pulling heads to local for deep search... > git rev-parse --is-inside-work-tree # timeout=30Setting origin to https://git.autodesk.com/Pipeline-Community/PSL.git > git config remote.origin.url https://git.autodesk.com/Pipeline-Community/PSL.git # timeout=30Fetching origin...Fetching upstream changes from origin > git --version # timeout=30using GIT_ASKPASS to set credentials ORS folder scan user > git fetch --tags --progress origin +refs/heads/ \ *:refs/remotes/origin/ \ * +refs/pull/ \ */head:refs/remotes/origin/ \ * > git rev-parse PR-111^\{commit} # timeout=30ERROR: Could not resolve PR-111hudson.plugins.git.GitException: Command "git rev-parse PR-111^\{commit}" returned status code 128:stdout: PR-111^\{commit}
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title
Bill Hamilton commented on JENKINS-48061
Re: git plugin 3.6.4 regression with shared libraries
Stephen Connolly Stephen, I am using GitHib as the SCM for the shared library configuration. And none of the following work: library("PSL@pr-111") library("PSL@PR-111") This all worked before we upgraded to Jenkins 2.89. I added +refs/pull//head:refs/remotes/origin/ to the PSL Git refspec, since I noticed it was missing from the fetch. But it still doesnt work. Here is the log output if that helps: Loading library PSL@PR-111 Attempting to resolve PR-111 from remote references... > git --version # timeout=30 using GIT_ASKPASS to set credentials ORS folder scan user > git ls-remote -h -t https://git.autodesk.com/Pipeline-Community/PSL.git # timeout=30 Could not find PR-111 in remote references. Pulling heads to local for deep search... > git rev-parse --is-inside-work-tree # timeout=30 Setting origin to https://git.autodesk.com/Pipeline-Community/PSL.git > git config remote.origin.url https://git.autodesk.com/Pipeline-Community/PSL.git # timeout=30 Fetching origin... Fetching upstream changes from origin > git --version # timeout=30 using GIT_ASKPASS to set credentials ORS folder scan user > git fetch --tags --progress origin +refs/heads/:refs/remotes/origin/ +refs/pull//head:refs/remotes/origin/ > git rev-parse PR-111^{commit} # timeout=30 ERROR: Could not resolve PR-111 hudson.plugins.git.GitException: Command "git rev-parse PR-111^{commit}" returned status code 128: stdout: PR-111^{commit}
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to th
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title rsandell assigned an issue to rsandell Jenkins / JENKINS-48061 git plugin 3.6.4 regression with shared libraries Change By: rsandell Assignee: Stephen Connolly rsandell Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title Robin Smith commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries If the pipeline shared libraries are in Bitbucket, it's necessary to use Git to load them. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title Stephen Connolly commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L1163-L1218 matches PR-... https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L1219-L1226 matches branches https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L1227-L1254 matches tags Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title Stephen Connolly commented on JENKINS-48061 Re: git plugin 3.6.4 regression with shared libraries The only issue with using GitHub Branch Source is that you cannot checkout shared libraries by hash as https://github.com/jenkinsci/git-plugin/blob/master/src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java#L782-L804 does not implement hash resolution. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title
Stephen Connolly commented on JENKINS-48061
Re: git plugin 3.6.4 regression with shared libraries
If you want to checkout pull requests, why are you using Git for the pipeline shared library... Something like: Should allow checking out the shared library by PR, e.g. library("PSL@pr-111") should checkout the PR.
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title Stephen Connolly updated an issue Jenkins / JENKINS-48061 git plugin 3.6.4 regression with shared libraries Change By: Stephen Connolly Attachment: Screen Shot 2018-03-05 at 21.58.01.png Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title
Bill Hamilton edited a comment on JENKINS-48061
Re: git plugin 3.6.4 regression with shared libraries
[~markewaite], I want to echo [~xxthunder] and [~robin_smith]. I too want to test PSL changes. The Jenkinsfile in my PSL PR does:_def utils_pkg=library("PSL@$\{branch}").ors.utils_where branch is determined at runtime, and could be a PR build. So I expanded the refspec in the PSL configuration to this:_+refs/pull/*/head:refs/remotes/@\{remote}/pr/*_so when the build for my PR111 executes it is calling:_def utils_pkg=library("PSL@pr/111").ors.utils_This fails, with this output: > git fetch --tags --progress origin +refs/heads/*:refs/remotes/origin/* +refs/pull/*/head:refs/remotes/origin/pr/* > git rev-parse origin/pr/111^\{commit} # timeout=30 > git branch -v --no-abbrev --contains f39b737d67b11218dad26756e7c4b1f5900ff037 # timeout=30Could not find a branch containing commit f39b737d67b11218dad26756e7c4b1f5900ff037 Also, I wouldnt consider this a minor bug. This is breaks our ability to unit test code changes to our PSL library, which is used by hundreds of customers in our organization. We have trained them to contribute to our PSL library via PRs. But all of the PRs they file fail because of this regression.
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48061) git plugin 3.6.4 regression with shared libraries
Title: Message Title
Bill Hamilton commented on JENKINS-48061
Re: git plugin 3.6.4 regression with shared libraries
Mark Waite, I want to echo Karsten Günther and Robin Smith. I too want to test PSL changes. The Jenkinsfile in my PSL PR does: def utils_pkg=library("PSL@${branch}").ors.utils where branch is determined at runtime, and could be a PR build. So I expanded the refspec in the PSL configuration to this: +refs/pull//head:refs/remotes/@{remote}/pr/ so when the build for my PR111 executes it is calling: def utils_pkg=library("PSL@pr/111").ors.utils This fails, with this output: > git fetch --tags --progress origin +refs/heads/:refs/remotes/origin/ +refs/pull//head:refs/remotes/origin/pr/ > git rev-parse origin/pr/111^{commit} # timeout=30 > git branch -v --no-abbrev --contains f39b737d67b11218dad26756e7c4b1f5900ff037 # timeout=30 Could not find a branch containing commit f39b737d67b11218dad26756e7c4b1f5900ff037
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
