[JIRA] (JENKINS-49691) FilePath.installIfNecessaryFrom always download even if target already exists
Title: Message Title
Cyril MARIN created an issue
Jenkins / JENKINS-49691
FilePath.installIfNecessaryFrom always download even if target already exists
Issue Type:
Bug
Assignee:
Unassigned
Components:
core
Created:
2018-02-22 10:48
Environment:
2.89.4 (lts)
Labels:
jenkins tools
Priority:
Minor
Reporter:
Cyril MARIN
FilePath.installIfNecessaryFrom, used from ZipExtractionInstaller, is designed to check if target already exists before downloading from remote URL. But I observe that every time I run the build job, the tool is downloaded from remote URL even if the files exists in local $JENKINS_HOME/tools directory. No exception raised while processing. Simple test pipeline to reproduce issue:
pipeline {
agent any
tools {
maven "M3"
jdk "JDK8_161"
}
stages {
stage('Test') {
steps {
echo 'Testing..'
}
}
}
}
*Job output logs for this example *:
[Pipeline] node Running on Jenkins in /var/jenkins_home/workspace/test [Pipeline] { [Pipeline] stage [Pipeline] { (Declarative: Tool Install) [Pipeline] tool [Pipeline] envVarsForTool [Pipeline] tool Unpacking https://.box.co
[JIRA] (JENKINS-49691) FilePath.installIfNecessaryFrom always download even if target already exists
Title: Message Title Cyril MARIN commented on JENKINS-49691 Re: FilePath.installIfNecessaryFrom always download even if target already exists A little précision : My tools are hosted on a Box.com repository with a public static URL. Maybe there is a trouble with Box hosting. Http headers may not contain "last-modified" for some reason. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49691) FilePath.installIfNecessaryFrom always download even if target already exists
Title: Message Title Oleg Nenashev updated an issue Jenkins / JENKINS-49691 FilePath.installIfNecessaryFrom always download even if target already exists Change By: Oleg Nenashev Labels: jenkins newbie-friendly tools Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49691) FilePath.installIfNecessaryFrom always download even if target already exists
Title: Message Title C R commented on JENKINS-49691 Re: FilePath.installIfNecessaryFrom always download even if target already exists Hi Cyril MARIN I looked at the code and you're right. The "last-modified" http header is missing. Now, we could add a condition to check if the "file exists locally and http header missing" then skip download, but this is wrong because if the remote file is updated, Jenkins will not download the fresh copy and assume we already have the updated copy. So I think this issue should be closed since the problem lies outside Jenkins. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49691) FilePath.installIfNecessaryFrom always download even if target already exists
Title: Message Title Sam Hrncir assigned an issue to Sam Hrncir Jenkins / JENKINS-49691 FilePath.installIfNecessaryFrom always download even if target already exists Change By: Sam Hrncir Assignee: Sam Hrncir Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.188626.1519296535000.7727.1576425840163%40Atlassian.JIRA.
[JIRA] (JENKINS-49691) FilePath.installIfNecessaryFrom always download even if target already exists
Title: Message Title Sam Hrncir assigned an issue to Unassigned Jenkins / JENKINS-49691 FilePath.installIfNecessaryFrom always download even if target already exists Change By: Sam Hrncir Assignee: Sam Hrncir Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.188626.1519296535000.19991.1588257660484%40Atlassian.JIRA.
