[JIRA] (JENKINS-49983) NullPointerException from gerrit plugin due to lack of configuration
Title: Message Title lucamilanesio updated JENKINS-49983 Jenkins / JENKINS-49983 NullPointerException from gerrit plugin due to lack of configuration Change By: lucamilanesio Status: In Review Closed Resolution: Fixed Released As: gerrit-code-review-0.2 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49983) NullPointerException from gerrit plugin due to lack of configuration
Title: Message Title lucamilanesio started work on JENKINS-49983 Change By: lucamilanesio Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49983) NullPointerException from gerrit plugin due to lack of configuration
Title: Message Title lucamilanesio updated JENKINS-49983 Jenkins / JENKINS-49983 NullPointerException from gerrit plugin due to lack of configuration Change By: lucamilanesio Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49983) NullPointerException from gerrit plugin due to lack of configuration
Title: Message Title lucamilanesio commented on JENKINS-49983 Re: NullPointerException from gerrit plugin due to lack of configuration PR with the fix available at: https://github.com/jenkinsci/gerrit-code-review-plugin/pull/14 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49983) NullPointerException from gerrit plugin due to lack of configuration
Title: Message Title lucamilanesio commented on JENKINS-49983 Re: NullPointerException from gerrit plugin due to lack of configuration Stephen Connolly agreed, let me fix this in the Gerrit plugin and just display a warning that feedback cannot be sent to Gerrit because of missing credentials. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49983) NullPointerException from gerrit plugin due to lack of configuration
Title: Message Title Stephen Connolly assigned an issue to lucamilanesio Jenkins / JENKINS-49983 NullPointerException from gerrit plugin due to lack of configuration Change By: Stephen Connolly Assignee: Stephen Connolly lucamilanesio Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49983) NullPointerException from gerrit plugin due to lack of configuration
Title: Message Title
Stephen Connolly commented on JENKINS-49983
Re: NullPointerException from gerrit plugin due to lack of configuration
Oleg Nenashev did you even look at the line in the credentials plugin: https://github.com/jenkinsci/credentials-plugin/blob/845bb7946a53650da1eeb457152d4296eaeb58c5/src/main/java/com/cloudbees/plugins/credentials/CredentialsProvider.java#L874
public static extends IdCredentials> C findCredentialById(@NonNull String id, @NonNull Class type,
@NonNull Run run,
@Nullable List domainRequirements) {
id.getClass(); // throw NPE if null;
It's the id.getClass(); // throw NPE if null line that is verifing the @NonNull contract on the id parameter. Nothing to do with the credentials plugin. If somebody passes null to a @NonNull parameter, the person doing the passing is the root cause... not the credentials plugin.
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49983) NullPointerException from gerrit plugin due to lack of configuration
Title: Message Title Stephen Connolly updated an issue Jenkins / JENKINS-49983 NullPointerException from gerrit plugin due to lack of configuration Change By: Stephen Connolly Component/s: credentials-plugin Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49983) NullPointerException from gerrit plugin due to lack of configuration
Title: Message Title Sorin Sbarnea commented on JENKINS-49983 Re: NullPointerException from gerrit plugin due to lack of configuration This happens when you configure gerrit without authetication, which is ok for reading until you attempt to add a comment. The normal behaviour would be to have a clear message that sounds like "Failed to perform xxx as this requires authentication" instead NullPointerException stacktrace. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49983) NullPointerException from gerrit plugin due to lack of configuration
Title: Message Title Sorin Sbarnea updated an issue Jenkins / JENKINS-49983 NullPointerException from gerrit plugin due to lack of configuration Change By: Sorin Sbarnea Priority: Critical Minor Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49983) NullPointerException from gerrit plugin due to lack of configuration
Title: Message Title Oleg Nenashev commented on JENKINS-49983 Re: NullPointerException from gerrit plugin due to lack of configuration Sounds to be a credentials issue actually Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49983) NullPointerException from gerrit plugin due to lack of configuration
Title: Message Title Oleg Nenashev updated an issue Jenkins / JENKINS-49983 NullPointerException from gerrit plugin due to lack of configuration Change By: Oleg Nenashev Component/s: credentials-plugin Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49983) NullPointerException from gerrit plugin due to lack of configuration
Title: Message Title Oleg Nenashev assigned an issue to Stephen Connolly Jenkins / JENKINS-49983 NullPointerException from gerrit plugin due to lack of configuration Change By: Oleg Nenashev Assignee: lucamilanesio Stephen Connolly Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49983) NullPointerException from gerrit plugin due to lack of configuration
Title: Message Title Sorin Sbarnea created an issue Jenkins / JENKINS-49983 NullPointerException from gerrit plugin due to lack of configuration Issue Type: Task Assignee: lucamilanesio Components: gerrit-plugin Created: 2018-03-07 12:17 Priority: Critical Reporter: Sorin Sbarnea It seems that the most basic use case of gerrit plugin documented at https://wiki.jenkins.io/display/JENKINS/Gerrit+Code+Review+Plugin does not mention how the user is supposed to configure access to Gerrit server, or even to mention which Gerrit server should be used. java.lang.NullPointerException at com.cloudbees.plugins.credentials.CredentialsProvider.findCredentialById(CredentialsProvider.java:874) at com.cloudbees.plugins.credentials.CredentialsProvider.findCredentialById(CredentialsProvider.java:852) at org.jenkinsci.plugins.credentialsbinding.MultiBinding.getCredentials(MultiBinding.java:151) at org.jenkinsci.plugins.credentialsbinding.impl.UsernamePasswordMultiBinding.bind(UsernamePasswordMultiBinding.java:76) at org.jenkinsci.plugins.credentialsbinding.impl.BindingStep$Execution.start(BindingStep.java:114) at org.jenkinsci.plugins.workflow.cps.DSL.invokeStep(DSL.java:229) at org.jenkinsci.plugins.workflow.cps.DSL.invokeMethod(DSL.java:153) at org.jenkinsci.plugins.workflow.cps.CpsScript.invokeMethod(CpsScript.java:108) at org.codehaus.groovy.runtime.callsite.PogoMetaClassSite.call(PogoMetaClassSite.java:48) at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113) at com.cloudbees.groovy.cps.sandbox.DefaultInvoker.methodCall(DefaultInvoker.java:19) at jenkins.plugins.gerrit.workflow.Gerrit.post(jar:file:/var/lib/jenkins/plugins/gerrit/WEB-INF/lib/gerrit.jar!/jenkins/plugins/gerrit/w
