[JIRA] (JENKINS-50027) Polling build filters in jenkinsfile broken or need guidance on what code should be
Title: Message Title
Karl Wirth edited a comment on JENKINS-50027
Re: Polling build filters in jenkinsfile broken or need guidance on what code should be
Following Test code now works for polling and build:{code:java}filter: [viewFilter('''//test/main/workers'''){code} +Note:+ that if you use multiple 'viewFilter' entries the second will overwrite the first. In the example below only changes to 'workers2' will trigger a build.{code:java}filter: [viewFilter('''//test/main/workers'''),viewFilter('''//test/main/workers2''')]{code}The correct way to have multiple inclusions is to include a carriage return in the mapping and use 3 quotes.{code:java}filter: [viewFilter('''//test/main/workers//test/main/workers2''')]{code} *IMPORTANT NOTE*: This is +not+ Perforce syntax do do not use '...'. For example use '//test/main/workers' instead of '//test/main/workers/...'.
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50027) Polling build filters in jenkinsfile broken or need guidance on what code should be
Title: Message Title Paul Allen closed an issue as Fixed Released in 1.8.9 Jenkins / JENKINS-50027 Polling build filters in jenkinsfile broken or need guidance on what code should be Change By: Paul Allen Status: Resolved Closed Assignee: Paul Allen Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit
[JIRA] (JENKINS-50027) Polling build filters in jenkinsfile broken or need guidance on what code should be
Title: Message Title Paul Allen updated JENKINS-50027 Ready for release. Jenkins / JENKINS-50027 Polling build filters in jenkinsfile broken or need guidance on what code should be Change By: Paul Allen Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit
[JIRA] (JENKINS-50027) Polling build filters in jenkinsfile broken or need guidance on what code should be
Title: Message Title
Karl Wirth commented on JENKINS-50027
Re: Polling build filters in jenkinsfile broken or need guidance on what code should be
Following Test code now works for polling and build:
filter: [viewFilter('''//test/main/workers''')
Note: that if you use multiple 'viewFilter' entries the second will overwrite the first. In the example below only changes to 'workers2' will trigger a build.
filter: [viewFilter('''//test/main/workers'''),viewFilter('''//test/main/workers2''')]
The correct way to have multiple inclusions is to include a carriage return in the mapping and use 3 quotes.
filter: [viewFilter('''//test/main/workers
//test/main/workers2''')]
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
[JIRA] (JENKINS-50027) Polling build filters in jenkinsfile broken or need guidance on what code should be
Title: Message Title Paul Allen updated JENKINS-50027 Jenkins / JENKINS-50027 Polling build filters in jenkinsfile broken or need guidance on what code should be Change By: Paul Allen Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50027) Polling build filters in jenkinsfile broken or need guidance on what code should be
Title: Message Title Paul Allen updated an issue Jenkins / JENKINS-50027 Polling build filters in jenkinsfile broken or need guidance on what code should be Change By: Paul Allen Labels: P4_B P4_VERIFY Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50027) Polling build filters in jenkinsfile broken or need guidance on what code should be
Title: Message Title Paul Allen started work on JENKINS-50027 Change By: Paul Allen Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50027) Polling build filters in jenkinsfile broken or need guidance on what code should be
Title: Message Title SCM/JIRA link daemon commented on JENKINS-50027 Re: Polling build filters in jenkinsfile broken or need guidance on what code should be Code changed in jenkins User: Paul Allen Path: src/main/java/org/jenkinsci/plugins/p4/filters/FilterPatternListImpl.java src/main/resources/org/jenkinsci/plugins/p4/filters/FilterPatternListImpl/help-patternList.html src/main/resources/org/jenkinsci/plugins/p4/filters/FilterPatternListImpl/help-patternText.html http://jenkins-ci.org/commit/p4-plugin/0e986e8b9265b21d568287d1193ce13b03360d10 Log: Change Java Pattern polling filter name. The @Symbol name for the Java Pattern filter clashed with the View Mask filter. (minor) Renamed help file to match argument name. JENKINS-50027 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50027) Polling build filters in jenkinsfile broken or need guidance on what code should be
Title: Message Title
Karl Wirth commented on JENKINS-50027
Re: Polling build filters in jenkinsfile broken or need guidance on what code should be
A slight twist. Only happens if there are files that match the build filter. Repro case: (1) Create stream depot. (2) Add files in '//streams/main/workers'. (3) Create Jenkins job with following content:
pipeline {
agent {label 'master'}
stages {
stage('Sync code') {
steps {
echo "Starting"
checkout perforce(credential: 'MasterServer',
filter: [viewFilter(viewMask: '''//streams/main/workers''')],
populate: autoClean(delete: true, modtime: false,
parallel: [enable: false, minbytes: '1024', minfiles: '1', threads: '4'],
pin: '', quiet: false, replace: true, tidy: false),
workspace: streamSpec(charset: 'none',
format: 'jenkins-${NODE_NAME}-${JOB_NAME}-${EXECUTOR_NUMBER}',
pinHost: false, streamName: '//streams/main'))
}
}
}
(4) Run 'Build Now'. (5) Run 'Poll Now'. No errors in polling log.
Perforce Software Polling Log
Started on Apr 6, 2018 11:17:00 AM
P4: Polling on: master with:jenkins-master-FilteredPipeline-0
Found last change 417 on syncID jenkins-NODE_NAME-FilteredPipeline-EXECUTOR_NUMBER
... p4 client -o jenkins-master-FilteredPipeline-0 +
... p4 info +
P4 Task: establishing connection.
... server: 10.1.3.217:1666
... node: vm-kwirth-swarm174-xenial
P4: Polling with range: 417,now
... p4 changes -m20 //jenkins-master-FilteredPipeline-0/...@417,now +
... p4 repos -C +
Done. Took 0.11 sec
No changes
(6) Edit and submit //streams/main/workers/f1. (7) Run 'Poll Now'. Following errors seen:
Perforce Software Polling Log
Started on Apr 6, 2018 11:15:00 AM
P4: Polling on: master with:jenkins-master-FilteredPipeline-0
Found last change 415 on syncID jenkins-NODE_NAME-FilteredPipeline-EXECUTOR_NUMBER
... p4 client -o jenkins-master-FilteredPipeline-0 +
... p4 info +
P4 Task: establishing connection.
... server: 10.1.3.217:1666
... node: vm-kwirth-swarm174-xenial
P4: Polling with range: 415,now
... p4 changes -m20 //jenkins-master-FilteredPipeline-0/...@415,now +
... p4 change -o 417 +
... p4 describe -s 417 +
P4 Task: attempt: 1
P4 Task: failed: java.lang.NullPointerException
ERROR: polling failed in /var/lib/jenkins/workspace/FilteredPipeline on : P4 Task: failed: java.lang.NullPointerException
Done. Took 3.1 sec
No changes
(8) Error in Jenkins log:
P4 Task: attempt: 1
Apr 06, 2018 11:14:03 AM WARNING
[JIRA] (JENKINS-50027) Polling build filters in jenkinsfile broken or need guidance on what code should be
Title: Message Title Karl Wirth commented on JENKINS-50027 Re: Polling build filters in jenkinsfile broken or need guidance on what code should be Ping to keep this one visible. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50027) Polling build filters in jenkinsfile broken or need guidance on what code should be
Title: Message Title Paul Allen updated an issue Jenkins / JENKINS-50027 Polling build filters in jenkinsfile broken or need guidance on what code should be Change By: Paul Allen Labels: P4_B P4_VERIFY Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50027) Polling build filters in jenkinsfile broken or need guidance on what code should be
Title: Message Title Karl Wirth updated an issue Jenkins / JENKINS-50027 Polling build filters in jenkinsfile broken or need guidance on what code should be Change By: Karl Wirth Labels: P4_VERIFY Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50027) Polling build filters in jenkinsfile broken or need guidance on what code should be
Title: Message Title
Karl Wirth created an issue
Jenkins / JENKINS-50027
Polling build filters in jenkinsfile broken or need guidance on what code should be
Issue Type:
Bug
Assignee:
Unassigned
Components:
p4-plugin
Created:
2018-03-08 17:18
Environment:
1.8.5 1.8.6
Priority:
Blocker
Reporter:
Karl Wirth
If you use the syntax generator to create a checkout step that includes a polling build filter the following text is created:
filter: [userFilter('BUILDER'), viewFilter('''//corvus/main/workers''')],
If you try to execute this code in Pipeline (jenkinsfile or defined in job window) it will fail with error:
[Pipeline] End of Pipeline
java.lang.IllegalArgumentException: Arguments to class org.jenkinsci.plugins.p4.filters.FilterPatternListImpl have to be explicitly named
at org.jenkinsci.plugins.structs.describable.DescribableModel.instantiate(DescribableModel.java:254)
at org.jenkinsci.plugins.structs.describable.UninstantiatedDescribable.instantiate(UninstantiatedDescribable.java:167)
at org.jenkinsci.plugins.structs.describable.DescribableModel.coerce(DescribableModel.java:372)
at org.jenkinsci.plugins.structs.describable.DescribableModel.coerceList(DescribableModel.java:463)
at
