[JIRA] (JENKINS-50164) Renaming a job with non default build record directory makes old builds disappear
Title: Message Title Baptiste Mathus commented on JENKINS-50164 Re: Renaming a job with non default build record directory makes old builds disappear For my purpose indeed, I don't need it to be changeable. It would be done once only. If this issue can simply help make drive/surface the fact this should be a sysprop, and never a UI thing, I'm totally fine with this and tend to agree. I guess at the very least, we need to double-check the current behaviour, and document it more in the help text (it's already said there that no migration is handled FWIW). Then in the mid term, see if we should remove it. I would vote yes. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50164) Renaming a job with non default build record directory makes old builds disappear
Title: Message Title Daniel Beck commented on JENKINS-50164 Re: Renaming a job with non default build record directory makes old builds disappear Changing the value in runtime requires manual migration work for sure Hence It was never a good idea to use the UI option while Jenkins was running. … This should never have been a UI option, it's so insanely unsafe to use. I'm not saying the option shouldn't exist – I'm saying it's something that should need to be set while Jenkins is shut down. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50164) Renaming a job with non default build record directory makes old builds disappear
Title: Message Title Oleg Nenashev commented on JENKINS-50164 Re: Renaming a job with non default build record directory makes old builds disappear It is a nice option if you want to configure an external storage for build records and do it properly. I'd guess it's what Baptiste Mathus wanted to do. Changing the value in runtime requires manual migration work for sure Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50164) Renaming a job with non default build record directory makes old builds disappear
Title: Message Title Daniel Beck commented on JENKINS-50164 Re: Renaming a job with non default build record directory makes old builds disappear Devin Nusbaum Renaming jobs is fine, but Change default "Build Record Root Directory" is not. Insane option. Even working as intended it will nuke all your existing builds on restart. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50164) Renaming a job with non default build record directory makes old builds disappear
Title: Message Title Devin Nusbaum commented on JENKINS-50164 Re: Renaming a job with non default build record directory makes old builds disappear This should never have been a UI option, it's so insanely unsafe to use. Daniel Beck: Now that -JENKINS-22936- is done I guess we could split confirm-rename.jelly and RenameAction out to a separate plugin. Would require some awkward documentation for AbstractItem#isNameEditable, and the renaming itself (AbstractItem#renameTo) would have to stay in core, but it would get rid of the UI for new installations. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50164) Renaming a job with non default build record directory makes old builds disappear
Title: Message Title Baptiste Mathus updated an issue Jenkins / JENKINS-50164 Renaming a job with non default build record directory makes old builds disappear Change By: Baptiste Mathus Priority: Major Minor Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50164) Renaming a job with non default build record directory makes old builds disappear
Title: Message Title Baptiste Mathus commented on JENKINS-50164 Re: Renaming a job with non default build record directory makes old builds disappear Good point. I (thought I) did, but wrongly it seems. Sigh. I can also reproduce this using 2.89.4... Lowering priority then. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50164) Renaming a job with non default build record directory makes old builds disappear
Title: Message Title
Baptiste Mathus updated an issue
Jenkins / JENKINS-50164
Renaming a job with non default build record directory makes old builds disappear
Change By:
Baptiste Mathus
I think this was introduced by JENKINS-22936 h3. How to reproduce* Start Jenkins 2.110 * Create a job and run/create some builds* Change default "Build Record Root Directory" to "${JENKINS_HOME}/var/${ITEM_FULL_NAME}/builds/"* Rename the job* Open a build created before the rename, it will show {{No such file: /var/jenkins_home/var/new_name/builds/2/log}}h3. Stack traceThere's the following stack trace when renaming:{noformat}Mar 14, 2018 9:29:03 AM hudson.model.Job$SubItemBuildsLocationImpl onLocationChanged SEVERE: Failed to move /var/jenkins_home/var/current_name/builds/ to /var/jenkins_home/var/new_name/builds java.io.FileNotFoundException: /var/jenkins_home/var/current_name/builds/lastFailedBuild (No such file or directory) at java.io.FileInputStream.open0(Native Method) at java.io.FileInputStream.open(FileInputStream.java:195) at java.io.FileInputStream.(FileInputStream.java:138) at org.apache.commons.io.FileUtils.doCopyFile(FileUtils.java:1138)at org.apache.commons.io.FileUtils.doCopyDirectory(FileUtils.java:1428)at org.apache.commons.io.FileUtils.copyDirectory(FileUtils.java:1389)at org.apache.commons.io.FileUtils.copyDirectory(FileUtils.java:1261)at org.apache.commons.io.FileUtils.copyDirectory(FileUtils.java:1230)at org.apache.commons.io.FileUtils.moveDirectory(FileUtils.java:2755)at hudson.model.Job$SubItemBuildsLocationImpl.onLocationChanged(Job.java:701)at hudson.model.listeners.ItemListener$6.apply(ItemListener.java:272)at hudson.model.listeners.ItemListener$6.apply(ItemListener.java:270)at hudson.model.listeners.ItemListener.forAll(ItemListener.java:180)at hudson.model.listeners.ItemListener.fireLocationChange(ItemListener.java:270)at hudson.model.AbstractItem.renameTo(AbstractItem.java:438)at hudson.model.Job.renameTo(Job.java:653)at hudson.model.AbstractItem.doConfirmRename(AbstractItem.java:261)at java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:627)at org.kohsuke.stapler.Function$MethodFunction.invoke(Function.java:343)at org.kohsuke.stapler.interceptor.RequirePOST$Processor.invoke(RequirePOST.java:77)at org.kohsuke.stapler.PreInvokeInterceptedFunction.invoke(PreInvokeInterceptedFunction.java:26)at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:184)at org.kohsuke.stapler.Function.bindAndInvokeAndServeResponse(Function.java:117)at org.kohsuke.stapler.MetaClass$1.doDispatch(MetaClass.java:129)at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:58)at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:715)at org.kohsuke.stapler.Stapler.invo
[JIRA] (JENKINS-50164) Renaming a job with non default build record directory makes old builds disappear
Title: Message Title
Baptiste Mathus updated an issue
Jenkins / JENKINS-50164
Renaming a job with non default build record directory makes old builds disappear
Change By:
Baptiste Mathus
I think this was introduced by JENKINS-22936h3. How to reproduce* Start Jenkins 2.110* Create a job and run/create some builds* Change default "Build Record Root Directory" to {{ _ ${JENKINS_HOME}/var/${ITEM_FULL_NAME}/builds/ }} _ * Rename the job* Open a build created before the rename, it will show {{No such file: /var/jenkins_home/var/new_name/builds/2/log}}h3. Stack traceThere's the following stack trace when renaming:{noformat}Mar 14, 2018 9:29:03 AM hudson.model.Job$SubItemBuildsLocationImpl onLocationChanged SEVERE: Failed to move /var/jenkins_home/var/current_name/builds/ to /var/jenkins_home/var/new_name/builds java.io.FileNotFoundException: /var/jenkins_home/var/current_name/builds/lastFailedBuild (No such file or directory) at java.io.FileInputStream.open0(Native Method) at java.io.FileInputStream.open(FileInputStream.java:195) at java.io.FileInputStream.(FileInputStream.java:138) at org.apache.commons.io.FileUtils.doCopyFile(FileUtils.java:1138)at org.apache.commons.io.FileUtils.doCopyDirectory(FileUtils.java:1428)at org.apache.commons.io.FileUtils.copyDirectory(FileUtils.java:1389)at org.apache.commons.io.FileUtils.copyDirectory(FileUtils.java:1261)at org.apache.commons.io.FileUtils.copyDirectory(FileUtils.java:1230)at org.apache.commons.io.FileUtils.moveDirectory(FileUtils.java:2755)at hudson.model.Job$SubItemBuildsLocationImpl.onLocationChanged(Job.java:701)at hudson.model.listeners.ItemListener$6.apply(ItemListener.java:272)at hudson.model.listeners.ItemListener$6.apply(ItemListener.java:270)at hudson.model.listeners.ItemListener.forAll(ItemListener.java:180)at hudson.model.listeners.ItemListener.fireLocationChange(ItemListener.java:270)at hudson.model.AbstractItem.renameTo(AbstractItem.java:438)at hudson.model.Job.renameTo(Job.java:653)at hudson.model.AbstractItem.doConfirmRename(AbstractItem.java:261)at java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:627)at org.kohsuke.stapler.Function$MethodFunction.invoke(Function.java:343)at org.kohsuke.stapler.interceptor.RequirePOST$Processor.invoke(RequirePOST.java:77)at org.kohsuke.stapler.PreInvokeInterceptedFunction.invoke(PreInvokeInterceptedFunction.java:26)at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:184)at org.kohsuke.stapler.Function.bindAndInvokeAndServeResponse(Function.java:117)at org.kohsuke.stapler.MetaClass$1.doDispatch(MetaClass.java:129)at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:58)at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:715)at org.kohsuke.stapler.Stap
[JIRA] (JENKINS-50164) Renaming a job with non default build record directory makes old builds disappear
Title: Message Title
Baptiste Mathus updated an issue
Jenkins / JENKINS-50164
Renaming a job with non default build record directory makes old builds disappear
Change By:
Baptiste Mathus
I think this was introduced by JENKINS-22936h3. How to reproduce* Start Jenkins 2.110* Create a job and run/create some builds* Change default "Build Record Root Directory" to _ " ${JENKINS_HOME}/var/${ITEM_FULL_NAME}/builds/ _ " * Rename the job* Open a build created before the rename, it will show {{No such file: /var/jenkins_home/var/new_name/builds/2/log}}h3. Stack traceThere's the following stack trace when renaming:{noformat}Mar 14, 2018 9:29:03 AM hudson.model.Job$SubItemBuildsLocationImpl onLocationChanged SEVERE: Failed to move /var/jenkins_home/var/current_name/builds/ to /var/jenkins_home/var/new_name/builds java.io.FileNotFoundException: /var/jenkins_home/var/current_name/builds/lastFailedBuild (No such file or directory) at java.io.FileInputStream.open0(Native Method) at java.io.FileInputStream.open(FileInputStream.java:195) at java.io.FileInputStream.(FileInputStream.java:138) at org.apache.commons.io.FileUtils.doCopyFile(FileUtils.java:1138)at org.apache.commons.io.FileUtils.doCopyDirectory(FileUtils.java:1428)at org.apache.commons.io.FileUtils.copyDirectory(FileUtils.java:1389)at org.apache.commons.io.FileUtils.copyDirectory(FileUtils.java:1261)at org.apache.commons.io.FileUtils.copyDirectory(FileUtils.java:1230)at org.apache.commons.io.FileUtils.moveDirectory(FileUtils.java:2755)at hudson.model.Job$SubItemBuildsLocationImpl.onLocationChanged(Job.java:701)at hudson.model.listeners.ItemListener$6.apply(ItemListener.java:272)at hudson.model.listeners.ItemListener$6.apply(ItemListener.java:270)at hudson.model.listeners.ItemListener.forAll(ItemListener.java:180)at hudson.model.listeners.ItemListener.fireLocationChange(ItemListener.java:270)at hudson.model.AbstractItem.renameTo(AbstractItem.java:438)at hudson.model.Job.renameTo(Job.java:653)at hudson.model.AbstractItem.doConfirmRename(AbstractItem.java:261)at java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:627)at org.kohsuke.stapler.Function$MethodFunction.invoke(Function.java:343)at org.kohsuke.stapler.interceptor.RequirePOST$Processor.invoke(RequirePOST.java:77)at org.kohsuke.stapler.PreInvokeInterceptedFunction.invoke(PreInvokeInterceptedFunction.java:26)at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:184)at org.kohsuke.stapler.Function.bindAndInvokeAndServeResponse(Function.java:117)at org.kohsuke.stapler.MetaClass$1.doDispatch(MetaClass.java:129)at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:58)at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:715)at org.kohsuke.stapler.Staple
[JIRA] (JENKINS-50164) Renaming a job with non default build record directory makes old builds disappear
Title: Message Title Baptiste Mathus updated an issue Jenkins / JENKINS-50164 Renaming a job with non default build record directory makes old builds disappear Change By: Baptiste Mathus Environment: Jenkins 2.110 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50164) Renaming a job with non default build record directory makes old builds disappear
Title: Message Title Daniel Beck edited a comment on JENKINS-50164 Re: Renaming a job with non default build record directory makes old builds disappear Please try to confirm this actually worked in older releases before claiming regression , or mention that you did so (and which release) . There's no indication here that this is new. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50164) Renaming a job with non default build record directory makes old builds disappear
Title: Message Title Daniel Beck commented on JENKINS-50164 Re: Renaming a job with non default build record directory makes old builds disappear Please try to confirm this actually worked in older releases before claiming regression. There's no indication here that this is new. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50164) Renaming a job with non default build record directory makes old builds disappear
Title: Message Title Daniel Beck commented on JENKINS-50164 Re: Renaming a job with non default build record directory makes old builds disappear It was never a good idea to use the UI option while Jenkins was running. While the error could be new (which I doubt but whatever), just restarting Jenkins would have wiped all your previous build records. This should never have been a UI option, it's so insanely unsafe to use. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50164) Renaming a job with non default build record directory makes old builds disappear
Title: Message Title Oleg Nenashev updated an issue Jenkins / JENKINS-50164 Renaming a job with non default build record directory makes old builds disappear Change By: Oleg Nenashev Labels: regression Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50164) Renaming a job with non default build record directory makes old builds disappear
Title: Message Title Baptiste Mathus updated an issue Jenkins / JENKINS-50164 Renaming a job with non default build record directory makes old builds disappear Change By: Baptiste Mathus Summary: Renaming a job with non default build record directory makes old build builds disappear Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
