[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title Tobias Gruetzmacher updated JENKINS-50176 Jenkins / JENKINS-50176 Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks Change By: Tobias Gruetzmacher Status: Fixed but Unreleased Resolved Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.189195.1521053055000.7348.1572650701447%40Atlassian.JIRA.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title Tobias Gruetzmacher updated JENKINS-50176 Jenkins / JENKINS-50176 Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks Change By: Tobias Gruetzmacher Status: Open Fixed but Unreleased Assignee: Tobias Gruetzmacher Resolution: Fixed Released As: https://github.com/jenkinsci/lockable-resources-plugin/releases/tag/lockable-resources-2.7 Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title vikash srivastava edited a comment on JENKINS-50176 Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks [|https://github.com/jenkinsci/lockable-resources-plugin/pull/117/files/2802f118e7957429d0664d24584343b94ba5d51f] Below changeset is fixing this issue.[https://github.com/jenkinsci/lockable-resources-plugin/pull/117/files/2802f118e7957429d0664d24584343b94ba5d51f] Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.189195.1521053055000.6286.1562742302196%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title vikash srivastava commented on JENKINS-50176 Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks https://github.com/jenkinsci/lockable-resources-plugin/pull/117/files/2802f118e7957429d0664d24584343b94ba5d51f Below changeset is fixing this issue. https://github.com/jenkinsci/lockable-resources-plugin/pull/117/files/2802f118e7957429d0664d24584343b94ba5d51f Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.189195.1521053055000.6236.1562742240637%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title Christopher Head commented on JENKINS-50176 Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks There is a workaround (of sorts) which we deployed in our environment (we are using a declarative pipeline): put a loop around the lock statement which breaks out only once the variable is set successfully. It means you lose the FIFO property, and occasionally it can deadlock if there are a lot of waiters, but in a low-contention case the waiter will loop and on the second iteration the lock will be free so it will get it and set the variable. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.189195.1521053055000.22688.1559829300605%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title Carlos Garcia commented on JENKINS-50176 Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks The same issue is reproduced in my environment. Does anybody know if there is a feasible solution? Is there any release planned to address this issue? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.189195.1521053055000.22642.1559825280820%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title Adrian Constantin commented on JENKINS-50176 Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks vikash srivastava the reason for my question is that since June 2018 I could only see a security fix released in March and one bug fixed in Jan. And all pull requests, except one, have failed the CI build after the last release: https://github.com/jenkinsci/lockable-resources-plugin/pulls I have also browsed 5-6 PRs in the list above, and they all seem to be waiting for comments or actions from maintainers for a few months, including the PR that fixes this issue. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.189195.1521053055000.26.1557826939413%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title vikash srivastava commented on JENKINS-50176 Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks yes its active ,see some bug fixes going in , we use it for our CI pipeline in validation stage. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.189195.1521053055000.23213.1557479100436%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title Adrian Constantin edited a comment on JENKINS-50176 Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks Dose anybody have an idea know if the Lockable Resource plugin is still active? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.189195.1521053055000.23188.1557478380613%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title Adrian Constantin commented on JENKINS-50176 Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks Dose anybody have an idea if the Lockable Resource plugin is still active? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.189195.1521053055000.23163.1557478080415%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title Niels Wegner commented on JENKINS-50176 Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks Steven Foster Thanks for that info. This will get us around stuck pipelines when freeing reservations Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title Steven Foster commented on JENKINS-50176 Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks Stefan Rystedt's PR also fixes JENKINS-54541 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title Stefan Rystedt edited a comment on JENKINS-50176 Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks I have created PR#117 which should solve this issue. My way of solving it is a little bit cleaner according to my opinion. But the then I have not done any Jenkins plugin development until I did this fix. It can be merged as is thought. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title Stefan Rystedt commented on JENKINS-50176 Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks I have created PR#117 which should solve this issue. My way of solving it is a little bit cleaner according to my opinion. But the I have not done any Jenkins plugin development until I did this fix. It can be merged as is thought. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title Jagadeesh Inugunti edited a comment on JENKINS-50176 Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks [~jbogers] We are still seeing this issue with lockable resource plugin , I dont see changes in PR #87 merged to master either . Please let us know if someone is working/looking into this issue , it will be really helpful if this gets resolved . Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title Jagadeesh Inugunti commented on JENKINS-50176 Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks Jeroen Bogers We are still seeing this issue with lockable resource plugin , I dont see changes in PR #87 merged to master either . Please let us know if someone is working/looking into this issue , it will be really helpful if this gets resolved . Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title Jeroen Bogers commented on JENKINS-50176 Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks Issue is also solved in PR #87 which has already been merged to master. Waiting for next release now. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title Curt Coleman commented on JENKINS-50176 Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks Antonio Muñiz, is there anything you can do on your end to get this fix (PR-95) pushed through (assuming you agree with the changes)? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title
Jeroen Bogers edited a comment on JENKINS-50176
Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
[~avidviewer], sadly I have no follow up to offer on this. I'm not the owner of the pull request and have no special access.To me it seems the build failure is just a random failure on the build server (it encountered a timeout were I would expect none). I have built the plugin locally (on Linux) and ran the same tests without any problems.Since then I have taken that own build and installed it in my Jenkins instead as my team was being blocked by the issue. It has been running without issue for a few days now.It is up to [~amuniz] now to take the patch { { boblloyd} } provided and move forward with it.
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title
Jeroen Bogers commented on JENKINS-50176
Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Brandon Saunders, sadly I have no follow up to offer on this. I'm not the owner of the pull request and have no special access. To me it seems the build failure is just a random failure on the build server (it encountered a timeout were I would expect none). I have built the plugin locally (on Linux) and ran the same tests without any problems. Since then I have taken that own build and installed it in my Jenkins instead as my team was being blocked by the issue. It has been running without issue for a few days now. It is up to Antonio Muñiz now to take the patch {boblloyd} provided and move forward with it.
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title Brandon Saunders commented on JENKINS-50176 Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks Any update on this Jeroen Bogers? It looks like the fix is ready but some unit tests are blocking the ability to merge? Any followup on why it would work in windows but not linux? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title Jeroen Bogers updated an issue Jenkins / JENKINS-50176 Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks Change By: Jeroen Bogers Environment: lockable-resources 2.2 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title Jeroen Bogers updated an issue Jenkins / JENKINS-50176 Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks Change By: Jeroen Bogers Priority: Minor Major Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title
Jeroen Bogers edited a comment on JENKINS-50176
Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
It seems that if the lock can be immediately granted, the variable is set. If waiting on the resource is needed it is not set.I suspect the error is on line 51 of src/main/java/org/jenkins/plugins/lockableresources/LockStepExecution.javaThe code there states:{code:java} LockableResourcesStruct resourceHolder = new LockableResourcesStruct(resources, step.label, step.quantity);{code}I think this should have been (in accordance with the added LockableResourcesStruct on line 56 of src/main/java/org/jenkins/plugins/lockableresources/queue/LockableResourcesStruct.java):{code:java} LockableResourcesStruct resourceHolder = new LockableResourcesStruct(resources, step.label, step.quantity, step.variable);{code}This is because if the lock is queued instead of granting the lock directly (with the variable as part of the 'lock' call, the resourceHolder is put on the queue.When the lock is then granted the variable name is looked up in the LockableResourcesStruct but it is not set and thus the environment variable will not be set. EDIT: A PR was already created by 'boblloyd' to fix this issue: https://github.com/jenkinsci/lockable-resources-plugin/pull/95
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title
Jeroen Bogers edited a comment on JENKINS-50176
Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
It seems that if the lock can be immediately granted, the variable is set. If waiting on the resource is needed it is not set.I suspect the error is on line 51 of src/main/java/org/jenkins/plugins/lockableresources/LockStepExecution.javaThe code there states:{code:java} LockableResourcesStruct resourceHolder = new LockableResourcesStruct(resources, step.label, step.quantity);{code}I think this should have been (in accordance with the added LockableResourcesStruct on line 56 of src/main/java/org/jenkins/plugins/lockableresources/queue/LockableResourcesStruct.java):{code:java} LockableResourcesStruct resourceHolder = new LockableResourcesStruct(resources, step.label, step.quantity, step.variable);{code} This is because if the lock is queued instead of granting the lock directly (with the variable as part of the 'lock' call, the resourceHolder is put on the queue.When the lock is then granted the variable name is looked up in the LockableResourcesStruct but it is not set and thus the environment variable will not be set.
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title Jeroen Bogers commented on JENKINS-50176 Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks It seems that if the lock can be immediately granted, the variable is set. If waiting on the resource is needed it is not set. I suspect the error is on line 51 of src/main/java/org/jenkins/plugins/lockableresources/LockStepExecution.java The code there states: LockableResourcesStruct resourceHolder = new LockableResourcesStruct(resources, step.label, step.quantity); I think this should have been (in accordance with the added LockableResourcesStruct on line 56 of src/main/java/org/jenkins/plugins/lockableresources/queue/LockableResourcesStruct.java): LockableResourcesStruct resourceHolder = new LockableResourcesStruct(resources, step.label, step.quantity, step.variable); Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title Jan Kacik commented on JENKINS-50176 Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks We are experiencing the same issue. When you try to lock a resource and it has to wait in the queue for some time, then it will get null in the variable. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title Tom Skrainar commented on JENKINS-50176 Re: Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks Observing the same issue as well. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title
Brandon Saunders updated an issue
Jenkins / JENKINS-50176
Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Change By:
Brandon Saunders
I'm appearing to hit an issue where a released resource does not get an update on the environment variable once the lock is released. See the following code (with only two resources available in the automation-accounts label) {{node \{}} {{ parallel (}} {{ "p1": \{}} {{ lock(label: 'automation-accounts', variable: 'ACCOUNTS_VAR', quantity: 1) \{}} {{ echo "A $env.ACCOUNTS_VAR"}} {{ sleep 4}} } {{ },}} {{ "p2": \{}} {{ lock(label: 'automation-accounts', variable: 'ACCOUNTS_VAR', quantity: 1) \{}} {{ echo "B $env.ACCOUNTS_VAR"}} {{ sleep 2}} } {{ },}} {{ "p3": \{}} {{ lock(label: 'automation-accounts', variable: 'ACCOUNTS_VAR', quantity: 1) \{}} {{ }}{{echo "C $env.ACCOUNTS_VAR"}} } } {{ )}} {{}}} In the log I get the following (note "C null"): [Pipeline] \{ [Pipeline] parallel [Pipeline] [p1] \{ (Branch: p1) [Pipeline] [p2] \{ (Branch: p2) [Pipeline] [p3] \{ (Branch: p3) [Pipeline] [p1] lock [p1] Trying to acquire lock on [Label: automation-accounts, Quantity: 1] [p1] Lock acquired on [Label: automation-accounts, Quantity: 1] [Pipeline] [p1] \{ [Pipeline] [p2] lock [p2] Trying to acquire lock on [Label: automation-accounts, Quantity: 1] [p2] Lock acquired on [Label: automation-accounts, Quantity: 1] [Pipeline] [p2] \{ [Pipeline] [p3] lock [p3] Trying to acquire lock on [Label: automation-accounts, Quantity: 1] [p3] Found 0 available resource(s). Waiting for correct amount: 1. [p3] [Label: automation-accounts, Quantity: 1] is locked, waiting... [Pipeline] [p1] echo [p1] A [Pipeline] [p1] sleep [p1] Sleeping for 4 sec [Pipeline] [p2] echo [p2] B [Pipeline] [p2] sleep [p2] Sleeping for 2 sec [p3] Lock acquired on [Label: automation-accounts, Quantity: 1] [Pipeline] [p2] } [p2] Lock released on resource [Label: automation-accounts, Quantity: 1] [Pipeline] [p3] \{ [Pipeline] [p2] // lock [Pipeline] [p2] } [Pipeline] [p3] echo {color:#ff}[p3] C null{color} [Pipeline] [p3] } [p3] Lock released on resource [Label: automation-accounts, Quantity: 1] [Pipeline] [p3] // lock [Pipeline] [p3] } [Pipeline] [p1] } [p1] Lock released on resource [Label: automation-accounts, Quantity: 1] [Pipeline] [p1] // lock [Pipeline] [p1] } [Pipeline] // parallel [Pipeline] } [Pipeline] // node [Pipeline] End of Pipeline*Expected Result*: I should get "C Perhaps I'm calling it wrong though? It appears that the lock is being acquired BEFORE the resource is released though this might be just a logging complication of calling it in parallel
[JIRA] (JENKINS-50176) Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks
Title: Message Title Brandon Saunders updated an issue Jenkins / JENKINS-50176 Locked resources using the variable parameter do not get reset to the variable once released to another requester and only appear as null on subsequent locks Change By: Brandon Saunders Summary: Locked resources using the variable parameter do not get set reset to the variable once released to another requester and only appear as null on subsequent locks Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
