[JIRA] (JENKINS-50216) Google Auth Plugin is incompatible with Jenkins 2.102+
Title: Message Title Oleg Nenashev updated JENKINS-50216 The fix has been released in 0.6 Jenkins / JENKINS-50216 Google Auth Plugin is incompatible with Jenkins 2.102+ Change By: Oleg Nenashev Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50216) Google Auth Plugin is incompatible with Jenkins 2.102+
Title: Message Title SCM/JIRA link daemon commented on JENKINS-50216 Re: Google Auth Plugin is incompatible with Jenkins 2.102+ Code changed in jenkins User: Oleg Nenashev Path: pom.xml src/main/java/com/google/jenkins/plugins/credentials/oauth/RemotableGoogleCredentials.java src/main/java/com/google/jenkins/plugins/util/JodaDateTimeConverter.java src/test/java/com/google/jenkins/plugins/credentials/oauth/RemotableGoogleCredentialsIntegrationTest.java http://jenkins-ci.org/commit/google-oauth-plugin/bb9c2cc5ca5940b2043ee35bf6afb3ac3c7c68af Log: JENKINS-50216 - Cleanup codestyle and re-enable Checkstyle Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50216) Google Auth Plugin is incompatible with Jenkins 2.102+
Title: Message Title SCM/JIRA link daemon commented on JENKINS-50216 Re: Google Auth Plugin is incompatible with Jenkins 2.102+ Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/google/jenkins/plugins/util/JodaDateTimeConverter.java src/main/resources/META-INF/hudson.remoting.ClassFilter http://jenkins-ci.org/commit/google-oauth-plugin/498b54bb486d4a5dfd91ca47cfb04fbbf946502f Log: JENKINS-50216 - Whitelist org.joda.time.DateTime so that there is no need to tweak converter priorities Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50216) Google Auth Plugin is incompatible with Jenkins 2.102+
Title: Message Title SCM/JIRA link daemon commented on JENKINS-50216 Re: Google Auth Plugin is incompatible with Jenkins 2.102+ Code changed in jenkins User: astroilov Path: .gitignore Jenkinsfile checkstyleJavaHeader pom.xml src/main/java/com/google/jenkins/plugins/credentials/oauth/RemotableGoogleCredentials.java src/main/resources/com/google/jenkins/plugins/credentials/oauth/GoogleRobotMetadataCredentials/config.jelly src/main/resources/com/google/jenkins/plugins/credentials/oauth/GoogleRobotPrivateKeyCredentials/config.jelly src/main/resources/com/google/jenkins/plugins/credentials/oauth/JsonServiceAccountConfig/config.jelly src/main/resources/com/google/jenkins/plugins/credentials/oauth/P12ServiceAccountConfig/config.jelly http://jenkins-ci.org/commit/google-oauth-plugin/e68bbcc00395124e4b27e90b84e1edeaff33fc74 Log: Merge pull request #17 from jglick/RemotableGoogleCredentials.expiration-JENKINS-50216 JENKINS-50216 - RemotableGoogleCredentials.expiration fix Compare: https://github.com/jenkinsci/google-oauth-plugin/compare/62126a657c2d...e68bbcc00395 *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50216) Google Auth Plugin is incompatible with Jenkins 2.102+
Title: Message Title SCM/JIRA link daemon commented on JENKINS-50216 Re: Google Auth Plugin is incompatible with Jenkins 2.102+ Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/google/jenkins/plugins/util/JodaDateTimeConverter.java src/test/java/com/google/jenkins/plugins/credentials/oauth/RemotableGoogleCredentialsIntegrationTest.java src/test/resources/com/google/jenkins/plugins/credentials/oauth/jodaDateTimeNull.xml http://jenkins-ci.org/commit/google-oauth-plugin/dbdef9b760d3c1d21be7d8199022b1bae60864e0 Log: JENKINS-50216 - Joda DateTime converter now has higher priority than JEP-200 blacklist Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50216) Google Auth Plugin is incompatible with Jenkins 2.102+
Title: Message Title SCM/JIRA link daemon commented on JENKINS-50216 Re: Google Auth Plugin is incompatible with Jenkins 2.102+ Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/google-oauth-plugin/51fb71acab97b80be2b1cc27aae19d9203a09a09 Log: JENKINS-50216 - Add BouncyCastle API dependency to enable tests against 2.107.2 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50216) Google Auth Plugin is incompatible with Jenkins 2.102+
Title: Message Title SCM/JIRA link daemon commented on JENKINS-50216 Re: Google Auth Plugin is incompatible with Jenkins 2.102+ Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/google/jenkins/plugins/credentials/oauth/RemotableGoogleCredentials.java src/main/java/com/google/jenkins/plugins/util/JodaDateTimeConverter.java src/test/java/com/google/jenkins/plugins/credentials/oauth/RemotableGoogleCredentialsIntegrationTest.java src/test/resources/com/google/jenkins/plugins/credentials/oauth/jodaDateTimeBroken.xml src/test/resources/com/google/jenkins/plugins/credentials/oauth/jodaDateTimeXML.xml http://jenkins-ci.org/commit/google-oauth-plugin/c47f47226c036b6f25d252877a34e68a0b1af99e Log: JENKINS-50216 - Introduce a custom serializer for org.joda.time.DateTime Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50216) Google Auth Plugin is incompatible with Jenkins 2.102+
Title: Message Title SCM/JIRA link daemon commented on JENKINS-50216 Re: Google Auth Plugin is incompatible with Jenkins 2.102+ Code changed in jenkins User: Oleg Nenashev Path: Jenkinsfile pom.xml http://jenkins-ci.org/commit/google-oauth-plugin/5e0448e8d183f26aaf056a79aa11129e73bb3329 Log: JENKINS-50216 - Add Jenkinsfile to verify JEP-200 regressions Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50216) Google Auth Plugin is incompatible with Jenkins 2.102+
Title: Message Title Jesse Glick commented on JENKINS-50216 Re: Google Auth Plugin is incompatible with Jenkins 2.102+ I suspect that the compatibility impact on even the unimportant fingerprint issue is zero: from what I can tell, the fingerprints were hashing based on an expiration timestamp which is different every time the credentials are used, so it would never have matched to begin with. Since the problematic class is supposed to be ephemeral and apparently for Remoting only, this indicates a design flaw in the plugin. Perhaps it needed to implement CredentialsSnapshotTaker rather than rolling its own GoogleRobotCredentials.forRemote. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50216) Google Auth Plugin is incompatible with Jenkins 2.102+
Title: Message Title Jesse Glick assigned an issue to Jesse Glick Jenkins / JENKINS-50216 Google Auth Plugin is incompatible with Jenkins 2.102+ Change By: Jesse Glick Assignee: Oleg Nenashev Jesse Glick Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50216) Google Auth Plugin is incompatible with Jenkins 2.102+
Title: Message Title Jesse Glick commented on JENKINS-50216 Re: Google Auth Plugin is incompatible with Jenkins 2.102+ Filed a simpler revision: PR 17. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50216) Google Auth Plugin is incompatible with Jenkins 2.102+
Title: Message Title Jesse Glick commented on JENKINS-50216 Re: Google Auth Plugin is incompatible with Jenkins 2.102+ AFAICT this has been misdiagnosed. The errors are indeed coming from XStream, but not as part of persisted settings like you might think. Rather, the stack traces here and in the duplicate all come from CredentialsProvider.getOrCreateFingerprintOf, which uses XStream merely to get a hash to identify credentials. Thus, changing the serial format from one plugin release to another just means that existing fingerprints will no longer match—as if anyone cares. RemotableGoogleCredentials is explicitly documented as an ephemeral object to be passed over Remoting. Therefore, there is no compatibility concern about its serial form—we can pick anything. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50216) Google Auth Plugin is incompatible with Jenkins 2.102+
Title: Message Title Oleg Nenashev commented on JENKINS-50216 Re: Google Auth Plugin is incompatible with Jenkins 2.102+ According to https://issues.jenkins-ci.org/browse/JENKINS-50899?focusedCommentId=335821&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-335821, my fix likely does not work as expected Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50216) Google Auth Plugin is incompatible with Jenkins 2.102+
Title: Message Title Oleg Nenashev updated JENKINS-50216 Jenkins / JENKINS-50216 Google Auth Plugin is incompatible with Jenkins 2.102+ Change By: Oleg Nenashev Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50216) Google Auth Plugin is incompatible with Jenkins 2.102+
Title: Message Title Oleg Nenashev commented on JENKINS-50216 Re: Google Auth Plugin is incompatible with Jenkins 2.102+ I have created a fix proposal in https://github.com/jenkinsci/google-oauth-plugin/pull/15, needs reviews Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50216) Google Auth Plugin is incompatible with Jenkins 2.102+
Title: Message Title Oleg Nenashev commented on JENKINS-50216 Re: Google Auth Plugin is incompatible with Jenkins 2.102+ So the example XML format is... 1523889095013 "org.joda.time.chrono.ISOChronology" resolves-to="org.joda.time.chrono.ISOChronology$Stub" serialization="custom"> "org.joda.time.DateTimeZone$Stub" serialization="custom"> Europe/Zurich I can probably apply an XStream converter to that Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50216) Google Auth Plugin is incompatible with Jenkins 2.102+
Title: Message Title Oleg Nenashev commented on JENKINS-50216 Re: Google Auth Plugin is incompatible with Jenkins 2.102+ I am still blocked by CLA, but I will update the pull request to contain a fix Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50216) Google Auth Plugin is incompatible with Jenkins 2.102+
Title: Message Title Oleg Nenashev started work on JENKINS-50216 Change By: Oleg Nenashev Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50216) Google Auth Plugin is incompatible with Jenkins 2.102+
Title: Message Title Oleg Nenashev assigned an issue to Oleg Nenashev Jenkins / JENKINS-50216 Google Auth Plugin is incompatible with Jenkins 2.102+ Change By: Oleg Nenashev Assignee: Andrey Stroilov Oleg Nenashev Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50216) Google Auth Plugin is incompatible with Jenkins 2.102+
Title: Message Title Oleg Nenashev commented on JENKINS-50216 Re: Google Auth Plugin is incompatible with Jenkins 2.102+ I have got a response from plugin maintainers regarding this issue. They are ready to help with reviews, and CLA is not longer required according to them. So I have created https://github.com/jenkinsci/google-oauth-plugin/pull/16. Once it is merged, we can proceed with the fix (if prioritized) Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50216) Google Auth Plugin is incompatible with Jenkins 2.102+
Title: Message Title Oleg Nenashev updated an issue Jenkins / JENKINS-50216 Google Auth Plugin is incompatible with Jenkins 2.102+ Change By: Oleg Nenashev Summary: Google Source Auth Plugin is incompatible with Jenkins 2.102+ Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
