[JIRA] (JENKINS-51048) Setting workspace type to 'READONLY' doesn't work with servers running < 2017.1
Title: Message Title Paul Allen closed an issue as Fixed Released in 1.8.15 Jenkins / JENKINS-51048 Setting workspace type to 'READONLY' doesn't work with servers running < 2017.1 Change By: Paul Allen Status: In Progress Closed Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51048) Setting workspace type to 'READONLY' doesn't work with servers running < 2017.1
Title: Message Title Paul Allen started work on JENKINS-51048 Change By: Paul Allen Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51048) Setting workspace type to 'READONLY' doesn't work with servers running < 2017.1
Title: Message Title Aaron Ling updated an issue Jenkins / JENKINS-51048 Setting workspace type to 'READONLY' doesn't work with servers running < 2017.1 Change By: Aaron Ling Summary: Setting workspace type to 'READONLY' doesn't work for with servers running < 2017.1 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51048) Setting workspace type to 'READONLY' doesn't work for servers running < 2017.1
Title: Message Title
Aaron Ling created an issue
Jenkins / JENKINS-51048
Setting workspace type to 'READONLY' doesn't work for servers running < 2017.1
Issue Type:
Bug
Assignee:
Unassigned
Components:
p4-plugin
Created:
2018-04-30 18:46
Environment:
P4 Plugin 1.8.9 p4 server 2016.2 Jenkins Enterprise 2.89.4.2-rolling
Priority:
Minor
Reporter:
Aaron Ling
I’m trying to implement readonly workspaces on one of our servers, which is running 2016.2. Readonly workspaces were introduced in 2015.2, so as expected, I can create them manually. However, if I go through the plugin, the workspace type is blank. I’ve uncovered this is because of a couple of if statements that restrict setting workspace type to server versions 2017.1 or later: In src\main\java\org\jenkinsci\plugins\p4\workspace\ManualWorkspaceImpl.java (Line 112) if (connection.getServerVersionNumber() >= 20171) { WorkspaceSpecType type = parseClientType(getSpec().getType()); implClient.setType(type.getId()); } [...] (Line 149) if (connection.getServerVersionNumber() >= 20171) { WorkspaceSpecType type = parseClientType(getSpec().getType()); [...] } I created a custom version of the plugin that replaces 20171 in both if statements with 20162, and everything works as expected – workspaces created through the plugin are correctly set as ‘READONLY’. The changes were added in this commit: https://github.com/jenkinsci/p4-plugin/commit/91e3a3c8284d2bb84061f1afe2d16f63aeb95ee7 for JENKINS-39753
