[JIRA] (JENKINS-54992) Terrifying message makes me think Jenkins will delete my github repo
Title: Message Title Liam Newman updated JENKINS-54992 Jenkins / JENKINS-54992 Terrifying message makes me think Jenkins will delete my github repo Change By: Liam Newman Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54992) Terrifying message makes me think Jenkins will delete my github repo
Title: Message Title Liam Newman updated an issue Jenkins / JENKINS-54992 Terrifying message makes me think Jenkins will delete my github repo Change By: Liam Newman Component/s: branch-api-plugin Component/s: cloudbees-folder-plugin Component/s: github-branch-source-plugin Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54992) Terrifying message makes me think Jenkins will delete my github repo
Title: Message Title Liam Newman commented on JENKINS-54992 Re: Terrifying message makes me think Jenkins will delete my github repo Merged fix as https://github.com/jenkinsci/branch-api-plugin/pull/150 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54992) Terrifying message makes me think Jenkins will delete my github repo
Title: Message Title Liam Newman started work on JENKINS-54992 Change By: Liam Newman Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54992) Terrifying message makes me think Jenkins will delete my github repo
Title: Message Title Liam Newman updated JENKINS-54992 Jenkins / JENKINS-54992 Terrifying message makes me think Jenkins will delete my github repo Change By: Liam Newman Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54992) Terrifying message makes me think Jenkins will delete my github repo
Title: Message Title Liam Newman commented on JENKINS-54992 Re: Terrifying message makes me think Jenkins will delete my github repo Also, not this same issue manifests in the GitHub Organization Pipeline:This looks like we're going to delete an Organization not the GitHub Organization Pipeline. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54992) Terrifying message makes me think Jenkins will delete my github repo
Title: Message Title Liam Newman updated an issue Jenkins / JENKINS-54992 Terrifying message makes me think Jenkins will delete my github repo Change By: Liam Newman Attachment: Screen Shot 2019-04-11 at 12.45.33 PM.png Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54992) Terrifying message makes me think Jenkins will delete my github repo
Title: Message Title Liam Newman commented on JENKINS-54992 Re: Terrifying message makes me think Jenkins will delete my github repo Interesting point: This is only an issue for the GitHub branch source. No other currently implemented source has this problem. All others display this way: This is because no other branch source includes a pronoun, or related implementation changes introduced with JENKINS-38987 - https://github.com/jenkinsci/github-branch-source-plugin/commit/c0557dd3fa8b53e0ff52d315424cebd8fdfd61d9#diff-3f936a67918affedec628eae019f97f3 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54992) Terrifying message makes me think Jenkins will delete my github repo
Title: Message Title Liam Newman updated an issue Jenkins / JENKINS-54992 Terrifying message makes me think Jenkins will delete my github repo Change By: Liam Newman Attachment: Screen Shot 2019-04-11 at 12.03.39 PM.png Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54992) Terrifying message makes me think Jenkins will delete my github repo
Title: Message Title Michael Neale commented on JENKINS-54992 Re: Terrifying message makes me think Jenkins will delete my github repo proposed fix: https://github.com/jenkinsci/github-branch-source-plugin/pull/195 (many other options "delete" is used elsewhere so maybe it isn't a problem, other than in this case). It is deleteing something, just not the repository. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54992) Terrifying message makes me think Jenkins will delete my github repo
Title: Message Title Michael Neale updated an issue Jenkins / JENKINS-54992 Terrifying message makes me think Jenkins will delete my github repo Change By: Michael Neale Component/s: github-branch-source-plugin Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54992) Terrifying message makes me think Jenkins will delete my github repo
Title: Message Title Michael Neale created an issue Jenkins / JENKINS-54992 Terrifying message makes me think Jenkins will delete my github repo Issue Type: Bug Assignee: Francisco Fernández Attachments: image-2018-12-04-11-12-50-073.png Components: cloudbees-folder-plugin Created: 2018-12-04 00:12 Priority: Minor Reporter: Michael Neale When you go to delete a multibranch folder that is using Github as a branch source - you will see a message "delete repository". This is usually alarming as the access token used often has permissions to actually do this, but this is not the intent. This is due to the Pronoun for GithubSCMSource being "Repository". see https://github.com/jenkinsci/github-branch-source-plugin/blob/github-branch-source-2.4.1/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L544 and the wording: https://github.com/jenkinsci/github-branch-source-plugin/blob/github-branch-source-2.4.1/src/main/resources/org/jenkinsci/plugins/github_branch_source/Messages.properties#L40 This is then used in https://github.com/jenkinsci/cloudbees-folder-plugin/blob/cloudbees-folder-6.7/src/main/resources/com/cloudbees/hudson/plugins/folder/AbstractFolder/tasks-new.properties which ends up with the scary looking:
