[JIRA] (JENKINS-55853) Customized Post Build Comment ignored for multi-configuration projects
Title: Message Title Pavel Roskin updated JENKINS-55853 Jenkins / JENKINS-55853 Customized Post Build Comment ignored for multi-configuration projects Change By: Pavel Roskin Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55853) Customized Post Build Comment ignored for multi-configuration projects
Title: Message Title Pavel Roskin updated an issue Jenkins / JENKINS-55853 Customized Post Build Comment ignored for multi-configuration projects Change By: Pavel Roskin URL: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/pull/43 Labels: configuration matrix stash Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55853) Customized Post Build Comment ignored for multi-configuration projects
Title: Message Title Pavel Roskin assigned an issue to Pavel Roskin Jenkins / JENKINS-55853 Customized Post Build Comment ignored for multi-configuration projects Change By: Pavel Roskin Assignee: Pavel Roskin Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55853) Customized Post Build Comment ignored for multi-configuration projects
Title: Message Title Pavel Roskin started work on JENKINS-55853 Change By: Pavel Roskin Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55853) Customized Post Build Comment ignored for multi-configuration projects
Title: Message Title Pavel Roskin updated JENKINS-55853 Jenkins / JENKINS-55853 Customized Post Build Comment ignored for multi-configuration projects Change By: Pavel Roskin Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55853) Customized Post Build Comment ignored for multi-configuration projects
Title: Message Title Pavel Roskin commented on JENKINS-55853 Re: Customized Post Build Comment ignored for multi-configuration projects Indeed, it's possible to get the StashPostBuildComment object from the project using getPublishersList(). PR posted: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/pull/43 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55853) Customized Post Build Comment ignored for multi-configuration projects
Title: Message Title Pavel Roskin commented on JENKINS-55853 Re: Customized Post Build Comment ignored for multi-configuration projects I tried to fix the issue, but my knowledge of Jenkins internals is insufficient. Let's me just describe where I stopped. One approach is to introduce a dependency on the Matrix plugin. email-ext-plugins is an example of such code. It can select whether the post-build action happens in child builds, in the top-level build or in both. But I would rather avoid adding a dependency. I believe that StashPostBuildComment.perform() is not the best place to publish the configuration of StashPostBuildComment, as it happens in a child build. But I've noticed getRootProject() and getRootBuild(), I'll see if they would help. A cleaner approach would be to examine the project for an object of the given class, just like it's done for the trigger. StashBuild.onCompleted() calls StashBuildTrigger.getTrigger(build.getProject()), which is implemented using project's getTrigger(). That would make it possible to read the StashPostBuildComment configuration from the project. But I don't see such method for post-build actions. Another approach would be to make StashPostBuildComment listen to some event that happens for the top-level build and publish its configuration with addAction to that build. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55853) Customized Post Build Comment ignored for multi-configuration projects
Title: Message Title Pavel Roskin commented on JENKINS-55853 Re: Customized Post Build Comment ignored for multi-configuration projects As I suspected, there is some data that is created in the child builds but consumed in the top level build. Specifically, StashPostBuildComment.perform() is run in child executors and creates StashPostBuildCommentAction objects. Then StashBuilds.onCompleted() is run in the top level project and tries to get comments from StashPostBuildCommentAction. It gets null, quite expectedly. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55853) Customized Post Build Comment ignored for multi-configuration projects
Title: Message Title Jakub Bochenski commented on JENKINS-55853 Re: Customized Post Build Comment ignored for multi-configuration projects Sorry, I don't really use multiconfiguration projects so I can't help here. Will be glad to review a PR though Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55853) Customized Post Build Comment ignored for multi-configuration projects
Title: Message Title Pavel Roskin created an issue Jenkins / JENKINS-55853 Customized Post Build Comment ignored for multi-configuration projects Issue Type: Bug Assignee: Unassigned Components: stash-pullrequest-builder-plugin Created: 2019-01-30 06:49 Environment: Jenkins 2.138.4, stash-pullrequest-builder-plugin 1.7.0. Labels: configuration Priority: Minor Reporter: Pavel Roskin The "Post Build Comment" settings are ignored for some jobs. Instead, Jenkins posts the default comments to Stash. I tried customizing several jobs, and I see that the customization is ignored if and only if it's a multi-configuration project. Free-style projects support customized messages. Add Comment
