[JIRA] (JENKINS-56257) Git clone/fetch filtering user:password from git https://user:pwd@path-2-git
Title: Message Title Mark Waite updated JENKINS-56257 Jenkins / JENKINS-56257 Git clone/fetch filtering user:password from git https://user:pwd@path-2-git Change By: Mark Waite Status: Fixed but Unreleased Closed Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.197828.1551027038000.3660.1568478300405%40Atlassian.JIRA.
[JIRA] (JENKINS-56257) Git clone/fetch filtering user:password from git https://user:pwd@path-2-git
Title: Message Title Mark Waite updated JENKINS-56257 Included in git client plugin 2.8.5 Jenkins / JENKINS-56257 Git clone/fetch filtering user:password from git https://user:pwd@path-2-git Change By: Mark Waite Status: Open Fixed but Unreleased Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the w
[JIRA] (JENKINS-56257) Git clone/fetch filtering user:password from git https://user:pwd@path-2-git
Title: Message Title Chandrasekar Sankarram commented on JENKINS-56257 Re: Git clone/fetch filtering user:password from git https://user:pwd@path-2-git Fixed in https://github.com/jenkinsci/git-client-plugin/pull/416 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56257) Git clone/fetch filtering user:password from git https://user:pwd@path-2-git
Title: Message Title Chandrasekar Sankarram commented on JENKINS-56257 Re: Git clone/fetch filtering user:password from git https://user:pwd@path-2-git Hello Mark, We need this fix as soon as possible, will fix it and send PR Thanks Sankar Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56257) Git clone/fetch filtering user:password from git https://user:pwd@path-2-git
Title: Message Title Chandrasekar Sankarram assigned an issue to Chandrasekar Sankarram Jenkins / JENKINS-56257 Git clone/fetch filtering user:password from git https://user:pwd@path-2-git Change By: Chandrasekar Sankarram Assignee: Chandrasekar Sankarram Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56257) Git clone/fetch filtering user:password from git https://user:pwd@path-2-git
Title: Message Title Mark Waite assigned an issue to Unassigned Jenkins / JENKINS-56257 Git clone/fetch filtering user:password from git https://user:pwd@path-2-git Change By: Mark Waite Assignee: Mark Waite Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56257) Git clone/fetch filtering user:password from git https://user:pwd@path-2-git
Title: Message Title Mark Waite updated an issue Jenkins / JENKINS-56257 Git clone/fetch filtering user:password from git https://user:pwd@path-2-git Change By: Mark Waite Component/s: git-client-plugin Component/s: git-plugin Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56257) Git clone/fetch filtering user:password from git https://user:pwd@path-2-git
Title: Message Title Chandrasekar Sankarram updated an issue Jenkins / JENKINS-56257 Git clone/fetch filtering user:password from git https://user:pwd@path-2-git Change By: Chandrasekar Sankarram Summary: Git clone/fetch filtering user:password from git https://user:pwd / @ path-2-git Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56257) Git clone/fetch filtering user:password from git https://user:pwd/path-2-git
Title: Message Title Chandrasekar Sankarram created an issue Jenkins / JENKINS-56257 Git clone/fetch filtering user:password from git https://user:pwd/path-2-git Issue Type: Bug Assignee: Mark Waite Components: git-plugin Created: 2019-02-24 16:50 Priority: Major Reporter: Chandrasekar Sankarram CliGitApiImpl fetch method is not binding git fetch url correctly, URIished url is binding the args by filtering the user:password in the url with call to url.toString() as against url.toPrivateString() to allow the original url to be passed through. It is understood for some git access command like commit can potentially cause issue; and it is valid to filter the user:password for special situation and enforce the security via credentials binding routes. Fix is identified and isolated to CliGitApiImpl FetchCommand fetch_() execute method and url binding to args list around line 454 in current version is: args.add(url); and to be revised as args.add(url.toPrivateString()); Above revision will benefit for scenarios when we create seeding jobs to create another job and pass it parameters. This will also relieve the need to setup credentials in jenkins globally and the callers url is respected for the processing Thanks Sankar
[JIRA] (JENKINS-56257) Git clone/fetch filtering user:password from git https://user:pwd/path-2-git
Title: Message Title Chandrasekar Sankarram created an issue Jenkins / JENKINS-56257 Git clone/fetch filtering user:password from git https://user:pwd/path-2-git Issue Type: Bug Assignee: Mark Waite Components: git-plugin Created: 2019-02-24 16:50 Priority: Major Reporter: Chandrasekar Sankarram CliGitApiImpl fetch method is not binding git fetch url correctly, URIished url is binding the args by filtering the user:password in the url with call to url.toString() as against url.toPrivateString() to allow the original url to be passed through. It is understood for some git access command like commit can potentially cause issue; and it is valid to filter the user:password for special situation and enforce the security via credentials binding routes. Fix is identified and isolated to CliGitApiImpl FetchCommand fetch_() execute method and url binding to args list around line 454 in current version is: args.add(url); and to be revised as args.add(url.toPrivateString()); Above revision will benefit for scenarios when we create seeding jobs to create another job and pass it parameters. This will also relieve the need to setup credentials in jenkins globally and the callers url is respected for the processing Thanks Sankar
