[JIRA] (JENKINS-56699) Provide formatter for messages that contain newlines
Title: Message Title Ulli Hafner updated JENKINS-56699 Jenkins / JENKINS-56699 Provide formatter for messages that contain newlines Change By: Ulli Hafner Status: Open Fixed but Unreleased Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198337.1553335794000.14484.1587453960293%40Atlassian.JIRA.
[JIRA] (JENKINS-56699) Provide formatter for messages that contain newlines
Title: Message Title Benjamin Cross commented on JENKINS-56699 Re: Provide formatter for messages that contain newlines Ulli Hafner I made a PR [#438|https://github.com/jenkinsci/warnings-ng-plugin/pull/438] with what I think you are looking for. Let me know if you have any suggestions or changes. Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198337.1553335794000.9140.1586552220336%40Atlassian.JIRA.
[JIRA] (JENKINS-56699) Provide formatter for messages that contain newlines
Title: Message Title Benjamin Cross edited a comment on JENKINS-56699 Re: Provide formatter for messages that contain newlines [~drulli] I made a PR [ # 438|[https://github.com/jenkinsci/warnings-ng-plugin/pull/438]] with what I think you are looking for. Let me know if you have any suggestions or changes. Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198337.1553335794000.9142.1586552220386%40Atlassian.JIRA.
[JIRA] (JENKINS-56699) Provide formatter for messages that contain newlines
Title: Message Title Ulli Hafner commented on JENKINS-56699 Re: Provide formatter for messages that contain newlines I see, you are looking for an newbie issue that you can fix? Currently some parsers create multiline messages and descriptions (in plain text using newlines as separator). If these messages are shown in the UI, then the newlines are simply ignored since they have no meaning in HTML. So the fix would be to detect the newlines and show the information in a better way. Example: Set a breakpoint in https://github.com/jenkinsci/warnings-ng-plugin/blob/master/src/test/java/io/jenkins/plugins/analysis/warnings/StepsITest.java#L275 and open the Jenkins under test (you need to suspend the test thread only). This parser creates a 2 line message. It has newlines in the issue.message property but in the UI it is shown in a single line. It would make sense to either put everything into a * or to insert after each line. (The same is true for the description if I remember correctly). I'm not sure if such a change can be applied to all parsers or if we should have a property for parsers that already report messages or descriptions in HTML. But we can check this afterwards if the fix is working for some of the multi-line parsers... Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198337.
[JIRA] (JENKINS-56699) Provide formatter for messages that contain newlines
Title: Message Title Benjamin Cross edited a comment on JENKINS-56699 Re: Provide formatter for messages that contain newlines Sorry, I'm very newbie and want to ensure I am understanding the improvement you are asking for. I see the SourcePrinter has a render method. When the message is rendered it uses the Sanitizer. Are you asking for a new method to put that message into html for the createTitle method where each new line is considered a newbreak ? Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198337.1553335794000.3057.1583183880139%40Atlassian.JIRA.
[JIRA] (JENKINS-56699) Provide formatter for messages that contain newlines
Title: Message Title Benjamin Cross edited a comment on JENKINS-56699 Re: Provide formatter for messages that contain newlines Sorry, I'm very newbie and want to ensure I am understanding the improvement you are asking for. I see the SourcePrinter has a render method. When the message is rendered it uses the Sanitizer. Are you asking for a new method to put that message into html for the createTitle method where each new line is considered a new ? Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198337.1553335794000.3003.1583182200107%40Atlassian.JIRA.
[JIRA] (JENKINS-56699) Provide formatter for messages that contain newlines
Title: Message Title Benjamin Cross commented on JENKINS-56699 Re: Provide formatter for messages that contain newlines Sorry, I'm very newbie and want to ensure I am understanding the improvement you are asking for. I see the SourcePrinter has a render method. When the message is rendered it uses the Sanitizer. Are you asking for a new method to put that message into html for the createTitle method? Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198337.1553335794000.2995.1583182140354%40Atlassian.JIRA.
[JIRA] (JENKINS-56699) Provide formatter for messages that contain newlines
Title: Message Title Ulli Hafner commented on JENKINS-56699 Re: Provide formatter for messages that contain newlines Hmm, I don't think that this has been fixed yet. Or what do you think? Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198337.1553335794000.2869.1583173080099%40Atlassian.JIRA.
[JIRA] (JENKINS-56699) Provide formatter for messages that contain newlines
Title: Message Title Benjamin Cross commented on JENKINS-56699 Re: Provide formatter for messages that contain newlines So then can this issue be closed? What HTML tags should be added? Ulli Hafner Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198337.1553335794000.2841.1583169960206%40Atlassian.JIRA.
[JIRA] (JENKINS-56699) Provide formatter for messages that contain newlines
Title: Message Title Ulli Hafner updated an issue Jenkins / JENKINS-56699 Provide formatter for messages that contain newlines Change By: Ulli Hafner Labels: help-wanted newbie-friendly Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198337.1553335794000.1985.1569002940058%40Atlassian.JIRA.
[JIRA] (JENKINS-56699) Provide formatter for messages that contain newlines
Title: Message Title Andreas Pabst assigned an issue to Unassigned Jenkins / JENKINS-56699 Provide formatter for messages that contain newlines Change By: Andreas Pabst Assignee: Andreas Pabst Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56699) Provide formatter for messages that contain newlines
Title: Message Title Andreas Pabst assigned an issue to Andreas Pabst Jenkins / JENKINS-56699 Provide formatter for messages that contain newlines Change By: Andreas Pabst Assignee: Andreas Pabst Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56699) Provide formatter for messages that contain newlines
Title: Message Title Ulli Hafner assigned an issue to Unassigned Jenkins / JENKINS-56699 Provide formatter for messages that contain newlines Change By: Ulli Hafner Assignee: Ulli Hafner Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56699) Provide formatter for messages that contain newlines
Title: Message Title Ulli Hafner commented on JENKINS-56699 Re: Provide formatter for messages that contain newlines Rendering of the warnings message and description is done in: DetailsTableModel (see existing test DetailsTableModelTest) SourcePrinter (see existing test SourcePrinterTest) Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56699) Provide formatter for messages that contain newlines
Title: Message Title Ulli Hafner updated an issue Jenkins / JENKINS-56699 Provide formatter for messages that contain newlines Change By: Ulli Hafner Priority: Minor Major Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56699) Provide formatter for messages that contain newlines
Title: Message Title Ulli Hafner created an issue Jenkins / JENKINS-56699 Provide formatter for messages that contain newlines Issue Type: Improvement Assignee: Ulli Hafner Components: warnings-ng-plugin Created: 2019-03-23 10:09 Priority: Minor Reporter: Ulli Hafner If a message contains newline characters then the message is not shown properly in the UI. I.e. the content should be reformatted using HTML tags. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)