[JIRA] (JENKINS-57206) Support draft pull requests from GitHub
Title: Message Title Liam Newman updated JENKINS-57206 Jenkins / JENKINS-57206 Support draft pull requests from GitHub Change By: Liam Newman Status: Open Fixed but Unreleased Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198963.1556379411000.22337.1588720862506%40Atlassian.JIRA.
[JIRA] (JENKINS-57206) Support draft pull requests from GitHub
Title: Message Title Liam Newman updated JENKINS-57206 Jenkins / JENKINS-57206 Support draft pull requests from GitHub Change By: Liam Newman Status: Fixed but Unreleased Closed Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198963.1556379411000.22339.1588720862710%40Atlassian.JIRA.
[JIRA] (JENKINS-57206) Support draft pull requests from GitHub
Title: Message Title Jordan Jennings commented on JENKINS-57206 Re: Support draft pull requests from GitHub Draft PRs working here as well now. Maybe a complete coincidence, but as soon as we upgraded after the fix for JENKINS-54126 was released everything has been working as expected. Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198963.1556379411000.9818.1586803020338%40Atlassian.JIRA.
[JIRA] (JENKINS-57206) Support draft pull requests from GitHub
Title: Message Title Thomas Wunderlich commented on JENKINS-57206 Re: Support draft pull requests from GitHub I'll note that draft PRs are currently building for me, so this may have been fixed and can likely be closed. Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198963.1556379411000.9757.1586796180284%40Atlassian.JIRA.
[JIRA] (JENKINS-57206) Support draft pull requests from GitHub
Title: Message Title Josh Soref commented on JENKINS-57206 Re: Support draft pull requests from GitHub Ebrahim Moshaya: that's JENKINS-54126 Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198963.1556379411000.3351.1579639440338%40Atlassian.JIRA.
[JIRA] (JENKINS-57206) Support draft pull requests from GitHub
Title: Message Title Ebrahim Moshaya commented on JENKINS-57206 Re: Support draft pull requests from GitHub Still having this issue here... We don't use draft pull requests... we keep having to delete the cache and run the scan repository again which is not ideal Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198963.1556379411000.70.1568034960261%40Atlassian.JIRA.
[JIRA] (JENKINS-57206) Support draft pull requests from GitHub
Title: Message Title
Ben Langfeld edited a comment on JENKINS-57206
Re: Support draft pull requests from GitHub
I'm seeing the following event log entries when a draft PR is created:{code:java}Examining powerhome/nitro-web Checking branches... Getting remote branch benlangfeld-patch-1...Checking branch benlangfeld-patch-1 1 branches were processed Checking pull-requests... Getting remote pull request #12231...Checking pull request #12231 ‘Jenkinsfile’ not foundDoes not meet criteriaChecking pull request #12231 ‘Jenkinsfile’ not foundDoes not meet criteria 2 pull requests were processedFinished examining powerhome/nitro-web{code}The branch does of course contain a Jenkinsfile. When the same diff is used to open a non-draft PR, the Jenkinsfile is found. The only difference in the webhook received is the following: {code:java}"draft": true,"mergeable_state": "draft",{code}vs {code:java}"draft": false,"mergeable_state": "unknown",{code}This difference should not cause the divergence in detection of the Jenkinsfile, but I can't figure out what does; the code is a massive jumble of dependencies. Can someone help me unravel it so I can figure out what's going on here?
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198963.1556379411000.2234.1565745780231%40Atlassian.JIRA.
[JIRA] (JENKINS-57206) Support draft pull requests from GitHub
Title: Message Title Ben Langfeld commented on JENKINS-57206 Re: Support draft pull requests from GitHub I'm seeing the following event log entries when a draft PR is created: Examining powerhome/nitro-web Checking branches... Getting remote branch benlangfeld-patch-1... Checking branch benlangfeld-patch-1 1 branches were processed Checking pull-requests... Getting remote pull request #12231... Checking pull request #12231 ‘Jenkinsfile’ not found Does not meet criteria Checking pull request #12231 ‘Jenkinsfile’ not found Does not meet criteria 2 pull requests were processed Finished examining powerhome/nitro-web The branch does of course contain a Jenkinsfile. When the same diff is used to open a non-draft PR, the Jenkinsfile is found. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198963.1556379411000.2232.1565745540170%40Atlassian.JIRA.
[JIRA] (JENKINS-57206) Support draft pull requests from GitHub
Title: Message Title
Liam Newman updated an issue
Jenkins / JENKINS-57206
Support draft pull requests from GitHub
Change By:
Liam Newman
We use GitHub PRs as conditions to build prerelease version of our applications using the following pipeline clause: {{ when \{ changeRequest() } }} However, if we create the pull requests as _draft_ pull requests (a nice feature for in-progress work), Jenkins does not detect the PR or create any build for it. We have enabled the traits below, but I cannot find any hints regarding draft PRs:{{}} {{}} {{1}} {{}} {{}} {{1}} {{}} {{}} {{1}} {{}} {{}} {{}} {{}}
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57206) Support draft pull requests from GitHub
Title: Message Title
Liam Newman updated an issue
Jenkins / JENKINS-57206
Support draft pull requests from GitHub
Change By:
Liam Newman
We use GitHub PRs as conditions to build prerelease version of our applications using the following pipeline clause:{ \ {when \ { changeRequest() } }}However, if we create the pull requests as _draft_ pull requests (a nice feature for in-progress work), Jenkins does not detect the PR or create any build for it. We have enabled the traits below, but I cannot find any hints regarding draft PRs:{{}} {{}} {{1}} {{}} {{}} {{1}} {{}} {{}} {{1}} {{}} {{}} {{}} {{}}
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57206) Support draft pull requests from GitHub
Title: Message Title
Liam Newman updated an issue
Jenkins / JENKINS-57206
Support draft pull requests from GitHub
Change By:
Liam Newman
We use GitHub PRs as conditions to build prerelease version of our applications using the following pipeline clause:{ \ {when \ { changeRequest() }}}However, if we create the pull requests as _draft_ pull requests (a nice feature for in-progress work), Jenkins does not detect the PR or create any build for it. We have enabled the traits below, but I cannot find any hints regarding draft PRs:{{}} {{}} {{1}} {{}} {{}} {{1}} {{}} {{}} {{1}} {{}} {{}} {{}} {{}}
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57206) Support draft pull requests from GitHub
Title: Message Title
Liam Newman updated an issue
Jenkins / JENKINS-57206
Support draft pull requests from GitHub
Change By:
Liam Newman
We use GitHub PRs as conditions to build prerelease version of our applications using the following pipeline clause: {{ when \{ changeRequest() } }} However, if we create the pull requests as _draft_ pull requests (a nice feature for in-progress work), Jenkins does not detect the PR or create any build for it. We have enabled the traits below, but I cannot find any hints regarding draft PRs:{{}} {{}} {{1}} {{}} {{}} {{1}} {{}} {{}} {{1}} {{}} {{}} {{}} {{}}
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57206) Support draft pull requests from GitHub
Title: Message Title
Liam Newman updated an issue
Jenkins / JENKINS-57206
Support draft pull requests from GitHub
Change By:
Liam Newman
We use GitHub PRs as conditions to build prerelease version of our applications using the following pipeline clause:{{when \{ changeRequest() }}}However, if we create the pull requests as _draft_ pull requests (a nice feature for in-progress work), Jenkins does not detect the PR or create any build for it. We have enabled the traits below, but I cannot find any hints regarding draft PRs:{{}}{{}}{{1}}{{}}{{}}{{1}}{{}}{{}}{{1}}{{}}{{}}{{}}{{}}
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57206) Support draft pull requests from GitHub
Title: Message Title
Liam Newman updated an issue
Jenkins / JENKINS-57206
Support draft pull requests from GitHub
Change By:
Liam Newman
We use GitHub PRs as conditions to build prerelease version of our applications using the following pipeline clause:{{ when \{ changeRequest() }}}However, if we create the pull requests as _draft_ pull requests (a nice feature for in-progress work), Jenkins does not detect the PR or create any build for it. We have enabled the traits below, but I cannot find any hints regarding draft PRs:{{ }}{{ }}{{ 1}}{{ }}{{ }}{{ 1}}{{ }}{{ }}{{ 1}}{{ }}{{ }}{{ }}{{ }}
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57206) Support draft pull requests from GitHub
Title: Message Title asgeirn commented on JENKINS-57206 Re: Support draft pull requests from GitHub It would appear the issue is related to the GitHub webhook - after the scheduled repository scan, the PR was detected. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57206) Support draft pull requests from GitHub
Title: Message Title
asgeirn created an issue
Jenkins / JENKINS-57206
Support draft pull requests from GitHub
Issue Type:
Improvement
Assignee:
Unassigned
Components:
github-branch-source-plugin
Created:
2019-04-27 15:36
Environment:
OpenJDK 1.8.0_212-8u212-b01-1~deb9u1-b01, Jenkins 2,164.2, github-branch-source 2.4.5 os.arch amd64 os.name Linux os.version 4.15.0-1037-azure
Priority:
Minor
Reporter:
asgeirn
We use GitHub PRs as conditions to build prerelease version of our applications using the following pipeline clause: {{ when { changeRequest() }}} However, if we create the pull requests as draft pull requests (a nice feature for in-progress work), Jenkins does not detect the PR or create any build for it. We have enabled the traits below, but I cannot find any hints regarding draft PRs: {{ }} {{ branch_source.BranchDiscoveryTrait>}} {{ 1}} {{ branch_source.BranchDiscoveryTrait>}} {{ branch_source.OriginPullRequestDiscoveryTrait>}} {{ 1}} {{ branch_source.OriginPullRequestDiscoveryTrait>}} {{ branch_source.ForkPullRequestDiscoveryTrait>}} {{ 1}} {{ }} {{ branch_source.ForkPullRequestDiscoveryTrait>}} {{ branch_source.TagDiscoveryTrait/>}} {{ }}
