[JIRA] (JENKINS-57691) GitLabAuthSourceTest fails

2019-05-28 Thread parichay.barpa...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Parichay Barpanda updated  JENKINS-57691  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-57691  
 
 
  GitLabAuthSourceTest fails   
 

  
 
 
 
 

 
Change By: 
 Parichay Barpanda  
 
 
Status: 
 In  Progress  Review  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199626.1558901074000.14221.1559069160442%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-57691) GitLabAuthSourceTest fails

2019-05-28 Thread parichay.barpa...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Parichay Barpanda updated  JENKINS-57691  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Solved after adding GitLabAuthToken class to Extension list.  
 

  
 
 
 
 

 
 Jenkins /  JENKINS-57691  
 
 
  GitLabAuthSourceTest fails   
 

  
 
 
 
 

 
Change By: 
 Parichay Barpanda  
 
 
Status: 
 In Review Resolved  
 
 
Resolution: 
 Fixed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199626.1558901074000.14222.1559069160463%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-57691) GitLabAuthSourceTest fails

2019-05-28 Thread parichay.barpa...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Parichay Barpanda started work on  JENKINS-57691  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Parichay Barpanda  
 
 
Status: 
 Open In Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199626.1558901074000.14218.1559069100259%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-57691) GitLabAuthSourceTest fails

2019-05-28 Thread parichay.barpa...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Parichay Barpanda commented on  JENKINS-57691  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: GitLabAuthSourceTest fails   
 

  
 
 
 
 

 
 The GitLabAuthToken was not annotated with Extension so the credentials plugin always returned `null` for the runtime initalisation.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199626.1558901074000.14217.1559069100243%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-57691) GitLabAuthSourceTest fails

2019-05-26 Thread parichay.barpa...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Parichay Barpanda updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-57691  
 
 
  GitLabAuthSourceTest fails   
 

  
 
 
 
 

 
Change By: 
 Parichay Barpanda  
 
 
Sprint: 
 GSoC 2019.  Coding Phase 1  Community Bonding  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199626.1558901074000.12123.1558901220162%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-57691) GitLabAuthSourceTest fails

2019-05-26 Thread parichay.barpa...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Parichay Barpanda created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-57691  
 
 
  GitLabAuthSourceTest fails   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 Parichay Barpanda  
 
 
Components: 
 gitlab-branch-source-plugin  
 
 
Created: 
 2019-05-26 20:04  
 
 
Labels: 
 gsoc-2019  
 
 
Priority: 
  Critical  
 
 
Reporter: 
 Parichay Barpanda  
 

  
 
 
 
 

 
 The test fails in `given_tokenCredentialwhenconvertthen_tokenAuth()` method of `GitLabAuthSourceTest` class.  This function is responsible for checking if the `GitLabAuth` object returned by `AuthenticationTokens.convert(GitLabAuth, PersonalAccessToken)` is actually an instance of `GitLabAuthToken`. But the object returned is null while `PersonalAccessToken` object is not null. The error shown: ``` java.lang.AssertionError: java.lang.AssertionError: Expected: an instance of io.jenkins.plugins.gitlabbranchsource.client.api.GitLabAuthToken     but: null {{ at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.junit.Assert.assertThat(Assert.java:956) at org.junit.Assert.assertThat(Assert.java:923) at io.jenkins.plugins.gitlabbranchsource.authentication.GitLabAuthSourceTest.given_tokenCredentialwhenconvertthen_tokenAuth(GitLabAuthSourceTest.java:31) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) a