[JIRA] (JENKINS-58306) Kubernetes plugin upgrade breaks ownerReference usage
Title: Message Title Deiwin Sarjas commented on JENKINS-58306 Re: Kubernetes plugin upgrade breaks ownerReference usage Thank you for the quick fix and release! Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200414.1562098146000.13624.1563348900520%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-58306) Kubernetes plugin upgrade breaks ownerReference usage
Title: Message Title Jesse Glick updated JENKINS-58306 Jenkins / JENKINS-58306 Kubernetes plugin upgrade breaks ownerReference usage Change By: Jesse Glick Status: Fixed but Unreleased Resolved Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200414.1562098146000.12587.1563303780211%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-58306) Kubernetes plugin upgrade breaks ownerReference usage
Title: Message Title Jesse Glick updated an issue Jenkins / JENKINS-58306 Kubernetes plugin upgrade breaks ownerReference usage Change By: Jesse Glick Released As: 1.17.2 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200414.1562098146000.12186.1563284880169%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-58306) Kubernetes plugin upgrade breaks ownerReference usage
Title: Message Title Vincent Latombe updated JENKINS-58306 Jenkins / JENKINS-58306 Kubernetes plugin upgrade breaks ownerReference usage Change By: Vincent Latombe Status: In Review Fixed but Unreleased Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200414.1562098146000.12184.1563284820837%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-58306) Kubernetes plugin upgrade breaks ownerReference usage
Title: Message Title Jesse Glick updated JENKINS-58306 Jenkins / JENKINS-58306 Kubernetes plugin upgrade breaks ownerReference usage Change By: Jesse Glick Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200414.1562098146000.12181.1563284820758%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-58306) Kubernetes plugin upgrade breaks ownerReference usage
Title: Message Title Jesse Glick assigned an issue to Jesse Glick Jenkins / JENKINS-58306 Kubernetes plugin upgrade breaks ownerReference usage Change By: Jesse Glick Assignee: Carlos Sanchez Jesse Glick Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200414.1562098146000.11237.1563201900281%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-58306) Kubernetes plugin upgrade breaks ownerReference usage
Title: Message Title Jesse Glick started work on JENKINS-58306 Change By: Jesse Glick Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200414.1562098146000.11239.1563201900307%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-58306) Kubernetes plugin upgrade breaks ownerReference usage
Title: Message Title
Deiwin Sarjas commented on JENKINS-58306
Re: Kubernetes plugin upgrade breaks ownerReference usage
Here's a pipeline snippet that checks for this behavior. I left out the auth things, because they're specific to the k8s cluster. We use a default service account in some cases and a kubectl config mounted from a k8s secret in other cases, for reference.
def kubectlYaml = """\
apiVersion: v1
kind: Pod
spec:
containers:
- name: kubectl
image: bitnami/kubectl:1.12
stdin: true
tty: true
command:
- '/bin/sh'
args:
- -c
- cat
env:
- name: HUB_NAME
valueFrom:
fieldRef:
fieldPath: metadata.name
- name: HUB_UID
valueFrom:
fieldRef:
fieldPath: metadata.uid
- name: HUB_IP
valueFrom:
fieldRef:
fieldPath: status.podIP
securityContext:
runAsUser: 1000
fsGroup: 1000
"""
def name = "test-${UUID.randomUUID()}"
podTemplate(
cloud: '..',
name: name,
label: name,
podRetention: never(),
idleMinutes: 0,
yaml: kubectlYaml,
) {
node(name) {
container('kubectl') {
sh('''\
deploy=$(
kubectl create -o name -f -
[JIRA] (JENKINS-58306) Kubernetes plugin upgrade breaks ownerReference usage
Title: Message Title Deiwin Sarjas commented on JENKINS-58306 Re: Kubernetes plugin upgrade breaks ownerReference usage Just FYI, we use this to create on-deman Selenium clusters. The test pod has a container for the Selenium hub, and then we spawn a whole bunch of browsers. The browsers are garbage collected by k8s after the test finishes and the test pod is cleaned up by kubernetes-plugin. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200414.1562098146000.6940.1562768880497%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-58306) Kubernetes plugin upgrade breaks ownerReference usage
Title: Message Title Deiwin Sarjas commented on JENKINS-58306 Re: Kubernetes plugin upgrade breaks ownerReference usage Yeah, I think I can put together a simple Jenkinsfile to demonstrate this. I'll post it here when I have one. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200414.1562098146000.6932.1562768701163%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-58306) Kubernetes plugin upgrade breaks ownerReference usage
Title: Message Title Jesse Glick commented on JENKINS-58306 Re: Kubernetes plugin upgrade breaks ownerReference usage Deiwin Sarjas do you have a simple way to reproduce this issue, such as a self-contained demo repository? In particular it is not obvious to me how your build pod is creating resources (I suppose using a service account?) and finding its own name/UID to link to. This seems like a rather unusual use case, certainly not one we normally test. We would ideally be able to write a functional test in kubernetes-plugin that fails in master (in the expected way—derivative resource remains after build completion) but passes when the client dependency is updated to include this proposed fix. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200414.1562098146000.6928.1562767980153%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-58306) Kubernetes plugin upgrade breaks ownerReference usage
Title: Message Title Deiwin Sarjas created an issue Jenkins / JENKINS-58306 Kubernetes plugin upgrade breaks ownerReference usage Issue Type: Bug Assignee: Carlos Sanchez Components: kubernetes-plugin Created: 2019-07-02 20:09 Environment: Jenkins 2.176.1 kubernetes-plugin 1.16.2 Priority: Minor Reporter: Deiwin Sarjas Background We create Kubernetes resources (Deployments) from within Kubernetes Pods created with podTemplate. We want these resources to be deleted when the Pod created with podTemplate is deleted. To do this we set ownerReferences for the created resources, using the generated Pod's name and uid. This worked well for us a for a while. Problem We upgraded the Kubernetes plugin from 1.15.2 to 1.16.2 and this stopped working. The manually created resources (Deployments) weren't being cleaned up by Kubernetes garbage collection any more. We had to revert the plugin upgrade. Possible cause Version 1.16.0 of the plugin upgraded kubernetes-client from 4.1.3 to 4.3.0. The changelog for kubernetes-client includes only one change within that range that would be likely to cause this change in behavior: Fix #758: Deleting Deployments with `.cascading(true)` creates a new Replica Set. Possible fix I don't understand the plugin's code well, but it seems like adding .cascading(true) to this line could return the previous behavior.
