[JIRA] (JENKINS-58540) Console output of pipeline extra stars
Title: Message Title Karol Gil commented on JENKINS-58540 Re: Console output of pipeline extra stars Jesse Glick we have a set of secrets assigned to pods depending on the environment which they are testing. If given service does not exist on certain environment secret for it is empty. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200689.1563433318000.2886.1564405980252%40Atlassian.JIRA.
[JIRA] (JENKINS-58540) Console output of pipeline extra stars
Title: Message Title Jesse Glick commented on JENKINS-58540 Re: Console output of pipeline extra stars As a matter of curiosity, how did you wind up with an empty secret to begin with? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200689.1563433318000.2880.1564405380244%40Atlassian.JIRA.
[JIRA] (JENKINS-58540) Console output of pipeline extra stars
Title: Message Title Jesse Glick commented on JENKINS-58540 Re: Console output of pipeline extra stars Best done upstream in JENKINS-58706. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200689.1563433318000.2873.1564405262164%40Atlassian.JIRA.
[JIRA] (JENKINS-58540) Console output of pipeline extra stars
Title: Message Title Jesse Glick started work on JENKINS-58540 Change By: Jesse Glick Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200689.1563433318000.2855.1564405141064%40Atlassian.JIRA.
[JIRA] (JENKINS-58540) Console output of pipeline extra stars
Title: Message Title Jesse Glick assigned an issue to Karol Gil Jenkins / JENKINS-58540 Console output of pipeline extra stars Change By: Jesse Glick Assignee: Karol Gil Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200689.1563433318000.2848.1564405140956%40Atlassian.JIRA.
[JIRA] (JENKINS-58540) Console output of pipeline extra stars
Title: Message Title Jesse Glick updated JENKINS-58540 Jenkins / JENKINS-58540 Console output of pipeline extra stars Change By: Jesse Glick Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200689.1563433318000.2862.1564405141139%40Atlassian.JIRA.
[JIRA] (JENKINS-58540) Console output of pipeline extra stars
Title: Message Title Vincent Latombe updated an issue Jenkins / JENKINS-58540 Console output of pipeline extra stars Change By: Vincent Latombe Component/s: kubernetes-plugin Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200689.1563433318000.2660.1564398782410%40Atlassian.JIRA.
[JIRA] (JENKINS-58540) Console output of pipeline extra stars
Title: Message Title Karol Gil commented on JENKINS-58540 Re: Console output of pipeline extra stars I've added a PR with fix proposal, feel free to comment/feedback there: https://github.com/jenkinsci/kubernetes-plugin/pull/558 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200689.1563433318000.2649.1564398480197%40Atlassian.JIRA.
[JIRA] (JENKINS-58540) Console output of pipeline extra stars
Title: Message Title Karol Gil commented on JENKINS-58540 Re: Console output of pipeline extra stars I meant using system properties - won't clutter the UI but will still be an option. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200689.1563433318000.1813.1564152000627%40Atlassian.JIRA.
[JIRA] (JENKINS-58540) Console output of pipeline extra stars
Title: Message Title Daniel Beck commented on JENKINS-58540 Re: Console output of pipeline extra stars A single character is also too short to be useful in masking. 2 should be the minimum for masking (and it needs to be documented). Would recommend against an option, the vast majority won't care or even understand it, and it'll just clutter up the UI. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200689.1563433318000.1786.1564148580518%40Atlassian.JIRA.
[JIRA] (JENKINS-58540) Console output of pipeline extra stars
Title: Message Title Karol Gil commented on JENKINS-58540 Re: Console output of pipeline extra stars I think it still might not be enough. The problem is IMO that your secret may be common for example `kubernetes` and then making it into `***` can easily give away your secret anyway - as you'll find many like that in the logs. But this is fixable on end user side of things, so I agree, having even length > 0 would be great or even better - to be configurable. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200689.1563433318000.1763.1564147500175%40Atlassian.JIRA.
[JIRA] (JENKINS-58540) Console output of pipeline extra stars
Title: Message Title Daniel Beck commented on JENKINS-58540 Re: Console output of pipeline extra stars Karol Gil Agree, that was also my guess in the first comment. Would consider no value shorter than two characters maskable. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200689.1563433318000.1750.1564145760453%40Atlassian.JIRA.
[JIRA] (JENKINS-58540) Console output of pipeline extra stars
Title: Message Title
Karol Gil edited a comment on JENKINS-58540
Re: Console output of pipeline extra stars
I think the problem lies in `SecretsMasker` class. Here, it tries to replace every value kept in `values` set with bunch of asterisks: [https://github.com/jenkinsci/kubernetes-plugin/blob/master/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/SecretsMasker.java#L74]But what is not takes into account I assume, is that some of strings kept in `values` field may be empty string "" causing this line be like:{{ s = s.replace("", "");}}which actually gives away the secret value :) I'm not sure how to implement it properly, but this assumes that secrets are not obvious strings that will be replaced.
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200689.1563433318000.1691.1564142100198%40Atlassian.JIRA.
[JIRA] (JENKINS-58540) Console output of pipeline extra stars
Title: Message Title
Karol Gil edited a comment on JENKINS-58540
Re: Console output of pipeline extra stars
I think the problem lies in `SecretsMasker` class. Here, it tries to replace every value kept in `values` set with bunch of asterisks: [ https://github.com/jenkinsci/kubernetes-plugin/blob/master/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/SecretsMasker.java#L74 ] But what is not takes into account I assume, is that some of strings kept in `values` field may be empty string "" causing this line be like: ``` s = s.replace("", ""); ``` which actually gives away the secret value :)
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200689.1563433318000.1677.1564141980961%40Atlassian.JIRA.
[JIRA] (JENKINS-58540) Console output of pipeline extra stars
Title: Message Title
Karol Gil edited a comment on JENKINS-58540
Re: Console output of pipeline extra stars
I think the problem lies in `SecretsMasker` class. Here, it tries to replace every value kept in `values` set with bunch of asterisks: [https://github.com/jenkinsci/kubernetes-plugin/blob/master/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/SecretsMasker.java#L74]But what is not takes into account I assume, is that some of strings kept in `values` field may be empty string "" causing this line be like:{{ s = s.replace("", "");}}which actually gives away the secret value :)
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200689.1563433318000.1685.1564141981200%40Atlassian.JIRA.
[JIRA] (JENKINS-58540) Console output of pipeline extra stars
Title: Message Title
Karol Gil edited a comment on JENKINS-58540
Re: Console output of pipeline extra stars
I think the problem lies in `SecretsMasker` class. Here, it tries to replace every value kept in `values` set with bunch of asterisks: [https://github.com/jenkinsci/kubernetes-plugin/blob/master/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/SecretsMasker.java#L74]But what is not takes into account I assume, is that some of strings kept in `values` field may be empty string "" causing this line be like: {{ s = s.replace("", ""); }} which actually gives away the secret value :)
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200689.1563433318000.1683.1564141981154%40Atlassian.JIRA.
[JIRA] (JENKINS-58540) Console output of pipeline extra stars
Title: Message Title
Karol Gil commented on JENKINS-58540
Re: Console output of pipeline extra stars
I think the problem lies in `SecretsMasker` class. Here, it tries to replace every value kept in `values` set with bunch of asterisks: https://github.com/jenkinsci/kubernetes-plugin/blob/master/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/SecretsMasker.java#L74 But what is not takes into account I assume, is that some of strings kept in `values` field may be empty string "" causing this line be like: ``` s = s.replace("", ""); ``` which actually gives away the secret value
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200689.1563433318000.1667.1564141921182%40Atlassian.JIRA.
[JIRA] (JENKINS-58540) Console output of pipeline extra stars
Title: Message Title Sebastian Wojas commented on JENKINS-58540 Re: Console output of pipeline extra stars Any updates here ? we have exactly the same problem on our end. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200689.1563433318000.858.1564060860205%40Atlassian.JIRA.
[JIRA] (JENKINS-58540) Console output of pipeline extra stars
Title: Message Title Daniel Beck updated an issue Jenkins / JENKINS-58540 Console output of pipeline extra stars Change By: Daniel Beck Component/s: credentials-binding-plugin Component/s: core Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200689.1563433318000.16709.1563551280247%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-58540) Console output of pipeline extra stars
Title: Message Title Matt Sicker commented on JENKINS-58540 Re: Console output of pipeline extra stars That looks like it's replacing empty spaces by asterisks, so yeah, it does appear that way. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200689.1563433318000.16702.1563548700117%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-58540) Console output of pipeline extra stars
Title: Message Title Erwin Müller commented on JENKINS-58540 Re: Console output of pipeline extra stars This worked before perfectly fine. All my secrets are set and the pipeline is green. Why is that happening only if I select a maven agent? I already tried to rename the agent in something like "aaa" and it's still happening. The extra * are added even if the pipeline is not using any secrets. The bug with the credential-binding plugin was solved in 2017. Maybe it's a regression. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200689.1563433318000.16291.1563526380089%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-58540) Console output of pipeline extra stars
Title: Message Title Daniel Beck commented on JENKINS-58540 Re: Console output of pipeline extra stars Matt Sicker Could this happen when a secret being masked is empty? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200689.1563433318000.16269.1563524220220%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-58540) Console output of pipeline extra stars
Title: Message Title
Erwin Müller created an issue
Jenkins / JENKINS-58540
Console output of pipeline extra stars
Issue Type:
Bug
Assignee:
Unassigned
Components:
core
Created:
2019-07-18 07:01
Environment:
Kubernetes 1.13. Jenkins ver. 2.176.2 installPlugins: - kubernetes:1.17.2 - workflow-job:2.32 - workflow-aggregator:2.6 - credentials-binding:1.19 - git:3.10.1 - oic-auth:1.6 - matrix-auth:2.4.2 - sonar:2.9 - config-file-provider:3.6.2 - gitea:1.1.2 - pipeline-maven:3.8.0 - junit-attachments:1.5 - jacoco:3.0.4 - warnings-ng:5.3.0 - pipeline-utility-steps:2.3.0 - groovy-postbuild:2.5 - embeddable-build-status:2.0.2
Labels:
consoleoutput
Priority:
Major
Reporter:
Erwin Müller
Since yesterday my console logs have extra * stars at each character. Even if I have a really simple pipeline like
pipeline {options {
buildDiscarder(logRotator(numToKeepStr: "3"))
disableConcurrentBuilds()
timeout(time: 120, unit: "MINUTES")
}agent {
label "maven-3-jdk-12"
}stages {/**
* The stage will checkout the current branch.
*/
stage("Checkout Build") {
steps {
checkout scm
}
}} // stages}
