[JIRA] (JENKINS-59466) Nested Views are incompatible with Config as Code

2019-11-21 Thread atay...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Alex Taylor commented on  JENKINS-59466  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Nested Views are incompatible with Config as Code   
 

  
 
 
 
 

 
 After testing out the PR, I have found that Nested views just pretty much doesnt work with Config as code. This stops if from breaking but the views dont actually work which means either nested views needs to ensure that it is following Config as Code practices or CasC needs to change so that this plugin works with it. I am assuming the former is going to be easiest. Technically, this defect is "done" but the plugin still doesnt work with CasC  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202064.1569007172000.4994.1574344082831%40Atlassian.JIRA.


[JIRA] (JENKINS-59466) Nested Views are incompatible with Config as Code

2019-09-25 Thread atay...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Alex Taylor commented on  JENKINS-59466  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Nested Views are incompatible with Config as Code   
 

  
 
 
 
 

 
 So I created this PR which does fix the error but I am not confident that this is the best fix since it would set the owner of all your nested views to the SYSTEM user or Jenkins user. That may be bad practice and make things break...  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202064.1569007172000.5295.1569443400185%40Atlassian.JIRA.


[JIRA] (JENKINS-59466) Nested Views are incompatible with Config as Code

2019-09-20 Thread atay...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Alex Taylor created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-59466  
 
 
  Nested Views are incompatible with Config as Code   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 Ewelina Wilkosz  
 
 
Components: 
 configuration-as-code-plugin, nested-view-plugin  
 
 
Created: 
 2019-09-20 19:19  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Alex Taylor  
 

  
 
 
 
 

 
 Issue: When trying to import a yaml with config as code, if that yml code has nested views then it will fail due to a Null pointer Steps to reproduce: 1. Create a view with nested views 2. Export that config as code yaml 3. Import the yaml and observe the null pointer The error: 

 

java.lang.Error: java.lang.reflect.InvocationTargetException
	at hudson.init.TaskMethodFinder.invoke(TaskMethodFinder.java:110)
	at hudson.init.TaskMethodFinder$TaskImpl.run(TaskMethodFinder.java:175)
	at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:296)
	at jenkins.model.Jenkins$5.runTask(Jenkins.java:1095)
	at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:214)
	at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.reflect.InvocationTargetException
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at hudson.init.TaskMethodFinder.invoke(TaskMethodFinder.java:104)
	... 8 more
Caused by: java.lang.NullPointerException
	at hudson.plugins.nested_view.NestedView.save(NestedView.java:258)
	at hudson.BulkChange.commit(BulkChange.java:98)
	at