[JIRA] (JENKINS-59992) "Jenkins.instance is missing" error when restarting Jenkins
Title: Message Title Wadeck Follonier updated JENKINS-59992 Symptoms resolved in 2.223 Jenkins / JENKINS-59992 "Jenkins.instance is missing" error when restarting Jenkins Change By: Wadeck Follonier Status: In Review Closed Resolution: Fixed Released As: 2.223 Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to
[JIRA] (JENKINS-59992) "Jenkins.instance is missing" error when restarting Jenkins
Title: Message Title Wadeck Follonier updated JENKINS-59992 Jenkins / JENKINS-59992 "Jenkins.instance is missing" error when restarting Jenkins Change By: Wadeck Follonier Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202800.1572474146000.6048.1582636322940%40Atlassian.JIRA.
[JIRA] (JENKINS-59992) "Jenkins.instance is missing" error when restarting Jenkins
Title: Message Title Wadeck Follonier assigned an issue to Wadeck Follonier Jenkins / JENKINS-59992 "Jenkins.instance is missing" error when restarting Jenkins Change By: Wadeck Follonier Assignee: Wadeck Follonier Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202800.1572474146000.6063.1582636323130%40Atlassian.JIRA.
[JIRA] (JENKINS-59992) "Jenkins.instance is missing" error when restarting Jenkins
Title: Message Title Wadeck Follonier started work on JENKINS-59992 Change By: Wadeck Follonier Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202800.1572474146000.6044.1582636260499%40Atlassian.JIRA.
[JIRA] (JENKINS-59992) "Jenkins.instance is missing" error when restarting Jenkins
Title: Message Title Wadeck Follonier commented on JENKINS-59992 Re: "Jenkins.instance is missing" error when restarting Jenkins Symptom correction proposal: https://github.com/jenkinsci/jenkins/pull/4525 Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202800.1572474146000.6042.1582636260473%40Atlassian.JIRA.
[JIRA] (JENKINS-59992) "Jenkins.instance is missing" error when restarting Jenkins
Title: Message Title
Wadeck Follonier edited a comment on JENKINS-59992
Re: "Jenkins.instance is missing" error when restarting Jenkins
Thank you [~csclutgen] for the report. Due to the stack trace, the symptoms are different from JENKINS-55070. Here the problem is revealed in [AuthorizationContainer.java#L169|https://github.com/jenkinsci/matrix-auth-plugin/blob/master/src/main/java/org/jenkinsci/plugins/matrixauth/AuthorizationContainer.java#L169].After a deeper investigation, the problem seems to be after the nullification of {{theInstance}} in [Jenkins#L3400|https://github.com/jenkinsci/jenkins/blob/06f4c89121533fd669a102c97b514534ef1ebcb7/core/src/main/java/jenkins/model/Jenkins.java#L3400-L3404]. There is a moment between the instance being null and the real restart (fraction of second) and during that that time, the instance cannot be retrieved.As the HudsonIsRestarting is only used as the last filter, it has no chance to avoid other computation yet. The problem is when a filter that is applied earlier, requires to have access to {{Jenkins.get()}}.I see two opportunities to correct the problem:# Ensure every filter or class being potentially used by a filter, to not use {{Jenkins.get()}}, but instead {{Jenkins.getInstanceOrNull()}} and act correctly in case it's null. This could require a lots of work and hard time explaining the situation to people.# Prevent the regular filters to be applied when the HudsonIsRestarting is the "app" in the servletContext. To elaborate on option 2, current flow of filters to servlet:* DiagnosticThreadNameFilter* CharacterEncodingFilter* CompressionFilter* HudsonFilter** ChainedServletFilter*** HttpSessionContextIntegrationFilter2*** BasicHeaderProcessor*** AuthenticationProcessingFilter2*** RememberMeProcessingFilter*** AnonymousProcessingFilter*** ExceptionTranslationFilter*** UnwrapSecurityExceptionFilter* CrumbFilter* PluginServletFilter** UserLanguages** [...] << PluginServletFilter.addFilter (mainly for legacy plugins)* Stapler as the main ServletWe could either bypass completely the filters (HudsonFilter + CrumbFilter + PluginServletFilter) and reach directly the app (Stapler), or disabling the configured filters. If we bypass the rest of the filter, we will have troubles to deliver the asset bounded to the restart page, but this could be done "inline" and avoid any other parallel call. That could solve the > WARNING h.s.HttpSessionContextIntegrationFilter2#hasInvalidSessionSeed: Encountered IllegalStateException trying to get a user. System init may not have completed yet. Invalidating user session.But I was not able to reproduce the second warning, as I was not using the WindowsService. I imagine it's somewhat linked.
Add Comment
[JIRA] (JENKINS-59992) "Jenkins.instance is missing" error when restarting Jenkins
Title: Message Title Daniel Beck assigned an issue to Unassigned Jenkins / JENKINS-59992 "Jenkins.instance is missing" error when restarting Jenkins Change By: Daniel Beck Assignee: Daniel Beck Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202800.1572474146000.11853.1573466820491%40Atlassian.JIRA.
[JIRA] (JENKINS-59992) "Jenkins.instance is missing" error when restarting Jenkins
Title: Message Title Daniel Beck updated an issue Jenkins / JENKINS-59992 "Jenkins.instance is missing" error when restarting Jenkins Change By: Daniel Beck Component/s: matrix-auth-plugin Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202800.1572474146000.11848.1573466820426%40Atlassian.JIRA.
[JIRA] (JENKINS-59992) "Jenkins.instance is missing" error when restarting Jenkins
Title: Message Title Oleg Nenashev assigned an issue to Daniel Beck Jenkins / JENKINS-59992 "Jenkins.instance is missing" error when restarting Jenkins Change By: Oleg Nenashev Assignee: Daniel Beck Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202800.1572474146000.11745.1573428840427%40Atlassian.JIRA.
[JIRA] (JENKINS-59992) "Jenkins.instance is missing" error when restarting Jenkins
Title: Message Title Oleg Nenashev updated an issue Jenkins / JENKINS-59992 "Jenkins.instance is missing" error when restarting Jenkins Change By: Oleg Nenashev Component/s: matrix-auth-plugin Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202800.1572474146000.11741.1573428840348%40Atlassian.JIRA.
[JIRA] (JENKINS-59992) "Jenkins.instance is missing" error when restarting Jenkins
Title: Message Title
Wadeck Follonier edited a comment on JENKINS-59992
Re: "Jenkins.instance is missing" error when restarting Jenkins
Thank you [~csclutgen] for the report. Due to the stack trace, the symptoms are different from JENKINS-55070. Here the problem is revealed in [AuthorizationContainer.java#L169|https://github.com/jenkinsci/matrix-auth-plugin/blob/master/src/main/java/org/jenkinsci/plugins/matrixauth/AuthorizationContainer.java#L169].After a deeper investigation, the problem seems to be after the nullification of {{theInstance}} in [Jenkins#L3400|https://github.com/jenkinsci/jenkins/blob/06f4c89121533fd669a102c97b514534ef1ebcb7/core/src/main/java/jenkins/model/Jenkins.java#L3400-L3404]. There is a moment between the instance being null and the real restart (fraction of second) and that that time, the instance cannot be retrieved.As the HudsonIsRestarting is only used as the last filter, it has no chance to avoid other computation yet. The problem is when a filter that is applied earlier, requires to have access to {{Jenkins.get()}}.I see two opportunities to correct the problem:# Ensure every filter or class being potentially used by a filter, to not use {{Jenkins.get()}}, but instead {{Jenkins.getInstanceOrNull()}} and act correctly in case it's null. This could require a lots of work and hard time explaining the situation to people.# Prevent the regular filters to be applied when the HudsonIsRestarting is the "app" in the servletContext. To elaborate on option 2, current flow of filters to servlet:* DiagnosticThreadNameFilter* CharacterEncodingFilter* CompressionFilter* HudsonFilter** ChainedServletFilter*** HttpSessionContextIntegrationFilter2*** BasicHeaderProcessor*** AuthenticationProcessingFilter2*** RememberMeProcessingFilter*** AnonymousProcessingFilter*** ExceptionTranslationFilter*** UnwrapSecurityExceptionFilter* * CrumbFilter* * PluginServletFilter** * UserLanguages** * [...] << PluginServletFilter.addFilter (mainly for legacy plugins)* Stapler as the main ServletWe could either bypass completely the filters (HudsonFilter + CrumbFilter + PluginServletFilter) and reach directly the app (Stapler), or disabling the configured filters. If we bypass the rest of the filter, we will have troubles to deliver the asset bounded to the restart page, but this could be done "inline" and avoid any other parallel call. That could solve the > WARNING h.s.HttpSessionContextIntegrationFilter2#hasInvalidSessionSeed: Encountered IllegalStateException trying to get a user. System init may not have completed yet. Invalidating user session.But I was not able to reproduce the second warning, as I was not using the WindowsService. I imagine it's somewhat linked.
Add Comment
[JIRA] (JENKINS-59992) "Jenkins.instance is missing" error when restarting Jenkins
Title: Message Title
Wadeck Follonier edited a comment on JENKINS-59992
Re: "Jenkins.instance is missing" error when restarting Jenkins
Thank you [~csclutgen] for the report. Due to the stack trace, the symptoms are different from JENKINS-55070. Here the problem is revealed in [AuthorizationContainer.java#L169|https://github.com/jenkinsci/matrix-auth-plugin/blob/master/src/main/java/org/jenkinsci/plugins/matrixauth/AuthorizationContainer.java#L169].After a deeper investigation, the problem seems to be after the nullification of {{theInstance}} in [Jenkins#L3400|https://github.com/jenkinsci/jenkins/blob/06f4c89121533fd669a102c97b514534ef1ebcb7/core/src/main/java/jenkins/model/Jenkins.java#L3400-L3404]. There is a moment between the instance being null and the real restart (fraction of second) and that that time, the instance cannot be retrieved.As the HudsonIsRestarting is only used as the last filter, it has no chance to avoid other computation yet. The problem is when a filter that is applied earlier, requires to have access to {{Jenkins.get()}}.I see two opportunities to correct the problem:# Ensure every filter or class being potentially used by a filter, to not use {{Jenkins.get()}}, but instead {{Jenkins.getInstanceOrNull()}} and act correctly in case it's null. This could require a lots of work and hard time explaining the situation to people.# Prevent the regular filters to be applied when the HudsonIsRestarting is the "app" in the servletContext. To elaborate on option 2, current flow of filters to servlet:* DiagnosticThreadNameFilter* CharacterEncodingFilter* CompressionFilter* HudsonFilter** ChainedServletFilter*** HttpSessionContextIntegrationFilter2*** BasicHeaderProcessor*** AuthenticationProcessingFilter2*** RememberMeProcessingFilter*** AnonymousProcessingFilter*** ExceptionTranslationFilter*** UnwrapSecurityExceptionFilter** CrumbFilter** PluginServletFilter*** UserLanguages*** [...] << PluginServletFilter.addFilter (mainly for legacy plugins)* Stapler as the main ServletWe could either bypass completely the filter filters (HudsonFilter + CrumbFilter + PluginServletFilter) and reach directly the app (Stapler) , or disabling the configured filters. If we bypass the rest of the filter, we will have troubles to deliver the asset bounded to the restart page, but this could be done "inline" and avoid any other parallel call. That could solve the > WARNING h.s.HttpSessionContextIntegrationFilter2#hasInvalidSessionSeed: Encountered IllegalStateException trying to get a user. System init may not have completed yet. Invalidating user session.But I was not able to reproduce the second warning, as I was not using the WindowsService. I imagine it's somewhat linked.
Add Comment
[JIRA] (JENKINS-59992) "Jenkins.instance is missing" error when restarting Jenkins
Title: Message Title Wadeck Follonier commented on JENKINS-59992 Re: "Jenkins.instance is missing" error when restarting Jenkins Thank you Craig Lutgen for the report. Due to the stack trace, the symptoms are different from JENKINS-55070. Here the problem is revealed in AuthorizationContainer.java#L169. After a deeper investigation, the problem seems to be after the nullification of theInstance in Jenkins#L3400. There is a moment between the instance being null and the real restart (fraction of second) and that that time, the instance cannot be retrieved. As the HudsonIsRestarting is only used as the last filter, it has no chance to avoid other computation yet. The problem is when a filter that is applied earlier, requires to have access to Jenkins.get(). I see two opportunities to correct the problem: Ensure every filter or class being potentially used by a filter, to not use Jenkins.get(), but instead Jenkins.getInstanceOrNull() and act correctly in case it's null. This could require a lots of work and hard time explaining the situation to people. Prevent the regular filters to be applied when the HudsonIsRestarting is the "app" in the servletContext. To elaborate on option 2, current flow of filters to servlet: DiagnosticThreadNameFilter CharacterEncodingFilter CompressionFilter HudsonFilter ChainedServletFilter HttpSessionContextIntegrationFilter2 BasicHeaderProcessor AuthenticationProcessingFilter2 RememberMeProcessingFilter AnonymousProcessingFilter ExceptionTranslationFilter UnwrapSecurityExceptionFilter CrumbFilter PluginServletFilter UserLanguages [...] << PluginServletFilter.addFilter (mainly for legacy plugins) Stapler as the main Servlet We could either bypass
[JIRA] (JENKINS-59992) "Jenkins.instance is missing" error when restarting Jenkins
Title: Message Title
Wadeck Follonier updated an issue
Jenkins / JENKINS-59992
"Jenkins.instance is missing" error when restarting Jenkins
Change By:
Wadeck Follonier
Auto-Upgrade Jenkins, select Restart Jenkins when complete...Manual restart via https:///restart... Logs (see below) show shutdown and restart occurs. However, during startup, an infinite cycle of exceptions (Jenkins.instance is missing) see below. Must manually restart windows service to successfully restart jenkins. {code:java}2019-10-30 19:58:18.332+ [id=154905] INFO h.model.UpdateCenter$DownloadJob#run: Starting the installation of jenkins.war on behalf of x2019 x2019 -10-30 19:58:18.332+ [id=154905] INFO h.model.UpdateCenter$DownloadJob#run: Starting the installation of jenkins.war on behalf of x2019 x2019 -10-30 19:58:18.532+ [id=154905] INFO h.m.UpdateCenter$UpdateCenterConfiguration#download: Downloading jenkins. war2019 war2019 -10-30 19:58:23.497+ [id=154905] INFO h.model.UpdateCenter$DownloadJob#run: Installation successful: jenkins. war2019 war2019 -10-30 20:01:07.466+ [id=151608] INFO hudson.model.UpdateCenter#doSafeRestart: Scheduling Jenkins reboot2019 reboot2019 -10-30 20:01:07.478+ [id=155008] INFO jenkins.model.Jenkins$23#run: Restart in 10 seconds2019 seconds2019 -10-30 20:01:17.479+ [id=155008] INFO jenkins.model.Jenkins$23#run: Restarting VM as requested by x2019 x2019 -10-30 20:01:17.481+ [id=155008] INFO jenkins.model.Jenkins#cleanUp: Stopping Jenkins2019 Jenkins2019 -10-30 20:01:17.529+ [id=155008] INFO jenkins.model.Jenkins$18#onAttained: Started termination2019 termination2019 -10-30 20:01:17.542+ [id=155008] INFO jenkins.model.Jenkins$18#onAttained: Completed termination2019 termination2019 -10-30 20:01:17.542+ [id=155008] INFO jenkins.model.Jenkins#_cleanUpDisconnectComputers: Starting node disconnection2019 disconnection2019 -10-30 20:01:17.550+ [id=155008] INFO j.s.DefaultJnlpSlaveReceiver#channelClosed: safe-restart thread for terminated: java.nio.channels. ClosedChannelException2019 ClosedChannelException2019 -10-30 20:01:17.557+ [id=155008] INFO j.s.DefaultJnlpSlaveReceiver#channelClosed: safe-restart thread for terminated: java.nio.channels. ClosedChannelException2019 ClosedChannelException2019 -10-30 20:01:18.569+ [id=155008] INFO jenkins.model.Jenkins#_cleanUpShutdownPluginManager: Stopping plugin manager2019 manager2019 -10-30 20:01:18.596+ [id=155008] INFO jenkins.model.Jenkins#_cleanUpPersistQueue: Persisting build queue2019 queue2019 -10-30 20:01:18.602+ [id=155008] INFO jenkins.model.Jenkins#_cleanUpAwaitDisconnects: Waiting for node disconnection completion2019 completion2019 -10-30 20:01:18.602+ [id=155008] INFO jenkins.model.Jenkins#cleanUp: Jenkins stopped2019 stopped2019 -10-30 20:01:22.820+ [id=151613] WARNING h.s.HttpSessionContextIntegrationFilter2#hasInvalidSessionSeed: Encountered IllegalStateException trying to get a user. System init may not have
[JIRA] (JENKINS-59992) "Jenkins.instance is missing" error when restarting Jenkins
Title: Message Title Craig Lutgen created an issue Jenkins / JENKINS-59992 "Jenkins.instance is missing" error when restarting Jenkins Issue Type: Bug Assignee: Unassigned Components: core Created: 2019-10-30 22:22 Environment: Windows Server 2016 Java 1.8.0_221-b.11 Jenkins 2.202 IIS Reverse proxy configured per https://wiki.jenkins.io/display/JENKINS/Running+Jenkins+behind+IIS CSRF Protection w/ Default Crumb Issuer Priority: Minor Reporter: Craig Lutgen Auto-Upgrade Jenkins, select Restart Jenkins when complete... Manual restart via https:///restart... Logs (see below) show shutdown and restart occurs. However, during startup, an infinite cycle of exceptions (Jenkins.instance is missing) see below. Must manually restart windows service to successfully restart jenkins. 2019-10-30 19:58:18.332+ [id=154905] INFO h.model.UpdateCenter$DownloadJob#run: Starting the installation of jenkins.war on behalf of x2019-10-30 19:58:18.332+ [id=154905] INFO h.model.UpdateCenter$DownloadJob#run: Starting the installation of jenkins.war on behalf of x2019-10-30 19:58:18.532+ [id=154905] INFO h.m.UpdateCenter$UpdateCenterConfiguration#download: Downloading jenkins.war2019-10-30 19:58:23.497+ [id=154905] INFO h.model.UpdateCenter$DownloadJob#run: Installation successful: jenkins.war2019-10-30 20:01:07.466+ [id=151608] INFO hudson.model.UpdateCenter#doSafeRestart: Scheduling Jenkins reboot2019-10-30 20:01:07.478+ [id=155008] INFO jenkins.model.Jenkins$23#run: Restart in 10 seconds2019-10-30 20:01:17.479+ [id=155008] INFO jenkins.model.Jenkins$23#run: Resta
