[JIRA] (JENKINS-60117) Rework sorting for the Enabled columns of Installed in Plugin Manager
Title: Message Title Sam Hrncir commented on JENKINS-60117 Re: Rework sorting for the Enabled columns of Installed in Plugin Manager I'll also look into this and report. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202966.157338165.4548.1582313460873%40Atlassian.JIRA.
[JIRA] (JENKINS-60117) Rework sorting for the Enabled columns of Installed in Plugin Manager
Title: Message Title Sam Hrncir assigned an issue to Kalana Wijethunga Jenkins / JENKINS-60117 Rework sorting for the Enabled columns of Installed in Plugin Manager Change By: Sam Hrncir Assignee: Sam Hrncir Kalana Wijethunga Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202966.157338165.4481.1582311780422%40Atlassian.JIRA.
[JIRA] (JENKINS-60117) Rework sorting for the Enabled columns of Installed in Plugin Manager
Title: Message Title Sam Hrncir assigned an issue to Sam Hrncir Jenkins / JENKINS-60117 Rework sorting for the Enabled columns of Installed in Plugin Manager Change By: Sam Hrncir Assignee: Kalana Wijethunga Sam Hrncir Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202966.157338165.4468.1582311720517%40Atlassian.JIRA.
[JIRA] (JENKINS-60117) Rework sorting for the Enabled columns of Installed in Plugin Manager
Title: Message Title Kalana Wijethunga commented on JENKINS-60117 Re: Rework sorting for the Enabled columns of Installed in Plugin Manager I have achieved the following expected result. Sorting by Enabled should sort into three sets: Enabled (checkbox checked) Enabled (checkbox disabled) and can't be disabled (because they're used by enabled plugins) Disabled (checkbox unchecked) But it can be seen that there is one more group in addition to the above and that is 'Enabled (checkbox checked) and can be disabled(because it has mandatory dependents, but all the dependents are disabled)'. I used Plugin.hasMandatoryDependencies() to check whether the plugin can be disabled or not. But seems it is incorrect in the identified case because a plugin can be disabled even if it hasMandatoryDependencies() when those dependencies are disabled. Oleg Nenashev, Daniel Beck Can somebody suggest me a better criteria to identify whether the plugins can be disabled or not, please? Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit
[JIRA] (JENKINS-60117) Rework sorting for the Enabled columns of Installed in Plugin Manager
Title: Message Title Kalana Wijethunga commented on JENKINS-60117 Re: Rework sorting for the Enabled columns of Installed in Plugin Manager Hi Oleg Nenashev, I was able to reproduce the issue and I followed the same process used in https://github.com/jenkinsci/jenkins/pull/4298 to group the data rows into Enabled, Enabled and cannot disable and Disabled and add the group name to data attribute of the table data column. I used the following logic to group these 3 categories. Enabled - plugin.Enabled and !hasMandatoryDependencies Enabled and cannot disable - plugin.Enabled and hasMandatoryDependencies Disabled - If it doesnt belong to above 2 categories(essentially !plugin.Enabled should belong to this) I am able to correctly sort by Enable column using these groups. But some of the actually enabled plugins are yielding false for plugin.Enabled and therefore they are categorized into the Disabled group, which is wrong. I cant understand why some of the actually working plugins are giving the result false for plugin.Enabled . Do you have any idea what is causing this? I have attached a screenshot for further clarification. I have setup the checked attribute of the highlighted input tab directly from the value plugin.Enabled. You can see that it has resulted in a false Any help would be much appreciated Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
[JIRA] (JENKINS-60117) Rework sorting for the Enabled columns of Installed in Plugin Manager
Title: Message Title Kalana Wijethunga updated an issue Jenkins / JENKINS-60117 Rework sorting for the Enabled columns of Installed in Plugin Manager Change By: Kalana Wijethunga Attachment: jenkins.jpg Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202966.157338165.8220.1576498860588%40Atlassian.JIRA.
[JIRA] (JENKINS-60117) Rework sorting for the Enabled columns of Installed in Plugin Manager
Title: Message Title Kalana Wijethunga assigned an issue to Kalana Wijethunga Jenkins / JENKINS-60117 Rework sorting for the Enabled columns of Installed in Plugin Manager Change By: Kalana Wijethunga Assignee: Kalana Wijethunga Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202966.157338165.7998.1576468260658%40Atlassian.JIRA.
[JIRA] (JENKINS-60117) Rework sorting for the Enabled columns of Installed in Plugin Manager
Title: Message Title Oleg Nenashev commented on JENKINS-60117 Re: Rework sorting for the Enabled columns of Installed in Plugin Manager Feel free to do so Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202966.157338165.5194.1576065300184%40Atlassian.JIRA.
[JIRA] (JENKINS-60117) Rework sorting for the Enabled columns of Installed in Plugin Manager
Title: Message Title Kalana Wijethunga commented on JENKINS-60117 Re: Rework sorting for the Enabled columns of Installed in Plugin Manager Hi Oleg Nenashev, Shall I work on this? Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202966.157338165.5190.1576064760431%40Atlassian.JIRA.
[JIRA] (JENKINS-60117) Rework sorting for the Enabled columns of Installed in Plugin Manager
Title: Message Title Oleg Nenashev commented on JENKINS-60117 Re: Rework sorting for the Enabled columns of Installed in Plugin Manager In https://github.com/jenkinsci/jenkins/pull/4298 is was suggested that the issue is fixed, but looks like it's not according to the feedback from Daniel Beck and Josh Soref. So I detached it to a separate ticket Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202966.157338165.11542.1573381860189%40Atlassian.JIRA.
[JIRA] (JENKINS-60117) Rework sorting for the Enabled columns of Installed in Plugin Manager
Title: Message Title Oleg Nenashev updated an issue Jenkins / JENKINS-60117 Rework sorting for the Enabled columns of Installed in Plugin Manager Change By: Oleg Nenashev Summary: Rework sorting for the Uninstall Enabled columns of Installed in Plugin Manager Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202966.157338165.11541.1573381800188%40Atlassian.JIRA.
