[JIRA] (JENKINS-60785) corrupt workspaces.txt file on agent, changes multibranch builds to use workspace directory with slash converted to %2F, causing errors

2020-01-16 Thread j...@jrichards.ca (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jeff Richards commented on  JENKINS-60785  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: corrupt workspaces.txt file on agent, changes multibranch builds to use workspace directory with slash converted to %2F, causing errors   
 

  
 
 
 
 

 
 Yeah, from my perspective, I would have been totally satisfied if the node was just marked offline.  The file is corrupt.  There is a problem. The problem is rare (any defense against partial writing of a file in code is admirable, but going to be partial (what happens in case of power outages). So marking the node offline would avoid an unexpected workspace name, alert that the node needs attention and the confusion that that causes.  Call in the humans and let them deal with it.  Once I realized that my issue was related to a problem on a single node, it only took a few minutes to think to look at the log, which pointed me straight to the problem.  And while I didn't know quite what to do to fix it, I think that would be handled by an FAQ/Troubleshooting entry on the web for people to find.  Or better yet reference it in the log message that is displayed.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.204110.1579125476000.470.1579187340204%40Atlassian.JIRA.


[JIRA] (JENKINS-60785) corrupt workspaces.txt file on agent, changes multibranch builds to use workspace directory with slash converted to %2F, causing errors

2020-01-15 Thread jgl...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jesse Glick commented on  JENKINS-60785  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: corrupt workspaces.txt file on agent, changes multibranch builds to use workspace directory with slash converted to %2F, causing errors   
 

  
 
 
 
 

 
 

an uncerimonious shut down
 It certainly looks like it, though the code is supposed to defend against that. Not sure what happened. Do you still have the system log that you found the warning in? At any rate, this code could try harder. Currently it falls back to the previous implementation (a reversible translation from job name to folder name), which was correct behavior so far as it goes but leads to trouble if you are using buggy build tools which cannot handle certain characters in the working directory path. Alternately it could discard the corrupted index and start fresh, though this introduces other risks: stale workspaces being permanently forgotten (consuming disk space); possible collision between similarly-named jobs trying to use the same (nonreversibly simplified) folder name.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.204110.1579125476000.108.1579138740277%40Atlassian.JIRA.


[JIRA] (JENKINS-60785) corrupt workspaces.txt file on agent, changes multibranch builds to use workspace directory with slash converted to %2F, causing errors

2020-01-15 Thread jgl...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jesse Glick assigned an issue to Unassigned  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-60785  
 
 
  corrupt workspaces.txt file on agent, changes multibranch builds to use workspace directory with slash converted to %2F, causing errors   
 

  
 
 
 
 

 
Change By: 
 Jesse Glick  
 
 
Assignee: 
 Brian Elliott  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.204110.1579125476000.104.1579138020314%40Atlassian.JIRA.


[JIRA] (JENKINS-60785) corrupt workspaces.txt file on agent, changes multibranch builds to use workspace directory with slash converted to %2F, causing errors

2020-01-15 Thread jgl...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jesse Glick updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-60785  
 
 
  corrupt workspaces.txt file on agent, changes multibranch builds to use workspace directory with slash converted to %2F, causing errors   
 

  
 
 
 
 

 
Change By: 
 Jesse Glick  
 
 
Component/s: 
 nodepool-agents-plugin  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.204110.1579125476000.106.1579138020344%40Atlassian.JIRA.


[JIRA] (JENKINS-60785) corrupt workspaces.txt file on agent, changes multibranch builds to use workspace directory with slash converted to %2F, causing errors

2020-01-15 Thread j...@jrichards.ca (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jeff Richards created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-60785  
 
 
  corrupt workspaces.txt file on agent, changes multibranch builds to use workspace directory with slash converted to %2F, causing errors   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 Brian Elliott  
 
 
Attachments: 
 workspaces.txt_corrupt  
 
 
Components: 
 branch-api-plugin, nodepool-agents-plugin  
 
 
Created: 
 2020-01-15 21:57  
 
 
Environment: 
 linux, multi-branch pipeline build with agents doing the building.  Jenkins version 2.190.3 Branch API Plugin Version 2.5.5  
 
 
Labels: 
 robustness  
 
 
Priority: 
  Major  
 
 
Reporter: 
 Jeff Richards  
 

  
 
 
 
 

 
 I'm facing the same problem with my multibranch pipeline project: "feature/branch" from a git repository is transformed to "feature%2Fbranch" which causes build to fail because the build process cannot find the files. Agents  aredoing the building. In my case interestingly this was only happening on 1 of three nodes (it took me hours to figure THAT out). After much searching what I found was that when I reviewed the node log for the failing node (Manage Jenkins -> Manage Nodes -> click on node in question -> Log, I found that the /home/jenkins/workspace/workspace.txt file was noted as being corrupt.  For whatever reason this meant that when the build was attempted on that node, the build directory was not the usual workspace directory (which has all branch name slashes (encoded as %2F) cases  repla