[JIRA] (JENKINS-60972) Rename the root breadcrumb
Title: Message Title Félix Queiruga Balado commented on JENKINS-60972 Re: Rename the root breadcrumb Levi Williamson Sladyn has already started work on this one, the PR can be found here: https://github.com/jenkinsci/jenkins/pull/4634 Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.204437.1580894909000.7996.1586337840229%40Atlassian.JIRA.
[JIRA] (JENKINS-60972) Rename the root breadcrumb
Title: Message Title Sladyn Nunes assigned an issue to Sladyn Nunes Jenkins / JENKINS-60972 Rename the root breadcrumb Change By: Sladyn Nunes Assignee: Levi Williamson Sladyn Nunes Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.204437.1580894909000.7956.1586322420281%40Atlassian.JIRA.
[JIRA] (JENKINS-60972) Rename the root breadcrumb
Title: Message Title Levi Williamson assigned an issue to Levi Williamson Jenkins / JENKINS-60972 Rename the root breadcrumb Change By: Levi Williamson Assignee: Levi Williamson Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.204437.1580894909000.7951.1586322180390%40Atlassian.JIRA.
[JIRA] (JENKINS-60972) Rename the root breadcrumb
Title: Message Title Félix Queiruga Balado commented on JENKINS-60972 Re: Rename the root breadcrumb Something like that indeed. My OG idea was to to have on the Java side 2 models: Breadcrumbs: has the logic to build the whole breadcrumb trail (maybe a getBreadcrumbItems method) and hooked into the jelly view. It would also allow prepending and appending breadcrumbs, and renaming the first one (??) BreadcrumbItem: has logic to determine if it's the last one, get the parent, check if it has a contextual menu, etc. Then on the jelly side you would get the breadcrumb model and iterate on the breadcrumb items Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.204437.1580894909000.8424.1584463680220%40Atlassian.JIRA.
[JIRA] (JENKINS-60972) Rename the root breadcrumb
Title: Message Title Sladyn Nunes commented on JENKINS-60972 Re: Rename the root breadcrumb Sounds like a really good plan, so basically we would like the jelly functionality to happen via java code, also where would such a module go in the file hierarchy jenkins/core/src/main/resources/breadcrumb ? Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.204437.1580894909000.8290.1584425100147%40Atlassian.JIRA.
[JIRA] (JENKINS-60972) Rename the root breadcrumb
Title: Message Title Félix Queiruga Balado commented on JENKINS-60972 Re: Rename the root breadcrumb It would be great if you can work on this one! TBH there's no good support for breadcrumbs atm in Jenkins. They are just generated iterating through request ancestors, something that I guess is provided by Stapler (https://github.com/jenkinsci/jenkins/blob/07c48b03fb4c651e7314e7adbe3a0ef0fe249586/core/src/main/resources/lib/layout/breadcrumbBar.jelly#L44). A hacky way to do it that comes to mind could be to check if the ancestor points to the rootURL, then it could be replaced. That said, I'd favour using some Java code to do this. If we get a Breadcrumbs module going on, then we can expand it in the future with some utilities like: Get the last breadcrumb item. Check if a breadcrumb item is the current one (good for styling purposes). Prepend/append items to the breadcrumbs. Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.204437.1580894909000.7683.1584352200166%40Atlassian.JIRA.
[JIRA] (JENKINS-60972) Rename the root breadcrumb
Title: Message Title Sladyn Nunes commented on JENKINS-60972 Re: Rename the root breadcrumb I could get started with this issue. Could you point me to the code ? Félix Queiruga Balado Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.204437.1580894909000.7235.1584254640169%40Atlassian.JIRA.
[JIRA] (JENKINS-60972) Rename the root breadcrumb
Title: Message Title Félix Queiruga Balado updated an issue Jenkins / JENKINS-60972 Rename the root breadcrumb Change By: Félix Queiruga Balado One of the items discussed on the UX SIG meetings ([https://jenkins.io/sigs/ux/]) was renaming the root breadcrumb to _"Home"_. The reason for this is that it can be confusing having Jenkins in 2 consecutive lines. An example of how it could look:!rootbreadcrumb.png! The solution probably should take into account i18n capabilities. Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.204437.1580894909000.6673.1583404380163%40Atlassian.JIRA.
[JIRA] (JENKINS-60972) Rename the root breadcrumb
Title: Message Title Félix Queiruga Balado updated an issue Jenkins / JENKINS-60972 Rename the root breadcrumb Change By: Félix Queiruga Balado Labels: newbie-friendly Add Comment This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.204437.1580894909000.6657.1583404140382%40Atlassian.JIRA.
[JIRA] (JENKINS-60972) Rename the root breadcrumb
Title: Message Title Félix Queiruga Balado created an issue Jenkins / JENKINS-60972 Rename the root breadcrumb Issue Type: Story Assignee: Unassigned Attachments: rootbreadcrumb.png Components: core Created: 2020-02-05 09:28 Priority: Minor Reporter: Félix Queiruga Balado One of the items discussed on the UX SIG meetings (https://jenkins.io/sigs/ux/) was renaming the root breadcrumb to "Home". The reason for this is that it can be confusing having Jenkins in 2 consecutive lines. An example of how it could look: Add Comment
