[JIRA] (JENKINS-8617) cannot customize security group to launch slaves into
[ https://issues.jenkins-ci.org/browse/JENKINS-8617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=163048#comment-163048 ] SCM/JIRA link daemon commented on JENKINS-8617: --- Code changed in jenkins User: Francis Upton Path: pom.xml src/main/java/hudson/plugins/ec2/SlaveTemplate.java src/main/resources/hudson/plugins/ec2/SlaveTemplate/config.jelly src/test/java/hudson/plugins/ec2/SlaveTemplateTest.java src/test/java/hudson/plugins/ec2/TemplateLabelsTest.java http://jenkins-ci.org/commit/ec2-plugin/543777c6f79adaf243df931bfffda6d3a86ca5f7 Log: Merge pull request #18 from yyuu/master JENKINS-8617 cannot customize security group to launch slaves into Compare: https://github.com/jenkinsci/ec2-plugin/compare/d96e049...543777c cannot customize security group to launch slaves into - Key: JENKINS-8617 URL: https://issues.jenkins-ci.org/browse/JENKINS-8617 Project: Jenkins Issue Type: Improvement Components: ec2 Reporter: mwhudson Assignee: Yuu Yamashita Priority: Minor It's slightly inconvenient to have to use the 'default' security group for our slaves. It's only slightly inconvenient, but it seems that this should be pretty easy to fix, too. I may even try myself! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-8617) cannot customize security group to launch slaves into
[ https://issues.jenkins-ci.org/browse/JENKINS-8617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=163049#comment-163049 ] francis Upton commented on JENKINS-8617: Thanks for your contribution Yuu. I committed this, but I'm concerned about the the commit that changes the required version to 1.462; I think that 1.399 should be fine (certain for this work), unless something else has changed. If you agree can you provide another pull request to fix the version back? cannot customize security group to launch slaves into - Key: JENKINS-8617 URL: https://issues.jenkins-ci.org/browse/JENKINS-8617 Project: Jenkins Issue Type: Improvement Components: ec2 Reporter: mwhudson Assignee: Yuu Yamashita Priority: Minor It's slightly inconvenient to have to use the 'default' security group for our slaves. It's only slightly inconvenient, but it seems that this should be pretty easy to fix, too. I may even try myself! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-8617) cannot customize security group to launch slaves into
[ https://issues.jenkins-ci.org/browse/JENKINS-8617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] francis Upton resolved JENKINS-8617. Resolution: Fixed Thanks for your contribution! cannot customize security group to launch slaves into - Key: JENKINS-8617 URL: https://issues.jenkins-ci.org/browse/JENKINS-8617 Project: Jenkins Issue Type: Improvement Components: ec2 Reporter: mwhudson Assignee: Yuu Yamashita Priority: Minor It's slightly inconvenient to have to use the 'default' security group for our slaves. It's only slightly inconvenient, but it seems that this should be pretty easy to fix, too. I may even try myself! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-8617) cannot customize security group to launch slaves into
[ https://issues.jenkins-ci.org/browse/JENKINS-8617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=163050#comment-163050 ] francis Upton commented on JENKINS-8617: Sorry for the spam, I fixed the version thing. cannot customize security group to launch slaves into - Key: JENKINS-8617 URL: https://issues.jenkins-ci.org/browse/JENKINS-8617 Project: Jenkins Issue Type: Improvement Components: ec2 Reporter: mwhudson Assignee: Yuu Yamashita Priority: Minor It's slightly inconvenient to have to use the 'default' security group for our slaves. It's only slightly inconvenient, but it seems that this should be pretty easy to fix, too. I may even try myself! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-8617) cannot customize security group to launch slaves into
[ https://issues.jenkins-ci.org/browse/JENKINS-8617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=163053#comment-163053 ] Yuu Yamashita commented on JENKINS-8617: I committed this, but I'm concerned about the the commit that changes the required version to 1.462; I think that 1.399 should be fine (certain for this work), unless something else has changed. If you agree can you provide another pull request to fix the version back? Thanks for merging. I'm agree to rollback Jenkins to 1.399. There's no special reason to upgrade Jenkins to 1.462. I just thought newer Jenkins must be greater :) cannot customize security group to launch slaves into - Key: JENKINS-8617 URL: https://issues.jenkins-ci.org/browse/JENKINS-8617 Project: Jenkins Issue Type: Improvement Components: ec2 Reporter: mwhudson Assignee: Yuu Yamashita Priority: Minor It's slightly inconvenient to have to use the 'default' security group for our slaves. It's only slightly inconvenient, but it seems that this should be pretty easy to fix, too. I may even try myself! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-8617) cannot customize security group to launch slaves into
[ https://issues.jenkins-ci.org/browse/JENKINS-8617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=162793#comment-162793 ] Yuu Yamashita commented on JENKINS-8617: Thanks for comment. umm... I perfer EC2 instance tag to count matching instances. EC2's DescribeInstances API has capability to find instances with specified tags. Now I'm planning to write new patch to apply instance tags to provisioned instances and then count them later. cannot customize security group to launch slaves into - Key: JENKINS-8617 URL: https://issues.jenkins-ci.org/browse/JENKINS-8617 Project: Jenkins Issue Type: Improvement Components: ec2 Reporter: mwhudson Assignee: mwhudson Priority: Minor It's slightly inconvenient to have to use the 'default' security group for our slaves. It's only slightly inconvenient, but it seems that this should be pretty easy to fix, too. I may even try myself! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-8617) cannot customize security group to launch slaves into
[ https://issues.jenkins-ci.org/browse/JENKINS-8617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=162814#comment-162814 ] mwhudson commented on JENKINS-8617: --- The problem with tags, unless I'm misremembering or things have changed, is that you can't start an instance with a tag, you can only start an instance and then tag it. So there is a risk of a race there. But you're right that it's probably a bit silly to use security groups for that, and there is certainly a case for wanting to have per slave template security groups rather than per cloud groups. cannot customize security group to launch slaves into - Key: JENKINS-8617 URL: https://issues.jenkins-ci.org/browse/JENKINS-8617 Project: Jenkins Issue Type: Improvement Components: ec2 Reporter: mwhudson Assignee: mwhudson Priority: Minor It's slightly inconvenient to have to use the 'default' security group for our slaves. It's only slightly inconvenient, but it seems that this should be pretty easy to fix, too. I may even try myself! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-8617) cannot customize security group to launch slaves into
[ https://issues.jenkins-ci.org/browse/JENKINS-8617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=162615#comment-162615 ] Yuu Yamashita commented on JENKINS-8617: oh, i just created my version of the patch but it is a duplication of this issue :( https://github.com/jenkinsci/ec2-plugin/pull/18 IMHO, putting security group configuration in SlaveTemplate is good idea since some AMIs may require distinct security group. cannot customize security group to launch slaves into - Key: JENKINS-8617 URL: https://issues.jenkins-ci.org/browse/JENKINS-8617 Project: Jenkins Issue Type: Improvement Components: ec2 Reporter: mwhudson Assignee: mwhudson Priority: Minor It's slightly inconvenient to have to use the 'default' security group for our slaves. It's only slightly inconvenient, but it seems that this should be pretty easy to fix, too. I may even try myself! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[JIRA] (JENKINS-8617) cannot customize security group to launch slaves into
[ https://issues.jenkins-ci.org/browse/JENKINS-8617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=162627#comment-162627 ] mwhudson commented on JENKINS-8617: --- I'm not sure really -- and I'm not administering Jenkins myself any more, so I'm might not to be able to contribute any useful thinking here. IIRC, one of the reasons I wanted to put it onto the cloud was that I wanted to be able to count the instances Jenkins has launched by checking the security group. We've had issues where Jenkins has refused to launch instances because there have been other instances launched by the same account and they are currently counted against the cap. If the jenkins-launched instances had a distinct security group, a more accurate count of how many instances have been launched by jenkins would be possible.' cannot customize security group to launch slaves into - Key: JENKINS-8617 URL: https://issues.jenkins-ci.org/browse/JENKINS-8617 Project: Jenkins Issue Type: Improvement Components: ec2 Reporter: mwhudson Assignee: mwhudson Priority: Minor It's slightly inconvenient to have to use the 'default' security group for our slaves. It's only slightly inconvenient, but it seems that this should be pretty easy to fix, too. I may even try myself! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
