[JIRA] [analysis-core-plugin] (JENKINS-25917) Spaces in URL (from project name or view) cause invalid cookies to be saved
Title: Message Title evernat commented on JENKINS-25917 Re: Spaces in URL (from project name or view) cause invalid cookies to be saved yes, cookie path is correct and http header "Set-Cookie" received by the browser seems also correct: Server Jetty(winstone-2.9) Set-Cookie TestResultAction_failureOnly=false;Path="/job/project%20with%20spaces";Expires=Mon, 09-Jan-2017 11:27:25 GMT But the cookie is not saved correctly by the browser (Chrome and Firefox), certainly because of quotes in the Path. It happens that Jenkins uses Jetty 8.1.13 (https://github.com/jenkinsci/winstone/blob/master/pom.xml#L221) which is buggy (see here and here) It will be needed to upgrade Jetty to 9.0.6 or later. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [analysis-core-plugin] (JENKINS-25917) Spaces in URL (from project name or view) cause invalid cookies to be saved
Title: Message Title Ulli Hafner commented on JENKINS-25917 Re: Spaces in URL (from project name or view) cause invalid cookies to be saved Thanks for finding the actual reason! Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [analysis-core-plugin] (JENKINS-25917) Spaces in URL (from project name or view) cause invalid cookies to be saved
Title: Message Title Ulli Hafner resolved as Fixed Fixed in Jenkins 2.x. Jenkins / JENKINS-25917 Spaces in URL (from project name or view) cause invalid cookies to be saved Change By: Ulli Hafner Status: Open Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [analysis-core-plugin] (JENKINS-25917) Spaces in URL (from project name or view) cause invalid cookies to be saved
Title: Message Title Ulli Hafner assigned an issue to Kohsuke Kawaguchi Jenkins / JENKINS-25917 Spaces in URL (from project name or view) cause invalid cookies to be saved Change By: Ulli Hafner Assignee: Kohsuke Kawaguchi Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [analysis-core-plugin] (JENKINS-25917) Spaces in URL (from project name or view) cause invalid cookies to be saved
Title: Message Title SCM/JIRA link daemon commented on JENKINS-25917 Re: Spaces in URL (from project name or view) cause invalid cookies to be saved Code changed in jenkins User: Ulli Hafner Path: src/main/java/org/jenkinsci/test/acceptance/plugins/analysis_core/GraphConfigurationView.java src/test/java/plugins/AbstractAnalysisTest.java http://jenkins-ci.org/commit/acceptance-test-harness/b3691320192217d8a2d5e7e60e65119f3b13ea7f Log: Added a test case that checks trend configuration via cookie. Basically a test the checks that JENKINS-25917 and JENKINS-32377 are resolved in Jenkins 2.1. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [analysis-core-plugin] (JENKINS-25917) Spaces in URL (from project name or view) cause invalid cookies to be saved
Title: Message Title SCM/JIRA link daemon commented on JENKINS-25917 Re: Spaces in URL (from project name or view) cause invalid cookies to be saved Code changed in jenkins User: Ulli Hafner Path: src/test/java/plugins/AbstractAnalysisTest.java http://jenkins-ci.org/commit/acceptance-test-harness/75c8f774c6474f5bfb6a67b256b4acff57a977fc Log: JENKINS-25917 JENKINS-32377 Let cookie test case run with 2.x only. Actually use a job name in the cookie test case that contains spaces. Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/00068c6c59b0...75c8f774c647 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [analysis-core-plugin] (JENKINS-25917) Spaces in URL (from project name or view) cause invalid cookies to be saved
Ulli Hafner updated JENKINS-25917 Spaces in URL (from project name or view) cause invalid cookies to be saved Change By: Ulli Hafner (19/Feb/15 8:05 PM) Summary: Spaces in URL (from project name or view) cause invalid cookie cookies to be saved when configuring trend graphs Component/s: core Component/s: junit-plugin Component/s: warnings-plugin This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [analysis-core-plugin] (JENKINS-25917) Spaces in URL (from project name or view) cause invalid cookies to be saved
Ulli Hafner assigned JENKINS-25917 to Unassigned Spaces in URL (from project name or view) cause invalid cookies to be saved Change By: Ulli Hafner (19/Feb/15 8:11 PM) Assignee: Ulli Hafner This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [analysis-core-plugin] (JENKINS-25917) Spaces in URL (from project name or view) cause invalid cookies to be saved
Ulli Hafner commented on JENKINS-25917 Spaces in URL (from project name or view) cause invalid cookies to be saved I finally managed it to reproduce this issue: Seems that even if the correct path is set with cookie.setPath(ancestor.getUrl()); it will be somehow changed in staplers ResponseImpl. This problem also occurs with the JUnit view that uses a cookie to decide which graph to use (failures only vs. all). So the problem must be somewhere in core (or any of the bundled libraries). This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
